portapack-mayhem/mayhem-firmware
1
0
Fork 0
mirror of https://github.com/portapack-mayhem/mayhem-firmware.git synced 2026-09-12 17:49:31 +00:00
Code Issues Packages Projects Releases 10 Wiki Activity

Frequman widget gets a non owning reference to the database instead of copying (#1175)

Browse Source 
-Get rid of -Weffc++ pointer member warnings by restricting copy of FreqManUIList
-Add null checks
-Remove unused macro
This commit is contained in:
E.T
2023-06-21 12:05:07 +02:00
committed by GitHub
parent 909f37f89b
commit e1c519d71e
3 changed files with 17 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
firmware/application/freqman.hpp
+6 -6
View File
@@ -32,11 +32,11 @@
#include "string_format.hpp"
#include "ui_widget.hpp"
#define FREQMAN_DESC_MAX_LEN 24 // This is the number of characters that can be drawn in front of "R: TEXT..." before taking a full screen line
#define FREQMAN_MAX_PER_FILE 60 // Maximum of entries we can read. This is a hardware limit
// It was tested and lowered to leave a bit of space to the caller
#define FREQMAN_MAX_PER_FILE_STR "60" // STRING OF FREQMAN_MAX_PER_FILE
#define FREQMAN_READ_BUF_SIZE 96 // max freqman line size including desc is 90, +6 for a bit of space
#define FREQMAN_DESC_MAX_LEN 24 // This is the number of characters that can be drawn in front of "R: TEXT..." before taking a full screen line
#define FREQMAN_MAX_PER_FILE 100 // Maximum of entries we can read. This is a hardware limit
// It was tested and lowered to leave a bit of space to the caller
#define FREQMAN_READ_BUF_SIZE 96 // max freqman line size including desc is 90, +6 for a bit of space
using namespace ui;
using namespace std;
@@ -52,7 +52,7 @@ enum freqman_error {
ERROR_DUPLICATE
};
enum freqman_entry_type {
enum freqman_entry_type : uint8_t {
SINGLE = 0, // f=
RANGE, // a=,b=
HAMRADIO, // r=,t=