From c3c680fc045d590c99e7e16b136870d18d885bc3 Mon Sep 17 00:00:00 2001 From: GullCode Date: Wed, 27 Jan 2021 16:46:58 +0100 Subject: [PATCH 1/2] removed unused var --- firmware/application/ui/ui_tv.cpp | 2 +- firmware/application/ui/ui_tv.hpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/firmware/application/ui/ui_tv.cpp b/firmware/application/ui/ui_tv.cpp index 59c99e073..5c3f0fbcc 100644 --- a/firmware/application/ui/ui_tv.cpp +++ b/firmware/application/ui/ui_tv.cpp @@ -182,7 +182,7 @@ void TVView::clear() { /* TVWidget *******************************************************/ -TVWidget::TVWidget(const bool cursor) { +TVWidget::TVWidget() { add_children({ &tv_view, &field_xcorr diff --git a/firmware/application/ui/ui_tv.hpp b/firmware/application/ui/ui_tv.hpp index 1fb7887a5..7accf7d45 100644 --- a/firmware/application/ui/ui_tv.hpp +++ b/firmware/application/ui/ui_tv.hpp @@ -92,7 +92,7 @@ class TVWidget : public View { public: std::function on_select { }; - TVWidget(const bool cursor = false); + TVWidget(); TVWidget(const TVWidget&) = delete; TVWidget(TVWidget&&) = delete; From 1a48fb8c5a1256a8c189a75fcf805c2f99bb58e9 Mon Sep 17 00:00:00 2001 From: GullCode Date: Thu, 28 Jan 2021 10:08:57 +0100 Subject: [PATCH 2/2] removed a var, added a void, removed a unused initializer --- firmware/application/apps/analog_tv_app.cpp | 3 ++- firmware/application/apps/analog_tv_app.hpp | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/firmware/application/apps/analog_tv_app.cpp b/firmware/application/apps/analog_tv_app.cpp index 8f4980788..b3710573b 100644 --- a/firmware/application/apps/analog_tv_app.cpp +++ b/firmware/application/apps/analog_tv_app.cpp @@ -199,7 +199,7 @@ void AnalogTvView::on_show_options_rf_gain() { void AnalogTvView::on_show_options_modulation() { std::unique_ptr widget; - const auto modulation = static_cast(receiver_model.modulation()); + static_cast(receiver_model.modulation()); tv.show_audio_spectrum_view(true); set_options_widget(std::move(widget)); @@ -216,6 +216,7 @@ void AnalogTvView::on_reference_ppm_correction_changed(int32_t v) { } void AnalogTvView::on_headphone_volume_changed(int32_t v) { + (void)v; //avoid warning //tv::TVView::set_headphone_volume(this,v); } diff --git a/firmware/application/apps/analog_tv_app.hpp b/firmware/application/apps/analog_tv_app.hpp index 552f7f6ba..6f90a55cf 100644 --- a/firmware/application/apps/analog_tv_app.hpp +++ b/firmware/application/apps/analog_tv_app.hpp @@ -107,7 +107,7 @@ private: std::unique_ptr options_widget { }; - tv::TVWidget tv { true }; + tv::TVWidget tv { }; void on_tuning_frequency_changed(rf::Frequency f); void on_baseband_bandwidth_changed(uint32_t bandwidth_hz);