Update clang format to 18 (#2891)

* move to clang-format-18
* clang-format-18 indendation

firmware/baseband/baseband_processor.hpp

@@ -34,7 +34,7 @@ class BasebandProcessor {
 
     virtual void execute(const buffer_c8_t& buffer) = 0;
 
-    virtual void on_message(const Message* const){};
+    virtual void on_message(const Message* const) {};
 
    protected:
     void feed_channel_stats(const buffer_c16_t& channel);

firmware/baseband/debug.hpp

@@ -30,8 +30,7 @@ extern uint32_t __process_stack_end__;
 
 inline uint32_t get_free_stack_space() {
     uint32_t* p;
-    for (p = &__process_stack_base__; *p == CRT0_STACKS_FILL_PATTERN && p < &__process_stack_end__; p++)
-        ;
+    for (p = &__process_stack_base__; *p == CRT0_STACKS_FILL_PATTERN && p < &__process_stack_end__; p++);
     auto stack_space_left = p - &__process_stack_base__;
 
     return stack_space_left;

firmware/baseband/fxpt_atan2.cpp

@@ -76,7 +76,7 @@ static inline int16_t q15_mul(const int16_t j, const int16_t k) {
 	return intermediate >> 15;
 #elif 0  // biased rounding
     return (intermediate + 0x4000) >> 15;
-#else    // unbiased rounding
+#else  // unbiased rounding
     return (intermediate + ((intermediate & 0x7FFF) == 0x4000 ? 0 : 0x4000)) >> 15;
 #endif
 }

firmware/baseband/proc_ook.cpp

@@ -108,8 +108,7 @@ inline size_t OOKProcessor::duval_algo_step() {
         for (unsigned int j = 0; j < w - idx; j++)
             v[idx + j] = v[j];
 
-        for (idx = w; (idx > 0) && (v[idx - 1] >= duval_symbols - 1); idx--)
-            ;
+        for (idx = w; (idx > 0) && (v[idx - 1] >= duval_symbols - 1); idx--);
 
         if (idx)
             v[idx - 1]++;

firmware/baseband/sd_over_usb/scsi.c

@@ -45,8 +45,7 @@ void usb_send_bulk(void* const data, const uint32_t maximum_length) {
         usb_bulk_block_cb,
         NULL);
 
-    while (!usb_bulk_block_done)
-        ;
+    while (!usb_bulk_block_done);
 }
 
 void usb_receive_bulk(void* const data, const uint32_t maximum_length) {
@@ -59,8 +58,7 @@ void usb_receive_bulk(void* const data, const uint32_t maximum_length) {
         usb_bulk_block_cb,
         NULL);
 
-    while (!usb_bulk_block_done)
-        ;
+    while (!usb_bulk_block_done);
 }
 
 void usb_send_csw(msd_cbw_t* msd_cbw_data, uint8_t status) {

firmware/baseband/sd_over_usb/sd_over_usb.c

@@ -118,8 +118,7 @@ void usb_transfer(void) {
             scsi_bulk_transfer_complete,
             NULL);
 
-        while (!transfer_complete)
-            ;
+        while (!transfer_complete);
 
         msd_cbw_t* msd_cbw_data = (msd_cbw_t*)&usb_bulk_buffer[0x4000];