portapack-mayhem/mayhem-firmware
1
0
Fork 0
mirror of https://github.com/portapack-mayhem/mayhem-firmware.git synced 2026-09-10 08:39:29 +00:00
Code Issues Packages Projects Releases 10 Wiki Activity

UI and bug fixes (#3164)

Browse Source 
* Fix BLE RX RSSI and Channel scale

* Properly reset gradient index 0

* Use move constructor in MenuView::add_item

* Avoid erasing during iteration

* Fix gradient rounding. Extend to end of table

* Add comment to add_item
This commit is contained in:
Synray
2026-05-09 15:08:05 -07:00
committed by GitHub
parent 590f19062b
commit 245a36459f
5 changed files with 30 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files
firmware/application/ui/ui_menu.cpp
+4 -5
View File
@@ -159,16 +159,15 @@ size_t MenuView::item_count() const {
return menu_items.size();
}
void MenuView::add_item(MenuItem new_item) {
menu_items.push_back(new_item);
void MenuView::add_item(MenuItem&& new_item) {
menu_items.push_back(std::move(new_item));
update_items();
}
void MenuView::add_items(std::initializer_list<MenuItem> new_items) {
for (auto item : new_items) {
add_item(item);
}
menu_items.insert(menu_items.end(), new_items);
update_items();
}
void MenuView::update_items() {
firmware/application/ui/ui_menu.hpp
+4 -1
View File
@@ -83,7 +83,10 @@ class MenuView : public View {
~MenuView();
void add_item(MenuItem new_item);
// This function takes a temporary to avoid copies and heap allocations.
// To pass a variable 'item', use add_item(std::move(item)),
// or construct the MenuItem in the call, add_item(MenuItem{...})
void add_item(MenuItem&& new_item);
void add_items(std::initializer_list<MenuItem> new_items);
void clear();
size_t item_count() const;