From 16c4c285840331454066aa82f4037bf1a31432d2 Mon Sep 17 00:00:00 2001 From: gullradriel <3157857+gullradriel@users.noreply.github.com> Date: Wed, 25 Feb 2026 01:28:16 +0100 Subject: [PATCH] fix guru in level / scanner / recon app (#3047) * fix guru * fix potential guru * added information for the sudden return --- firmware/application/apps/ui_recon.cpp | 1 + firmware/application/external/level/ui_level.cpp | 1 + firmware/application/external/scanner/ui_scanner.cpp | 1 + 3 files changed, 3 insertions(+) diff --git a/firmware/application/apps/ui_recon.cpp b/firmware/application/apps/ui_recon.cpp index 255b73bb4..e0ba6a97c 100644 --- a/firmware/application/apps/ui_recon.cpp +++ b/firmware/application/apps/ui_recon.cpp @@ -1261,6 +1261,7 @@ size_t ReconView::change_mode(freqman_index_t new_mod) { else v = SPEC_MODULATION; field_mode.set_selected_index(v); + return; // Important ! Guru will occur if you don't return when modifying field from within on_change ! } last_mode = v; change_mode(v); diff --git a/firmware/application/external/level/ui_level.cpp b/firmware/application/external/level/ui_level.cpp index e8034f31d..d5608b6b3 100644 --- a/firmware/application/external/level/ui_level.cpp +++ b/firmware/application/external/level/ui_level.cpp @@ -137,6 +137,7 @@ LevelView::LevelView(NavigationView& nav) else v = SPEC_MODULATION; field_mode.set_selected_index(v); + return; // Important ! Guru will occur if you don't return when modifying field from within on_change ! } last_mode = v; change_mode(v); diff --git a/firmware/application/external/scanner/ui_scanner.cpp b/firmware/application/external/scanner/ui_scanner.cpp index 8d87b6c39..cc116eefe 100644 --- a/firmware/application/external/scanner/ui_scanner.cpp +++ b/firmware/application/external/scanner/ui_scanner.cpp @@ -461,6 +461,7 @@ ScannerView::ScannerView( else v = WFM_MODULATION; field_mode.set_selected_index(v); + return; // Important ! Guru will occur if you don't return when modifying field from within on_change ! } last_mode = v; receiver_model.disable();