From a52be6b68ee259e9a5fe0286f0e850dddccb1acf Mon Sep 17 00:00:00 2001 From: Joel Wetzell Date: Mon, 11 Sep 2023 18:43:58 -0500 Subject: [PATCH 1/2] cleanup frame logic --- index.js | 6 ------ 1 file changed, 6 deletions(-) diff --git a/index.js b/index.js index 7f8ffe3..6b6658c 100644 --- a/index.js +++ b/index.js @@ -95,9 +95,6 @@ class Decoder { // console.log('found complete info frame'); this.updateInfo(this.infoPacketFrames[currentInfoPacketHeader.frame_id]); delete this.infoPacketFrames[currentInfoPacketHeader.frame_id]; - } else { - // TODO(jwetzell): need to compute whether a frame is complete - // console.log('compute frame completion'); } this.lastInfoPacketHeader = currentInfoPacketHeader; @@ -126,9 +123,6 @@ class Decoder { // console.log('found complete data frame'); this.updateData(this.dataPacketFrames[currentDataPacketHeader.frame_id]); delete this.dataPacketFrames[currentDataPacketHeader.frame_id]; - } else { - // TODO(jwetzell): need to compute whether a frame is complete - // console.log('compute data frame completion'); } this.lastDataPacketHeader = currentDataPacketHeader; From 63a9db3a249a702431d4f95994a886b4e147e913 Mon Sep 17 00:00:00 2001 From: Joel Wetzell Date: Mon, 11 Sep 2023 20:44:55 -0500 Subject: [PATCH 2/2] no need to track last packet header i think --- index.js | 8 -------- 1 file changed, 8 deletions(-) diff --git a/index.js b/index.js index 6b6658c..ba666a3 100644 --- a/index.js +++ b/index.js @@ -6,10 +6,6 @@ const DATA_PACKET = 0x6755; const INFO_PACKET = 0x6756; class Decoder { - lastInfoPacketHeader; - - lastDataPacketHeader; - infoPacketFrames = {}; dataPacketFrames = {}; @@ -96,8 +92,6 @@ class Decoder { this.updateInfo(this.infoPacketFrames[currentInfoPacketHeader.frame_id]); delete this.infoPacketFrames[currentInfoPacketHeader.frame_id]; } - - this.lastInfoPacketHeader = currentInfoPacketHeader; } } } else if (packet.id === DATA_PACKET) { @@ -124,8 +118,6 @@ class Decoder { this.updateData(this.dataPacketFrames[currentDataPacketHeader.frame_id]); delete this.dataPacketFrames[currentDataPacketHeader.frame_id]; } - - this.lastDataPacketHeader = currentDataPacketHeader; } } }