From eb8c6aba190a497c17cad8bbe1d2359f84f6b10d Mon Sep 17 00:00:00 2001 From: Joel Wetzell Date: Fri, 27 Feb 2026 22:30:52 -0600 Subject: [PATCH] use t.Run for tests --- internal/decoders/chunk_test.go | 41 ++++++++----------- internal/decoders/data_packet_chunk_test.go | 21 ++++------ internal/decoders/data_tracker_chunk_test.go | 21 ++++------ .../decoders/data_tracker_list_chunk_test.go | 21 ++++------ .../data_tracker_status_chunk_test.go | 21 ++++------ .../data_tracker_timestamp_chunk_test.go | 20 ++++----- .../decoders/data_tracker_xyz_chunk_test.go | 21 ++++------ internal/decoders/info_packet_chunk_test.go | 22 ++++------ .../decoders/info_system_name_chunk_test.go | 21 ++++------ internal/decoders/info_tracker_chunk_test.go | 21 ++++------ .../decoders/info_tracker_list_chunk_test.go | 21 ++++------ .../decoders/info_tracker_name_chunk_test.go | 20 ++++----- internal/decoders/packet_header_chunk_test.go | 21 ++++------ internal/encoders/chunk_test.go | 14 +++---- .../encoders/data_tracker_accel_chunk_test.go | 14 +++---- .../encoders/data_tracker_ori_chunk_test.go | 14 +++---- .../encoders/data_tracker_pos_chunk_test.go | 14 +++---- .../encoders/data_tracker_speed_chunk_test.go | 14 +++---- .../data_tracker_status_chunk_test.go | 14 +++---- .../data_tracker_timestamp_chunk_test.go | 14 +++---- .../data_tracker_trgtpos_chunk_test.go | 13 +++--- .../encoders/info_system_name_chunk_test.go | 14 +++---- internal/encoders/info_tracker_chunk_test.go | 14 +++---- .../encoders/info_tracker_list_chunk_test.go | 22 +++++----- .../encoders/info_tracker_name_chunk_test.go | 14 +++---- internal/encoders/packet_header_chunk_test.go | 14 +++---- 26 files changed, 208 insertions(+), 273 deletions(-) diff --git a/internal/decoders/chunk_test.go b/internal/decoders/chunk_test.go index 880ae23..ebad2fc 100644 --- a/internal/decoders/chunk_test.go +++ b/internal/decoders/chunk_test.go @@ -1,7 +1,6 @@ package decoders import ( - "fmt" "reflect" "strings" "testing" @@ -58,19 +57,17 @@ func TestGoodChunkDecoding(t *testing.T) { } for _, testCase := range testCases { + t.Run(testCase.description, func(t *testing.T) { + actual, err := DecodeChunk(testCase.bytes) - actual, err := DecodeChunk(testCase.bytes) + if err != nil { + t.Errorf("failed to decode chunk properly, error: %v", err) + } - if err != nil { - t.Errorf("Test '%s' failed to decode chunk properly", testCase.description) - fmt.Println(err) - } - - if !reflect.DeepEqual(actual, testCase.expected) { - t.Errorf("Test '%s' failed to decode chunk properly", testCase.description) - fmt.Printf("expected: %v\n", testCase.expected) - fmt.Printf("actual: %v\n", actual) - } + if !reflect.DeepEqual(actual, testCase.expected) { + t.Errorf("failed to decode chunk properly, expected: %+v, actual: %+v", testCase.expected, actual) + } + }) } } @@ -88,18 +85,16 @@ func TestBadChunkDecoding(t *testing.T) { } for _, testCase := range testCases { + t.Run(testCase.description, func(t *testing.T) { + _, err := DecodeChunk(testCase.bytes) - _, err := DecodeChunk(testCase.bytes) - - if err == nil { - t.Errorf("Test '%s' should have failed fail to decode chunk properly", testCase.description) - } - - if !strings.Contains(err.Error(), testCase.errorShouldContain) { - t.Errorf("Test '%s' did not return the correct error", testCase.description) - fmt.Printf("expected: %v\n", testCase.errorShouldContain) - fmt.Printf("actual: %v\n", err.Error()) - } + if err == nil { + t.Error("should have failed fail to decode chunk properly") + } + if !strings.Contains(err.Error(), testCase.errorShouldContain) { + t.Errorf("did not return the correct error expected: %s, got: %s", testCase.errorShouldContain, err.Error()) + } + }) } } diff --git a/internal/decoders/data_packet_chunk_test.go b/internal/decoders/data_packet_chunk_test.go index 0b02d49..e10cf94 100644 --- a/internal/decoders/data_packet_chunk_test.go +++ b/internal/decoders/data_packet_chunk_test.go @@ -1,7 +1,6 @@ package decoders import ( - "fmt" "reflect" "testing" @@ -155,18 +154,16 @@ func TestGoodDataPacketChunkDecoding(t *testing.T) { } for _, testCase := range testCases { + t.Run(testCase.description, func(t *testing.T) { + actual, err := DecodeDataPacketChunk(testCase.bytes) - actual, err := DecodeDataPacketChunk(testCase.bytes) + if err != nil { + t.Errorf("failed to decode chunk properly, error: %v", err) + } - if err != nil { - t.Errorf("Test '%s' failed to decode chunk properly", testCase.description) - fmt.Println(err) - } - - if !reflect.DeepEqual(actual, testCase.expected) { - t.Errorf("Test '%s' failed to decode chunk properly", testCase.description) - fmt.Printf("expected: %+v\n", testCase.expected) - fmt.Printf("actual: %+v\n", actual) - } + if !reflect.DeepEqual(actual, testCase.expected) { + t.Errorf("failed to decode chunk properly, expected: %+v, actual: %+v", testCase.expected, actual) + } + }) } } diff --git a/internal/decoders/data_tracker_chunk_test.go b/internal/decoders/data_tracker_chunk_test.go index 31ba1bb..b6ea4fb 100644 --- a/internal/decoders/data_tracker_chunk_test.go +++ b/internal/decoders/data_tracker_chunk_test.go @@ -1,7 +1,6 @@ package decoders import ( - "fmt" "reflect" "testing" @@ -111,18 +110,16 @@ func TestGoodDataTrackerChunkDecoding(t *testing.T) { } for _, testCase := range testCases { + t.Run(testCase.description, func(t *testing.T) { + actual, err := DecodeDataTrackerChunk(testCase.bytes) - actual, err := DecodeDataTrackerChunk(testCase.bytes) + if err != nil { + t.Errorf("failed to decode chunk properly, error: %v", err) + } - if err != nil { - t.Errorf("Test '%s' failed to decode chunk properly", testCase.description) - fmt.Println(err) - } - - if !reflect.DeepEqual(actual, testCase.expected) { - t.Errorf("Test '%s' failed to decode chunk properly", testCase.description) - fmt.Printf("expected: %+v\n", testCase.expected) - fmt.Printf("actual: %+v\n", actual) - } + if !reflect.DeepEqual(actual, testCase.expected) { + t.Errorf("failed to decode chunk properly, expected: %+v, actual: %+v", testCase.expected, actual) + } + }) } } diff --git a/internal/decoders/data_tracker_list_chunk_test.go b/internal/decoders/data_tracker_list_chunk_test.go index 326e83a..c05a2ce 100644 --- a/internal/decoders/data_tracker_list_chunk_test.go +++ b/internal/decoders/data_tracker_list_chunk_test.go @@ -1,7 +1,6 @@ package decoders import ( - "fmt" "reflect" "testing" @@ -126,18 +125,16 @@ func TestGoodDataTrackerListChunkDecoding(t *testing.T) { } for _, testCase := range testCases { + t.Run(testCase.description, func(t *testing.T) { + actual, err := DecodeDataTrackerListChunk(testCase.bytes) - actual, err := DecodeDataTrackerListChunk(testCase.bytes) + if err != nil { + t.Errorf("failed to decode chunk properly, error: %v", err) + } - if err != nil { - t.Errorf("Test '%s' failed to decode chunk properly", testCase.description) - fmt.Println(err) - } - - if !reflect.DeepEqual(actual, testCase.expected) { - t.Errorf("Test '%s' failed to decode chunk properly", testCase.description) - fmt.Printf("expected: %+v\n", testCase.expected) - fmt.Printf("actual: %+v\n", actual) - } + if !reflect.DeepEqual(actual, testCase.expected) { + t.Errorf("failed to decode chunk properly, expected: %+v, actual: %+v", testCase.expected, actual) + } + }) } } diff --git a/internal/decoders/data_tracker_status_chunk_test.go b/internal/decoders/data_tracker_status_chunk_test.go index 76faeaa..87ca7a8 100644 --- a/internal/decoders/data_tracker_status_chunk_test.go +++ b/internal/decoders/data_tracker_status_chunk_test.go @@ -1,7 +1,6 @@ package decoders import ( - "fmt" "reflect" "testing" @@ -31,19 +30,17 @@ func TestGoodDataTrackerStatusChunk(t *testing.T) { } for _, testCase := range testCases { + t.Run(testCase.description, func(t *testing.T) { + actual, err := DecodeDataTrackerStatusChunk(testCase.bytes) - actual, err := DecodeDataTrackerStatusChunk(testCase.bytes) + if err != nil { + t.Errorf("failed to decode chunk properly, error: %v", err) + } - if err != nil { - t.Errorf("Test '%s' failed to decode chunk properly", testCase.description) - fmt.Println(err) - } - - if !reflect.DeepEqual(actual, testCase.expected) { - t.Errorf("Test '%s' failed to decode chunk properly", testCase.description) - fmt.Printf("expected: %v\n", testCase.expected) - fmt.Printf("actual: %v\n", actual) - } + if !reflect.DeepEqual(actual, testCase.expected) { + t.Errorf("failed to decode chunk properly, expected: %+v, actual: %+v", testCase.expected, actual) + } + }) } } diff --git a/internal/decoders/data_tracker_timestamp_chunk_test.go b/internal/decoders/data_tracker_timestamp_chunk_test.go index 06317eb..57de0ed 100644 --- a/internal/decoders/data_tracker_timestamp_chunk_test.go +++ b/internal/decoders/data_tracker_timestamp_chunk_test.go @@ -1,7 +1,6 @@ package decoders import ( - "fmt" "reflect" "testing" @@ -32,18 +31,17 @@ func TestGoodDataTrackerTimestampChunk(t *testing.T) { for _, testCase := range testCases { - actual, err := DecodeDataTrackerTimestampChunk(testCase.bytes) + t.Run(testCase.description, func(t *testing.T) { + actual, err := DecodeDataTrackerTimestampChunk(testCase.bytes) - if err != nil { - t.Errorf("Test '%s' failed to decode chunk properly", testCase.description) - fmt.Println(err) - } + if err != nil { + t.Errorf("failed to decode chunk properly, error: %v", err) + } - if !reflect.DeepEqual(actual, testCase.expected) { - t.Errorf("Test '%s' failed to decode chunk properly", testCase.description) - fmt.Printf("expected: %v\n", testCase.expected) - fmt.Printf("actual: %v\n", actual) - } + if !reflect.DeepEqual(actual, testCase.expected) { + t.Errorf("failed to decode chunk properly, expected: %+v, actual: %+v", testCase.expected, actual) + } + }) } } diff --git a/internal/decoders/data_tracker_xyz_chunk_test.go b/internal/decoders/data_tracker_xyz_chunk_test.go index 949d730..d71d48a 100644 --- a/internal/decoders/data_tracker_xyz_chunk_test.go +++ b/internal/decoders/data_tracker_xyz_chunk_test.go @@ -1,7 +1,6 @@ package decoders import ( - "fmt" "reflect" "testing" @@ -93,19 +92,17 @@ func TestGoodDataTrackerXYZChunk(t *testing.T) { } for _, testCase := range testCases { + t.Run(testCase.description, func(t *testing.T) { + actual, err := DecodeDataTrackerXYZChunk(testCase.bytes) - actual, err := DecodeDataTrackerXYZChunk(testCase.bytes) + if err != nil { + t.Errorf("failed to decode chunk properly, error: %v", err) + } - if err != nil { - t.Errorf("Test '%s' failed to decode chunk properly", testCase.description) - fmt.Println(err) - } - - if !reflect.DeepEqual(actual, testCase.expected) { - t.Errorf("Test '%s' failed to decode chunk properly", testCase.description) - fmt.Printf("expected: %v\n", testCase.expected) - fmt.Printf("actual: %v\n", actual) - } + if !reflect.DeepEqual(actual, testCase.expected) { + t.Errorf("failed to decode chunk properly, expected: %+v, actual: %+v", testCase.expected, actual) + } + }) } } diff --git a/internal/decoders/info_packet_chunk_test.go b/internal/decoders/info_packet_chunk_test.go index 9ae50b4..9715812 100644 --- a/internal/decoders/info_packet_chunk_test.go +++ b/internal/decoders/info_packet_chunk_test.go @@ -1,7 +1,6 @@ package decoders import ( - "fmt" "reflect" "testing" @@ -134,19 +133,16 @@ func TestGoodInfoPacketChunkDecoding(t *testing.T) { for _, testCase := range testCases { - actual, err := DecodeInfoPacketChunk(testCase.bytes) + t.Run(testCase.description, func(t *testing.T) { + actual, err := DecodeInfoPacketChunk(testCase.bytes) - if err != nil { - t.Errorf("Test '%s' failed to decode chunk properly", testCase.description) - fmt.Println(err) - } + if err != nil { + t.Errorf("failed to decode chunk properly, error: %v", err) + } - if !reflect.DeepEqual(actual, testCase.expected) { - fmt.Printf("%+v\n", actual.Data.TrackerList) - fmt.Printf("%+v\n", testCase.expected.Data.TrackerList) - t.Errorf("Test '%s' failed to decode chunk properly", testCase.description) - // fmt.Printf("expected: %+v\n", testCase.expected) - // fmt.Printf("actual: %+v\n", actual) - } + if !reflect.DeepEqual(actual, testCase.expected) { + t.Errorf("failed to decode chunk properly, expected: %+v, actual: %+v", testCase.expected, actual) + } + }) } } diff --git a/internal/decoders/info_system_name_chunk_test.go b/internal/decoders/info_system_name_chunk_test.go index a61e532..4085610 100644 --- a/internal/decoders/info_system_name_chunk_test.go +++ b/internal/decoders/info_system_name_chunk_test.go @@ -1,7 +1,6 @@ package decoders import ( - "fmt" "reflect" "testing" @@ -32,18 +31,16 @@ func TestGoodInfoSystemNameChunkDecoding(t *testing.T) { } for _, testCase := range testCases { + t.Run(testCase.description, func(t *testing.T) { + actual, err := DecodeInfoSystemNameChunk(testCase.bytes) - actual, err := DecodeInfoSystemNameChunk(testCase.bytes) + if err != nil { + t.Errorf("failed to decode chunk properly, error: %v", err) + } - if err != nil { - t.Errorf("Test '%s' failed to decode chunk properly", testCase.description) - fmt.Println(err) - } - - if !reflect.DeepEqual(actual, testCase.expected) { - t.Errorf("Test '%s' failed to decode chunk properly", testCase.description) - fmt.Printf("expected: %+v\n", testCase.expected) - fmt.Printf("actual: %+v\n", actual) - } + if !reflect.DeepEqual(actual, testCase.expected) { + t.Errorf("failed to decode chunk properly, expected: %+v, actual: %+v", testCase.expected, actual) + } + }) } } diff --git a/internal/decoders/info_tracker_chunk_test.go b/internal/decoders/info_tracker_chunk_test.go index 208256d..77c1ac3 100644 --- a/internal/decoders/info_tracker_chunk_test.go +++ b/internal/decoders/info_tracker_chunk_test.go @@ -1,7 +1,6 @@ package decoders import ( - "fmt" "reflect" "testing" @@ -40,18 +39,16 @@ func TestGoodInfoTrackerChunkDecoding(t *testing.T) { } for _, testCase := range testCases { + t.Run(testCase.description, func(t *testing.T) { + actual, err := DecodeInfoTrackerChunk(testCase.bytes) - actual, err := DecodeInfoTrackerChunk(testCase.bytes) + if err != nil { + t.Errorf("failed to decode chunk properly, error: %v", err) + } - if err != nil { - t.Errorf("Test '%s' failed to decode chunk properly", testCase.description) - fmt.Println(err) - } - - if !reflect.DeepEqual(actual, testCase.expected) { - t.Errorf("Test '%s' failed to decode chunk properly", testCase.description) - fmt.Printf("expected: %+v\n", testCase.expected) - fmt.Printf("actual: %+v\n", actual) - } + if !reflect.DeepEqual(actual, testCase.expected) { + t.Errorf("failed to decode chunk properly, expected: %+v, actual: %+v", testCase.expected, actual) + } + }) } } diff --git a/internal/decoders/info_tracker_list_chunk_test.go b/internal/decoders/info_tracker_list_chunk_test.go index ee393da..14e15cc 100644 --- a/internal/decoders/info_tracker_list_chunk_test.go +++ b/internal/decoders/info_tracker_list_chunk_test.go @@ -1,7 +1,6 @@ package decoders import ( - "fmt" "reflect" "testing" @@ -50,18 +49,16 @@ func TestGoodInfoTrackerListChunkDecoding(t *testing.T) { } for _, testCase := range testCases { + t.Run(testCase.description, func(t *testing.T) { + actual, err := DecodeInfoTrackerListChunk(testCase.bytes) - actual, err := DecodeInfoTrackerListChunk(testCase.bytes) + if err != nil { + t.Errorf("failed to decode chunk properly, error: %v", err) + } - if err != nil { - t.Errorf("Test '%s' failed to decode chunk properly", testCase.description) - fmt.Println(err) - } - - if !reflect.DeepEqual(actual, testCase.expected) { - t.Errorf("Test '%s' failed to decode chunk properly", testCase.description) - fmt.Printf("expected: %+v\n", testCase.expected) - fmt.Printf("actual: %+v\n", actual) - } + if !reflect.DeepEqual(actual, testCase.expected) { + t.Errorf("failed to decode chunk properly, expected: %+v, actual: %+v", testCase.expected, actual) + } + }) } } diff --git a/internal/decoders/info_tracker_name_chunk_test.go b/internal/decoders/info_tracker_name_chunk_test.go index 7736a5a..e9a1335 100644 --- a/internal/decoders/info_tracker_name_chunk_test.go +++ b/internal/decoders/info_tracker_name_chunk_test.go @@ -1,7 +1,6 @@ package decoders import ( - "fmt" "reflect" "testing" @@ -33,17 +32,16 @@ func TestGoodInfoTrackerNameChunkDecoding(t *testing.T) { for _, testCase := range testCases { - actual, err := DecodeInfoTrackerNameChunk(testCase.bytes) + t.Run(testCase.description, func(t *testing.T) { + actual, err := DecodeInfoTrackerNameChunk(testCase.bytes) - if err != nil { - t.Errorf("Test '%s' failed to decode chunk properly", testCase.description) - fmt.Println(err) - } + if err != nil { + t.Errorf("failed to decode chunk properly, error: %v", err) + } - if !reflect.DeepEqual(actual, testCase.expected) { - t.Errorf("Test '%s' failed to decode chunk properly", testCase.description) - fmt.Printf("expected: %+v\n", testCase.expected) - fmt.Printf("actual: %+v\n", actual) - } + if !reflect.DeepEqual(actual, testCase.expected) { + t.Errorf("failed to decode chunk properly, expected: %+v, actual: %+v", testCase.expected, actual) + } + }) } } diff --git a/internal/decoders/packet_header_chunk_test.go b/internal/decoders/packet_header_chunk_test.go index 5760337..52dc102 100644 --- a/internal/decoders/packet_header_chunk_test.go +++ b/internal/decoders/packet_header_chunk_test.go @@ -1,7 +1,6 @@ package decoders import ( - "fmt" "reflect" "testing" @@ -36,18 +35,16 @@ func TestGoodPacketHeaderChunkDecoding(t *testing.T) { } for _, testCase := range testCases { + t.Run(testCase.description, func(t *testing.T) { + actual, err := DecodePacketHeaderChunk(testCase.bytes) - actual, err := DecodePacketHeaderChunk(testCase.bytes) + if err != nil { + t.Errorf("failed to decode chunk properly, error: %v", err) + } - if err != nil { - t.Errorf("Test '%s' failed to decode chunk properly", testCase.description) - fmt.Println(err) - } - - if !reflect.DeepEqual(actual, testCase.expected) { - t.Errorf("Test '%s' failed to decode chunk properly", testCase.description) - fmt.Printf("expected: %+v\n", testCase.expected) - fmt.Printf("actual: %+v\n", actual) - } + if !reflect.DeepEqual(actual, testCase.expected) { + t.Errorf("failed to decode chunk properly, expected: %+v, actual: %+v", testCase.expected, actual) + } + }) } } diff --git a/internal/encoders/chunk_test.go b/internal/encoders/chunk_test.go index 0c445a8..fbc6b70 100644 --- a/internal/encoders/chunk_test.go +++ b/internal/encoders/chunk_test.go @@ -1,7 +1,6 @@ package encoders import ( - "fmt" "reflect" "testing" @@ -57,13 +56,12 @@ func TestChunkEncoding(t *testing.T) { } for _, testCase := range testCases { + t.Run(testCase.description, func(t *testing.T) { + actual := EncodeChunk(testCase.chunk.Header.Id, testCase.chunk.ChunkData, testCase.chunk.Header.HasSubchunks) - actual := EncodeChunk(testCase.chunk.Header.Id, testCase.chunk.ChunkData, testCase.chunk.Header.HasSubchunks) - - if !reflect.DeepEqual(actual, testCase.expected) { - t.Errorf("Test '%s' failed to encode chunk properly", testCase.description) - fmt.Printf("expected: %v\n", testCase.expected) - fmt.Printf("actual: %v\n", actual) - } + if !reflect.DeepEqual(actual, testCase.expected) { + t.Errorf("failed to encode chunk properly, expected: %v, actual: %v\n", testCase.expected, actual) + } + }) } } diff --git a/internal/encoders/data_tracker_accel_chunk_test.go b/internal/encoders/data_tracker_accel_chunk_test.go index 0bf0554..50df257 100644 --- a/internal/encoders/data_tracker_accel_chunk_test.go +++ b/internal/encoders/data_tracker_accel_chunk_test.go @@ -1,7 +1,6 @@ package encoders import ( - "fmt" "reflect" "testing" @@ -28,13 +27,12 @@ func TestDataTrackerAccelChunkEncoding(t *testing.T) { } for _, testCase := range testCases { + t.Run(testCase.description, func(t *testing.T) { + actual := EncodeDataTrackerAccelChunk(testCase.data.X, testCase.data.Y, testCase.data.Z) - actual := EncodeDataTrackerAccelChunk(testCase.data.X, testCase.data.Y, testCase.data.Z) - - if !reflect.DeepEqual(actual, testCase.expected) { - t.Errorf("Test '%s' failed to encode chunk properly", testCase.description) - fmt.Printf("expected: %v\n", testCase.expected) - fmt.Printf("actual: %v\n", actual) - } + if !reflect.DeepEqual(actual, testCase.expected) { + t.Errorf("failed to encode chunk properly, expected: %v, actual: %v\n", testCase.expected, actual) + } + }) } } diff --git a/internal/encoders/data_tracker_ori_chunk_test.go b/internal/encoders/data_tracker_ori_chunk_test.go index 269d0e3..94196ee 100644 --- a/internal/encoders/data_tracker_ori_chunk_test.go +++ b/internal/encoders/data_tracker_ori_chunk_test.go @@ -1,7 +1,6 @@ package encoders import ( - "fmt" "reflect" "testing" @@ -28,13 +27,12 @@ func TestDataTrackerOriChunkEncoding(t *testing.T) { } for _, testCase := range testCases { + t.Run(testCase.description, func(t *testing.T) { + actual := EncodeDataTrackerOriChunk(testCase.data.X, testCase.data.Y, testCase.data.Z) - actual := EncodeDataTrackerOriChunk(testCase.data.X, testCase.data.Y, testCase.data.Z) - - if !reflect.DeepEqual(actual, testCase.expected) { - t.Errorf("Test '%s' failed to encode chunk properly", testCase.description) - fmt.Printf("expected: %v\n", testCase.expected) - fmt.Printf("actual: %v\n", actual) - } + if !reflect.DeepEqual(actual, testCase.expected) { + t.Errorf("failed to encode chunk properly, expected: %v, actual: %v\n", testCase.expected, actual) + } + }) } } diff --git a/internal/encoders/data_tracker_pos_chunk_test.go b/internal/encoders/data_tracker_pos_chunk_test.go index 10dd835..b57f110 100644 --- a/internal/encoders/data_tracker_pos_chunk_test.go +++ b/internal/encoders/data_tracker_pos_chunk_test.go @@ -1,7 +1,6 @@ package encoders import ( - "fmt" "reflect" "testing" @@ -28,13 +27,12 @@ func TestDataTrackerPosChunkEncoding(t *testing.T) { } for _, testCase := range testCases { + t.Run(testCase.description, func(t *testing.T) { + actual := EncodeDataTrackerPosChunk(testCase.data.X, testCase.data.Y, testCase.data.Z) - actual := EncodeDataTrackerPosChunk(testCase.data.X, testCase.data.Y, testCase.data.Z) - - if !reflect.DeepEqual(actual, testCase.expected) { - t.Errorf("Test '%s' failed to encode chunk properly", testCase.description) - fmt.Printf("expected: %v\n", testCase.expected) - fmt.Printf("actual: %v\n", actual) - } + if !reflect.DeepEqual(actual, testCase.expected) { + t.Errorf("failed to encode chunk properly, expected: %v, actual: %v\n", testCase.expected, actual) + } + }) } } diff --git a/internal/encoders/data_tracker_speed_chunk_test.go b/internal/encoders/data_tracker_speed_chunk_test.go index cf15862..e38e498 100644 --- a/internal/encoders/data_tracker_speed_chunk_test.go +++ b/internal/encoders/data_tracker_speed_chunk_test.go @@ -1,7 +1,6 @@ package encoders import ( - "fmt" "reflect" "testing" @@ -28,13 +27,12 @@ func TestDataTrackerSpeedChunkEncoding(t *testing.T) { } for _, testCase := range testCases { + t.Run(testCase.description, func(t *testing.T) { + actual := EncodeDataTrackerSpeedChunk(testCase.data.X, testCase.data.Y, testCase.data.Z) - actual := EncodeDataTrackerSpeedChunk(testCase.data.X, testCase.data.Y, testCase.data.Z) - - if !reflect.DeepEqual(actual, testCase.expected) { - t.Errorf("Test '%s' failed to encode chunk properly", testCase.description) - fmt.Printf("expected: %v\n", testCase.expected) - fmt.Printf("actual: %v\n", actual) - } + if !reflect.DeepEqual(actual, testCase.expected) { + t.Errorf("failed to encode chunk properly, expected: %v, actual: %v\n", testCase.expected, actual) + } + }) } } diff --git a/internal/encoders/data_tracker_status_chunk_test.go b/internal/encoders/data_tracker_status_chunk_test.go index a9df6b5..563ea95 100644 --- a/internal/encoders/data_tracker_status_chunk_test.go +++ b/internal/encoders/data_tracker_status_chunk_test.go @@ -1,7 +1,6 @@ package encoders import ( - "fmt" "reflect" "testing" @@ -26,13 +25,12 @@ func TestDataTrackerStatusChunkEncoding(t *testing.T) { } for _, testCase := range testCases { + t.Run(testCase.description, func(t *testing.T) { + actual := EncodeDataTrackerStatusChunk(testCase.data.Validity) - actual := EncodeDataTrackerStatusChunk(testCase.data.Validity) - - if !reflect.DeepEqual(actual, testCase.expected) { - t.Errorf("Test '%s' failed to encode chunk properly", testCase.description) - fmt.Printf("expected: %v\n", testCase.expected) - fmt.Printf("actual: %v\n", actual) - } + if !reflect.DeepEqual(actual, testCase.expected) { + t.Errorf("failed to encode chunk properly, expected: %v, actual: %v\n", testCase.expected, actual) + } + }) } } diff --git a/internal/encoders/data_tracker_timestamp_chunk_test.go b/internal/encoders/data_tracker_timestamp_chunk_test.go index c927c2c..7de2ddd 100644 --- a/internal/encoders/data_tracker_timestamp_chunk_test.go +++ b/internal/encoders/data_tracker_timestamp_chunk_test.go @@ -1,7 +1,6 @@ package encoders import ( - "fmt" "reflect" "testing" @@ -26,13 +25,12 @@ func TestDataTrackerTimestampChunkEncoding(t *testing.T) { } for _, testCase := range testCases { + t.Run(testCase.description, func(t *testing.T) { + actual := EncodeDataTrackerTimestampChunk(testCase.data.Timestamp) - actual := EncodeDataTrackerTimestampChunk(testCase.data.Timestamp) - - if !reflect.DeepEqual(actual, testCase.expected) { - t.Errorf("Test '%s' failed to encode chunk properly", testCase.description) - fmt.Printf("expected: %v\n", testCase.expected) - fmt.Printf("actual: %v\n", actual) - } + if !reflect.DeepEqual(actual, testCase.expected) { + t.Errorf("failed to encode chunk properly, expected: %v, actual: %v\n", testCase.expected, actual) + } + }) } } diff --git a/internal/encoders/data_tracker_trgtpos_chunk_test.go b/internal/encoders/data_tracker_trgtpos_chunk_test.go index 567e04b..0c54356 100644 --- a/internal/encoders/data_tracker_trgtpos_chunk_test.go +++ b/internal/encoders/data_tracker_trgtpos_chunk_test.go @@ -1,7 +1,6 @@ package encoders import ( - "fmt" "reflect" "testing" @@ -28,13 +27,13 @@ func TestDataTrackerTrgtPosChunkEncoding(t *testing.T) { } for _, testCase := range testCases { + t.Run(testCase.description, func(t *testing.T) { - actual := EncodeDataTrackerTrgtPosChunk(testCase.data.X, testCase.data.Y, testCase.data.Z) + actual := EncodeDataTrackerTrgtPosChunk(testCase.data.X, testCase.data.Y, testCase.data.Z) - if !reflect.DeepEqual(actual, testCase.expected) { - t.Errorf("Test '%s' failed to encode chunk properly", testCase.description) - fmt.Printf("expected: %v\n", testCase.expected) - fmt.Printf("actual: %v\n", actual) - } + if !reflect.DeepEqual(actual, testCase.expected) { + t.Errorf("failed to encode chunk properly, expected: %v, actual: %v\n", testCase.expected, actual) + } + }) } } diff --git a/internal/encoders/info_system_name_chunk_test.go b/internal/encoders/info_system_name_chunk_test.go index 0bee0ee..26dba00 100644 --- a/internal/encoders/info_system_name_chunk_test.go +++ b/internal/encoders/info_system_name_chunk_test.go @@ -1,7 +1,6 @@ package encoders import ( - "fmt" "reflect" "testing" @@ -26,13 +25,12 @@ func TestInfoSystemNameChunkEncoding(t *testing.T) { } for _, testCase := range testCases { + t.Run(testCase.description, func(t *testing.T) { + actual := EncodeInfoSystemNameChunk(testCase.data.SystemName) - actual := EncodeInfoSystemNameChunk(testCase.data.SystemName) - - if !reflect.DeepEqual(actual, testCase.expected) { - t.Errorf("Test '%s' failed to encode chunk properly", testCase.description) - fmt.Printf("expected: %v\n", testCase.expected) - fmt.Printf("actual: %v\n", actual) - } + if !reflect.DeepEqual(actual, testCase.expected) { + t.Errorf("failed to encode chunk properly, expected: %v, actual: %v\n", testCase.expected, actual) + } + }) } } diff --git a/internal/encoders/info_tracker_chunk_test.go b/internal/encoders/info_tracker_chunk_test.go index 53bc639..f2ce7a7 100644 --- a/internal/encoders/info_tracker_chunk_test.go +++ b/internal/encoders/info_tracker_chunk_test.go @@ -1,7 +1,6 @@ package encoders import ( - "fmt" "reflect" "testing" @@ -40,13 +39,12 @@ func TestInfoTrackerChunkEncoding(t *testing.T) { } for _, testCase := range testCases { + t.Run(testCase.description, func(t *testing.T) { + actual := EncodeInfoTrackerChunk(testCase.chunk.Chunk.Header.Id, EncodeInfoTrackerNameChunk(testCase.chunk.Data.TrackerName.Data.TrackerName)) - actual := EncodeInfoTrackerChunk(testCase.chunk.Chunk.Header.Id, EncodeInfoTrackerNameChunk(testCase.chunk.Data.TrackerName.Data.TrackerName)) - - if !reflect.DeepEqual(actual, testCase.expected) { - t.Errorf("Test '%s' failed to encode chunk properly", testCase.description) - fmt.Printf("expected: %v\n", testCase.expected) - fmt.Printf("actual: %v\n", actual) - } + if !reflect.DeepEqual(actual, testCase.expected) { + t.Errorf("failed to encode chunk properly, expected: %v, actual: %v\n", testCase.expected, actual) + } + }) } } diff --git a/internal/encoders/info_tracker_list_chunk_test.go b/internal/encoders/info_tracker_list_chunk_test.go index cbf2f6e..f3abc9f 100644 --- a/internal/encoders/info_tracker_list_chunk_test.go +++ b/internal/encoders/info_tracker_list_chunk_test.go @@ -1,7 +1,6 @@ package encoders import ( - "fmt" "reflect" "testing" @@ -50,18 +49,17 @@ func TestInfoTrackerListChunkEncoding(t *testing.T) { } for _, testCase := range testCases { + t.Run(testCase.description, func(t *testing.T) { + trackerChunks := [][]byte{} + for _, tracker := range testCase.chunk.Data.Trackers { + trackerChunks = append(trackerChunks, EncodeInfoTrackerChunk(tracker.Chunk.Header.Id, EncodeInfoTrackerNameChunk(tracker.Data.TrackerName.Data.TrackerName))) + } - trackerChunks := [][]byte{} - for _, tracker := range testCase.chunk.Data.Trackers { - trackerChunks = append(trackerChunks, EncodeInfoTrackerChunk(tracker.Chunk.Header.Id, EncodeInfoTrackerNameChunk(tracker.Data.TrackerName.Data.TrackerName))) - } + actual := EncodeInfoTrackerListChunk(trackerChunks) - actual := EncodeInfoTrackerListChunk(trackerChunks) - - if !reflect.DeepEqual(actual, testCase.expected) { - t.Errorf("Test '%s' failed to encode chunk properly", testCase.description) - fmt.Printf("expected: %v\n", testCase.expected) - fmt.Printf("actual: %v\n", actual) - } + if !reflect.DeepEqual(actual, testCase.expected) { + t.Errorf("failed to encode chunk properly, expected: %v, actual: %v\n", testCase.expected, actual) + } + }) } } diff --git a/internal/encoders/info_tracker_name_chunk_test.go b/internal/encoders/info_tracker_name_chunk_test.go index 4f82ea9..51cd062 100644 --- a/internal/encoders/info_tracker_name_chunk_test.go +++ b/internal/encoders/info_tracker_name_chunk_test.go @@ -1,7 +1,6 @@ package encoders import ( - "fmt" "reflect" "testing" @@ -26,13 +25,12 @@ func TestInfoTrackerNameChunkEncoding(t *testing.T) { } for _, testCase := range testCases { + t.Run(testCase.description, func(t *testing.T) { + actual := EncodeInfoTrackerNameChunk(testCase.data.TrackerName) - actual := EncodeInfoTrackerNameChunk(testCase.data.TrackerName) - - if !reflect.DeepEqual(actual, testCase.expected) { - t.Errorf("Test '%s' failed to encode chunk properly", testCase.description) - fmt.Printf("expected: %v\n", testCase.expected) - fmt.Printf("actual: %v\n", actual) - } + if !reflect.DeepEqual(actual, testCase.expected) { + t.Errorf("failed to encode chunk properly, expected: %v, actual: %v\n", testCase.expected, actual) + } + }) } } diff --git a/internal/encoders/packet_header_chunk_test.go b/internal/encoders/packet_header_chunk_test.go index 9149153..3bf19c5 100644 --- a/internal/encoders/packet_header_chunk_test.go +++ b/internal/encoders/packet_header_chunk_test.go @@ -1,7 +1,6 @@ package encoders import ( - "fmt" "reflect" "testing" @@ -30,13 +29,12 @@ func TestPacketHeaderChunkEncoding(t *testing.T) { } for _, testCase := range testCases { + t.Run(testCase.description, func(t *testing.T) { + actual := EncodePacketHeaderChunk(testCase.data.PacketTimestamp, testCase.data.VersionHigh, testCase.data.VersionLow, testCase.data.FrameId, testCase.data.FramePacketCount) - actual := EncodePacketHeaderChunk(testCase.data.PacketTimestamp, testCase.data.VersionHigh, testCase.data.VersionLow, testCase.data.FrameId, testCase.data.FramePacketCount) - - if !reflect.DeepEqual(actual, testCase.expected) { - t.Errorf("Test '%s' failed to encode chunk properly", testCase.description) - fmt.Printf("expected: %v\n", testCase.expected) - fmt.Printf("actual: %v\n", actual) - } + if !reflect.DeepEqual(actual, testCase.expected) { + t.Errorf("failed to encode chunk properly, expected: %v, actual: %v\n", testCase.expected, actual) + } + }) } }