From 145c13a9763498481e908983e4dc3fcceda36bc5 Mon Sep 17 00:00:00 2001
From: Joel Wetzell <git@jwetzell.com>
Date: Sun, 17 May 2026 09:25:27 -0500
Subject: [PATCH] some linting things

---
 decoder.go                      | 15 +++++++--------
 examples/benchmark/main.go      | 10 ++++++++--
 examples/psn_server/main.go     | 12 +++++++++---
 internal/decoders/chunk_test.go |  5 ++++-
 4 files changed, 28 insertions(+), 14 deletions(-)

diff --git a/decoder.go b/decoder.go
index bb81c70..83ede86 100644
--- a/decoder.go
+++ b/decoder.go
@@ -6,12 +6,10 @@ import (
 )
 
 type Decoder struct {
-	lastInfoPacketHeader *chunks.PacketHeaderChunk
-	lastDataPacketHeader *chunks.PacketHeaderChunk
-	infoPacketFrames     map[uint8][]chunks.InfoPacketChunk
-	dataPacketFrames     map[uint8][]chunks.DataPacketChunk
-	Trackers             map[uint16]*Tracker
-	SystemName           string
+	infoPacketFrames map[uint8][]chunks.InfoPacketChunk
+	dataPacketFrames map[uint8][]chunks.DataPacketChunk
+	Trackers         map[uint16]*Tracker
+	SystemName       string
 }
 
 func NewDecoder() *Decoder {
@@ -58,7 +56,8 @@ func (d *Decoder) Decode(bytes []byte) error {
 		return err
 	}
 
-	if chunk.Header.Id == 0x6756 {
+	switch chunk.Header.Id {
+	case 0x6756:
 		infoPacket, err := decoders.DecodeInfoPacketChunk(bytes)
 		if err != nil {
 			return err
@@ -76,7 +75,7 @@ func (d *Decoder) Decode(bytes []byte) error {
 			d.updateInfo(d.infoPacketFrames[currentInfoPacketHeader.Data.FrameId])
 			delete(d.infoPacketFrames, currentInfoPacketHeader.Data.FrameId)
 		}
-	} else if chunk.Header.Id == 0x6755 {
+	case 0x6755:
 		dataPacket, err := decoders.DecodeDataPacketChunk(bytes)
 		if err != nil {
 			return err
diff --git a/examples/benchmark/main.go b/examples/benchmark/main.go
index 6af9b99..bddcbc0 100644
--- a/examples/benchmark/main.go
+++ b/examples/benchmark/main.go
@@ -70,7 +70,10 @@ func benchmark(trackerCount int, iterations int, encoder psn.Encoder, decoder ps
 	dataDecodedStart := time.Now().UnixMicro()
 	for range iterations {
 		for _, packet := range latestEncodedPackets {
-			decoder.Decode(packet)
+			err := decoder.Decode(packet)
+			if err != nil {
+				fmt.Printf("failed to decode packet, error: %v\n", err)
+			}
 		}
 	}
 	benchmarkResults.data.decode = float64(time.Now().UnixMicro()-dataDecodedStart) / 1000.0
@@ -85,7 +88,10 @@ func benchmark(trackerCount int, iterations int, encoder psn.Encoder, decoder ps
 	infoDecodeStart := time.Now().UnixMicro()
 	for range iterations {
 		for _, packet := range latestEncodedPackets {
-			decoder.Decode(packet)
+			err := decoder.Decode(packet)
+			if err != nil {
+				fmt.Printf("failed to decode packet, error: %v\n", err)
+			}
 		}
 	}
 	benchmarkResults.info.decode = float64(time.Now().UnixMicro()-infoDecodeStart) / 1000.0
diff --git a/examples/psn_server/main.go b/examples/psn_server/main.go
index 150bfbd..96b00fb 100644
--- a/examples/psn_server/main.go
+++ b/examples/psn_server/main.go
@@ -72,13 +72,19 @@ func main() {
 			slog.Info("Sending Info Packets")
 			infoPackets := encoder.GetInfoPackets(uint64(timestamp), trackers)
 			for _, infoPacket := range infoPackets {
-				client.Write(infoPacket)
+				_, err := client.Write(infoPacket)
+				if err != nil {
+					slog.Error("failed to send info packet", "error", err)
+				}
 			}
 		case <-dataTicker.C:
 			slog.Info("Sending Data Packets")
 			dataPackets := encoder.GetDataPackets(uint64(timestamp), trackers)
-			for _, DataPacket := range dataPackets {
-				client.Write(DataPacket)
+			for _, dataPacket := range dataPackets {
+				_, err := client.Write(dataPacket)
+				if err != nil {
+					slog.Error("failed to send data packet", "error", err)
+				}
 			}
 			timestamp += 1
 		}
diff --git a/internal/decoders/chunk_test.go b/internal/decoders/chunk_test.go
index 175c8a0..4e0943d 100644
--- a/internal/decoders/chunk_test.go
+++ b/internal/decoders/chunk_test.go
@@ -106,6 +106,9 @@ func BenchmarkChunkDecoding(b *testing.B) {
 		0x80, 0x01, 0x00, 0x0d, 0x80, 0x00, 0x00, 0x09, 0x00, 0x54, 0x72, 0x61, 0x63, 0x6b, 0x65, 0x72, 0x20, 0x31,
 	}
 	for b.Loop() {
-		DecodeChunk(data)
+		_, err := DecodeChunk(data)
+		if err != nil {
+			b.Errorf("failed to decode chunk properly, error: %v", err)
+		}
 	}
 }