From 7bffb53691b59a32196afe6c0084277fed7c5531 Mon Sep 17 00:00:00 2001 From: Joel Wetzell Date: Tue, 15 Oct 2024 21:38:53 -0500 Subject: [PATCH] split up passing and failing tests --- packages/osc/tests/message-decode.test.js | 18 +++++++++++++++++- packages/osc/tests/message-encode.test.js | 4 +++- 2 files changed, 20 insertions(+), 2 deletions(-) diff --git a/packages/osc/tests/message-decode.test.js b/packages/osc/tests/message-decode.test.js index 4b798f2..d72c240 100644 --- a/packages/osc/tests/message-decode.test.js +++ b/packages/osc/tests/message-decode.test.js @@ -81,7 +81,14 @@ const goodTests = [ ], }, }, + { + description: 'simple address no type string', + bytes: new Uint8Array([47, 104, 101, 108, 108, 111, 0, 0]), expected: { + address: '/hello', + args: [], + }, + }, { description: 'osc 1.0 spec example 1', bytes: new Uint8Array([ @@ -146,9 +153,16 @@ const badTests = [ ]), throwsMessage: { name: /^Error$/, message: /not enough bytes/ }, }, + { + description: 'float64 bytes too small', + bytes: new Uint8Array([ + 47, 104, 101, 108, 108, 111, 0, 0, 44, 100, 0, 0, 0x40, 0x29, 0x87, 0xec, 0x82, 0x74, 0xb9, + ]), + throwsMessage: { name: /^Error$/, message: /not enough bytes/ }, + }, ]; -describe('OSC Message Decoding', () => { +describe('OSC Message Decoding Pass', () => { goodTests.forEach((messageTest) => { it(messageTest.description, () => { const [decoded, remainingBytes] = osc.messageFromBuffer(messageTest.bytes); @@ -156,7 +170,9 @@ describe('OSC Message Decoding', () => { deepEqual(decoded, messageTest.expected); }); }); +}); +describe('OSC Message Decoding Throws', () => { badTests.forEach((messageTest) => { it(messageTest.description, () => { throws(() => { diff --git a/packages/osc/tests/message-encode.test.js b/packages/osc/tests/message-encode.test.js index be36b7a..b09500f 100644 --- a/packages/osc/tests/message-encode.test.js +++ b/packages/osc/tests/message-encode.test.js @@ -141,14 +141,16 @@ const badTests = [ }, ]; -describe('OSC Message Encoding', () => { +describe('OSC Message Encoding Pass', () => { goodTests.forEach((messageTest) => { it(messageTest.description, () => { const encoded = osc.messageToBuffer(messageTest.message); deepEqual(encoded, messageTest.expected); }); }); +}); +describe('OSC Message Encoding Throws', () => { badTests.forEach((messageTest) => { it(messageTest.description, () => { throws(() => {