mirror of
https://github.com/cpvalente/ontime.git
synced 2026-08-04 06:58:02 +00:00
79a24a134e
* hotfix/6.0.2 fix issue where events could not have an ID * hotfix/6.0.2 version bump * hotfix/6.0.2 testing
524 lines
13 KiB
JavaScript
524 lines
13 KiB
JavaScript
import jest from 'jest-mock';
|
|
import {
|
|
makeString,
|
|
parseAliases_v1,
|
|
parseExcel_v1,
|
|
parseJson_v1,
|
|
validateEvent_v1,
|
|
} from '../parser.js';
|
|
import { dbModelv1 as dbModel } from '../../models/dataModel.js';
|
|
|
|
describe('test json parser with valid def', () => {
|
|
const testData = {
|
|
events: [
|
|
{
|
|
title: 'Guest Welcoming',
|
|
subtitle: '',
|
|
presenter: '',
|
|
note: '',
|
|
timeStart: 31500000,
|
|
timeEnd: 32400000,
|
|
isPublic: false,
|
|
type: 'event',
|
|
revision: 0,
|
|
id: '4b31',
|
|
},
|
|
{
|
|
title: 'Good Morning',
|
|
subtitle: 'Days schedule',
|
|
presenter: 'Carlos Valente',
|
|
note: '',
|
|
timeStart: 32400000,
|
|
timeEnd: 36000000,
|
|
isPublic: true,
|
|
type: 'event',
|
|
revision: 0,
|
|
id: 'f24d',
|
|
},
|
|
{
|
|
title: 'Stage 2 setup',
|
|
subtitle: '',
|
|
presenter: '',
|
|
note: '',
|
|
timeStart: 32400000,
|
|
timeEnd: 37200000,
|
|
isPublic: false,
|
|
type: 'event',
|
|
revision: 0,
|
|
id: 'bbc5',
|
|
},
|
|
{
|
|
title: 'Working Procedures',
|
|
subtitle: '',
|
|
presenter: 'Filip Johansen',
|
|
note: '',
|
|
timeStart: 37200000,
|
|
timeEnd: 39000000,
|
|
isPublic: true,
|
|
type: 'event',
|
|
revision: 0,
|
|
id: '5b3e',
|
|
},
|
|
{
|
|
title: 'Lunch',
|
|
subtitle: '',
|
|
presenter: '',
|
|
note: '',
|
|
timeStart: 39600000,
|
|
timeEnd: 45000000,
|
|
isPublic: false,
|
|
type: 'event',
|
|
revision: 0,
|
|
id: '8e2c',
|
|
},
|
|
{
|
|
title: 'A day being carlos',
|
|
subtitle: 'My life in a song',
|
|
presenter: 'Carlos Valente',
|
|
note: '',
|
|
timeStart: 46800000,
|
|
timeEnd: 50400000,
|
|
isPublic: true,
|
|
type: 'event',
|
|
revision: 0,
|
|
id: '08e9',
|
|
},
|
|
{
|
|
title: 'Hamburgers and Cheese',
|
|
subtitle: '... and other life questions',
|
|
presenter: 'Filip Johansen',
|
|
note: '',
|
|
timeStart: 54000000,
|
|
timeEnd: 57600000,
|
|
isPublic: true,
|
|
type: 'event',
|
|
revision: 0,
|
|
id: 'e25a',
|
|
},
|
|
],
|
|
event: {
|
|
title: 'This is a test definition',
|
|
url: 'www.carlosvalente.com',
|
|
publicInfo: 'WiFi: demoproject \nPassword: ontimeproject',
|
|
backstageInfo: 'WiFi: demobackstage\nPassword: ontimeproject',
|
|
},
|
|
settings: {
|
|
app: 'ontime',
|
|
version: 1,
|
|
},
|
|
};
|
|
|
|
let parseResponse;
|
|
|
|
beforeEach(async () => {
|
|
parseResponse = await parseJson_v1(testData);
|
|
});
|
|
|
|
it('has 7 events', () => {
|
|
const length = parseResponse?.events.length;
|
|
expect(length).toBe(7);
|
|
});
|
|
|
|
it('first event is as a match', () => {
|
|
const first = parseResponse?.events[0];
|
|
const expected = {
|
|
title: 'Guest Welcoming',
|
|
subtitle: '',
|
|
presenter: '',
|
|
note: '',
|
|
timeStart: 31500000,
|
|
timeEnd: 32400000,
|
|
isPublic: false,
|
|
type: 'event',
|
|
revision: 0,
|
|
id: '4b31',
|
|
};
|
|
expect(first).toStrictEqual(expected);
|
|
});
|
|
|
|
it('loaded event settings', () => {
|
|
const eventTitle = parseResponse?.event?.title;
|
|
expect(eventTitle).toBe('This is a test definition');
|
|
});
|
|
|
|
it('endMessage to exist but be empty', () => {
|
|
const endMessage = parseResponse?.event?.endMessage;
|
|
expect(endMessage).toBeDefined();
|
|
expect(endMessage).toBe('');
|
|
});
|
|
|
|
it('settings are for right app and version', () => {
|
|
const settings = parseResponse?.settings;
|
|
expect(settings.app).toBe('ontime');
|
|
expect(settings.version).toBe(1);
|
|
});
|
|
|
|
it('missing settings', () => {
|
|
const settings = parseResponse?.settings;
|
|
expect(settings.osc_port).toBeUndefined();
|
|
});
|
|
});
|
|
|
|
describe('test parser edge cases', () => {
|
|
it('generates missing ids', async () => {
|
|
const testData = {
|
|
events: [
|
|
{
|
|
title: 'Test Event',
|
|
type: 'event',
|
|
},
|
|
],
|
|
};
|
|
|
|
const parseResponse = await parseJson_v1(testData);
|
|
expect(parseResponse.events[0].id).toBeDefined();
|
|
});
|
|
|
|
it('detects duplicate Ids', async () => {
|
|
console.log = jest.fn();
|
|
const testData = {
|
|
events: [
|
|
{
|
|
title: 'Test Event 1',
|
|
type: 'event',
|
|
id: '1',
|
|
},
|
|
{
|
|
title: 'Test Event 2',
|
|
type: 'event',
|
|
id: '1',
|
|
},
|
|
],
|
|
};
|
|
|
|
const parseResponse = await parseJson_v1(testData);
|
|
expect(console.log).toHaveBeenCalledWith(
|
|
'ERROR: ID collision on import, skipping'
|
|
);
|
|
expect(parseResponse?.events.length).toBe(1);
|
|
});
|
|
|
|
it('handles incomplete datasets', async () => {
|
|
console.log = jest.fn();
|
|
const testData = {
|
|
events: [
|
|
{
|
|
title: 'Test Event 1',
|
|
id: '1',
|
|
},
|
|
{
|
|
title: 'Test Event 2',
|
|
id: '1',
|
|
},
|
|
],
|
|
};
|
|
|
|
const parseResponse = await parseJson_v1(testData);
|
|
expect(console.log).toHaveBeenCalledWith(
|
|
'ERROR: undefined event type, skipping'
|
|
);
|
|
|
|
expect(parseResponse?.events.length).toBe(0);
|
|
});
|
|
|
|
it('skips unknown app and version settings', async () => {
|
|
console.log = jest.fn();
|
|
const testData = {
|
|
settings: {
|
|
osc_port: 8888,
|
|
},
|
|
};
|
|
|
|
await parseJson_v1(testData);
|
|
expect(console.log).toHaveBeenCalledWith(
|
|
'ERROR: unknown app version, skipping'
|
|
);
|
|
});
|
|
});
|
|
|
|
describe('test corrupt data', () => {
|
|
it('handles some empty events', async () => {
|
|
const emptyEvents = {
|
|
events: [
|
|
{},
|
|
{},
|
|
{},
|
|
{
|
|
title: 'Test Event 1',
|
|
type: 'event',
|
|
id: '1',
|
|
},
|
|
{
|
|
title: 'Test Event 2',
|
|
type: 'event',
|
|
id: '2',
|
|
},
|
|
{},
|
|
{},
|
|
{},
|
|
],
|
|
event: {
|
|
title: 'All about Carlos demo event',
|
|
url: 'www.carlosvalente.com',
|
|
publicInfo: 'WiFi: demoproject \nPassword: ontimeproject',
|
|
backstageInfo: 'WiFi: demobackstage\nPassword: ontimeproject',
|
|
endMessage: '',
|
|
},
|
|
settings: {
|
|
app: 'ontime',
|
|
version: 1,
|
|
serverPort: 4001,
|
|
lock: null,
|
|
},
|
|
};
|
|
|
|
const parsedDef = await parseJson_v1(emptyEvents);
|
|
expect(parsedDef.events.length).toBe(2);
|
|
});
|
|
|
|
it('handles all empty events', async () => {
|
|
const emptyEvents = {
|
|
events: [{}, {}, {}, {}, {}, {}, {}, {}],
|
|
event: {
|
|
title: 'All about Carlos demo event',
|
|
url: 'www.carlosvalente.com',
|
|
publicInfo: 'WiFi: demoproject \nPassword: ontimeproject',
|
|
backstageInfo: 'WiFi: demobackstage\nPassword: ontimeproject',
|
|
endMessage: '',
|
|
},
|
|
settings: {
|
|
app: 'ontime',
|
|
version: 1,
|
|
serverPort: 4001,
|
|
lock: null,
|
|
},
|
|
};
|
|
|
|
const parsedDef = await parseJson_v1(emptyEvents);
|
|
expect(parsedDef.events.length).toBe(0);
|
|
});
|
|
|
|
it('handles missing event data', async () => {
|
|
const emptyEventData = {
|
|
events: [{}, {}, {}, {}, {}, {}, {}, {}],
|
|
event: {},
|
|
settings: {
|
|
app: 'ontime',
|
|
version: 1,
|
|
serverPort: 4001,
|
|
lock: null,
|
|
},
|
|
};
|
|
|
|
const parsedDef = await parseJson_v1(emptyEventData);
|
|
expect(parsedDef.event).toStrictEqual(dbModel.event);
|
|
});
|
|
|
|
it('handles missing settings', async () => {
|
|
const missingSettings = {
|
|
events: [{}, {}, {}, {}, {}, {}, {}, {}],
|
|
event: {},
|
|
settings: {
|
|
app: 'ontime',
|
|
version: 1,
|
|
},
|
|
};
|
|
|
|
const parsedDef = await parseJson_v1(missingSettings);
|
|
expect(parsedDef.settings).toStrictEqual(dbModel.settings);
|
|
});
|
|
|
|
it('fails with invalid JSON', async () => {
|
|
console.log = jest.fn();
|
|
const invalidJSON = 'some random dataset';
|
|
const parsedDef = await parseJson_v1(invalidJSON);
|
|
expect(console.log).toHaveBeenCalledWith('ERROR: Invalid JSON format');
|
|
expect(parsedDef).toBe(-1);
|
|
});
|
|
});
|
|
|
|
describe('test event validator', () => {
|
|
it('validates a good object', () => {
|
|
const event = {
|
|
title: 'test',
|
|
};
|
|
const validated = validateEvent_v1(event);
|
|
|
|
expect(validated).toEqual(
|
|
expect.objectContaining({
|
|
title: expect.any(String),
|
|
subtitle: expect.any(String),
|
|
presenter: expect.any(String),
|
|
note: expect.any(String),
|
|
timeStart: expect.any(Number),
|
|
timeEnd: expect.any(Number),
|
|
isPublic: expect.any(Boolean),
|
|
revision: expect.any(Number),
|
|
type: expect.any(String),
|
|
id: expect.any(String),
|
|
})
|
|
);
|
|
});
|
|
|
|
it('fails an empty object', () => {
|
|
const event = {};
|
|
const validated = validateEvent_v1(event);
|
|
expect(validated).toEqual(null);
|
|
});
|
|
|
|
it('makes objects strings', () => {
|
|
const event = {
|
|
title: 2,
|
|
subtitle: true,
|
|
presenter: 3.2,
|
|
note: '1899-12-30T08:00:10.000Z',
|
|
};
|
|
const validated = validateEvent_v1(event);
|
|
expect(typeof validated.title).toEqual('string');
|
|
expect(typeof validated.subtitle).toEqual('string');
|
|
expect(typeof validated.presenter).toEqual('string');
|
|
expect(typeof validated.note).toEqual('string');
|
|
});
|
|
|
|
it('enforces numbers on times', () => {
|
|
const event = {
|
|
timeStart: false,
|
|
timeEnd: '2',
|
|
};
|
|
const validated = validateEvent_v1(event);
|
|
expect(typeof validated.timeStart).toEqual('number');
|
|
expect(validated.timeStart).toEqual(0);
|
|
expect(typeof validated.timeEnd).toEqual('number');
|
|
expect(validated.timeEnd).toEqual(0);
|
|
});
|
|
|
|
it('handles bad objects', () => {
|
|
const event = {
|
|
title: {},
|
|
};
|
|
const validated = validateEvent_v1(event);
|
|
expect(typeof validated.title).toEqual('string');
|
|
});
|
|
});
|
|
|
|
describe('test makeString function', () => {
|
|
it('converts variables to string', () => {
|
|
let val = 2;
|
|
let expected = '2';
|
|
let converted = makeString(val);
|
|
expect(converted).toBe(expected);
|
|
|
|
val = 2.22222222;
|
|
expected = '2.22222222';
|
|
converted = makeString(val);
|
|
expect(converted).toBe(expected);
|
|
|
|
val = ['testing'];
|
|
expected = 'testing';
|
|
converted = makeString(val);
|
|
expect(converted).toBe(expected);
|
|
|
|
val = { doing: 'testing' };
|
|
converted = makeString(val, 'fallback');
|
|
expect(converted).toBe('fallback');
|
|
});
|
|
});
|
|
|
|
describe('test parseExcel function', () => {
|
|
it('parses the example file', async () => {
|
|
const testdata = [
|
|
['Ontime ┬À Schedule Template'],
|
|
[],
|
|
['Event Name', 'Test Event'],
|
|
['Event URL', 'www.carlosvalente.com'],
|
|
[],
|
|
[],
|
|
[
|
|
'Time Start',
|
|
'Time End',
|
|
'Event Title',
|
|
'Presenter Name',
|
|
'Event Subtitle',
|
|
'Is Public? (x)',
|
|
'Notes',
|
|
],
|
|
[
|
|
'1899-12-30T07:00:00.000Z',
|
|
'1899-12-30T08:00:10.000Z',
|
|
'Guest Welcome',
|
|
'Carlos',
|
|
'Getting things started',
|
|
'x',
|
|
'Ballyhoo',
|
|
],
|
|
[
|
|
'1899-12-30T08:00:00.000Z',
|
|
'1899-12-30T08:30:00.000Z',
|
|
'A song from the hearth',
|
|
'Still Carlos',
|
|
'Derailing early',
|
|
'',
|
|
'Rainbow chase',
|
|
],
|
|
[],
|
|
];
|
|
|
|
const expectedParsedEvents = [
|
|
{
|
|
timeStart: 25200000,
|
|
timeEnd: 28810000,
|
|
title: 'Guest Welcome',
|
|
presenter: 'Carlos',
|
|
subtitle: 'Getting things started',
|
|
isPublic: true,
|
|
note: 'Ballyhoo',
|
|
type: 'event',
|
|
},
|
|
{
|
|
timeStart: 28800000,
|
|
timeEnd: 30600000,
|
|
title: 'A song from the hearth',
|
|
presenter: 'Still Carlos',
|
|
subtitle: 'Derailing early',
|
|
isPublic: false,
|
|
note: 'Rainbow chase',
|
|
type: 'event',
|
|
},
|
|
];
|
|
|
|
const parsedData = await parseExcel_v1(testdata);
|
|
|
|
expect(parsedData.events).toBeDefined();
|
|
expect(parsedData.events.title).toBe(expectedParsedEvents.title);
|
|
expect(parsedData.events.presenter).toBe(expectedParsedEvents.presenter);
|
|
expect(parsedData.events.subtitle).toBe(expectedParsedEvents.subtitle);
|
|
expect(parsedData.events.isPublic).toBe(expectedParsedEvents.isPublic);
|
|
expect(parsedData.events.note).toBe(expectedParsedEvents.note);
|
|
expect(parsedData.events.type).toBe(expectedParsedEvents.type);
|
|
});
|
|
});
|
|
|
|
describe('test aliases import', () => {
|
|
it('imports a well defined alias', () => {});
|
|
const testData = {
|
|
events: [],
|
|
settings: {
|
|
app: 'ontime',
|
|
version: 1,
|
|
},
|
|
aliases: [
|
|
{
|
|
enabled: false,
|
|
alias: 'testalias',
|
|
pathAndParams: 'testpathAndParams',
|
|
},
|
|
],
|
|
};
|
|
|
|
const parsed = parseAliases_v1(testData, true);
|
|
expect(parsed.length).toBe(1);
|
|
|
|
// generates missing id
|
|
expect(parsed[0].id).toBeDefined();
|
|
});
|