Compare commits

..

1 Commits

Author SHA1 Message Date
Claude e9de1ec19f fix: prevent white background flash and overscroll on Safari iOS
- Set background-color: #101010 on html/body/.App so the Safari iOS
  rubber-band overscroll area is dark instead of white
- Always render body background style in ViewLoader (not just during
  Suspense fallback) so keyColour param and --background-color-override
  propagate to the body for the overscroll region
- Add viewport-fit=cover, apple-mobile-web-app meta tags for proper
  iOS notch/safe-area handling
- Fix manifest.json background_color from #ffffff to #101010
- Align theme_color across both manifests to #101010

https://claude.ai/code/session_016z5vU45pexTdkQV2eHJqh4
2026-05-09 16:35:53 +00:00
91 changed files with 1494 additions and 3175 deletions
+2 -2
View File
@@ -20,13 +20,13 @@ jobs:
node-version-file: '.nvmrc' node-version-file: '.nvmrc'
- name: Setup pnpm - name: Setup pnpm
uses: pnpm/action-setup@v6 uses: pnpm/action-setup@v4
- name: Get pnpm store directory - name: Get pnpm store directory
run: echo "PNPM_STORE_PATH=$(pnpm store path --silent)" >> $GITHUB_ENV run: echo "PNPM_STORE_PATH=$(pnpm store path --silent)" >> $GITHUB_ENV
- name: Setup pnpm cache - name: Setup pnpm cache
uses: actions/cache@v5 uses: actions/cache@v4
with: with:
path: ${{ env.PNPM_STORE_PATH }} path: ${{ env.PNPM_STORE_PATH }}
key: ${{ runner.os }}-pnpm-store-${{ hashFiles('pnpm-lock.yaml') }} key: ${{ runner.os }}-pnpm-store-${{ hashFiles('pnpm-lock.yaml') }}
+2 -2
View File
@@ -15,13 +15,13 @@ jobs:
- uses: actions/checkout@v6 - uses: actions/checkout@v6
- name: Setup pnpm - name: Setup pnpm
uses: pnpm/action-setup@v6 uses: pnpm/action-setup@v4
- name: Get pnpm store directory - name: Get pnpm store directory
run: echo "PNPM_STORE_PATH=$(pnpm store path --silent)" >> $GITHUB_ENV run: echo "PNPM_STORE_PATH=$(pnpm store path --silent)" >> $GITHUB_ENV
- name: Setup pnpm cache - name: Setup pnpm cache
uses: actions/cache@v5 uses: actions/cache@v4
with: with:
path: ${{ env.PNPM_STORE_PATH }} path: ${{ env.PNPM_STORE_PATH }}
key: ${{ runner.os }}-pnpm-store-${{ hashFiles('pnpm-lock.yaml') }} key: ${{ runner.os }}-pnpm-store-${{ hashFiles('pnpm-lock.yaml') }}
+4 -4
View File
@@ -17,13 +17,13 @@ jobs:
node-version-file: '.nvmrc' node-version-file: '.nvmrc'
- name: Setup pnpm - name: Setup pnpm
uses: pnpm/action-setup@v6 uses: pnpm/action-setup@v4
- name: Get pnpm store directory - name: Get pnpm store directory
run: echo "PNPM_STORE_PATH=$(pnpm store path --silent)" >> $GITHUB_ENV run: echo "PNPM_STORE_PATH=$(pnpm store path --silent)" >> $GITHUB_ENV
- name: Setup pnpm cache - name: Setup pnpm cache
uses: actions/cache@v5 uses: actions/cache@v4
with: with:
path: ${{ env.PNPM_STORE_PATH }} path: ${{ env.PNPM_STORE_PATH }}
key: ${{ runner.os }}-pnpm-store-${{ hashFiles('pnpm-lock.yaml') }} key: ${{ runner.os }}-pnpm-store-${{ hashFiles('pnpm-lock.yaml') }}
@@ -74,7 +74,7 @@ jobs:
node-version-file: '.nvmrc' node-version-file: '.nvmrc'
- name: Setup pnpm - name: Setup pnpm
uses: pnpm/action-setup@v6 uses: pnpm/action-setup@v4
- name: Install dependencies - name: Install dependencies
run: pnpm install --frozen-lockfile run: pnpm install --frozen-lockfile
@@ -111,7 +111,7 @@ jobs:
node-version-file: '.nvmrc' node-version-file: '.nvmrc'
- name: Setup pnpm - name: Setup pnpm
uses: pnpm/action-setup@v6 uses: pnpm/action-setup@v4
- name: Install dependencies - name: Install dependencies
run: pnpm install --frozen-lockfile run: pnpm install --frozen-lockfile
+2 -2
View File
@@ -18,13 +18,13 @@ jobs:
node-version-file: '.nvmrc' node-version-file: '.nvmrc'
- name: Setup pnpm - name: Setup pnpm
uses: pnpm/action-setup@v6 uses: pnpm/action-setup@v4
- name: Get pnpm store directory - name: Get pnpm store directory
run: echo "PNPM_STORE_PATH=$(pnpm store path --silent)" >> $GITHUB_ENV run: echo "PNPM_STORE_PATH=$(pnpm store path --silent)" >> $GITHUB_ENV
- name: Setup pnpm cache - name: Setup pnpm cache
uses: actions/cache@v5 uses: actions/cache@v4
with: with:
path: ${{ env.PNPM_STORE_PATH }} path: ${{ env.PNPM_STORE_PATH }}
key: ${{ runner.os }}-pnpm-store-${{ hashFiles('pnpm-lock.yaml') }} key: ${{ runner.os }}-pnpm-store-${{ hashFiles('pnpm-lock.yaml') }}
+7 -15
View File
@@ -15,18 +15,14 @@ jobs:
steps: steps:
- uses: actions/checkout@v6 - uses: actions/checkout@v6
- uses: actions/setup-node@v6
with:
node-version-file: '.nvmrc'
- name: Setup pnpm - name: Setup pnpm
uses: pnpm/action-setup@v6 uses: pnpm/action-setup@v4
- name: Get pnpm store directory - name: Get pnpm store directory
run: echo "PNPM_STORE_PATH=$(pnpm store path --silent)" >> $GITHUB_ENV run: echo "PNPM_STORE_PATH=$(pnpm store path --silent)" >> $GITHUB_ENV
- name: Setup pnpm cache - name: Setup pnpm cache
uses: actions/cache@v5 uses: actions/cache@v4
with: with:
path: ${{ env.PNPM_STORE_PATH }} path: ${{ env.PNPM_STORE_PATH }}
key: ${{ runner.os }}-pnpm-store-${{ hashFiles('pnpm-lock.yaml') }} key: ${{ runner.os }}-pnpm-store-${{ hashFiles('pnpm-lock.yaml') }}
@@ -58,18 +54,14 @@ jobs:
steps: steps:
- uses: actions/checkout@v6 - uses: actions/checkout@v6
- uses: actions/setup-node@v6
with:
node-version-file: '.nvmrc'
- name: Setup pnpm - name: Setup pnpm
uses: pnpm/action-setup@v6 uses: pnpm/action-setup@v4
- name: Get pnpm store directory - name: Get pnpm store directory
run: echo "PNPM_STORE_PATH=$(pnpm store path --silent)" >> $GITHUB_ENV run: echo "PNPM_STORE_PATH=$(pnpm store path --silent)" >> $GITHUB_ENV
- name: Setup pnpm cache - name: Setup pnpm cache
uses: actions/cache@v5 uses: actions/cache@v4
with: with:
path: ${{ env.PNPM_STORE_PATH }} path: ${{ env.PNPM_STORE_PATH }}
key: ${{ runner.os }}-pnpm-store-${{ hashFiles('pnpm-lock.yaml') }} key: ${{ runner.os }}-pnpm-store-${{ hashFiles('pnpm-lock.yaml') }}
@@ -82,18 +74,18 @@ jobs:
- name: Get installed Playwright version - name: Get installed Playwright version
run: echo "PLAYWRIGHT_VERSION=$(pnpm ls @playwright/test --parseable | cut -s -d '@' -f3 | cut -d '/' -f1)" >> $GITHUB_ENV run: echo "PLAYWRIGHT_VERSION=$(pnpm ls @playwright/test --parseable | cut -s -d '@' -f3 | cut -d '/' -f1)" >> $GITHUB_ENV
- name: Cache playwright binaries - name: Cache playwright binaries
uses: actions/cache@v5 uses: actions/cache@v4
with: with:
path: | path: |
~/.cache/ms-playwright ~/.cache/ms-playwright
key: ${{ runner.os }}-playwright-${{ env.PLAYWRIGHT_VERSION }} key: ${{ runner.os }}-playwright-${{ env.PLAYWRIGHT_VERSION }}
restore-keys: | restore-keys: |
${{ runner.os }}-playwright- ${{ runner.os }}-playwright-
- run: pnpm playwright install --with-deps - run: npx playwright install --with-deps
if: steps.playwright-cache.outputs.cache-hit != 'true' if: steps.playwright-cache.outputs.cache-hit != 'true'
- name: Install Playwright Browsers - name: Install Playwright Browsers
run: pnpm playwright install --with-deps run: npx playwright install --with-deps
- name: Run Playwright tests - name: Run Playwright tests
run: pnpm e2e run: pnpm e2e
+1 -1
View File
@@ -1 +1 @@
v22.22.3 v22.15.1
+1 -1
View File
@@ -1,4 +1,4 @@
ARG NODE_VERSION=22.22.2 ARG NODE_VERSION=22.15.1
FROM node:${NODE_VERSION}-alpine FROM node:${NODE_VERSION}-alpine
# Set environment variables # Set environment variables
+1 -1
View File
@@ -1,6 +1,6 @@
{ {
"name": "@getontime/cli", "name": "@getontime/cli",
"version": "4.9.0", "version": "4.7.0",
"author": "Carlos Valente", "author": "Carlos Valente",
"description": "Time keeping for live events", "description": "Time keeping for live events",
"repository": "https://github.com/cpvalente/ontime", "repository": "https://github.com/cpvalente/ontime",
+2 -8
View File
@@ -6,8 +6,9 @@
<link rel="icon" href="favicon.ico" /> <link rel="icon" href="favicon.ico" />
<meta name="viewport" content="width=device-width, initial-scale=1, viewport-fit=cover" /> <meta name="viewport" content="width=device-width, initial-scale=1, viewport-fit=cover" />
<meta name="theme-color" content="#101010" /> <meta name="theme-color" content="#101010" />
<meta name="ontime" content="ontime - time keeping for live events" /> <meta name="apple-mobile-web-app-capable" content="yes" />
<meta name="apple-mobile-web-app-status-bar-style" content="black-translucent" /> <meta name="apple-mobile-web-app-status-bar-style" content="black-translucent" />
<meta name="ontime" content="ontime - time keeping for live events" />
<link rel="apple-touch-icon" href="ontime-logo.png" /> <link rel="apple-touch-icon" href="ontime-logo.png" />
<link rel="icon" type="image/png" href="ontime-logo.png" /> <link rel="icon" type="image/png" href="ontime-logo.png" />
<link rel="manifest" href="site.webmanifest" /> <link rel="manifest" href="site.webmanifest" />
@@ -18,13 +19,6 @@
<body> <body>
<noscript>You need to enable JavaScript to run this app.</noscript> <noscript>You need to enable JavaScript to run this app.</noscript>
<div id="root"></div> <div id="root"></div>
<script>
if (/\/timer\/?$/.test(window.location.pathname) && typeof Promise.any !== 'function') {
var b = document.querySelector('base');
var base = b ? (b.getAttribute('href') || '').replace(/\/$/, '') : '';
window.location.replace(base + '/timer-legacy' + window.location.search);
}
</script>
<script type="module" src="/src/index.tsx"></script> <script type="module" src="/src/index.tsx"></script>
</body> </body>
</html> </html>
+4 -5
View File
@@ -1,6 +1,6 @@
{ {
"name": "ontime-ui", "name": "ontime-ui",
"version": "4.9.0", "version": "4.7.0",
"private": true, "private": true,
"type": "module", "type": "module",
"dependencies": { "dependencies": {
@@ -32,6 +32,7 @@
"react-icons": "5.5.0", "react-icons": "5.5.0",
"react-router": "^7.11.0", "react-router": "^7.11.0",
"react-virtuoso": "^4.17.0", "react-virtuoso": "^4.17.0",
"web-vitals": "^5.1.0",
"zustand": "^5.0.9" "zustand": "^5.0.9"
}, },
"scripts": { "scripts": {
@@ -50,8 +51,7 @@
"production": [ "production": [
">0.2%", ">0.2%",
"not dead", "not dead",
"not op_mini all", "not op_mini all"
"safari >= 14.1"
], ],
"development": [ "development": [
"last 1 chrome version", "last 1 chrome version",
@@ -64,10 +64,8 @@
"@types/qrcode": "^1.5.6", "@types/qrcode": "^1.5.6",
"@types/react": "^19.1.12", "@types/react": "^19.1.12",
"@types/react-dom": "^19.1.9", "@types/react-dom": "^19.1.9",
"@vitejs/plugin-legacy": "^8.0.1",
"@vitejs/plugin-react": "5.2.0", "@vitejs/plugin-react": "5.2.0",
"babel-plugin-react-compiler": "1.0.0", "babel-plugin-react-compiler": "1.0.0",
"happy-dom": "^20.9.0",
"ontime-types": "workspace:*", "ontime-types": "workspace:*",
"ontime-utils": "workspace:*", "ontime-utils": "workspace:*",
"sass": "^1.57.1", "sass": "^1.57.1",
@@ -75,6 +73,7 @@
"vite": "8.0.1", "vite": "8.0.1",
"vite-plugin-compression2": "2.5.1", "vite-plugin-compression2": "2.5.1",
"vite-plugin-svgr": "4.5.0", "vite-plugin-svgr": "4.5.0",
"vite-tsconfig-paths": "6.1.1",
"vitest": "catalog:" "vitest": "catalog:"
} }
} }
+1 -1
View File
@@ -14,6 +14,6 @@
"scope": "./", "scope": "./",
"start_url": "./", "start_url": "./",
"display": "", "display": "",
"theme_color": "#121212", "theme_color": "#101010",
"background_color": "#101010" "background_color": "#101010"
} }
+1 -1
View File
@@ -2,7 +2,7 @@
"name": "", "name": "",
"short_name": "", "short_name": "",
"icons": [{ "src": "ontime-logo.png", "sizes": "295x295", "type": "image/png" }], "icons": [{ "src": "ontime-logo.png", "sizes": "295x295", "type": "image/png" }],
"theme_color": "#121212", "theme_color": "#101010",
"background_color": "#101010", "background_color": "#101010",
"display": "standalone" "display": "standalone"
} }
+11 -22
View File
@@ -34,17 +34,19 @@ export async function fetchCurrentRundown(options?: RequestOptions): Promise<Run
throw new Error('Invalid rundown payload'); throw new Error('Invalid rundown payload');
} }
return res.data; return res.data;
}
/** function isValidRundown(x: any): x is Rundown {
* HTTP request to fetch all entries in the given rundown return (
*/ x &&
export async function fetchRundown(rundownId: RundownId, options?: RequestOptions): Promise<Rundown> { typeof x === 'object' &&
const res = await axios.get(`${rundownPath}/${rundownId}`, { signal: options?.signal }); typeof x.id === 'string' &&
if (!isValidRundown(res.data)) { Array.isArray(x.order) &&
throw new Error('Invalid rundown payload'); Array.isArray(x.flatOrder) &&
x.entries &&
typeof x.entries === 'object' &&
typeof x.revision === 'number'
);
} }
return res.data;
} }
/** /**
@@ -195,16 +197,3 @@ export async function requestDeleteAll(rundownId: RundownId): Promise<AxiosRespo
} }
// #endregion operations on rundown entries ======================= // #endregion operations on rundown entries =======================
function isValidRundown(x: any): x is Rundown {
return (
x &&
typeof x === 'object' &&
typeof x.id === 'string' &&
Array.isArray(x.order) &&
Array.isArray(x.flatOrder) &&
x.entries &&
typeof x.entries === 'object' &&
typeof x.revision === 'number'
);
}
@@ -3,8 +3,8 @@ import { ChangeEvent, KeyboardEvent, RefObject, useCallback, useEffect, useMemo,
interface UseReactiveTextInputReturn { interface UseReactiveTextInputReturn {
value: string; value: string;
onChange: (event: ChangeEvent<HTMLInputElement | HTMLTextAreaElement>) => void; onChange: (event: ChangeEvent) => void;
onBlur: (event: ChangeEvent<HTMLInputElement | HTMLTextAreaElement>) => void; onBlur: (event: ChangeEvent) => void;
onKeyDown: (event: KeyboardEvent<HTMLElement>) => void; onKeyDown: (event: KeyboardEvent<HTMLElement>) => void;
} }
@@ -15,9 +15,7 @@ export default function useReactiveTextInput(
options?: { options?: {
submitOnEnter?: boolean; submitOnEnter?: boolean;
submitOnCtrlEnter?: boolean; submitOnCtrlEnter?: boolean;
submitOnTab?: boolean;
onCancelUpdate?: () => void; onCancelUpdate?: () => void;
onTabCancel?: () => void;
allowSubmitSameValue?: boolean; allowSubmitSameValue?: boolean;
allowKeyboardNavigation?: boolean; allowKeyboardNavigation?: boolean;
}, },
@@ -25,10 +23,6 @@ export default function useReactiveTextInput(
const [text, setText] = useState<string>(initialText); const [text, setText] = useState<string>(initialText);
// track whether we are submitting via a submit key (eg enter) and avoid submitting again on blur // track whether we are submitting via a submit key (eg enter) and avoid submitting again on blur
const isKeyboardSubmitting = useRef(false); const isKeyboardSubmitting = useRef(false);
// track escape to prevent the subsequent blur from submitting
const isEscaping = useRef(false);
// track tab-out to prevent blur from submitting (used by timer cells)
const isTabbing = useRef(false);
useEffect(() => { useEffect(() => {
if (typeof initialText === 'undefined') { if (typeof initialText === 'undefined') {
@@ -84,7 +78,6 @@ export default function useReactiveTextInput(
* @param {string} valueToSubmit * @param {string} valueToSubmit
*/ */
const handleEscape = useCallback(() => { const handleEscape = useCallback(() => {
isEscaping.current = true;
// No need to update if it hasn't changed // No need to update if it hasn't changed
setText(initialText); setText(initialText);
// force the text to be the initial value // force the text to be the initial value
@@ -148,30 +141,16 @@ export default function useReactiveTextInput(
event.stopPropagation(); event.stopPropagation();
} }
// for cells that opt out of tab-submit, track tab-out without preventing navigation
if (event.key === 'Tab' && options?.submitOnTab === false) {
isTabbing.current = true;
}
hotKeyHandler(event); hotKeyHandler(event);
}; };
}, [handleEscape, handleSubmit, options?.submitOnCtrlEnter, options?.submitOnEnter, options?.submitOnTab, text]); }, [handleEscape, handleSubmit, options?.submitOnCtrlEnter, options?.submitOnEnter, text]);
return { return {
value: text, value: text,
onChange: (event) => handleChange(event.target.value), onChange: (event: ChangeEvent) => handleChange((event.target as HTMLInputElement).value),
onBlur: (event) => { onBlur: (event: ChangeEvent) => {
if (isTabbing.current) {
isTabbing.current = false;
(options?.onTabCancel ?? options?.onCancelUpdate)?.();
return;
}
if (isEscaping.current) {
isEscaping.current = false;
return;
}
if (!isKeyboardSubmitting.current) { if (!isKeyboardSubmitting.current) {
handleSubmit(event.target.value); handleSubmit((event.target as HTMLInputElement).value);
} }
}, },
onKeyDown: keyHandler, onKeyDown: keyHandler,
@@ -8,12 +8,9 @@
padding-top: 10vh; padding-top: 10vh;
} }
.inline { .empty {
display: flex; width: 100%;
align-items: center; opacity: 0.8;
justify-content: center;
gap: 1rem;
margin-top: 1em;
} }
.text { .text {
@@ -1,33 +1,18 @@
import { SupportedEntry } from 'ontime-types'; import EmptyImage from '../../../assets/images/empty.svg?react';
import { IoAdd } from 'react-icons/io5';
import { useTranslation } from '../../../translation/TranslationProvider';
import Button from '../buttons/Button';
import Empty from './Empty';
import style from './EmptyTableBody.module.scss'; import style from './EmptyTableBody.module.scss';
interface EmptyTableBodyProps { interface EmptyTableBodyProps {
handleAddNew?: (type: SupportedEntry) => void; text: string;
} }
export default function EmptyTableBody({ handleAddNew }: EmptyTableBodyProps) { export default function EmptyTableBody({ text }: EmptyTableBodyProps) {
const { getLocalizedString } = useTranslation();
const text = getLocalizedString('common.no_data');
return ( return (
<tbody className={style.emptyContainer}> <tbody className={style.emptyContainer}>
<tr> <tr>
<td colSpan={99} className={style.emptyCell}> <td colSpan={99} className={style.emptyCell}>
<Empty injectedStyles={{ marginTop: '5vh' }} /> <EmptyImage className={style.empty} />
<span className={style.text}>{text}</span> {text && <span className={style.text}>{text}</span>}
{handleAddNew && (
<div className={style.inline}>
<Button onClick={() => handleAddNew(SupportedEntry.Event)} variant='primary' size='large'>
<IoAdd />
Create Event
</Button>
</div>
)}
</td> </td>
</tr> </tr>
</tbody> </tbody>
@@ -12,7 +12,6 @@ import {
renameRundown, renameRundown,
} from '../api/rundown'; } from '../api/rundown';
//TODO: make suspends so we don't have to deal with no value all over
/** /**
* Project rundowns * Project rundowns
*/ */
@@ -4,7 +4,7 @@ import { useEffect, useMemo } from 'react';
import { queryRefetchIntervalSlow } from '../../ontimeConfig'; import { queryRefetchIntervalSlow } from '../../ontimeConfig';
import { CURRENT_RUNDOWN_QUERY_KEY, getRundownQueryKey } from '../api/constants'; import { CURRENT_RUNDOWN_QUERY_KEY, getRundownQueryKey } from '../api/constants';
import { fetchCurrentRundown, fetchRundown } from '../api/rundown'; import { fetchCurrentRundown } from '../api/rundown';
import { useSelectedEventId } from '../hooks/useSocket'; import { useSelectedEventId } from '../hooks/useSocket';
import { ExtendedEntry, getFlatRundownMetadata, getRundownMetadata } from '../utils/rundownMetadata'; import { ExtendedEntry, getFlatRundownMetadata, getRundownMetadata } from '../utils/rundownMetadata';
import { useProjectRundowns } from './useProjectRundowns'; import { useProjectRundowns } from './useProjectRundowns';
@@ -20,11 +20,7 @@ const cachedRundownPlaceholder: Rundown = {
}; };
/** /**
* Normalised rundown data for the currently loaded rundown. * Normalised rundown data
*
* Bootstraps via the `/current` alias so the first paint is a single round-trip,
* independent of the project rundown list. Once the loaded id is known, the
* query key swaps to the id-keyed cache that is shared with `useRundownById`.
*/ */
export default function useRundown() { export default function useRundown() {
const queryClient = useQueryClient(); const queryClient = useQueryClient();
@@ -38,13 +34,12 @@ export default function useRundown() {
refetchInterval: queryRefetchIntervalSlow, refetchInterval: queryRefetchIntervalSlow,
}); });
// Seed the id-keyed cache when fetching via the bootstrap alias // Seed the ID-based cache when fetching via the 'current' alias (bootstrap)
useEffect(() => { useEffect(() => {
if (!data || loadedRundownId) return; if (!data || loadedRundownId) return;
queryClient.setQueryData(getRundownQueryKey(data.id), data); queryClient.setQueryData(getRundownQueryKey(data.id), data);
}, [data, loadedRundownId, queryClient]); }, [data, loadedRundownId, queryClient]);
// Once we have the ID, drop the temporary current cache
useEffect(() => { useEffect(() => {
if (!loadedRundownId) return; if (!loadedRundownId) return;
queryClient.removeQueries({ queryKey: CURRENT_RUNDOWN_QUERY_KEY, exact: true }); queryClient.removeQueries({ queryKey: CURRENT_RUNDOWN_QUERY_KEY, exact: true });
@@ -119,21 +114,3 @@ export function useRundownAuxData() {
}, [data]); }, [data]);
return { data: filteredData, status }; return { data: filteredData, status };
} }
/**
* Provides access to a specific rundown by ID.
* When rundownId is null/undefined the query is disabled and returns the placeholder.
*/
export function useRundownById(rundownId: string | null | undefined) {
const enabled = Boolean(rundownId);
const { data, status, isError, refetch, isFetching } = useQuery<Rundown>({
queryKey: getRundownQueryKey(rundownId ?? ''),
queryFn: ({ signal }) => fetchRundown(rundownId!, { signal }),
enabled,
placeholderData: (previousData, _previousQuery) => previousData,
refetchInterval: queryRefetchIntervalSlow,
});
return { data: data ?? cachedRundownPlaceholder, status, isError, refetch, isFetching };
}
@@ -1,54 +0,0 @@
import { EntryId, Rundown } from 'ontime-types';
import { useMemo } from 'react';
import { useSelectedEventId } from '../hooks/useSocket';
import { getFlatRundownMetadata, type ExtendedEntry } from '../utils/rundownMetadata';
import { useProjectRundowns } from './useProjectRundowns';
import { useRundownById } from './useRundown';
export type RundownSource = {
rundownId: string | null;
rundown: Rundown;
flatRundown: ExtendedEntry[];
status: string;
selectedEventId: EntryId | null;
};
/**
* Explicitly scoped rundown data for views that may operate on a non-loaded rundown.
*/
export function useScopedRundown(rundownId: string | null): RundownSource {
const { data: projectRundowns } = useProjectRundowns();
return useRundownSource(rundownId, projectRundowns.loaded || null);
}
/**
* Loaded-rundown source for views that must follow the active runtime rundown.
*/
export function useLoadedRundownSource(): RundownSource {
const { data: projectRundowns } = useProjectRundowns();
const loadedRundownId = projectRundowns.loaded || null;
return useRundownSource(loadedRundownId, loadedRundownId);
}
function useRundownSource(rundownId: string | null, loadedRundownId: string | null): RundownSource {
const isLoadedTarget = rundownId !== null && rundownId === loadedRundownId;
const runtimeSelectedEventId = useSelectedEventId();
const effectiveSelectedEventId = isLoadedTarget ? runtimeSelectedEventId : null;
const { data: rundown, status } = useRundownById(rundownId);
const flatRundown = useMemo(
() => getFlatRundownMetadata(rundown, effectiveSelectedEventId),
[effectiveSelectedEventId, rundown],
);
return useMemo(
() => ({
rundownId,
rundown,
flatRundown,
status,
selectedEventId: effectiveSelectedEventId,
}),
[effectiveSelectedEventId, flatRundown, rundown, rundownId, status],
);
}
+8 -15
View File
@@ -63,16 +63,9 @@ export type EventOptions = Partial<{
}>; }>;
/** /**
* Gather utilities for actions on entries in the loaded rundown. * Gather utilities for actions on entries
*/ */
export const useEntryActions = () => useEntryActionsForRundown(undefined); export const useEntryActions = () => {
/**
* Gather utilities for actions on entries in an explicitly selected rundown.
*/
export const useScopedEntryActions = (rundownId: string | null) => useEntryActionsForRundown(rundownId ?? '');
function useEntryActionsForRundown(scopedRundownId: string | undefined) {
const queryClient = useQueryClient(); const queryClient = useQueryClient();
const { const {
linkPrevious, linkPrevious,
@@ -85,12 +78,12 @@ function useEntryActionsForRundown(scopedRundownId: string | undefined) {
} = useEditorSettings(); } = useEditorSettings();
const resolveCurrentRundownQueryKey = useCallback(() => { const resolveCurrentRundownQueryKey = useCallback(() => {
if (scopedRundownId !== undefined) {
return getRundownQueryKey(scopedRundownId);
}
const loadedRundownId = queryClient.getQueryData<ProjectRundownsList>(PROJECT_RUNDOWNS)?.loaded; const loadedRundownId = queryClient.getQueryData<ProjectRundownsList>(PROJECT_RUNDOWNS)?.loaded;
return loadedRundownId ? getRundownQueryKey(loadedRundownId) : CURRENT_RUNDOWN_QUERY_KEY; if (loadedRundownId) {
}, [queryClient, scopedRundownId]); return getRundownQueryKey(loadedRundownId);
}
return CURRENT_RUNDOWN_QUERY_KEY;
}, [queryClient]);
/** /**
* Returns the currently loaded rundown * Returns the currently loaded rundown
@@ -1011,7 +1004,7 @@ function useEntryActionsForRundown(scopedRundownId: string | undefined) {
updateTimer, updateTimer,
], ],
); );
} };
/** /**
* Utility to optimistically delete entries from client cache * Utility to optimistically delete entries from client cache
@@ -47,11 +47,6 @@ describe('getRouteFromPreset()', () => {
expect(getRouteFromPreset(location, presets)).toStrictEqual('timer?user=guest&alias=demopage'); expect(getRouteFromPreset(location, presets)).toStrictEqual('timer?user=guest&alias=demopage');
}); });
it('returns null when already on a preset path', () => {
const location = resolvePath('/preset/demopage');
expect(getRouteFromPreset(location, presets)).toBeNull();
});
it('returns null if the current location is the exact match of an unwrapped alias', () => { it('returns null if the current location is the exact match of an unwrapped alias', () => {
// we make the current location be the alias // we make the current location be the alias
const location = resolvePath('/timer?user=guest&alias=demopage'); const location = resolvePath('/timer?user=guest&alias=demopage');
+26 -24
View File
@@ -3,7 +3,9 @@ import {
Log, Log,
MaybeNumber, MaybeNumber,
MessageTag, MessageTag,
ProjectRundownsList,
RefetchKey, RefetchKey,
Rundown,
RuntimeStore, RuntimeStore,
WsPacketToClient, WsPacketToClient,
WsPacketToServer, WsPacketToServer,
@@ -14,17 +16,16 @@ import {
APP_SETTINGS, APP_SETTINGS,
CLIENT_LIST, CLIENT_LIST,
CSS_OVERRIDE, CSS_OVERRIDE,
CURRENT_RUNDOWN_QUERY_KEY,
CUSTOM_FIELDS, CUSTOM_FIELDS,
PROJECT_DATA, PROJECT_DATA,
CURRENT_RUNDOWN_QUERY_KEY,
PROJECT_RUNDOWNS,
REPORT, REPORT,
RUNDOWN,
RUNTIME, RUNTIME,
TRANSLATION, TRANSLATION,
URL_PRESETS, URL_PRESETS,
VIEW_SETTINGS, VIEW_SETTINGS,
getRundownQueryKey, getRundownQueryKey,
PROJECT_RUNDOWNS,
} from '../api/constants'; } from '../api/constants';
import { invalidateAllCaches } from '../api/utils'; import { invalidateAllCaches } from '../api/utils';
import { ontimeQueryClient } from '../queryClient'; import { ontimeQueryClient } from '../queryClient';
@@ -180,7 +181,7 @@ export const connectSocket = () => {
} }
case MessageTag.Refetch: { case MessageTag.Refetch: {
// the refetch message signals that the rundown has changed in the server side // the refetch message signals that the rundown has changed in the server side
const { target, revision, rundownId } = payload; const { target, revision } = payload;
switch (target) { switch (target) {
case RefetchKey.All: case RefetchKey.All:
invalidateAllCaches(); invalidateAllCaches();
@@ -195,7 +196,7 @@ export const connectSocket = () => {
ontimeQueryClient.invalidateQueries({ queryKey: REPORT }); ontimeQueryClient.invalidateQueries({ queryKey: REPORT });
break; break;
case RefetchKey.Rundown: { case RefetchKey.Rundown: {
maybeInvalidateRundownCache(revision, rundownId); maybeInvalidateRundownCache(revision);
break; break;
} }
case RefetchKey.UrlPresets: case RefetchKey.UrlPresets:
@@ -213,9 +214,6 @@ export const connectSocket = () => {
case RefetchKey.Settings: case RefetchKey.Settings:
ontimeQueryClient.invalidateQueries({ queryKey: APP_SETTINGS }); ontimeQueryClient.invalidateQueries({ queryKey: APP_SETTINGS });
break; break;
case RefetchKey.ProjectRundowns:
ontimeQueryClient.invalidateQueries({ queryKey: PROJECT_RUNDOWNS });
break;
default: { default: {
target satisfies never; target satisfies never;
break; break;
@@ -234,30 +232,34 @@ export const connectSocket = () => {
}; };
}; };
export function maybeInvalidateRundownCache(revision: MaybeNumber, rundownId?: string) { /**
if (!rundownId) { * When we receive a refetch message for the rundown
// we omit rundownId to signify invalidate all rundowns * check which rundown needs to be invalidated
ontimeQueryClient.invalidateQueries({ queryKey: RUNDOWN }); */
ontimeQueryClient.invalidateQueries({ queryKey: CURRENT_RUNDOWN_QUERY_KEY, exact: true }); export function maybeInvalidateRundownCache(revision: MaybeNumber) {
return; const loadedRundownId: string | undefined = (ontimeQueryClient.getQueryData(PROJECT_RUNDOWNS) as ProjectRundownsList)
} ?.loaded;
// skip if we dont recognise the ID the revision is lower
const queryKey = getRundownQueryKey(rundownId);
const cachedRundown = ontimeQueryClient.getQueryData<{ revision: number }>(queryKey);
const activeRundownQueryKey = loadedRundownId ? getRundownQueryKey(loadedRundownId) : CURRENT_RUNDOWN_QUERY_KEY;
const cachedRundown = ontimeQueryClient.getQueryData<Rundown>(activeRundownQueryKey);
if (revision === cachedRundown?.revision) { if (revision === cachedRundown?.revision) {
// we already have the latest change
return; return;
} }
ontimeQueryClient.invalidateQueries({ queryKey, exact: true }); ontimeQueryClient.invalidateQueries({ queryKey: activeRundownQueryKey, exact: true });
// keep current alias in sync with the ID-based cache if (loadedRundownId) {
const loadedRundownId = ontimeQueryClient.getQueryData<{ loaded: string }>(PROJECT_RUNDOWNS)?.loaded; // Keep bootstrap alias in sync with the ID-based cache
if (!loadedRundownId || loadedRundownId === rundownId) {
ontimeQueryClient.invalidateQueries({ queryKey: CURRENT_RUNDOWN_QUERY_KEY, exact: true }); ontimeQueryClient.invalidateQueries({ queryKey: CURRENT_RUNDOWN_QUERY_KEY, exact: true });
} else {
// During bootstrap, loadedRundownId is not yet known.
// Invalidate any ID-based rundown caches that may have been seeded early.
ontimeQueryClient.invalidateQueries({
predicate: (query) => query.queryKey[0] === 'rundown' && query.queryKey[1] !== 'current',
});
} }
ontimeQueryClient.invalidateQueries({ queryKey: CUSTOM_FIELDS });
} }
export function sendSocket<T extends MessageTag | ApiActionTag>( export function sendSocket<T extends MessageTag | ApiActionTag>(
+3 -3
View File
@@ -204,7 +204,7 @@ function isPresettableView(view: string): view is OntimeViewPresettable {
/** /**
* Check if current location is a preset path * Check if current location is a preset path
*/ */
function isPresetPath(location: Path): boolean { export function isPresetPath(location: Path): boolean {
const firstSegment = location.pathname.split('/').find(Boolean); const segments = location.pathname.split('/').filter(Boolean);
return firstSegment === 'preset'; return segments[0] === 'preset';
} }
-1
View File
@@ -9,7 +9,6 @@ export const apiRepoLatest = 'https://api.github.com/repos/cpvalente/ontime/rele
export const websiteUrl = 'https://www.getontime.no'; export const websiteUrl = 'https://www.getontime.no';
export const discordUrl = 'https://discord.com/invite/eje3CSUEXm'; export const discordUrl = 'https://discord.com/invite/eje3CSUEXm';
export const subredditUrl = 'https://www.reddit.com/r/ontimeapp/'; export const subredditUrl = 'https://www.reddit.com/r/ontimeapp/';
export const youtubeUrl = 'https://www.youtube.com/@ontimeapp';
export const documentationUrl = 'https://docs.getontime.no'; export const documentationUrl = 'https://docs.getontime.no';
export const customFieldsDocsUrl = 'https://docs.getontime.no/features/custom-fields/'; export const customFieldsDocsUrl = 'https://docs.getontime.no/features/custom-fields/';
@@ -53,6 +53,10 @@ ul {
background-color: $red-400; background-color: $red-400;
} }
} }
&.split {
margin-top: 1rem;
}
} }
.secondary { .secondary {
@@ -42,9 +42,16 @@ interface PanelListItemProps {
location?: string; location?: string;
} }
function PanelListItem({ panel, isSelected, location }: PanelListItemProps) { function PanelListItem(props: PanelListItemProps) {
const { panel, isSelected, location } = props;
const { setLocation } = useAppSettingsNavigation(); const { setLocation } = useAppSettingsNavigation();
const classes = cx([style.primary, isSelected && style.active, panel.highlight && style.highlight]);
const classes = cx([
style.primary,
isSelected && style.active,
panel.split && style.split,
panel.highlight && style.highlight,
]);
return ( return (
<Fragment key={panel.id}> <Fragment key={panel.id}>
@@ -7,7 +7,6 @@ import {
githubUrl, githubUrl,
subredditUrl, subredditUrl,
websiteUrl, websiteUrl,
youtubeUrl,
} from '../../../../externals'; } from '../../../../externals';
import * as Panel from '../../panel-utils/PanelUtils'; import * as Panel from '../../panel-utils/PanelUtils';
import AppVersion from './AppVersion'; import AppVersion from './AppVersion';
@@ -39,7 +38,6 @@ export default function AboutPanel() {
<ExternalLink href={documentationUrl}>Read the docs</ExternalLink> <ExternalLink href={documentationUrl}>Read the docs</ExternalLink>
<ExternalLink href={githubUrl}>Follow the project on GitHub</ExternalLink> <ExternalLink href={githubUrl}>Follow the project on GitHub</ExternalLink>
<ExternalLink href={discordUrl}>Discord server</ExternalLink> <ExternalLink href={discordUrl}>Discord server</ExternalLink>
<ExternalLink href={youtubeUrl}>YouTube channel</ExternalLink>
<ExternalLink href={subredditUrl}>Subreddit</ExternalLink> <ExternalLink href={subredditUrl}>Subreddit</ExternalLink>
</Panel.Section> </Panel.Section>
</> </>
@@ -89,9 +89,10 @@ export default function AutomationSettingsForm({
<Panel.Section> <Panel.Section>
<Info> <Info>
<span>Control Ontime and share its data with external systems in your workflow.</span> <p>Control Ontime and share its data with external systems in your workflow.</p>
<span>- Automations allow Ontime to send its data on lifecycle triggers.</span> <p>- Automations allow Ontime to send its data on lifecycle triggers.</p>
<span>- OSC Input tells Ontime to listen to messages on the specific port.</span> <p>- OSC Input tells Ontime to listen to messages on the specific port.</p>
<br />
<ExternalLink href={oscApiDocsUrl}>See the docs</ExternalLink> <ExternalLink href={oscApiDocsUrl}>See the docs</ExternalLink>
</Info> </Info>
</Panel.Section> </Panel.Section>
@@ -57,11 +57,11 @@ export default function CustomFieldSettings() {
<Panel.Divider /> <Panel.Divider />
<Panel.Section> <Panel.Section>
<Info> <Info>
<span>Custom fields allow for additional information to be added to an event.</span> Custom fields allow for additional information to be added to an event.
<span> <br />
To use custom fields as a data source in an{' '} <br />
<AppLink search='settings=automation__automations'>Automation</AppLink>, please note the generated key. To use custom fields as a data source in an{' '}
</span> <AppLink search='settings=automation__automations'>Automation</AppLink>, please note the generated key.
<ExternalLink href={customFieldsDocsUrl}>See the docs</ExternalLink> <ExternalLink href={customFieldsDocsUrl}>See the docs</ExternalLink>
</Info> </Info>
</Panel.Section> </Panel.Section>
@@ -52,9 +52,8 @@ export default function CustomViews() {
<Panel.Section> <Panel.Section>
<Info> <Info>
<span> Upload one <strong>index.html</strong> per view to <strong>/external/&lt;name&gt;/</strong>.
Upload one <strong>index.html</strong> per view to <strong>/external/&lt;name&gt;/</strong>. <br />
</span>
External imports are not allowed, include all assets inside the html file. External imports are not allowed, include all assets inside the html file.
<ExternalLink href={customViewsDocs}>See the docs</ExternalLink> <ExternalLink href={customViewsDocs}>See the docs</ExternalLink>
</Info> </Info>
@@ -9,7 +9,6 @@ import {
IoPencilOutline, IoPencilOutline,
IoTrash, IoTrash,
} from 'react-icons/io5'; } from 'react-icons/io5';
import { TbGhost3 } from 'react-icons/tb';
import { downloadAsExcel } from '../../../../common/api/excel'; import { downloadAsExcel } from '../../../../common/api/excel';
import { maybeAxiosError } from '../../../../common/api/utils'; import { maybeAxiosError } from '../../../../common/api/utils';
@@ -20,7 +19,6 @@ import { DropdownMenu } from '../../../../common/components/dropdown-menu/Dropdo
import Tag from '../../../../common/components/tag/Tag'; import Tag from '../../../../common/components/tag/Tag';
import { useMutateProjectRundowns, useProjectRundowns } from '../../../../common/hooks-query/useProjectRundowns'; import { useMutateProjectRundowns, useProjectRundowns } from '../../../../common/hooks-query/useProjectRundowns';
import { cx } from '../../../../common/utils/styleUtils'; import { cx } from '../../../../common/utils/styleUtils';
import { useDirectLinkToBackgroundEdit } from '../../../../views/cuesheet/useCuesheetRundownSelection';
import * as Panel from '../../panel-utils/PanelUtils'; import * as Panel from '../../panel-utils/PanelUtils';
import RundownRenameForm from './composite/RundownRenameForm'; import RundownRenameForm from './composite/RundownRenameForm';
import { ManageRundownForm } from './ManageRundownForm'; import { ManageRundownForm } from './ManageRundownForm';
@@ -99,8 +97,6 @@ export default function ManageRundowns() {
await downloadAsExcel(rundownId, title); await downloadAsExcel(rundownId, title);
}; };
const navigateToCuesheet = useDirectLinkToBackgroundEdit();
return ( return (
<> <>
<Panel.Section> <Panel.Section>
@@ -157,7 +153,7 @@ export default function ManageRundowns() {
</td> </td>
<td> <td>
<DropdownMenu <DropdownMenu
render={<IconButton variant='ghosted-white' data-testId='rundown_menu' />} render={<IconButton variant='ghosted-white' />}
items={[ items={[
{ {
type: 'item', type: 'item',
@@ -184,12 +180,6 @@ export default function ManageRundowns() {
label: 'Duplicate', label: 'Duplicate',
onClick: () => submitRundownDuplicate(id), onClick: () => submitRundownDuplicate(id),
}, },
{
type: 'item',
icon: TbGhost3,
label: 'Edit in cuesheet',
onClick: () => navigateToCuesheet(id),
},
{ type: 'divider' }, { type: 'divider' },
{ {
type: 'destructive', type: 'destructive',
@@ -20,5 +20,4 @@
border: 1px solid $gray-1100; border: 1px solid $gray-1100;
border-radius: 3px; border-radius: 3px;
overflow: hidden; overflow: hidden;
height: 100%;
} }
@@ -7,6 +7,7 @@ export type SettingsOption = {
id: string; id: string;
label: string; label: string;
secondary?: Readonly<SettingsOption[]>; secondary?: Readonly<SettingsOption[]>;
split?: boolean;
highlight?: string; highlight?: string;
}; };
@@ -25,6 +26,7 @@ const staticOptions = [
{ {
id: 'project', id: 'project',
label: 'Project', label: 'Project',
split: true,
secondary: [ secondary: [
{ id: 'project__create', label: 'Create...' }, { id: 'project__create', label: 'Create...' },
{ id: 'project__list', label: 'Manage projects' }, { id: 'project__list', label: 'Manage projects' },
@@ -44,6 +46,7 @@ const staticOptions = [
{ {
id: 'automation', id: 'automation',
label: 'Automation', label: 'Automation',
split: true,
secondary: [ secondary: [
{ id: 'automation__settings', label: 'Automation settings' }, { id: 'automation__settings', label: 'Automation settings' },
{ id: 'automation__automations', label: 'Manage automations' }, { id: 'automation__automations', label: 'Manage automations' },
@@ -53,6 +56,7 @@ const staticOptions = [
{ {
id: 'sharing', id: 'sharing',
label: 'Sharing and reporting', label: 'Sharing and reporting',
split: true,
secondary: [ secondary: [
{ id: 'sharing__presets', label: 'URL Presets' }, { id: 'sharing__presets', label: 'URL Presets' },
{ {
@@ -65,6 +69,7 @@ const staticOptions = [
{ {
id: 'network', id: 'network',
label: 'Network', label: 'Network',
split: true,
secondary: [ secondary: [
{ {
id: 'network__log', id: 'network__log',
@@ -79,10 +84,12 @@ const staticOptions = [
{ {
id: 'about', id: 'about',
label: 'About', label: 'About',
split: true,
}, },
{ {
id: 'shutdown', id: 'shutdown',
label: 'Shutdown', label: 'Shutdown',
split: true,
}, },
] as const; ] as const;
@@ -6,7 +6,6 @@ import ErrorBoundary from '../../common/components/error-boundary/ErrorBoundary'
import ViewNavigationMenu from '../../common/components/navigation-menu/ViewNavigationMenu'; import ViewNavigationMenu from '../../common/components/navigation-menu/ViewNavigationMenu';
import ProtectRoute from '../../common/components/protect-route/ProtectRoute'; import ProtectRoute from '../../common/components/protect-route/ProtectRoute';
import { EntryActionsProvider } from '../../common/context/EntryActionsContext'; import { EntryActionsProvider } from '../../common/context/EntryActionsContext';
import { useLoadedRundownSource } from '../../common/hooks-query/useScopedRundown';
import { useEntryActions } from '../../common/hooks/useEntryAction'; import { useEntryActions } from '../../common/hooks/useEntryAction';
import { useIsSmallDevice } from '../../common/hooks/useIsSmallDevice'; import { useIsSmallDevice } from '../../common/hooks/useIsSmallDevice';
import { handleLinks } from '../../common/utils/linkUtils'; import { handleLinks } from '../../common/utils/linkUtils';
@@ -105,8 +104,6 @@ interface RundownRootProps {
} }
function RundownRoot({ isSmallDevice, isExtracted, viewMode, setViewMode }: RundownRootProps) { function RundownRoot({ isSmallDevice, isExtracted, viewMode, setViewMode }: RundownRootProps) {
const source = useLoadedRundownSource();
return ( return (
<div className={style.rundownRoot}> <div className={style.rundownRoot}>
{isSmallDevice ? ( {isSmallDevice ? (
@@ -115,7 +112,7 @@ function RundownRoot({ isSmallDevice, isExtracted, viewMode, setViewMode }: Rund
<RundownHeader isExtracted={isExtracted} viewMode={viewMode} setViewMode={setViewMode} /> <RundownHeader isExtracted={isExtracted} viewMode={viewMode} setViewMode={setViewMode} />
)} )}
{viewMode === RundownViewMode.List ? <RundownList /> : <RundownTable />} {viewMode === RundownViewMode.List ? <RundownList /> : <RundownTable />}
{viewMode === RundownViewMode.Table && <EntryEditModal rundown={source.rundown} />} {viewMode === RundownViewMode.Table && <EntryEditModal />}
<RenumberCuesDialog /> <RenumberCuesDialog />
</div> </div>
); );
@@ -1,6 +1,7 @@
import { OntimeEntry, Rundown, isOntimeEvent, isOntimeGroup, isOntimeMilestone } from 'ontime-types'; import { OntimeEntry, isOntimeEvent, isOntimeGroup, isOntimeMilestone } from 'ontime-types';
import { useMemo } from 'react'; import { useMemo } from 'react';
import useRundown from '../../../common/hooks-query/useRundown';
import EventEditor from './EventEditor'; import EventEditor from './EventEditor';
import GroupEditor from './GroupEditor'; import GroupEditor from './GroupEditor';
import MilestoneEditor from './MilestoneEditor'; import MilestoneEditor from './MilestoneEditor';
@@ -9,18 +10,19 @@ import style from './EntryEditor.module.scss';
interface CuesheetEntryEditorProps { interface CuesheetEntryEditorProps {
entryId: string; entryId: string;
rundown: Rundown;
} }
export default function CuesheetEntryEditor({ entryId, rundown }: CuesheetEntryEditorProps) { export default function CuesheetEntryEditor({ entryId }: CuesheetEntryEditorProps) {
const { data } = useRundown();
const entry = useMemo<OntimeEntry | null>(() => { const entry = useMemo<OntimeEntry | null>(() => {
if (rundown.order.length === 0) { if (data.order.length === 0) {
return null; return null;
} }
const event = rundown.entries[entryId]; const event = data.entries[entryId];
return event ?? null; return event ?? null;
}, [entryId, rundown.entries, rundown.order.length]); }, [entryId, data.order, data.entries]);
if (isOntimeEvent(entry)) { if (isOntimeEvent(entry)) {
return ( return (
@@ -4,6 +4,18 @@
gap: 0.75rem; gap: 0.75rem;
} }
.section,
.formSection {
display: flex;
flex-direction: column;
gap: 0.5rem;
}
.sectionTitle {
font-size: $aux-text-size;
color: $label-gray;
}
.triggerList { .triggerList {
display: flex; display: flex;
flex-direction: column; flex-direction: column;
@@ -13,13 +25,25 @@
overflow: hidden; overflow: hidden;
} }
.triggerHeader { .triggerForm {
display: grid; display: flex;
grid-template-columns: 8rem 1fr 2rem; flex-direction: column;
gap: 0.5rem; gap: 0.5rem;
padding: 0.375rem 0.75rem; }
font-size: $aux-text-size;
color: $label-gray; .formFields {
display: grid;
grid-template-columns: 8rem 1fr;
gap: 0.75rem;
align-items: end;
}
.formActions {
display: flex;
justify-content: space-between;
align-items: center;
gap: 0.75rem;
min-height: 2rem;
} }
.trigger { .trigger {
@@ -27,22 +51,40 @@
display: grid; display: grid;
grid-template-columns: 8rem 1fr 2rem; grid-template-columns: 8rem 1fr 2rem;
align-items: center; align-items: center;
gap: 0.5rem;
min-height: 2.5rem; min-height: 2.5rem;
&:not(:first-child) { &:not(:first-child) {
border-top: 1px solid $white-10; border-top: 1px solid $white-10;
} }
&[data-duplicate] {
> button:not(:last-child) {
border-color: $orange-500;
}
}
} }
.duplicateMessage { .triggerMeta {
padding-left: 0.75rem; min-width: 0;
}
.metaLabel {
color: $label-gray;
font-size: $aux-text-size; font-size: $aux-text-size;
color: $orange-500; line-height: 1.2;
margin-bottom: 0.125rem;
}
.automationTitle {
overflow-wrap: anywhere;
}
.validationError,
.validationSuccess {
display: flex;
align-items: center;
gap: 0.375rem;
font-size: $aux-text-size;
}
.validationError {
color: $red-500;
}
.validationSuccess {
color: $green-500;
} }
@@ -1,9 +1,11 @@
import { Trigger } from 'ontime-types'; import { NormalisedAutomation, TimerLifeCycle, Trigger, timerLifecycleValues } from 'ontime-types';
import { generateId } from 'ontime-utils'; import { generateId } from 'ontime-utils';
import { IoAdd, IoTrash } from 'react-icons/io5'; import { Fragment, useCallback, useMemo, useState } from 'react';
import { IoAlertCircle, IoCheckmarkCircle, IoTrash } from 'react-icons/io5';
import Button from '../../../../common/components/buttons/Button'; import Button from '../../../../common/components/buttons/Button';
import IconButton from '../../../../common/components/buttons/IconButton'; import IconButton from '../../../../common/components/buttons/IconButton';
import * as Editor from '../../../../common/components/editor-utils/EditorUtils';
import Info from '../../../../common/components/info/Info'; import Info from '../../../../common/components/info/Info';
import Select from '../../../../common/components/select/Select'; import Select from '../../../../common/components/select/Select';
import { useEntryActionsContext } from '../../../../common/context/EntryActionsContext'; import { useEntryActionsContext } from '../../../../common/context/EntryActionsContext';
@@ -19,108 +21,174 @@ interface EventEditorTriggersProps {
export default function EventEditorTriggers({ triggers, eventId }: EventEditorTriggersProps) { export default function EventEditorTriggers({ triggers, eventId }: EventEditorTriggersProps) {
const { data: automationSettings, status: automationStatus } = useAutomationSettings(); const { data: automationSettings, status: automationStatus } = useAutomationSettings();
const { updateEntry } = useEntryActionsContext();
const automationsEnabled = automationStatus === 'pending' ? undefined : automationSettings.enabledAutomations; const automationsEnabled = automationStatus === 'pending' ? undefined : automationSettings.enabledAutomations;
const showTriggers = triggers.length > 0;
const allAutomationOptions = Object.values(automationSettings.automations).map(({ id, title }) => ({
value: id,
label: title,
}));
const hasAutomationOptions = allAutomationOptions.length > 0;
const triggerOptions = eventTriggerOptions.map((cycle) => ({ value: cycle, label: cycle }));
const duplicateIds = new Set<string>();
const seen = new Map<string, string>();
for (const trigger of triggers) {
const key = `${trigger.trigger}:${trigger.automationId}`;
if (seen.has(key)) {
duplicateIds.add(trigger.id);
} else {
seen.set(key, trigger.id);
}
}
const handleAdd = () => {
if (!hasAutomationOptions) return;
updateEntry({
id: eventId,
triggers: [
...triggers,
{ id: generateId(), title: '', trigger: eventTriggerOptions[0], automationId: allAutomationOptions[0].value },
],
});
};
const handleDelete = (triggerId: string) => {
updateEntry({ id: eventId, triggers: triggers.filter((t) => t.id !== triggerId) });
};
const handleChange = (triggerId: string, field: 'trigger' | 'automationId', value: string) => {
const newTriggers = triggers.map((t) => (t.id !== triggerId ? t : { ...t, [field]: value }));
updateEntry({ id: eventId, triggers: newTriggers });
};
return ( return (
<div className={style.triggers}> <div className={style.triggers}>
{automationsEnabled === false && ( {automationsEnabled === false && (
<Info>Automations are disabled. Event triggers stay configured, but they will not run until enabled.</Info> <Info>Automations are disabled. Event triggers stay configured, but they will not run until enabled.</Info>
)} )}
{automationsEnabled && !hasAutomationOptions && ( {showTriggers && (
<Info> <div className={style.section}>
<Info.Title>No automations available</Info.Title> <div className={style.sectionTitle}>Applied automations</div>
<Info.Body>Create an automation before attaching it to this event.</Info.Body> <ExistingEventTriggers triggers={triggers} eventId={eventId} automations={automationSettings.automations} />
</Info> </div>
)} )}
{triggers.length > 0 && ( <Editor.Panel className={style.formSection}>
<div className={style.triggerList}> <div className={style.sectionTitle}>Add automation</div>
<div className={style.triggerHeader}> <EventTriggerForm triggers={triggers} eventId={eventId} automations={automationSettings.automations} />
<span>Lifecycle</span> </Editor.Panel>
<span>Automation</span> </div>
</div> );
{triggers.map((trigger) => { }
const isDuplicate = duplicateIds.has(trigger.id);
const lifecycleOptions = isDuplicate interface EventTriggerFormProps {
? triggerOptions.map((opt) => (opt.value === trigger.trigger ? { ...opt, label: `${opt.label} *` } : opt)) eventId: string;
: triggerOptions; triggers?: Trigger[];
const automationOptions = isDuplicate automations: NormalisedAutomation;
? allAutomationOptions.map((opt) => }
opt.value === trigger.automationId ? { ...opt, label: `${opt.label} *` } : opt,
) function EventTriggerForm({ eventId, triggers, automations }: EventTriggerFormProps) {
: allAutomationOptions; const { updateEntry } = useEntryActionsContext();
const [automationId, setAutomationId] = useState<string | undefined>(undefined);
const [cycleValue, setCycleValue] = useState(TimerLifeCycle.onStart);
const handleSubmit = (triggerLifeCycle: TimerLifeCycle, automationId: string) => {
const newTriggers = triggers ?? new Array<Trigger>();
const id = generateId();
newTriggers.push({ id, title: '', trigger: triggerLifeCycle, automationId });
updateEntry({ id: eventId, triggers: newTriggers });
};
const getValidationError = (cycle: TimerLifeCycle, automationId?: string): string | undefined => {
if (automationId === undefined) {
return 'Select an automation';
}
if (!Object.keys(automations).includes(automationId)) {
return 'This automation does not exist';
}
if (triggers === undefined) {
return;
}
return Object.values(triggers).some((t) => t.automationId === automationId && t.trigger === cycle)
? 'Automation can only be used once'
: undefined;
};
const validationError = getValidationError(cycleValue, automationId);
const validationLabel = validationError ?? 'Ready to add automation';
const triggerOptions = useMemo(
() => [
{ value: null, label: 'Select lifecycle' },
...eventTriggerOptions.map((cycle) => ({ value: cycle, label: cycle })),
],
[], // eventTriggerOptions is a constant, no need for dependency
);
const automationOptions = useMemo(
() => [
{ value: null, label: 'Select Automation' },
...Object.values(automations).map(({ id, title }) => ({ value: id, label: title })),
],
[automations], // This needs to be a dependency as it can change
);
return (
<div className={style.triggerForm}>
<div className={style.formFields}>
<div>
<Editor.Label>Lifecycle</Editor.Label>
<Select
value={cycleValue}
onValueChange={(value) => {
if (value !== null) setCycleValue(value);
}}
options={triggerOptions}
/>
</div>
<div>
<Editor.Label>Automation</Editor.Label>
<Select
value={automationId ?? null}
onValueChange={(value) => {
if (value !== null) setAutomationId(value);
}}
options={automationOptions}
/>
</div>
</div>
<div className={style.formActions}>
<div className={validationError ? style.validationError : style.validationSuccess}>
{validationError ? <IoAlertCircle /> : <IoCheckmarkCircle />}
<span>{validationLabel}</span>
</div>
<Button
disabled={validationError !== undefined}
onClick={() => automationId && handleSubmit(cycleValue, automationId)}
>
Add automation
</Button>
</div>
</div>
);
}
interface ExistingEventTriggersProps {
eventId: string;
triggers: Trigger[];
automations: NormalisedAutomation;
}
function ExistingEventTriggers({ eventId, triggers, automations }: ExistingEventTriggersProps) {
const { updateEntry } = useEntryActionsContext();
const handleDelete = useCallback(
(triggerId: string) => {
const newTriggers = triggers.filter((trigger) => trigger.id !== triggerId);
updateEntry({ id: eventId, triggers: newTriggers });
},
[eventId, triggers, updateEntry],
);
const filteredTriggers: Record<string, Trigger[]> = {};
// sort triggers out into groups by the Lifecycle they are on
timerLifecycleValues.forEach((triggerType) => {
const thisTriggerType = triggers.filter((trigger) => trigger.trigger === triggerType);
if (thisTriggerType.length) {
Object.assign(filteredTriggers, { [triggerType]: thisTriggerType });
}
});
return (
<div className={style.triggerList}>
{Object.entries(filteredTriggers).map(([triggerLifeCycle, triggerGroup]) => (
<Fragment key={triggerLifeCycle}>
{triggerGroup.map((trigger) => {
const { id, automationId } = trigger;
const automationTitle = automations[automationId]?.title ?? '<MISSING AUTOMATION>';
return ( return (
<div key={trigger.id} className={style.trigger} data-duplicate={isDuplicate || undefined}> <div key={id} className={style.trigger}>
<Select <div className={style.triggerMeta}>
value={trigger.trigger} <div className={style.metaLabel}>Lifecycle</div>
onValueChange={(value) => { <div>{triggerLifeCycle}</div>
if (value !== null) handleChange(trigger.id, 'trigger', value); </div>
}} <div className={style.triggerMeta}>
options={lifecycleOptions} <div className={style.metaLabel}>Automation</div>
/> <div className={style.automationTitle}>{automationTitle}</div>
<Select </div>
value={trigger.automationId} <IconButton variant='ghosted-destructive' onClick={() => handleDelete(id)}>
onValueChange={(value) => {
if (value !== null) handleChange(trigger.id, 'automationId', value);
}}
options={automationOptions}
/>
<IconButton variant='ghosted-destructive' onClick={() => handleDelete(trigger.id)}>
<IoTrash /> <IoTrash />
</IconButton> </IconButton>
</div> </div>
); );
})} })}
</div> </Fragment>
)} ))}
{duplicateIds.size > 0 && (
<span className={style.duplicateMessage}>
* Duplicate combinations will only fire once per lifecycle event.
</span>
)}
{hasAutomationOptions && (
<Button variant='ghosted' onClick={handleAdd}>
<IoAdd /> Add automation
</Button>
)}
</div> </div>
); );
} }
@@ -0,0 +1,39 @@
import { Toolbar } from '@base-ui/react/toolbar';
import type { Column } from '@tanstack/react-table';
import type { ExtendedEntry } from '../../../common/utils/rundownMetadata';
import {
ColumnSettings,
ViewSettings,
} from '../../../views/cuesheet/cuesheet-table/cuesheet-table-settings/CuesheetTableSettings';
import { usePersistedRundownOptions } from '../rundown.options';
import style from '../../../views/cuesheet/cuesheet-table/cuesheet-table-settings/CuesheetTableSettings.module.scss';
interface EditorTableSettingsProps {
columns: Column<ExtendedEntry, unknown>[];
handleResetResizing: () => void;
handleResetReordering: () => void;
handleClearToggles: () => void;
}
export default function EditorTableSettings({
columns,
handleResetResizing,
handleResetReordering,
handleClearToggles,
}: EditorTableSettingsProps) {
const options = usePersistedRundownOptions();
return (
<Toolbar.Root className={style.tableSettings}>
<ViewSettings optionsStore={options} />
<ColumnSettings
columns={columns}
handleResetResizing={handleResetResizing}
handleResetReordering={handleResetReordering}
handleClearToggles={handleClearToggles}
/>
</Toolbar.Root>
);
}
@@ -1,10 +1,7 @@
import { memo, useEffect, useMemo } from 'react'; import { memo, useEffect, useMemo } from 'react';
import EmptyPage from '../../../common/components/state/EmptyPage'; import EmptyPage from '../../../common/components/state/EmptyPage';
import { EntryActionsProvider } from '../../../common/context/EntryActionsContext';
import useCustomFields from '../../../common/hooks-query/useCustomFields'; import useCustomFields from '../../../common/hooks-query/useCustomFields';
import { useLoadedRundownSource } from '../../../common/hooks-query/useScopedRundown';
import { useEntryActions } from '../../../common/hooks/useEntryAction';
import CuesheetDnd from '../../../views/cuesheet/cuesheet-dnd/CuesheetDnd'; import CuesheetDnd from '../../../views/cuesheet/cuesheet-dnd/CuesheetDnd';
import CuesheetTable from '../../../views/cuesheet/cuesheet-table/CuesheetTable'; import CuesheetTable from '../../../views/cuesheet/cuesheet-table/CuesheetTable';
import { useCuesheetPermissions } from '../../../views/cuesheet/useTablePermissions'; import { useCuesheetPermissions } from '../../../views/cuesheet/useTablePermissions';
@@ -16,8 +13,6 @@ function RundownTable() {
const { data: customFields, status: customFieldStatus } = useCustomFields(); const { data: customFields, status: customFieldStatus } = useCustomFields();
const setPermissions = useCuesheetPermissions((state) => state.setPermissions); const setPermissions = useCuesheetPermissions((state) => state.setPermissions);
const { editorMode } = useEditorFollowMode(); const { editorMode } = useEditorFollowMode();
const source = useLoadedRundownSource();
const actions = useEntryActions();
// Editor always has full permissions // Editor always has full permissions
useEffect(() => { useEffect(() => {
@@ -35,14 +30,12 @@ function RundownTable() {
const isLoading = !customFields || customFieldStatus === 'pending'; const isLoading = !customFields || customFieldStatus === 'pending';
return ( return (
<EntryActionsProvider actions={actions}> <CuesheetDnd columns={columns} tableRoot='editor'>
<CuesheetDnd columns={columns} tableRoot='editor'> {isLoading ? (
{isLoading ? ( <EmptyPage text='Loading...' />
<EmptyPage text='Loading...' /> ) : (
) : ( <CuesheetTable columns={columns} cuesheetMode={editorMode} tableRoot='editor' />
<CuesheetTable columns={columns} source={source} cuesheetMode={editorMode} tableRoot='editor' /> )}
)} </CuesheetDnd>
</CuesheetDnd>
</EntryActionsProvider>
); );
} }
@@ -2,7 +2,7 @@ import { EntryId, MaybeNumber, ProjectRundownsList, Rundown, isOntimeEvent } fro
import { MouseEvent } from 'react'; import { MouseEvent } from 'react';
import { create } from 'zustand'; import { create } from 'zustand';
import { PROJECT_RUNDOWNS, getRundownQueryKey } from '../../common/api/constants'; import { CURRENT_RUNDOWN_QUERY_KEY, PROJECT_RUNDOWNS, getRundownQueryKey } from '../../common/api/constants';
import { ontimeQueryClient } from '../../common/queryClient'; import { ontimeQueryClient } from '../../common/queryClient';
import { isMacOS } from '../../common/utils/deviceUtils'; import { isMacOS } from '../../common/utils/deviceUtils';
@@ -137,9 +137,12 @@ export const useEventSelection = create<EventSelectionStore>()((set, get) => ({
})); }));
function getLoadedRundownData() { function getLoadedRundownData() {
const rundownId = ontimeQueryClient.getQueryData<ProjectRundownsList>(PROJECT_RUNDOWNS)?.loaded; const loadedRundownId = ontimeQueryClient.getQueryData<ProjectRundownsList>(PROJECT_RUNDOWNS)?.loaded;
if (!rundownId) return undefined; if (loadedRundownId) {
return ontimeQueryClient.getQueryData<Rundown>(getRundownQueryKey(rundownId)); return ontimeQueryClient.getQueryData<Rundown>(getRundownQueryKey(loadedRundownId));
}
return ontimeQueryClient.getQueryData<Rundown>(CURRENT_RUNDOWN_QUERY_KEY);
} }
export function getSelectionMode(event: MouseEvent): SelectionMode { export function getSelectionMode(event: MouseEvent): SelectionMode {
+2 -1
View File
@@ -81,7 +81,8 @@ html,
user-select: none; user-select: none;
-webkit-app-region: drag; -webkit-app-region: drag;
isolation: isolate; isolation: isolate;
background-color: $ui-black; // prevent the safari from showing white background // prevents Safari iOS from showing white in the overscroll (rubber-band) area
background-color: $ui-black;
} }
// reset button styles // reset button styles
+15 -13
View File
@@ -23,19 +23,21 @@ export default function ViewLoader({ children }: PropsWithChildren) {
const searchParams = new URLSearchParams(window.location.search); const searchParams = new URLSearchParams(window.location.search);
const colourFromParams = searchParams.get('keyColour') ?? '#101010'; const colourFromParams = searchParams.get('keyColour') ?? '#101010';
// always keep body background in sync so Safari iOS overscroll area matches the view
const bodyBgStyle = `body { background-color: var(--background-color-override, ${colourFromParams}); }`;
return ( return (
<> <Suspense
<style>{`body { background: var(--background-color-override, ${colourFromParams}); }`}</style> fallback={
<Suspense <>
fallback={ <style>{bodyBgStyle}</style>
<> <Loader />
<Loader /> </>
</> }
} >
> <style>{bodyBgStyle}</style>
<OverrideStyles /> <OverrideStyles />
{children} {children}
</Suspense> </Suspense>
</>
); );
} }
@@ -14,7 +14,3 @@
'table'; 'table';
color: $ui-white; color: $ui-white;
} }
.rundownSelect {
min-width: min(20rem, calc(100vw - 6rem));
}
@@ -4,34 +4,28 @@ import { IoApps } from 'react-icons/io5';
import IconButton from '../../common/components/buttons/IconButton'; import IconButton from '../../common/components/buttons/IconButton';
import NavigationMenu from '../../common/components/navigation-menu/NavigationMenu'; import NavigationMenu from '../../common/components/navigation-menu/NavigationMenu';
import { EntryActionsProvider } from '../../common/context/EntryActionsContext'; import { EntryActionsProvider } from '../../common/context/EntryActionsContext';
import { useScopedRundown } from '../../common/hooks-query/useScopedRundown'; import { useEntryActions } from '../../common/hooks/useEntryAction';
import { useScopedEntryActions } from '../../common/hooks/useEntryAction';
import { useWindowTitle } from '../../common/hooks/useWindowTitle'; import { useWindowTitle } from '../../common/hooks/useWindowTitle';
import { getIsNavigationLocked } from '../../externals'; import { getIsNavigationLocked } from '../../externals';
import CuesheetOverview from '../../features/overview/CuesheetOverview'; import CuesheetOverview from '../../features/overview/CuesheetOverview';
import EntryEditModal from './cuesheet-edit-modal/EntryEditModal'; import EntryEditModal from './cuesheet-edit-modal/EntryEditModal';
import CuesheetProgress from './cuesheet-progress/CuesheetProgress'; import CuesheetProgress from './cuesheet-progress/CuesheetProgress';
import CuesheetTableWrapper from './CuesheetTableWrapper'; import CuesheetTableWrapper from './CuesheetTableWrapper';
import { FOLLOW_LOADED_RUNDOWN_ID, useCuesheetRundownSelection } from './useCuesheetRundownSelection';
import styles from './CuesheetPage.module.scss'; import styles from './CuesheetPage.module.scss';
export default function CuesheetPage() { export default function CuesheetPage() {
'use memo';
const [isMenuOpen, menuHandler] = useDisclosure(); const [isMenuOpen, menuHandler] = useDisclosure();
const { selectedRundownId, loadedRundownId, setSelectedRundownId, projectRundowns } = useCuesheetRundownSelection(); const entryActions = useEntryActions();
const source = useScopedRundown(selectedRundownId === FOLLOW_LOADED_RUNDOWN_ID ? loadedRundownId : selectedRundownId);
const actions = useScopedEntryActions(source.rundownId);
useWindowTitle('Cuesheet'); useWindowTitle('Cuesheet');
const isLocked = getIsNavigationLocked(); const isLocked = getIsNavigationLocked();
return ( return (
<EntryActionsProvider actions={actions}> <EntryActionsProvider actions={entryActions}>
<NavigationMenu isOpen={isMenuOpen} onClose={menuHandler.close} /> <NavigationMenu isOpen={isMenuOpen} onClose={menuHandler.close} />
<EntryEditModal rundown={source.rundown} /> <EntryEditModal />
<div className={styles.tableWrapper} data-testid='cuesheet'> <div className={styles.tableWrapper} data-testid='cuesheet'>
<CuesheetOverview> <CuesheetOverview>
{!isLocked && ( {!isLocked && (
@@ -41,13 +35,7 @@ export default function CuesheetPage() {
)} )}
</CuesheetOverview> </CuesheetOverview>
<CuesheetProgress /> <CuesheetProgress />
<CuesheetTableWrapper <CuesheetTableWrapper />
source={source}
selectedRundownId={selectedRundownId}
loadedRundownId={loadedRundownId}
setSelectedRundownId={setSelectedRundownId}
projectRundowns={projectRundowns}
/>
</div> </div>
</EntryActionsProvider> </EntryActionsProvider>
); );
@@ -1,40 +1,18 @@
import { MaybeString, ProjectRundown } from 'ontime-types';
import { memo, use, useMemo } from 'react'; import { memo, use, useMemo } from 'react';
import Select from '../../common/components/select/Select';
import EmptyPage from '../../common/components/state/EmptyPage'; import EmptyPage from '../../common/components/state/EmptyPage';
import { PresetContext } from '../../common/context/PresetContext'; import { PresetContext } from '../../common/context/PresetContext';
import useCustomFields from '../../common/hooks-query/useCustomFields'; import useCustomFields from '../../common/hooks-query/useCustomFields';
import type { RundownSource } from '../../common/hooks-query/useScopedRundown';
import { AppMode } from '../../ontimeConfig';
import CuesheetDnd from './cuesheet-dnd/CuesheetDnd'; import CuesheetDnd from './cuesheet-dnd/CuesheetDnd';
import { makeCuesheetColumns } from './cuesheet-table/cuesheet-table-elements/cuesheetColsFactory'; import { makeCuesheetColumns } from './cuesheet-table/cuesheet-table-elements/cuesheetColsFactory';
import CuesheetTable from './cuesheet-table/CuesheetTable'; import CuesheetTable from './cuesheet-table/CuesheetTable';
import { useApplyCuesheetPolicy } from './useApplyCuesheetPolicy'; import { useApplyCuesheetPolicy } from './useApplyCuesheetPolicy';
import { FOLLOW_LOADED_RUNDOWN_ID } from './useCuesheetRundownSelection';
import styles from './CuesheetPage.module.scss';
interface CuesheetTableWrapperProps {
source: RundownSource;
selectedRundownId: MaybeString;
loadedRundownId: string;
setSelectedRundownId: (rundownId: string) => void;
projectRundowns: ProjectRundown[];
}
export default memo(CuesheetTableWrapper); export default memo(CuesheetTableWrapper);
function CuesheetTableWrapper({ function CuesheetTableWrapper() {
source,
selectedRundownId,
setSelectedRundownId,
loadedRundownId,
projectRundowns,
}: CuesheetTableWrapperProps) {
const preset = use(PresetContext);
const isCurrentRundown = source.rundownId !== null && source.rundownId === loadedRundownId;
const { cuesheetMode, setCuesheetMode } = useApplyCuesheetPolicy(preset, { canRunMode: isCurrentRundown });
const { data: customFields, status: customFieldStatus } = useCustomFields(); const { data: customFields, status: customFieldStatus } = useCustomFields();
const preset = use(PresetContext);
const { cuesheetMode, setCuesheetMode } = useApplyCuesheetPolicy(preset);
const columns = useMemo( const columns = useMemo(
() => makeCuesheetColumns(customFields, cuesheetMode, preset), () => makeCuesheetColumns(customFields, cuesheetMode, preset),
@@ -50,66 +28,11 @@ function CuesheetTableWrapper({
) : ( ) : (
<CuesheetTable <CuesheetTable
columns={columns} columns={columns}
source={source}
cuesheetMode={cuesheetMode} cuesheetMode={cuesheetMode}
tableRoot='cuesheet' tableRoot='cuesheet'
setCuesheetMode={setCuesheetMode} setCuesheetMode={setCuesheetMode}
isCurrentRundown={isCurrentRundown}
insertElement={
<>
<RundownSelect
cuesheetMode={cuesheetMode}
selectedRundownId={selectedRundownId}
loadedRundownId={loadedRundownId}
setSelectedRundownId={setSelectedRundownId}
projectRundowns={projectRundowns}
/>
</>
}
/> />
)} )}
</CuesheetDnd> </CuesheetDnd>
); );
} }
interface RundownSelectProps {
cuesheetMode: AppMode;
selectedRundownId: MaybeString;
loadedRundownId: string;
setSelectedRundownId: (rundownId: string) => void;
projectRundowns: ProjectRundown[];
}
function RundownSelect({
cuesheetMode,
projectRundowns,
loadedRundownId,
selectedRundownId,
setSelectedRundownId,
}: RundownSelectProps) {
'use memo';
const options = projectRundowns.map(({ id, title }) => ({
value: id,
label: loadedRundownId === id ? `${title} (loaded)` : title,
}));
options.unshift({
value: FOLLOW_LOADED_RUNDOWN_ID,
label: 'Follow loaded', // TODO: Better wording and maybe icon? and translation
});
return (
<div className={styles.rundownSelect}>
<Select
value={selectedRundownId ?? undefined}
options={options}
onValueChange={(value) => {
if (value) {
setSelectedRundownId(value);
}
}}
disabled={cuesheetMode === AppMode.Run}
fluid
/>
</div>
);
}
@@ -1,25 +0,0 @@
import { describe, expect, it } from 'vitest';
import { AppMode } from '../../../ontimeConfig';
import { getEffectiveCuesheetMode } from '../useApplyCuesheetPolicy';
describe('getEffectiveCuesheetMode()', () => {
it('honors the stored mode when the user can change mode on the current rundown', () => {
const permissions = { canChangeMode: true };
expect(getEffectiveCuesheetMode(permissions, AppMode.Edit, { canRunMode: true })).toBe(AppMode.Edit);
expect(getEffectiveCuesheetMode(permissions, AppMode.Run, { canRunMode: true })).toBe(AppMode.Run);
});
it('forces Run mode when the preset forbids mode changes', () => {
const permissions = { canChangeMode: false };
expect(getEffectiveCuesheetMode(permissions, AppMode.Edit, { canRunMode: true })).toBe(AppMode.Run);
});
it('forces Edit mode for background rundowns without changing the permission policy', () => {
const permissions = { canChangeMode: true };
expect(getEffectiveCuesheetMode(permissions, AppMode.Run, { canRunMode: false })).toBe(AppMode.Edit);
});
});
@@ -1,21 +0,0 @@
import {
FOLLOW_LOADED_RUNDOWN_ID,
getCuesheetRundownStorageKey,
resolveSelectedRundownId,
} from '../useCuesheetRundownSelection';
describe('useCuesheetRundownSelection helpers', () => {
it('builds a project-scoped storage key', () => {
expect(getCuesheetRundownStorageKey('http://localhost:4001', 'My Project')).toBe(
'cuesheet-selected-rundown:http://localhost:4001:My Project',
);
});
it('falls back to the follow loaded rundown when the stored selection is missing', () => {
expect(resolveSelectedRundownId('missing', new Set(['loaded', 'other']))).toBe(FOLLOW_LOADED_RUNDOWN_ID);
});
it('keeps the stored selection when it still exists in the current project', () => {
expect(resolveSelectedRundownId('other', new Set(['loaded', 'other']))).toBe('other');
});
});
@@ -1,16 +1,11 @@
import { Rundown } from 'ontime-types';
import { memo } from 'react'; import { memo } from 'react';
import Modal from '../../../common/components/modal/Modal'; import Modal from '../../../common/components/modal/Modal';
import CuesheetEntryEditor from '../../../features/rundown/entry-editor/CuesheetEventEditor'; import CuesheetEntryEditor from '../../../features/rundown/entry-editor/CuesheetEventEditor';
import { useEditModal } from './useEditModal'; import { useEditModal } from './useEditModal';
interface EntryEditModalProps {
rundown: Rundown;
}
export default memo(EntryEditModal); export default memo(EntryEditModal);
function EntryEditModal({ rundown }: EntryEditModalProps) { function EntryEditModal() {
const entryId = useEditModal((state) => state.selectedEntryId); const entryId = useEditModal((state) => state.selectedEntryId);
const closeModal = useEditModal((state) => state.clearSelection); const closeModal = useEditModal((state) => state.clearSelection);
@@ -24,7 +19,7 @@ function EntryEditModal({ rundown }: EntryEditModalProps) {
onClose={closeModal} onClose={closeModal}
title='Edit entry' title='Edit entry'
showCloseButton showCloseButton
bodyElements={<CuesheetEntryEditor entryId={entryId} rundown={rundown} />} bodyElements={<CuesheetEntryEditor entryId={entryId} />}
/> />
); );
} }
@@ -1,7 +1,7 @@
import { useTableNav } from '@table-nav/react'; import { useTableNav } from '@table-nav/react';
import { ColumnDef, Table, getCoreRowModel, useReactTable } from '@tanstack/react-table'; import { ColumnDef, Table, getCoreRowModel, useReactTable } from '@tanstack/react-table';
import { OntimeEntry, SupportedEntry, TimeField, isOntimeDelay, isOntimeGroup, isOntimeMilestone } from 'ontime-types'; import { OntimeEntry, TimeField, isOntimeDelay, isOntimeGroup, isOntimeMilestone } from 'ontime-types';
import { ComponentProps, ReactNode, memo, useCallback, useEffect, useMemo, useRef } from 'react'; import { ComponentProps, memo, useCallback, useEffect, useMemo, useRef } from 'react';
import { import {
ContextProp, ContextProp,
ItemProps, ItemProps,
@@ -14,20 +14,21 @@ import {
import EmptyPage from '../../../common/components/state/EmptyPage'; import EmptyPage from '../../../common/components/state/EmptyPage';
import EmptyTableBody from '../../../common/components/state/EmptyTableBody'; import EmptyTableBody from '../../../common/components/state/EmptyTableBody';
import { useEntryActionsContext } from '../../../common/context/EntryActionsContext'; import { useEntryActionsContext } from '../../../common/context/EntryActionsContext';
import type { RundownSource } from '../../../common/hooks-query/useScopedRundown'; import { useFlatRundownWithMetadata } from '../../../common/hooks-query/useRundown';
import { useSelectedEventId } from '../../../common/hooks/useSocket';
import type { ExtendedEntry } from '../../../common/utils/rundownMetadata'; import type { ExtendedEntry } from '../../../common/utils/rundownMetadata';
import EditorTableSettings from '../../../features/rundown/rundown-table/EditorTableSettings';
import { usePersistedRundownOptions } from '../../../features/rundown/rundown.options'; import { usePersistedRundownOptions } from '../../../features/rundown/rundown.options';
import { useEventSelection } from '../../../features/rundown/useEventSelection'; import { useEventSelection } from '../../../features/rundown/useEventSelection';
import { AppMode } from '../../../ontimeConfig'; import { AppMode } from '../../../ontimeConfig';
import { usePersistedCuesheetOptions } from '../cuesheet.options'; import { usePersistedCuesheetOptions } from '../cuesheet.options';
import { useCuesheetPermissions } from '../useTablePermissions';
import { CuesheetHeader, SortableCuesheetHeader } from './cuesheet-table-elements/CuesheetHeader'; import { CuesheetHeader, SortableCuesheetHeader } from './cuesheet-table-elements/CuesheetHeader';
import DelayRow from './cuesheet-table-elements/DelayRow'; import DelayRow from './cuesheet-table-elements/DelayRow';
import EventRow from './cuesheet-table-elements/EventRow'; import EventRow from './cuesheet-table-elements/EventRow';
import GroupRow from './cuesheet-table-elements/GroupRow'; import GroupRow from './cuesheet-table-elements/GroupRow';
import MilestoneRow from './cuesheet-table-elements/MilestoneRow'; import MilestoneRow from './cuesheet-table-elements/MilestoneRow';
import TableMenu from './cuesheet-table-menu/TableMenu'; import TableMenu from './cuesheet-table-menu/TableMenu';
import CuesheetTableHeaderToolbar from './cuesheet-table-settings/CuesheetTableHeaderToolbar'; import CuesheetTableSettings from './cuesheet-table-settings/CuesheetTableSettings';
import { useColumnOrder, useColumnSizes, useColumnVisibility } from './useColumnManager'; import { useColumnOrder, useColumnSizes, useColumnVisibility } from './useColumnManager';
import style from './CuesheetTable.module.scss'; import style from './CuesheetTable.module.scss';
@@ -35,41 +36,30 @@ import style from './CuesheetTable.module.scss';
type CuesheetTableBaseProps = { type CuesheetTableBaseProps = {
columns: ColumnDef<ExtendedEntry>[]; columns: ColumnDef<ExtendedEntry>[];
cuesheetMode: AppMode; cuesheetMode: AppMode;
source: RundownSource;
insertElement?: ReactNode;
}; };
type EditorCuesheetTableProps = CuesheetTableBaseProps & { type EditorCuesheetTableProps = CuesheetTableBaseProps & {
tableRoot: 'editor'; tableRoot: 'editor';
setCuesheetMode?: undefined; setCuesheetMode?: undefined;
isCurrentRundown?: undefined;
}; };
type ViewCuesheetTableProps = CuesheetTableBaseProps & { type ViewCuesheetTableProps = CuesheetTableBaseProps & {
tableRoot: 'cuesheet'; tableRoot: 'cuesheet';
setCuesheetMode: (mode: AppMode) => void; setCuesheetMode: (mode: AppMode) => void;
isCurrentRundown?: boolean;
}; };
type CuesheetTableProps = EditorCuesheetTableProps | ViewCuesheetTableProps; type CuesheetTableProps = EditorCuesheetTableProps | ViewCuesheetTableProps;
export default function CuesheetTable({ export default function CuesheetTable({ columns, cuesheetMode, tableRoot, setCuesheetMode }: CuesheetTableProps) {
columns, const { data, status } = useFlatRundownWithMetadata();
cuesheetMode, const { updateEntry, updateTimer } = useEntryActionsContext();
source,
tableRoot,
setCuesheetMode,
isCurrentRundown,
insertElement,
}: CuesheetTableProps) {
const { flatRundown, status, selectedEventId } = source;
const { updateEntry, updateTimer, addEntry } = useEntryActionsContext();
const canCreateEntries = useCuesheetPermissions((state) => state.canCreateEntries) && cuesheetMode === AppMode.Edit;
const useOptions = tableRoot === 'editor' ? usePersistedRundownOptions : usePersistedCuesheetOptions; const useOptions = tableRoot === 'editor' ? usePersistedRundownOptions : usePersistedCuesheetOptions;
const optionsStore = useOptions(); const showDelayedTimes = useOptions((state) => state.showDelayedTimes);
const { showDelayedTimes, hideTableSeconds, hideIndexColumn } = optionsStore; const hideTableSeconds = useOptions((state) => state.hideTableSeconds);
const hideIndexColumn = useOptions((state) => state.hideIndexColumn);
const selectedEventId = useSelectedEventId();
const cursor = useEventSelection((state) => state.cursor); const cursor = useEventSelection((state) => state.cursor);
const setScrollHandler = useEventSelection((state) => state.setScrollHandler); const setScrollHandler = useEventSelection((state) => state.setScrollHandler);
@@ -80,7 +70,7 @@ export default function CuesheetTable({
() => ({ () => ({
handleUpdate: (rowIndex: number, accessor: string, payload: string, isCustom = false) => { handleUpdate: (rowIndex: number, accessor: string, payload: string, isCustom = false) => {
// check if value is the same // check if value is the same
const event = flatRundown[rowIndex]; const event = data[rowIndex];
if (!event) { if (!event) {
return; return;
@@ -111,7 +101,7 @@ export default function CuesheetTable({
hideIndexColumn, hideIndexColumn,
}, },
}), }),
[cuesheetMode, flatRundown, hideIndexColumn, hideTableSeconds, showDelayedTimes, updateEntry, updateTimer], [cuesheetMode, data, hideIndexColumn, hideTableSeconds, showDelayedTimes, updateEntry, updateTimer],
); );
const { columnOrder, resetColumnOrder } = useColumnOrder(columns, tableRoot); const { columnOrder, resetColumnOrder } = useColumnOrder(columns, tableRoot);
@@ -119,7 +109,7 @@ export default function CuesheetTable({
const { columnVisibility, setColumnVisibility } = useColumnVisibility(tableRoot); const { columnVisibility, setColumnVisibility } = useColumnVisibility(tableRoot);
const table = useReactTable({ const table = useReactTable({
data: flatRundown, data,
columns, columns,
columnResizeMode: 'onChange', columnResizeMode: 'onChange',
state: { state: {
@@ -147,13 +137,13 @@ export default function CuesheetTable({
return; return;
} }
const eventIndex = flatRundown.findIndex((event) => event.id === selectedEventId); const eventIndex = data.findIndex((event) => event.id === selectedEventId);
if (eventIndex === -1) { if (eventIndex === -1) {
return; return;
} }
virtuosoRef.current.scrollToIndex({ index: eventIndex, behavior: 'auto', align: 'start', offset: -50 }); virtuosoRef.current.scrollToIndex({ index: eventIndex, behavior: 'auto', align: 'start', offset: -50 });
}, [cuesheetMode, flatRundown, selectedEventId]); }, [cuesheetMode, data, selectedEventId]);
// Provide an imperative scroll handler for explicit jumps (finder/keyboard) // Provide an imperative scroll handler for explicit jumps (finder/keyboard)
useEffect(() => { useEffect(() => {
@@ -162,7 +152,7 @@ export default function CuesheetTable({
return; return;
} }
const eventIndex = flatRundown.findIndex((event) => event.id === entryId); const eventIndex = data.findIndex((event) => event.id === entryId);
if (eventIndex === -1) { if (eventIndex === -1) {
return; return;
} }
@@ -175,7 +165,7 @@ export default function CuesheetTable({
return () => { return () => {
setScrollHandler(null); setScrollHandler(null);
}; };
}, [flatRundown, setScrollHandler]); }, [data, setScrollHandler]);
/** /**
* To improve performance on resizing, we memoise the column sizes * To improve performance on resizing, we memoise the column sizes
@@ -204,9 +194,8 @@ export default function CuesheetTable({
listeners, listeners,
rows, rows,
table, table,
handleAddNew: canCreateEntries ? (type: SupportedEntry) => addEntry({ type }) : undefined,
}), }),
[columnSizeVars, cursor, listeners, rows, table, addEntry, canCreateEntries], [columnSizeVars, cursor, listeners, rows, table],
); );
const computeItemKey = useCallback((_: number, item: ExtendedEntry) => item.id, []); const computeItemKey = useCallback((_: number, item: ExtendedEntry) => item.id, []);
@@ -228,7 +217,7 @@ export default function CuesheetTable({
}); });
}, [cuesheetMode, hideIndexColumn, table]); }, [cuesheetMode, hideIndexColumn, table]);
const isLoading = !flatRundown || status === 'pending'; const isLoading = !data || status === 'pending';
if (isLoading) { if (isLoading) {
return <EmptyPage text='Loading...' />; return <EmptyPage text='Loading...' />;
@@ -236,27 +225,26 @@ export default function CuesheetTable({
return ( return (
<> <>
<CuesheetTableHeaderToolbar {tableRoot === 'editor' ? (
columns={allLeafColumns} <EditorTableSettings
optionsStore={optionsStore} columns={allLeafColumns}
handleResetResizing={resetColumnResizing} handleResetResizing={resetColumnResizing}
handleResetReordering={resetColumnOrder} handleResetReordering={resetColumnOrder}
handleClearToggles={setAllVisible} handleClearToggles={setAllVisible}
insertElement={insertElement} />
modeControls={ ) : (
tableRoot === 'cuesheet' <CuesheetTableSettings
? { columns={allLeafColumns}
cuesheetMode, cuesheetMode={cuesheetMode}
setCuesheetMode, setCuesheetMode={setCuesheetMode}
isCurrentRundown, handleResetResizing={resetColumnResizing}
} handleResetReordering={resetColumnOrder}
: undefined handleClearToggles={setAllVisible}
} />
showShare={tableRoot === 'cuesheet'} )}
/>
<TableVirtuoso <TableVirtuoso
ref={virtuosoRef} ref={virtuosoRef}
data={flatRundown} data={data}
context={virtuosoContext} context={virtuosoContext}
style={tableRoot === 'editor' ? { paddingLeft: '1rem' } : undefined} style={tableRoot === 'editor' ? { paddingLeft: '1rem' } : undefined}
computeItemKey={computeItemKey} computeItemKey={computeItemKey}
@@ -276,13 +264,10 @@ interface CuesheetVirtuosoContext {
listeners: ReturnType<typeof useTableNav>['listeners']; listeners: ReturnType<typeof useTableNav>['listeners'];
rows: ReturnType<Table<ExtendedEntry>['getRowModel']>['rows']; rows: ReturnType<Table<ExtendedEntry>['getRowModel']>['rows'];
table: Table<ExtendedEntry>; table: Table<ExtendedEntry>;
handleAddNew?: (type: SupportedEntry) => void;
} }
const EmptyPlaceholder = memo(function EmptyPlaceholder({ const EmptyPlaceholder = memo(function EmptyPlaceholder() {
context, return <EmptyTableBody text='No data in rundown' />;
}: TableProps & ContextProp<CuesheetVirtuosoContext>) {
return <EmptyTableBody handleAddNew={context.handleAddNew} />;
}); });
const CuesheetTableElement = memo(function CuesheetTableElement({ const CuesheetTableElement = memo(function CuesheetTableElement({
@@ -49,10 +49,6 @@ function DurationInput({
setIsEditing(false); setIsEditing(false);
setTimeout(() => textRef.current?.focusParentElement()); // Immediate timeout to ensure state change takes place first setTimeout(() => textRef.current?.focusParentElement()); // Immediate timeout to ensure state change takes place first
}; };
const handleTabOut = useCallback(() => {
setIsEditing(false);
// Tab moves focus naturally; do not steal it back to parent
}, []);
const handleUpdate = useCallback( const handleUpdate = useCallback(
(newValue: string) => { (newValue: string) => {
@@ -99,10 +95,8 @@ function DurationInput({
ref={inputRef} ref={inputRef}
initialValue={timeString} initialValue={timeString}
allowSubmitSameValue={!lockedValue} // if the value is not locked, submitting will lock the value allowSubmitSameValue={!lockedValue} // if the value is not locked, submitting will lock the value
submitOnTab={false}
handleUpdate={handleUpdate} handleUpdate={handleUpdate}
handleCancelUpdate={handleFakeBlur} handleCancelUpdate={handleFakeBlur}
handleTabCancel={handleTabOut}
/> />
) : ( ) : (
<TextLikeInput <TextLikeInput
@@ -1,101 +0,0 @@
import { memo, useCallback, useLayoutEffect, useRef, useState } from 'react';
import MultiLineCell from './MultiLineCell';
import SingleLineCell from './SingleLineCell';
import TextLikeInput from './TextLikeInput';
interface EditableCellProps {
initialValue: string;
multiline?: boolean;
fieldId?: string;
fieldLabel?: string;
handleUpdate: (newValue: string) => void;
}
interface FocusableEditor {
focus: () => void;
select?: () => void;
}
interface FocusableDisplay {
focusParentElement: () => void;
}
/**
* Lazily mounts the text editor for a cell.
*
* Mounting an `<input>`/`<textarea>` editor (with its reactive-input hooks and autosize) for every
* cell is expensive when many rows mount at once during virtualised scroll. While the cell is not
* being edited we render a lightweight, focusable display element and only mount the real editor
* when the user clicks/focuses the cell — mirroring how the time/duration cells already behave.
*
* On exit we return focus to the parent cell (through the display element, in a layout effect once
* it is back in the DOM) so the table keyboard navigation keeps working — the editor is unmounted
* by then, so we cannot rely on its own ref.
*/
function EditableCell({ initialValue, multiline, fieldId, fieldLabel, handleUpdate }: EditableCellProps) {
const [isEditing, setIsEditing] = useState(false);
const wasEditing = useRef(false);
const editorRef = useRef<FocusableEditor | null>(null);
const displayRef = useRef<FocusableDisplay | null>(null);
useLayoutEffect(() => {
if (isEditing) {
// focus the editor once it mounts on entering edit mode
editorRef.current?.focus();
editorRef.current?.select?.();
} else if (wasEditing.current) {
// returning from edit: hand focus back to the cell so table keyboard navigation continues
displayRef.current?.focusParentElement();
}
wasEditing.current = isEditing;
}, [isEditing]);
const enterEdit = useCallback(() => setIsEditing(true), []);
const exitEdit = useCallback(() => setIsEditing(false), []);
const onSubmit = useCallback(
(newValue: string) => {
setIsEditing(false);
handleUpdate(newValue);
},
[handleUpdate],
);
if (!isEditing) {
return (
<TextLikeInput
ref={displayRef}
onClick={enterEdit}
onFocus={enterEdit}
multiline={multiline}
topAligned
aria-label={fieldLabel ? `${fieldLabel} cell` : undefined}
>
{initialValue}
</TextLikeInput>
);
}
return multiline ? (
<MultiLineCell
ref={editorRef}
initialValue={initialValue}
fieldId={fieldId}
fieldLabel={fieldLabel}
handleUpdate={onSubmit}
handleCancelUpdate={exitEdit}
/>
) : (
<SingleLineCell
ref={editorRef}
initialValue={initialValue}
fieldId={fieldId}
fieldLabel={fieldLabel}
handleUpdate={onSubmit}
handleCancelUpdate={exitEdit}
/>
);
}
export default memo(EditableCell);
@@ -30,16 +30,15 @@ function EditableImage({ initialValue, readOnly, updateValue }: EditableImagePro
} }
}; };
if (!initialValue && readOnly) {
return null;
}
if (!initialValue) { if (!initialValue) {
return ( return (
<Input <Input
variant='ghosted' variant='ghosted'
className={style.imageInput} className={style.imageInput}
fluid fluid
readOnly={readOnly}
// we disable the field to prevent receiving focus
disabled={readOnly}
placeholder='Paste image URL' placeholder='Paste image URL'
onBlur={(event) => handleUpdate(event.currentTarget.value)} onBlur={(event) => handleUpdate(event.currentTarget.value)}
onKeyDown={(event) => { onKeyDown={(event) => {
@@ -1,7 +1,7 @@
import { Table, flexRender } from '@tanstack/react-table'; import { Table, flexRender } from '@tanstack/react-table';
import { EntryId, OntimeEntry, RGBColour, SupportedEntry } from 'ontime-types'; import { EntryId, OntimeEntry, RGBColour, SupportedEntry } from 'ontime-types';
import { colourToHex, cssOrHexToColour } from 'ontime-utils'; import { colourToHex, cssOrHexToColour } from 'ontime-utils';
import { CSSProperties, memo, useMemo } from 'react'; import { CSSProperties, useMemo } from 'react';
import { IoEllipsisHorizontal } from 'react-icons/io5'; import { IoEllipsisHorizontal } from 'react-icons/io5';
import IconButton from '../../../../common/components/buttons/IconButton'; import IconButton from '../../../../common/components/buttons/IconButton';
@@ -30,8 +30,7 @@ interface EventRowProps {
hasCursor?: boolean; hasCursor?: boolean;
} }
export default memo(EventRow); export default function EventRow({
function EventRow({
rowId, rowId,
id, id,
eventIndex, eventIndex,
@@ -56,25 +55,24 @@ function EventRow({
const openMenu = useCuesheetTableMenu((store) => store.openMenu); const openMenu = useCuesheetTableMenu((store) => store.openMenu);
const { rowBgColour, backgroundColor, mutedText } = useMemo(() => { const { color, backgroundColor } = getAccessibleColour(colour);
const accessible = getAccessibleColour(colour); const tmpColour = cssOrHexToColour(color) as RGBColour; // we know this to be a correct colour
const tmpColour = cssOrHexToColour(accessible.color) as RGBColour; const mutedText = colourToHex({ ...tmpColour, alpha: tmpColour.alpha * 0.8 });
let rowBgColour: string | undefined; const rowBgColour: string | undefined = useMemo(() => {
if (isLoaded) { if (isLoaded) {
rowBgColour = '#087A27'; // $active-green return '#087A27'; // $active-green
} else if (colour) { } else if (colour) {
const accessibleBg = cssOrHexToColour(accessible.backgroundColor); // the colour is user defined and might be invalid
if (accessibleBg !== null) { const accessibleBackgroundColor = cssOrHexToColour(getAccessibleColour(colour).backgroundColor);
rowBgColour = colourToHex({ ...accessibleBg, alpha: accessibleBg.alpha * 0.25 }); if (accessibleBackgroundColor !== null) {
return colourToHex({
...accessibleBackgroundColor,
alpha: accessibleBackgroundColor.alpha * 0.25,
});
} }
} }
return;
return {
rowBgColour,
backgroundColor: accessible.backgroundColor,
mutedText: colourToHex({ ...tmpColour, alpha: tmpColour.alpha * 0.8 }),
};
}, [colour, isLoaded]); }, [colour, isLoaded]);
return ( return (
@@ -1,6 +1,6 @@
import { Table, flexRender } from '@tanstack/react-table'; import { Table, flexRender } from '@tanstack/react-table';
import { EntryId, SupportedEntry } from 'ontime-types'; import { EntryId, SupportedEntry } from 'ontime-types';
import { CSSProperties, memo } from 'react'; import { CSSProperties } from 'react';
import { IoEllipsisHorizontal } from 'react-icons/io5'; import { IoEllipsisHorizontal } from 'react-icons/io5';
import IconButton from '../../../../common/components/buttons/IconButton'; import IconButton from '../../../../common/components/buttons/IconButton';
@@ -20,8 +20,7 @@ interface GroupRowProps {
hasCursor?: boolean; hasCursor?: boolean;
} }
export default memo(GroupRow); export default function GroupRow({
function GroupRow({
groupId, groupId,
colour, colour,
rowId, rowId,
@@ -1,7 +1,7 @@
import { Table, flexRender } from '@tanstack/react-table'; import { Table, flexRender } from '@tanstack/react-table';
import { EntryId, SupportedEntry } from 'ontime-types'; import { EntryId, SupportedEntry } from 'ontime-types';
import { colourToHex, cssOrHexToColour } from 'ontime-utils'; import { colourToHex, cssOrHexToColour } from 'ontime-utils';
import { CSSProperties, memo, useMemo } from 'react'; import { CSSProperties } from 'react';
import { IoEllipsisHorizontal } from 'react-icons/io5'; import { IoEllipsisHorizontal } from 'react-icons/io5';
import IconButton from '../../../../common/components/buttons/IconButton'; import IconButton from '../../../../common/components/buttons/IconButton';
@@ -25,8 +25,7 @@ interface MilestoneRowProps {
hasCursor?: boolean; hasCursor?: boolean;
} }
export default memo(MilestoneRow); export default function MilestoneRow({
function MilestoneRow({
entryId, entryId,
isPast, isPast,
parentBgColour, parentBgColour,
@@ -46,12 +45,17 @@ function MilestoneRow({
const openMenu = useCuesheetTableMenu((store) => store.openMenu); const openMenu = useCuesheetTableMenu((store) => store.openMenu);
const rowBgColour = useMemo(() => { let rowBgColour: string | undefined;
if (!colour) return undefined; if (colour) {
const accessibleBg = cssOrHexToColour(getAccessibleColour(colour).backgroundColor); // the colour is user defined and might be invalid
if (accessibleBg === null) return undefined; const accessibleBackgroundColor = cssOrHexToColour(getAccessibleColour(colour).backgroundColor);
return colourToHex({ ...accessibleBg, alpha: accessibleBg.alpha * 0.25 }); if (accessibleBackgroundColor !== null) {
}, [colour]); rowBgColour = colourToHex({
...accessibleBackgroundColor,
alpha: accessibleBackgroundColor.alpha * 0.25,
});
}
}
return ( return (
<tr <tr
@@ -1,4 +1,4 @@
import { forwardRef, memo, useCallback, useImperativeHandle, useRef } from 'react'; import { memo, useCallback, useRef } from 'react';
import { AutoTextarea } from '../../../../common/components/input/auto-textarea/AutoTextarea'; import { AutoTextarea } from '../../../../common/components/input/auto-textarea/AutoTextarea';
import useReactiveTextInput from '../../../../common/components/input/text-input/useReactiveTextInput'; import useReactiveTextInput from '../../../../common/components/input/text-input/useReactiveTextInput';
@@ -8,36 +8,19 @@ interface MultiLineCellProps {
fieldId?: string; fieldId?: string;
fieldLabel?: string; fieldLabel?: string;
handleUpdate: (newValue: string) => void; handleUpdate: (newValue: string) => void;
handleCancelUpdate?: () => void;
} }
const MultiLineCell = forwardRef(function MultiLineCell( export default memo(MultiLineCell);
{ initialValue, fieldId, fieldLabel, handleUpdate, handleCancelUpdate }: MultiLineCellProps,
inputRef, function MultiLineCell({ initialValue, fieldId, fieldLabel, handleUpdate }: MultiLineCellProps) {
) {
const ref = useRef<HTMLTextAreaElement | null>(null); const ref = useRef<HTMLTextAreaElement | null>(null);
const submitCallback = useCallback((newValue: string) => handleUpdate(newValue), [handleUpdate]); const submitCallback = useCallback((newValue: string) => handleUpdate(newValue), [handleUpdate]);
const { value, onChange, onBlur, onKeyDown } = useReactiveTextInput(initialValue, submitCallback, ref, { const { value, onChange, onBlur, onKeyDown } = useReactiveTextInput(initialValue, submitCallback, ref, {
submitOnCtrlEnter: true, submitOnCtrlEnter: true,
allowKeyboardNavigation: true, allowKeyboardNavigation: true,
onCancelUpdate: handleCancelUpdate,
}); });
// expose focus to the parent so the editor can be focused when mounted on demand
useImperativeHandle(
inputRef,
() => ({
focus() {
ref.current?.focus();
},
select() {
ref.current?.select();
},
}),
[ref],
);
return ( return (
<AutoTextarea <AutoTextarea
inputref={ref} inputref={ref}
@@ -53,6 +36,4 @@ const MultiLineCell = forwardRef(function MultiLineCell(
aria-label={fieldLabel ? `${fieldLabel} editor` : undefined} aria-label={fieldLabel ? `${fieldLabel} editor` : undefined}
/> />
); );
}); }
export default memo(MultiLineCell);
@@ -8,24 +8,13 @@ interface SingleLineCellProps {
fieldId?: string; fieldId?: string;
fieldLabel?: string; fieldLabel?: string;
allowSubmitSameValue?: boolean; allowSubmitSameValue?: boolean;
submitOnTab?: boolean;
handleUpdate: (newValue: string) => void; handleUpdate: (newValue: string) => void;
handleCancelUpdate?: () => void; handleCancelUpdate?: () => void;
handleTabCancel?: () => void;
} }
const SingleLineCell = forwardRef( const SingleLineCell = forwardRef(
( (
{ { initialValue, fieldId, fieldLabel, allowSubmitSameValue, handleUpdate, handleCancelUpdate }: SingleLineCellProps,
initialValue,
fieldId,
fieldLabel,
allowSubmitSameValue,
submitOnTab,
handleUpdate,
handleCancelUpdate,
handleTabCancel,
}: SingleLineCellProps,
inputRef, inputRef,
) => { ) => {
const ref = useRef<HTMLInputElement | null>(null); const ref = useRef<HTMLInputElement | null>(null);
@@ -36,9 +25,7 @@ const SingleLineCell = forwardRef(
allowKeyboardNavigation: true, allowKeyboardNavigation: true,
submitOnEnter: true, // single line should submit on enter submitOnEnter: true, // single line should submit on enter
submitOnCtrlEnter: true, submitOnCtrlEnter: true,
submitOnTab,
onCancelUpdate: handleCancelUpdate, onCancelUpdate: handleCancelUpdate,
onTabCancel: handleTabCancel,
}); });
// expose a subset of the methods to the parent // expose a subset of the methods to the parent
@@ -1,8 +1,6 @@
/* element matching input styles */ /* element matching input styles */
.textInput { .textInput {
width: 100%; height: 2rem;
height: 100%;
min-height: 2rem;
background-color: transparent; background-color: transparent;
border-radius: $component-border-radius-md; border-radius: $component-border-radius-md;
text-wrap: nowrap; text-wrap: nowrap;
@@ -34,21 +32,4 @@
background-color: $gray-1100; background-color: $gray-1100;
cursor: text; cursor: text;
} }
// single-line placeholder: keep the glyph in a 2rem band at the top of the cell so it lines up
// with the editor (which mounts top-aligned) and does not jump when the cell is taller than 2rem
&.topAligned:not(.multiline) {
align-items: flex-start;
line-height: 2rem;
}
&.multiline {
height: auto;
min-height: 100%; // fill the cell so the whole area is clickable (grows with content)
text-wrap: wrap;
white-space: break-spaces;
overflow: hidden;
align-items: flex-start;
padding-top: 0.25em;
}
} }
@@ -8,23 +8,11 @@ interface TextLikeInputProps extends HTMLAttributes<HTMLSpanElement> {
offset?: 'over' | 'under' | 'muted' | null; offset?: 'over' | 'under' | 'muted' | null;
muted?: boolean; muted?: boolean;
disabled?: boolean; disabled?: boolean;
multiline?: boolean;
/** keep the content at the top of the cell (matches an editor that mounts top-aligned) */
topAligned?: boolean;
} }
const TextLikeInput = forwardRef( const TextLikeInput = forwardRef(
( (
{ { offset, muted, disabled, children, className, ...elementProps }: PropsWithChildren<TextLikeInputProps>,
offset,
muted,
disabled,
multiline,
topAligned,
children,
className,
...elementProps
}: PropsWithChildren<TextLikeInputProps>,
textRef, textRef,
) => { ) => {
const ref = useRef<HTMLDivElement | null>(null); const ref = useRef<HTMLDivElement | null>(null);
@@ -33,8 +21,6 @@ const TextLikeInput = forwardRef(
offset && style[offset], offset && style[offset],
muted && style.muted, muted && style.muted,
disabled && style.disabled, disabled && style.disabled,
multiline && style.multiline,
topAligned && style.topAligned,
className, className,
]); ]);
@@ -50,10 +50,6 @@ function TimeInputDuration({
setIsEditing(false); setIsEditing(false);
setTimeout(() => textRef.current?.focusParentElement()); // Immediate timeout to ensure state change takes place first setTimeout(() => textRef.current?.focusParentElement()); // Immediate timeout to ensure state change takes place first
}; };
const handleTabOut = useCallback(() => {
setIsEditing(false);
// Tab moves focus naturally; do not steal it back to parent
}, []);
const handleUpdate = useCallback( const handleUpdate = useCallback(
(newValue: string) => { (newValue: string) => {
@@ -100,10 +96,8 @@ function TimeInputDuration({
ref={inputRef} ref={inputRef}
initialValue={timeString} initialValue={timeString}
allowSubmitSameValue={!lockedValue} // if the value is not locked, submitting will lock the value allowSubmitSameValue={!lockedValue} // if the value is not locked, submitting will lock the value
submitOnTab={false}
handleUpdate={handleUpdate} handleUpdate={handleUpdate}
handleCancelUpdate={handleFakeBlur} handleCancelUpdate={handleFakeBlur}
handleTabCancel={handleTabOut}
/> />
) : ( ) : (
<TextLikeInput <TextLikeInput
@@ -9,11 +9,12 @@ import { formatDuration, formatTime } from '../../../../common/utils/time';
import { AppMode } from '../../../../ontimeConfig'; import { AppMode } from '../../../../ontimeConfig';
import { getCuesheetColumnAccessPolicy } from '../../cuesheet.policies'; import { getCuesheetColumnAccessPolicy } from '../../cuesheet.policies';
import DurationInput from './DurationInput'; import DurationInput from './DurationInput';
import EditableCell from './EditableCell';
import EditableImage from './EditableImage'; import EditableImage from './EditableImage';
import FlagCell from './FlagCell'; import FlagCell from './FlagCell';
import GhostedText from './GhostedText'; import GhostedText from './GhostedText';
import MultiLineCell from './MultiLineCell';
import MutedText from './MutedText'; import MutedText from './MutedText';
import SingleLineCell from './SingleLineCell';
import TimeInput from './TimeInput'; import TimeInput from './TimeInput';
function getColumnLabel(column: CellContext<ExtendedEntry, unknown>['column']): string { function getColumnLabel(column: CellContext<ExtendedEntry, unknown>['column']): string {
@@ -150,8 +151,7 @@ function MakeMultiLineField({ row, column, table }: CellContext<ExtendedEntry, u
} }
return ( return (
<EditableCell <MultiLineCell
multiline
initialValue={initialValue as string} initialValue={initialValue as string}
fieldId={column.id} fieldId={column.id}
fieldLabel={getColumnLabel(column)} fieldLabel={getColumnLabel(column)}
@@ -198,7 +198,7 @@ function MakeSingleLineField({ row, column, table }: CellContext<ExtendedEntry,
} }
return ( return (
<EditableCell <SingleLineCell
initialValue={initialValue as string} initialValue={initialValue as string}
fieldId={column.id} fieldId={column.id}
fieldLabel={getColumnLabel(column)} fieldLabel={getColumnLabel(column)}
@@ -238,8 +238,7 @@ function MakeCustomField({ row, column, table }: CellContext<ExtendedEntry, unkn
} }
return ( return (
<EditableCell <MultiLineCell
multiline
initialValue={initialValue} initialValue={initialValue}
fieldId={column.id} fieldId={column.id}
fieldLabel={getColumnLabel(column)} fieldLabel={getColumnLabel(column)}
@@ -8,24 +8,6 @@
gap: 1rem; gap: 1rem;
font-size: $inner-section-text-size; font-size: $inner-section-text-size;
border-radius: 3px 3px 0 0; border-radius: 3px 3px 0 0;
transition: background-color 0.2s ease-in-out;
&[data-background-rundown='true'] {
background-color: rgba($ontime-color, 0.5);
.apart::before {
content: 'BACKGROUND EDIT';
color: $ui-white;
animation: blinker 2s ease-in-out infinite;
}
}
}
@keyframes blinker {
50% {
color: transparent;
}
} }
.sectionTitle { .sectionTitle {
@@ -61,9 +43,6 @@
.apart { .apart {
margin-left: auto; margin-left: auto;
display: flex;
align-items: center;
gap: 1rem;
} }
/** styles should match RundownHeader.module.scss */ /** styles should match RundownHeader.module.scss */
@@ -91,17 +70,12 @@
font-size: calc(1rem - 2px); font-size: calc(1rem - 2px);
font-weight: 600; font-weight: 600;
&[data-disabled] {
cursor: not-allowed;
opacity: 0.4;
}
&:focus-visible { &:focus-visible {
background: transparent; background: transparent;
outline: 1px solid $blue-500; outline: 1px solid $blue-500;
} }
&:hover:not([data-disabled]):not(:active) { &:hover:not(:disabled):not(:active) {
background: $gray-1000; background: $gray-1000;
} }
@@ -113,7 +87,7 @@
background: $blue-700; background: $blue-700;
color: $ui-white; color: $ui-white;
&:hover:not([data-disabled]):not(:active) { &:hover:not(:disabled):not(:active) {
background: $blue-600; background: $blue-600;
} }
} }
@@ -11,92 +11,78 @@ import Checkbox from '../../../../common/components/checkbox/Checkbox';
import * as Editor from '../../../../common/components/editor-utils/EditorUtils'; import * as Editor from '../../../../common/components/editor-utils/EditorUtils';
import PopoverContents from '../../../../common/components/popover/Popover'; import PopoverContents from '../../../../common/components/popover/Popover';
import type { ExtendedEntry } from '../../../../common/utils/rundownMetadata'; import type { ExtendedEntry } from '../../../../common/utils/rundownMetadata';
import { cx } from '../../../../common/utils/styleUtils';
import { AppMode } from '../../../../ontimeConfig'; import { AppMode } from '../../../../ontimeConfig';
import { CuesheetOptions, usePersistedCuesheetOptions } from '../../cuesheet.options';
import { useCuesheetPermissions } from '../../useTablePermissions'; import { useCuesheetPermissions } from '../../useTablePermissions';
import CuesheetShareModal from './CuesheetShareModal'; import CuesheetShareModal from './CuesheetShareModal';
import style from './CuesheetTableSettings.module.scss'; import style from './CuesheetTableSettings.module.scss';
type TableHeaderOptionsStore = { interface CuesheetTableSettingsProps {
hideTableSeconds: boolean; columns: Column<ExtendedEntry, unknown>[];
hideIndexColumn: boolean;
showDelayedTimes: boolean;
hideDelays: boolean;
setOption: <K extends keyof TableHeaderOptionValues>(key: K, value: TableHeaderOptionValues[K]) => void;
};
type TableHeaderOptionValues = Pick<
TableHeaderOptionsStore,
'hideTableSeconds' | 'hideIndexColumn' | 'showDelayedTimes' | 'hideDelays'
>;
type TableModeControls = {
cuesheetMode: AppMode; cuesheetMode: AppMode;
setCuesheetMode: (mode: AppMode) => void; setCuesheetMode: (mode: AppMode) => void;
isCurrentRundown?: boolean;
};
interface CuesheetTableHeaderToolbarProps {
columns: Column<ExtendedEntry, unknown>[];
optionsStore: TableHeaderOptionsStore;
handleResetResizing: () => void; handleResetResizing: () => void;
handleResetReordering: () => void; handleResetReordering: () => void;
handleClearToggles: () => void; handleClearToggles: () => void;
insertElement?: ReactNode;
modeControls?: TableModeControls;
showShare?: boolean;
} }
export default function CuesheetTableHeaderToolbar({ export interface ViewSettingsProps {
optionsStore: CuesheetOptions;
}
export interface ColumnSettingsProps {
columns: Column<ExtendedEntry, unknown>[];
handleResetResizing: () => void;
handleResetReordering: () => void;
handleClearToggles: () => void;
}
export default function CuesheetTableSettings({
columns, columns,
optionsStore, cuesheetMode,
setCuesheetMode,
handleResetResizing, handleResetResizing,
handleResetReordering, handleResetReordering,
handleClearToggles, handleClearToggles,
insertElement, }: CuesheetTableSettingsProps) {
modeControls,
showShare = false,
}: CuesheetTableHeaderToolbarProps) {
const canChangeMode = useCuesheetPermissions((state) => state.canChangeMode); const canChangeMode = useCuesheetPermissions((state) => state.canChangeMode);
const canShare = useCuesheetPermissions((state) => state.canShare); const canShare = useCuesheetPermissions((state) => state.canShare);
const options = usePersistedCuesheetOptions();
const toggleCuesheetMode = (mode: AppMode[]) => { const toggleCuesheetMode = (mode: AppMode[]) => {
// we need to stop user from deselecting a mode
const newValue = mode.at(0); const newValue = mode.at(0);
if (!newValue || !modeControls) return; if (!newValue) return;
modeControls.setCuesheetMode(newValue); setCuesheetMode(newValue);
}; };
const isBackground = !(modeControls?.isCurrentRundown ?? true);
return ( return (
<Toolbar.Root className={style.tableSettings} data-background-rundown={isBackground}> <Toolbar.Root className={style.tableSettings}>
<ViewSettings optionsStore={optionsStore} /> <ViewSettings optionsStore={options} />
<ColumnSettings <ColumnSettings
columns={columns} columns={columns}
handleResetResizing={handleResetResizing} handleResetResizing={handleResetResizing}
handleResetReordering={handleResetReordering} handleResetReordering={handleResetReordering}
handleClearToggles={handleClearToggles} handleClearToggles={handleClearToggles}
/> />
{modeControls && canChangeMode && ( {canChangeMode && (
<div className={style.apart}> <ToggleGroup
{insertElement} value={[cuesheetMode]}
<ToggleGroup onValueChange={toggleCuesheetMode}
value={[modeControls.cuesheetMode]} className={cx([style.group, style.apart])}
onValueChange={toggleCuesheetMode} >
className={style.group} <Toolbar.Button render={<Toggle />} value={AppMode.Run} className={style.radioButton}>
disabled={!modeControls.isCurrentRundown} Run
> </Toolbar.Button>
<Toolbar.Button render={<Toggle />} value={AppMode.Run} className={style.radioButton}> <Toolbar.Button render={<Toggle />} value={AppMode.Edit} className={style.radioButton}>
Run Edit
</Toolbar.Button> </Toolbar.Button>
<Toolbar.Button render={<Toggle />} value={AppMode.Edit} className={style.radioButton}> </ToggleGroup>
Edit
</Toolbar.Button>
</ToggleGroup>
</div>
)} )}
{showShare && canShare && ( {canShare && (
<> <>
<Editor.Separator orientation='vertical' /> <Editor.Separator orientation='vertical' />
<CuesheetShareModal /> <CuesheetShareModal />
@@ -106,18 +92,9 @@ export default function CuesheetTableHeaderToolbar({
); );
} }
interface ViewSettingsProps { export function ViewSettings({ optionsStore }: ViewSettingsProps) {
optionsStore: TableHeaderOptionsStore; const options = optionsStore;
}
interface ColumnSettingsProps {
columns: Column<ExtendedEntry, unknown>[];
handleResetResizing: () => void;
handleResetReordering: () => void;
handleClearToggles: () => void;
}
function ViewSettings({ optionsStore }: ViewSettingsProps) {
return ( return (
<Popover.Root> <Popover.Root>
<Popover.Trigger <Popover.Trigger
@@ -138,15 +115,15 @@ function ViewSettings({ optionsStore }: ViewSettingsProps) {
<Editor.Label className={style.sectionTitle}>Element visibility</Editor.Label> <Editor.Label className={style.sectionTitle}>Element visibility</Editor.Label>
<Editor.Label className={style.option}> <Editor.Label className={style.option}>
<Checkbox <Checkbox
defaultChecked={optionsStore.hideTableSeconds} defaultChecked={options.hideTableSeconds}
onCheckedChange={(checked) => optionsStore.setOption('hideTableSeconds', checked)} onCheckedChange={(checked) => options.setOption('hideTableSeconds', checked)}
/> />
Hide seconds in table Hide seconds in table
</Editor.Label> </Editor.Label>
<Editor.Label className={style.option}> <Editor.Label className={style.option}>
<Checkbox <Checkbox
defaultChecked={optionsStore.hideIndexColumn} defaultChecked={options.hideIndexColumn}
onCheckedChange={(checked) => optionsStore.setOption('hideIndexColumn', checked)} onCheckedChange={(checked) => options.setOption('hideIndexColumn', checked)}
/> />
Hide index column Hide index column
</Editor.Label> </Editor.Label>
@@ -156,15 +133,15 @@ function ViewSettings({ optionsStore }: ViewSettingsProps) {
<Editor.Label className={style.sectionTitle}>Table Behaviour</Editor.Label> <Editor.Label className={style.sectionTitle}>Table Behaviour</Editor.Label>
<Editor.Label className={style.option}> <Editor.Label className={style.option}>
<Checkbox <Checkbox
defaultChecked={optionsStore.showDelayedTimes} defaultChecked={options.showDelayedTimes}
onCheckedChange={(checked) => optionsStore.setOption('showDelayedTimes', checked)} onCheckedChange={(checked) => options.setOption('showDelayedTimes', checked)}
/> />
Show delayed times Show delayed times
</Editor.Label> </Editor.Label>
<Editor.Label className={style.option}> <Editor.Label className={style.option}>
<Checkbox <Checkbox
defaultChecked={optionsStore.hideDelays} defaultChecked={options.hideDelays}
onCheckedChange={(checked) => optionsStore.setOption('hideDelays', checked)} onCheckedChange={(checked) => options.setOption('hideDelays', checked)}
/> />
Hide delay entries Hide delay entries
</Editor.Label> </Editor.Label>
@@ -174,7 +151,7 @@ function ViewSettings({ optionsStore }: ViewSettingsProps) {
); );
} }
function ColumnSettings({ export function ColumnSettings({
columns, columns,
handleResetResizing, handleResetResizing,
handleResetReordering, handleResetReordering,
@@ -200,7 +177,6 @@ function ColumnSettings({
{columns.map((column) => { {columns.map((column) => {
const columnHeader = column.columnDef.header; const columnHeader = column.columnDef.header;
const visible = column.getIsVisible(); const visible = column.getIsVisible();
return ( return (
<Editor.Label key={`${column.id}-${visible}`} className={style.option}> <Editor.Label key={`${column.id}-${visible}`} className={style.option}>
<Checkbox defaultChecked={visible} onCheckedChange={column.toggleVisibility} /> <Checkbox defaultChecked={visible} onCheckedChange={column.toggleVisibility} />
@@ -5,33 +5,12 @@ import { useCallback, useEffect, useMemo } from 'react';
import { sessionScope } from '../../externals'; import { sessionScope } from '../../externals';
import { AppMode, sessionKeys } from '../../ontimeConfig'; import { AppMode, sessionKeys } from '../../ontimeConfig';
import { getCuesheetPermissionsPolicy } from './cuesheet.policies'; import { getCuesheetPermissionsPolicy } from './cuesheet.policies';
import type { CuesheetPermissions } from './useTablePermissions';
import { useCuesheetPermissions } from './useTablePermissions'; import { useCuesheetPermissions } from './useTablePermissions';
type CuesheetPolicyOptions = {
// Run mode is only meaningful for the loaded rundown — background rundowns force Edit.
canRunMode: boolean;
};
export function getEffectiveCuesheetMode(
permissions: Pick<CuesheetPermissions, 'canChangeMode'>,
storedMode: AppMode,
{ canRunMode }: CuesheetPolicyOptions,
) {
if (!permissions.canChangeMode) {
return AppMode.Run;
}
return canRunMode ? storedMode : AppMode.Edit;
}
/** /**
* Applies cuesheet permissions to shared state and exposes the effective mode for the UI. * Applies cuesheet permissions to shared state and exposes the effective mode for the UI.
*/ */
export function useApplyCuesheetPolicy( export function useApplyCuesheetPolicy(preset: URLPreset | undefined): {
preset: URLPreset | undefined,
{ canRunMode }: CuesheetPolicyOptions,
): {
cuesheetMode: AppMode; cuesheetMode: AppMode;
setCuesheetMode: (mode: AppMode) => void; setCuesheetMode: (mode: AppMode) => void;
} { } {
@@ -47,14 +26,16 @@ export function useApplyCuesheetPolicy(
defaultValue: preset ? AppMode.Run : AppMode.Edit, defaultValue: preset ? AppMode.Run : AppMode.Edit,
}); });
const cuesheetMode = getEffectiveCuesheetMode(permissions, storedCuesheetMode, { canRunMode }); const cuesheetMode = permissions.canChangeMode ? storedCuesheetMode : AppMode.Run;
const setCuesheetMode = useCallback( const setCuesheetMode = useCallback(
(mode: AppMode) => { (mode: AppMode) => {
if (!permissions.canChangeMode || !canRunMode) return; if (!permissions.canChangeMode) {
return;
}
setStoredCuesheetMode(mode); setStoredCuesheetMode(mode);
}, },
[canRunMode, permissions.canChangeMode, setStoredCuesheetMode], [permissions.canChangeMode, setStoredCuesheetMode],
); );
// Keep the shared permissions store aligned with the active preset policy. // Keep the shared permissions store aligned with the active preset policy.
@@ -1,65 +0,0 @@
import { useSessionStorage } from '@mantine/hooks';
import { startTransition, useCallback, useMemo } from 'react';
import { useNavigate } from 'react-router';
import { useOrderedProjectList } from '../../common/hooks-query/useProjectList';
import { useProjectRundowns } from '../../common/hooks-query/useProjectRundowns';
import { serverURL } from '../../externals';
export const FOLLOW_LOADED_RUNDOWN_ID = '__follow-loaded__' as const;
export function getCuesheetRundownStorageKey(server: string, projectFilename: string) {
return `cuesheet-selected-rundown:${server}:${projectFilename}`;
}
export function resolveSelectedRundownId(storedSelectedRundownId: string | null, availableRundownIds: Set<string>) {
if (storedSelectedRundownId && availableRundownIds.has(storedSelectedRundownId)) return storedSelectedRundownId;
return FOLLOW_LOADED_RUNDOWN_ID;
}
export function useCuesheetRundownSelection() {
'use memo';
const { data: projectRundowns } = useProjectRundowns();
const {
data: { lastLoadedProject },
} = useOrderedProjectList();
const storageKey = useMemo(() => getCuesheetRundownStorageKey(serverURL, lastLoadedProject), [lastLoadedProject]);
const [storedSelectedRundownId, setStoredSelectedRundownId] = useSessionStorage<string | null>({
key: storageKey,
defaultValue: FOLLOW_LOADED_RUNDOWN_ID,
});
const availableRundownIds = new Set(projectRundowns.rundowns.map(({ id }) => id)).add(FOLLOW_LOADED_RUNDOWN_ID);
const { loaded: loadedRundownId } = projectRundowns;
const selectedRundownId = resolveSelectedRundownId(storedSelectedRundownId, availableRundownIds);
return {
loadedRundownId,
selectedRundownId,
projectRundowns: projectRundowns.rundowns,
setSelectedRundownId: (rundownId: string) => {
startTransition(() => {
setStoredSelectedRundownId(rundownId);
});
},
};
}
export function useDirectLinkToBackgroundEdit() {
const {
data: { lastLoadedProject },
} = useOrderedProjectList();
const navigate = useNavigate();
const storageKey = getCuesheetRundownStorageKey(serverURL, lastLoadedProject);
const [_, setStoredSelectedRundownId] = useSessionStorage<string | null>({ key: storageKey, defaultValue: null });
return useCallback(
async (rundownId: string) => {
await navigate('/cuesheet');
startTransition(() => setStoredSelectedRundownId(rundownId));
},
[setStoredSelectedRundownId, navigate],
);
}
@@ -45,9 +45,6 @@ $studio-idle: $red-1300;
top: 0; top: 0;
top: 50%; top: 50%;
left: 50%; left: 50%;
margin-top: -0.5rem;
margin-left: -0.5rem;
} }
.tick--active { .tick--active {
+1 -5
View File
@@ -1,7 +1,6 @@
import path from 'path'; import path from 'path';
import { sentryVitePlugin } from '@sentry/vite-plugin'; import { sentryVitePlugin } from '@sentry/vite-plugin';
import legacy from '@vitejs/plugin-legacy';
import react from '@vitejs/plugin-react'; import react from '@vitejs/plugin-react';
import { defineConfig } from 'vite'; import { defineConfig } from 'vite';
import { compression } from 'vite-plugin-compression2'; import { compression } from 'vite-plugin-compression2';
@@ -22,9 +21,6 @@ export default defineConfig({
'import.meta.env.IS_DOCKER': process.env.NODE_ENV === 'docker', 'import.meta.env.IS_DOCKER': process.env.NODE_ENV === 'docker',
}, },
plugins: [ plugins: [
legacy({
targets: ['safari >= 14.1'],
}),
react({ react({
babel: { babel: {
plugins: [['babel-plugin-react-compiler', ReactCompilerConfig]], plugins: [['babel-plugin-react-compiler', ReactCompilerConfig]],
@@ -87,7 +83,7 @@ export default defineConfig({
}, },
test: { test: {
globals: true, globals: true,
dom: true, environment: 'jsdom',
}, },
build: { build: {
outDir: './build', outDir: './build',
+1 -1
View File
@@ -1,6 +1,6 @@
{ {
"name": "ontime-electron", "name": "ontime-electron",
"version": "4.9.0", "version": "4.7.0",
"author": "Carlos Valente", "author": "Carlos Valente",
"description": "Time keeping for live events", "description": "Time keeping for live events",
"repository": "https://github.com/cpvalente/ontime", "repository": "https://github.com/cpvalente/ontime",
+1 -1
View File
@@ -1,6 +1,6 @@
{ {
"name": "@getontime/resolver", "name": "@getontime/resolver",
"version": "4.9.0", "version": "4.7.0",
"type": "module", "type": "module",
"repository": "https://github.com/cpvalente/ontime", "repository": "https://github.com/cpvalente/ontime",
"types": "./dist/main.d.ts", "types": "./dist/main.d.ts",
+3 -1
View File
@@ -2,7 +2,7 @@
"name": "ontime-server", "name": "ontime-server",
"type": "module", "type": "module",
"main": "src/index.ts", "main": "src/index.ts",
"version": "4.9.0", "version": "4.7.0",
"exports": "./src/index.js", "exports": "./src/index.js",
"dependencies": { "dependencies": {
"@googleapis/sheets": "^5.0.5", "@googleapis/sheets": "^5.0.5",
@@ -29,10 +29,12 @@
"@types/express": "5.0.3", "@types/express": "5.0.3",
"@types/multer": "2.1.0", "@types/multer": "2.1.0",
"@types/node": "catalog:", "@types/node": "catalog:",
"@types/websocket": "^1.0.5",
"@types/ws": "^8.5.10", "@types/ws": "^8.5.10",
"esbuild": "^0.24.0", "esbuild": "^0.24.0",
"ontime-types": "workspace:*", "ontime-types": "workspace:*",
"server-timing": "^3.3.3", "server-timing": "^3.3.3",
"shx": "^0.3.4",
"ts-essentials": "catalog:", "ts-essentials": "catalog:",
"tsx": "^4.19.2", "tsx": "^4.19.2",
"typescript": "catalog:", "typescript": "catalog:",
+2 -2
View File
@@ -262,6 +262,6 @@ export const socket = new SocketServer();
/** /**
* Utility function to notify clients that the REST data is stale * Utility function to notify clients that the REST data is stale
*/ */
export function sendRefetch(target: RefetchKey, revision: MaybeNumber = null, rundownId?: string) { export function sendRefetch(target: RefetchKey, revision: MaybeNumber = null) {
socket.sendAsJson(MessageTag.Refetch, { target, revision, rundownId }); socket.sendAsJson(MessageTag.Refetch, { target, revision });
} }
@@ -47,15 +47,7 @@ export function triggerAutomations(cycle: TimerLifeCycle) {
return; return;
} }
// deduplicate — if the same automation appears multiple times on one lifecycle, fire it once filteredTrigger.forEach((trigger) => {
const seen = new Set<string>();
const uniqueTriggers = filteredTrigger.filter((t) => {
if (seen.has(t.automationId)) return false;
seen.add(t.automationId);
return true;
});
uniqueTriggers.forEach((trigger) => {
const automation = automations[trigger.automationId]; const automation = automations[trigger.automationId];
if (!automation || automation.outputs.length === 0) { if (!automation || automation.outputs.length === 0) {
return; return;
@@ -1,13 +1,11 @@
import { import {
CustomField, CustomField,
EntryId,
OntimeDelay, OntimeDelay,
OntimeEvent, OntimeEvent,
OntimeGroup, OntimeGroup,
OntimeMilestone, OntimeMilestone,
Rundown, Rundown,
SupportedEntry, SupportedEntry,
isOntimeGroup,
} from 'ontime-types'; } from 'ontime-types';
import { makeNewRundown } from '../../../models/dataModel.js'; import { makeNewRundown } from '../../../models/dataModel.js';
@@ -61,24 +59,13 @@ export function makeOntimeMilestone(patch: Partial<OntimeMilestone>): OntimeMile
} }
/** /**
* Utility to create a rundown object. * Utility to create a rundown object
* Derives flatOrder from order/entries when the patch does not provide one,
* so test fixtures match the shape of a processed rundown.
*/ */
export function makeRundown(patch: Partial<Rundown>): Rundown { export function makeRundown(patch: Partial<Rundown>): Rundown {
const rundown = { ...makeNewRundown(), ...patch }; return {
if (!patch.flatOrder) { ...makeNewRundown(),
const flatOrder: EntryId[] = []; ...patch,
for (const id of rundown.order) { };
flatOrder.push(id);
const entry = rundown.entries[id];
if (isOntimeGroup(entry)) {
flatOrder.push(...entry.entries);
}
}
rundown.flatOrder = flatOrder;
}
return rundown;
} }
export function makeCustomField(patch: Partial<CustomField>): CustomField { export function makeCustomField(patch: Partial<CustomField>): CustomField {
@@ -63,7 +63,7 @@ describe('createTransaction', () => {
expect(typeof commit).toBe('function'); expect(typeof commit).toBe('function');
}); });
it('should return the updated data after commit is called and writes are scheduled', async () => { it('should return the updated data after commit is called and writes are scheduled', () => {
const { rundown, customFields, commit } = createTransaction({ mutableRundown: true, mutableCustomFields: true }); const { rundown, customFields, commit } = createTransaction({ mutableRundown: true, mutableCustomFields: true });
rundown.title = 'Another Title'; rundown.title = 'Another Title';
customFields['newField'] = { customFields['newField'] = {
@@ -72,7 +72,8 @@ describe('createTransaction', () => {
colour: 'blue', colour: 'blue',
}; };
const updated = await commit(); const updated = commit();
vi.runAllTimers();
expect(updated.rundown.title).toBe('Another Title'); expect(updated.rundown.title).toBe('Another Title');
expect(updated.customFields).toHaveProperty('newField'); expect(updated.customFields).toHaveProperty('newField');
@@ -131,23 +132,6 @@ describe('processRundown()', () => {
expect(initResult.entries['3'].type).toBe(SupportedEntry.Delay); expect(initResult.entries['3'].type).toBe(SupportedEntry.Delay);
}); });
it('produces order, flatOrder and applies delays to following events', () => {
const rundown = makeRundown({
order: ['1', 'delay', '2'],
entries: {
'1': makeOntimeEvent({ id: '1', timeStart: 0, timeEnd: 1000, duration: 1000 }),
delay: makeOntimeDelay({ id: 'delay', duration: 250 }),
'2': makeOntimeEvent({ id: '2', timeStart: 1000, timeEnd: 2000, duration: 1000 }),
},
});
const processed = processRundown(rundown, {});
expect(processed.order).toEqual(['1', 'delay', '2']);
expect(processed.flatEntryOrder).toEqual(['1', 'delay', '2']);
expect((processed.entries['2'] as OntimeEvent).delay).toBe(250);
});
it('calculates delays versions of a given rundown', () => { it('calculates delays versions of a given rundown', () => {
const rundown = makeRundown({ const rundown = makeRundown({
order: ['1', '2'], order: ['1', '2'],
@@ -1638,34 +1622,6 @@ describe('rundownMutation.applyDelay()', () => {
}, },
}); });
}); });
it('uses the passed rundown own order, not the loaded rundown metadata', () => {
// The loaded rundown has completely different events
const loadedRundown = makeRundown({
order: ['loaded-delay', 'loaded-ev'],
entries: {
'loaded-delay': makeOntimeDelay({ id: 'loaded-delay', duration: 9999 }),
'loaded-ev': makeOntimeEvent({ id: 'loaded-ev', timeStart: 0, timeEnd: 100, duration: 100 }),
},
});
rundownCache.init(loadedRundown, {});
// Background rundown is independent of the loaded one
const bgRundown = makeRundown({
order: ['bg-delay', 'bg-ev'],
entries: {
'bg-delay': makeOntimeDelay({ id: 'bg-delay', duration: 500 }),
'bg-ev': makeOntimeEvent({ id: 'bg-ev', timeStart: 0, timeEnd: 200, duration: 200 }),
},
});
rundownMutation.applyDelay(bgRundown, bgRundown.entries['bg-delay'] as OntimeDelay);
// bg-ev must be shifted by its own delay (500), not influenced by the loaded rundown
expect((bgRundown.entries['bg-ev'] as OntimeEvent).timeStart).toBe(500);
// loaded-ev must be untouched
expect((loadedRundown.entries['loaded-ev'] as OntimeEvent).timeStart).toBe(0);
});
}); });
describe('rundownMutation.swap()', () => { describe('rundownMutation.swap()', () => {
+93 -124
View File
@@ -74,7 +74,6 @@ let rundownMetadata: RundownMetadata = {
let projectCustomFields: CustomFields = {}; let projectCustomFields: CustomFields = {};
export const getCurrentRundown = (): Readonly<Rundown> => cachedRundown; export const getCurrentRundown = (): Readonly<Rundown> => cachedRundown;
export const getCurrentRundownId = (): string => cachedRundown.id;
export const getRundownMetadata = (): Readonly<RundownMetadata> => rundownMetadata; export const getRundownMetadata = (): Readonly<RundownMetadata> => rundownMetadata;
export const getProjectCustomFields = (): Readonly<CustomFields> => projectCustomFields; export const getProjectCustomFields = (): Readonly<CustomFields> => projectCustomFields;
export const getEntryWithId = (entryId: EntryId): OntimeEntry | undefined => cachedRundown.entries[entryId]; export const getEntryWithId = (entryId: EntryId): OntimeEntry | undefined => cachedRundown.entries[entryId];
@@ -82,85 +81,56 @@ export const getEntryWithId = (entryId: EntryId): OntimeEntry | undefined => cac
type Transaction = { type Transaction = {
customFields: CustomFields; customFields: CustomFields;
rundown: Rundown; rundown: Rundown;
rundownMetadata: Readonly<RundownMetadata>;
commit: (shouldProcess?: boolean) => Promise<{ commit: (shouldProcess?: boolean) => {
rundown: Readonly<Rundown>; rundown: Readonly<Rundown>;
rundownMetadata: Readonly<RundownMetadata> | null; rundownMetadata: Readonly<RundownMetadata>;
customFields: Readonly<CustomFields>; customFields: Readonly<CustomFields>;
revision: Readonly<number>; revision: Readonly<number>;
}>; };
}; };
type TransactionOptions = { type TransactionOptions = {
mutableRundown?: boolean; mutableRundown?: boolean;
mutableCustomFields?: boolean; mutableCustomFields?: boolean;
/**
* Target rundown ID. Defaults to the loaded rundown.
* When targeting a non-loaded ("background") rundown, the cache and runtime
* metadata are bypassed the rundown is read from disk and persisted directly.
*/
rundownId?: string;
}; };
export function createTransaction(options: TransactionOptions): Transaction { export function createTransaction(options: TransactionOptions): Transaction {
const targetId = options.rundownId ?? cachedRundown.id; const rundown = options.mutableRundown ? structuredClone(cachedRundown) : cachedRundown;
const isLoaded = targetId === cachedRundown.id;
const sourceRundown: Rundown = isLoaded ? cachedRundown : (getDataProvider().getRundown(targetId) as Rundown);
const rundown = options.mutableRundown ? structuredClone(sourceRundown) : sourceRundown;
const customFields = options.mutableCustomFields ? structuredClone(projectCustomFields) : projectCustomFields; const customFields = options.mutableCustomFields ? structuredClone(projectCustomFields) : projectCustomFields;
/** /**
* Applies a mutated rundown to its persistence target * Applies a mutated rundown to the cache
* @param shouldProcess - whether the rundown should be processed after the commit * @param shouldProcess - whether the rundown should be processed after the commit
* Some edit mutations, and custom field changes do not require processing * Some edit mutations, and custom field changes do not require processing
*/ */
async function commit(shouldProcess: boolean = true) { function commit(shouldProcess: boolean = true) {
let committedRundown: Readonly<Rundown> = isLoaded ? cachedRundown : rundown;
let committedMetadata: RundownMetadata | null = isLoaded ? rundownMetadata : null;
let committedRevision: number = sourceRundown.revision;
// if the rundown is mutable we persist the changes // if the rundown is mutable we persist the changes
if (options.mutableRundown) { if (options.mutableRundown) {
if (isLoaded) { // update fields which are agnostic of whether the rundown is processed
// update fields which are agnostic of whether the rundown is processed cachedRundown.revision = cachedRundown.revision + 1;
cachedRundown.revision = cachedRundown.revision + 1; cachedRundown.title = rundown.title;
cachedRundown.title = rundown.title;
if (!shouldProcess) { if (!shouldProcess) {
// if we dont need to process, we just reassign the commit data to the cache // if we dont need to process, we just reassign the commit data to the cache
cachedRundown.entries = rundown.entries; cachedRundown.entries = rundown.entries;
cachedRundown.order = rundown.order; cachedRundown.order = rundown.order;
cachedRundown.flatOrder = rundown.flatOrder; cachedRundown.flatOrder = rundown.flatOrder;
} else {
const processedData = processRundown(rundown, projectCustomFields, { mutate: true });
// update the cache values
// eslint-disable-next-line @typescript-eslint/no-unused-vars -- we are not interested in the iteration data
const { previousEvent, latestEvent, previousEntry, entries, order, ...metadata } = processedData;
cachedRundown.entries = entries;
cachedRundown.order = order;
cachedRundown.flatOrder = metadata.flatEntryOrder;
rundownMetadata = metadata;
}
// persist after all mutations are applied
await getDataProvider().setRundown(cachedRundown.id, cachedRundown);
committedRundown = cachedRundown;
committedMetadata = rundownMetadata;
committedRevision = cachedRundown.revision;
} else { } else {
// background rundown: process if requested, persist directly, no runtime metadata const processedData = processRundown(rundown, projectCustomFields);
rundown.revision = rundown.revision + 1; // update the cache values
if (shouldProcess) { // eslint-disable-next-line @typescript-eslint/no-unused-vars -- we are not interested in the iteration data
const processedData = processRundown(rundown, projectCustomFields, { mutate: true }); const { previousEvent, latestEvent, previousEntry, entries, order, ...metadata } = processedData;
rundown.entries = processedData.entries;
rundown.order = processedData.order; cachedRundown.entries = entries;
rundown.flatOrder = processedData.flatEntryOrder; cachedRundown.order = order;
} cachedRundown.flatOrder = metadata.flatEntryOrder;
await getDataProvider().setRundown(targetId, rundown); rundownMetadata = metadata;
committedRundown = rundown;
committedRevision = rundown.revision;
} }
// persist after all mutations are applied
getDataProvider().setRundown(cachedRundown.id, cachedRundown);
} }
// if the customFields are mutable we persist the changes // if the customFields are mutable we persist the changes
@@ -168,20 +138,21 @@ export function createTransaction(options: TransactionOptions): Transaction {
projectCustomFields = customFields; projectCustomFields = customFields;
// persist after reassignment // persist after reassignment
await getDataProvider().setCustomFields(projectCustomFields); getDataProvider().setCustomFields(projectCustomFields);
} }
return { return {
rundown: committedRundown, rundown: cachedRundown,
rundownMetadata: committedMetadata, rundownMetadata,
customFields: projectCustomFields, customFields: projectCustomFields,
revision: committedRevision, revision: cachedRundown.revision,
}; };
} }
return { return {
customFields, customFields,
rundown, rundown,
rundownMetadata,
commit, commit,
}; };
} }
@@ -316,11 +287,11 @@ function reorder(rundown: Rundown, eventFrom: OntimeEntry, eventTo: OntimeEntry,
* Mutates the given rundown * Mutates the given rundown
*/ */
function applyDelay(rundown: Rundown, delay: OntimeDelay) { function applyDelay(rundown: Rundown, delay: OntimeDelay) {
const delayIndex = rundown.flatOrder.indexOf(delay.id); const delayIndex = rundownMetadata.flatEntryOrder.indexOf(delay.id);
// if the delay is empty, or the last element // if the delay is empty, or the last element
// there is nothing do apply // there is nothing do apply
if (delay.duration === 0 || delayIndex === rundown.flatOrder.length - 1) { if (delay.duration === 0 || delayIndex === rundownMetadata.flatEntryOrder.length - 1) {
return; return;
} }
@@ -333,8 +304,8 @@ function applyDelay(rundown: Rundown, delay: OntimeDelay) {
let lastEntry: OntimeEvent | null = null; let lastEntry: OntimeEvent | null = null;
let isFirstEvent = true; let isFirstEvent = true;
for (let i = delayIndex + 1; i < rundown.flatOrder.length; i++) { for (let i = delayIndex + 1; i < rundownMetadata.flatEntryOrder.length; i++) {
const currentId = rundown.flatOrder[i]; const currentId = rundownMetadata.flatEntryOrder[i];
const currentEntry = rundown.entries[currentId]; const currentEntry = rundown.entries[currentId];
// we don't do operation on other event types // we don't do operation on other event types
@@ -616,23 +587,6 @@ export async function updateBackgroundRundown(rundownId: string, rundown: Rundow
await getDataProvider().setRundown(rundownId, rundown); await getDataProvider().setRundown(rundownId, rundown);
} }
/**
* Reads a rundown from disk and returns it in the processed shape used by clients.
* Used for non-loaded rundowns the loaded rundown is served directly from cache.
*/
export function getProcessedRundown(rundownId: string): Rundown {
const stored = getDataProvider().getRundown(rundownId);
const processed = processRundown(stored, getDataProvider().getCustomFields());
return {
id: stored.id,
title: stored.title,
entries: processed.entries,
order: processed.order,
flatOrder: processed.flatEntryOrder,
revision: stored.revision,
};
}
/** /**
* Adds a new custom field to the object and returns it * Adds a new custom field to the object and returns it
*/ */
@@ -711,7 +665,7 @@ export const customFieldMutation = {
export function init(initialRundown: Readonly<Rundown>, initialCustomFields: Readonly<CustomFields>) { export function init(initialRundown: Readonly<Rundown>, initialCustomFields: Readonly<CustomFields>) {
const rundown = structuredClone(initialRundown); const rundown = structuredClone(initialRundown);
const customFields = structuredClone(initialCustomFields); const customFields = structuredClone(initialCustomFields);
const processedData = processRundown(rundown, customFields, { mutate: true }); const processedData = processRundown(rundown, customFields);
// update the cache values // update the cache values
cachedRundown.id = rundown.id; cachedRundown.id = rundown.id;
@@ -744,57 +698,72 @@ export const rundownCache = {
}; };
/** /**
* Computes derived rundown metadata (delays, gaps, group times, ordered lists). * Utility updates cache after a mutation
* By default the input rundown is not mutated entries are cloned as they are processed. * Handles calculating the rundown metadata
* Callers that own a writable rundown can pass `{ mutate: true }` to skip the per-entry clone.
* @private should not be called outside of `rundown.dao.ts`, exported for testing * @private should not be called outside of `rundown.dao.ts`, exported for testing
*/ */
export function processRundown( export function processRundown(
initialRundown: Readonly<Rundown>, initialRundown: Readonly<Rundown>,
customFields: Readonly<CustomFields>, customFields: Readonly<CustomFields>,
options?: { mutate?: boolean },
): ProcessedRundownMetadata { ): ProcessedRundownMetadata {
const { process, getMetadata } = makeRundownMetadata(customFields, options); const { process, getMetadata } = makeRundownMetadata(customFields);
for (let i = 0; i < initialRundown.order.length; i++) { for (let i = 0; i < initialRundown.order.length; i++) {
const currentEntry = initialRundown.entries[initialRundown.order[i]]; // we assign a reference to the current entry, this will be mutated in place
if (!currentEntry) continue; const currentEntryId = initialRundown.order[i];
const currentEntry = initialRundown.entries[currentEntryId];
const processedEntry = process(currentEntry, null); if (!currentEntry) {
if (!isOntimeGroup(processedEntry)) continue; continue;
// process nested entries and recompute aggregate group fields
let groupStartTime: number | null = null;
let groupEndTime: number | null = null;
let isFirstLinked = false;
const groupEvents: EntryId[] = [];
processedEntry.duration = 0;
for (let j = 0; j < processedEntry.entries.length; j++) {
const nestedEntry = initialRundown.entries[processedEntry.entries[j]];
if (!nestedEntry) continue;
groupEvents.push(nestedEntry.id);
const processedNestedEntry = process(nestedEntry, processedEntry.id);
// skip metadata aggregation for non-playable nested entries
if (!isOntimeEvent(processedNestedEntry) || !isPlayableEvent(processedNestedEntry)) continue;
if (groupStartTime === null) {
groupStartTime = processedNestedEntry.timeStart;
isFirstLinked = Boolean(processedNestedEntry.linkStart);
}
groupEndTime = processedNestedEntry.timeEnd;
if (j > 0) {
processedEntry.duration += processedNestedEntry.gap;
}
processedEntry.duration += processedNestedEntry.duration;
} }
const { processedEntry } = process(currentEntry, null);
processedEntry.timeStart = groupStartTime; // if the event is a group, we process the nested entries
processedEntry.timeEnd = groupEndTime; // the code here is a copy of the processing of top level events
processedEntry.isFirstLinked = isFirstLinked; if (isOntimeGroup(processedEntry)) {
processedEntry.entries = groupEvents; let groupStartTime = null;
let groupEndTime = null;
let isFirstLinked = false;
const groupEvents: EntryId[] = [];
processedEntry.duration = 0;
// check if the group contains nested entries
for (let j = 0; j < processedEntry.entries.length; j++) {
const nestedEntryId = processedEntry.entries[j];
const nestedEntry = initialRundown.entries[nestedEntryId];
if (!nestedEntry) {
continue;
}
groupEvents.push(nestedEntry.id);
const { processedEntry: processedNestedEntry } = process(nestedEntry, processedEntry.id);
// we dont extract metadata of skipped events,
// if this is not a playable event there is nothing else to do
if (!isOntimeEvent(processedNestedEntry) || !isPlayableEvent(processedNestedEntry)) {
continue;
}
// first start is always the first event
if (groupStartTime === null) {
groupStartTime = processedNestedEntry.timeStart;
isFirstLinked = Boolean(processedNestedEntry.linkStart);
}
// lastEntry is the event with the latest end time
groupEndTime = processedNestedEntry.timeEnd;
if (j > 0) {
processedEntry.duration += processedNestedEntry.gap;
}
processedEntry.duration = processedEntry.duration + processedNestedEntry.duration;
}
// update group metadata
processedEntry.timeStart = groupStartTime;
processedEntry.timeEnd = groupEndTime;
processedEntry.isFirstLinked = isFirstLinked;
processedEntry.entries = groupEvents;
}
} }
return getMetadata(); return getMetadata();
@@ -205,15 +205,10 @@ export type ProcessedRundownMetadata = RundownMetadata & {
/** /**
* Factory function to create a rundown metadata processor * Factory function to create a rundown metadata processor
* * @returns {process, getMetadata} process() - processes entries in order | getMetadata() -> returns the current metadata
* @param customFields project custom fields used to sanitise entries
* @param options.mutate when true, entries are mutated in place rather than cloned.
* Callers must own (or have already cloned) the input rundown.
* @returns process() - processes entries in order | getMetadata() returns the accumulated metadata
*/ */
export function makeRundownMetadata(customFields: CustomFields, options?: { mutate?: boolean }) { export function makeRundownMetadata(customFields: CustomFields) {
const mutate = options?.mutate ?? false; let rundownMeta: ProcessedRundownMetadata = {
const rundownMeta: ProcessedRundownMetadata = {
totalDelay: 0, totalDelay: 0,
totalDuration: 0, totalDuration: 0,
totalDays: 0, totalDays: 0,
@@ -233,8 +228,13 @@ export function makeRundownMetadata(customFields: CustomFields, options?: { muta
previousEntry: null, previousEntry: null,
}; };
function process<T extends OntimeEntry>(entry: T, childOfGroup: EntryId | null): T { function process<T extends OntimeEntry>(
return processEntry(rundownMeta, customFields, mutate ? entry : structuredClone(entry), childOfGroup); entry: T,
childOfGroup: EntryId | null,
): { processedData: ProcessedRundownMetadata; processedEntry: T } {
const data = processEntry(rundownMeta, customFields, entry, childOfGroup);
rundownMeta = data.processedData;
return data;
} }
function getMetadata(): ProcessedRundownMetadata { function getMetadata(): ProcessedRundownMetadata {
@@ -245,19 +245,20 @@ export function makeRundownMetadata(customFields: CustomFields, options?: { muta
} }
/** /**
* Processes a single entry, mutating both `entry` and `rundownMetadata` in place. * Processes a single entry and updates the rundown metadata
* Returns the same `entry` reference for caller convenience.
*/ */
function processEntry<T extends OntimeEntry>( function processEntry<T extends OntimeEntry>(
rundownMetadata: ProcessedRundownMetadata, rundownMetadata: ProcessedRundownMetadata,
customFields: CustomFields, customFields: CustomFields,
entry: T, entry: T,
childOfGroup: EntryId | null, childOfGroup: EntryId | null,
): T { ): { processedData: ProcessedRundownMetadata; processedEntry: T } {
rundownMetadata.flatEntryOrder.push(entry.id); const processedData = { ...rundownMetadata };
const currentEntry = structuredClone(entry);
processedData.flatEntryOrder.push(currentEntry.id);
if (isOntimeEvent(entry)) { if (isOntimeEvent(currentEntry)) {
rundownMetadata.timedEventOrder.push(entry.id); processedData.timedEventOrder.push(currentEntry.id);
/** /**
* 1.Checks that link can be established (ie, events exist and are valid) * 1.Checks that link can be established (ie, events exist and are valid)
@@ -265,91 +266,91 @@ function processEntry<T extends OntimeEntry>(
* The linked event is always the previous playable event * The linked event is always the previous playable event
* If no previous event exists, the link is removed * If no previous event exists, the link is removed
*/ */
if (entry.linkStart) { if (currentEntry.linkStart) {
if (rundownMetadata.previousEvent) { if (processedData.previousEvent) {
const timePatch = getLinkedTimes(entry, rundownMetadata.previousEvent); const timePatch = getLinkedTimes(currentEntry, processedData.previousEvent);
entry.timeStart = timePatch.timeStart; currentEntry.timeStart = timePatch.timeStart;
entry.timeEnd = timePatch.timeEnd; currentEntry.timeEnd = timePatch.timeEnd;
entry.duration = timePatch.duration; currentEntry.duration = timePatch.duration;
} else { } else {
entry.linkStart = false; currentEntry.linkStart = false;
} }
} }
// 2. handle custom fields - mutates entry // 2. handle custom fields - mutates currentEntry
sanitiseCustomFields(customFields, entry); sanitiseCustomFields(customFields, currentEntry);
rundownMetadata.totalDays += calculateDayOffset(entry, rundownMetadata.previousEvent); processedData.totalDays += calculateDayOffset(currentEntry, processedData.previousEvent);
entry.dayOffset = rundownMetadata.totalDays as Day; currentEntry.dayOffset = processedData.totalDays as Day;
entry.delay = 0; // this means we dont calculate delays or gaps for skipped events currentEntry.delay = 0; // this means we dont calculate delays or gaps for skipped events
entry.gap = 0; // this means we dont calculate delays or gaps for skipped events currentEntry.gap = 0; // this means we dont calculate delays or gaps for skipped events
entry.parent = childOfGroup; currentEntry.parent = childOfGroup;
// update rundown metadata, it only concerns playable events // update rundown metadata, it only concerns playable events
if (isPlayableEvent(entry)) { if (isPlayableEvent(currentEntry)) {
rundownMetadata.playableEventOrder.push(entry.id); processedData.playableEventOrder.push(currentEntry.id);
// first start is always the first event // first start is always the first event
if (rundownMetadata.firstStart === null) { if (processedData.firstStart === null) {
rundownMetadata.firstStart = entry.timeStart; processedData.firstStart = currentEntry.timeStart;
} }
// check if event is flagged // check if event is flagged
if (entry.flag) { if (currentEntry.flag) {
rundownMetadata.flags.push(entry.id); processedData.flags.push(currentEntry.id);
} }
entry.gap = getTimeFrom(entry, rundownMetadata.latestEvent); currentEntry.gap = getTimeFrom(currentEntry, processedData.latestEvent);
if (entry.gap === 0) { if (currentEntry.gap === 0) {
// event starts on previous finish, we add its duration // event starts on previous finish, we add its duration
rundownMetadata.totalDuration += entry.duration; processedData.totalDuration += currentEntry.duration;
} else if (entry.gap > 0) { } else if (currentEntry.gap > 0) {
// event has a gap, we add the gap and the duration // event has a gap, we add the gap and the duration
rundownMetadata.totalDuration += entry.gap + entry.duration; processedData.totalDuration += currentEntry.gap + currentEntry.duration;
} else { } else if (currentEntry.gap < 0) {
// there is an overlap, we remove the overlap from the duration // there is an overlap, we remove the overlap from the duration
// ensuring that the sum is not negative (ie: fully overlapped events) // ensuring that the sum is not negative (ie: fully overlapped events)
// NOTE: we add the gap since it is a negative number // NOTE: we add the gap since it is a negative number
rundownMetadata.totalDuration += Math.max(entry.duration + entry.gap, 0); processedData.totalDuration += Math.max(currentEntry.duration + currentEntry.gap, 0);
} }
// remove eventual gaps from the accumulated delay // remove eventual gaps from the accumulated delay
// we only affect positive delays (time forwards) // we only affect positive delays (time forwards)
if (rundownMetadata.totalDelay > 0 && entry.gap > 0) { if (processedData.totalDelay > 0 && currentEntry.gap > 0) {
let correctedDelay = 0; let correctedDelay = 0;
// we need to separate the delay that is accumulated from one that may exist after the gap // we need to separate the delay that is accumulated from one that may exist after the gap
if (isOntimeDelay(rundownMetadata.previousEntry)) { if (isOntimeDelay(processedData.previousEntry)) {
correctedDelay = rundownMetadata.previousEntry.duration; correctedDelay = processedData.previousEntry.duration;
rundownMetadata.totalDelay -= correctedDelay; processedData.totalDelay -= correctedDelay;
} }
rundownMetadata.totalDelay = Math.max(rundownMetadata.totalDelay - entry.gap, 0); processedData.totalDelay = Math.max(processedData.totalDelay - currentEntry.gap, 0);
rundownMetadata.totalDelay += correctedDelay; processedData.totalDelay += correctedDelay;
} }
// current event delay is the current accumulated delay // current event delay is the current accumulated delay
entry.delay = rundownMetadata.totalDelay; currentEntry.delay = processedData.totalDelay;
// assign data for next iteration // assign data for next iteration
rundownMetadata.previousEvent = entry; processedData.previousEvent = currentEntry;
// lastEntry is the event with the latest end time // lastEntry is the event with the latest end time
if (isNewLatest(entry, rundownMetadata.latestEvent)) { if (isNewLatest(currentEntry, processedData.latestEvent)) {
rundownMetadata.latestEvent = entry; processedData.latestEvent = currentEntry;
rundownMetadata.lastEnd = entry.timeEnd; processedData.lastEnd = currentEntry.timeEnd;
} }
} }
} else if (isOntimeDelay(entry)) { } else if (isOntimeDelay(currentEntry)) {
// !!! this must happen after handling the links // !!! this must happen after handling the links
rundownMetadata.totalDelay += entry.duration; processedData.totalDelay += currentEntry.duration;
entry.parent = childOfGroup; currentEntry.parent = childOfGroup;
} }
if (!childOfGroup) { if (!childOfGroup) {
rundownMetadata.order.push(entry.id); processedData.order.push(currentEntry.id);
} }
rundownMetadata.entries[entry.id] = entry; processedData.entries[currentEntry.id] = currentEntry;
rundownMetadata.previousEntry = entry; processedData.previousEntry = currentEntry;
return entry; return { processedData, processedEntry: currentEntry };
} }
@@ -5,14 +5,14 @@ import { ErrorResponse, OntimeEntry, ProjectRundownsList, RenumberCues, Rundown
import { getErrorMessage } from 'ontime-utils'; import { getErrorMessage } from 'ontime-utils';
import { getDataProvider } from '../../classes/data-provider/DataProvider.js'; import { getDataProvider } from '../../classes/data-provider/DataProvider.js';
import { makeNewRundown } from '../../models/dataModel.js';
import { paramsWithId } from '../validation-utils/validationFunction.js'; import { paramsWithId } from '../validation-utils/validationFunction.js';
import { getCurrentRundown, getProcessedRundown } from './rundown.dao.js'; import { getCurrentRundown } from './rundown.dao.js';
import { import {
addEntry, addEntry,
applyDelay, applyDelay,
batchEditEntries, batchEditEntries,
cloneEntry, cloneEntry,
createNewRundown,
deleteAllEntries, deleteAllEntries,
deleteEntries, deleteEntries,
editEntry, editEntry,
@@ -35,6 +35,7 @@ import {
entrySwapValidator, entrySwapValidator,
rundownArrayOfIds, rundownArrayOfIds,
rundownPostValidator, rundownPostValidator,
validateRundownMutation,
} from './rundown.validation.js'; } from './rundown.validation.js';
export const router: Router = express.Router(); export const router: Router = express.Router();
@@ -57,19 +58,6 @@ router.get('/current', async (_req: Request, res: Response<Rundown>) => {
res.json(rundown); res.json(rundown);
}); });
/**
* Returns a given rundown in its normalised client shape
*/
router.get('/:id', paramsWithId, async (req: Request, res: Response<Rundown | ErrorResponse>) => {
try {
const rundown = getProcessedRundown(req.params.id);
res.json(rundown);
} catch (error) {
const message = getErrorMessage(error);
res.status(404).send({ message });
}
});
/** /**
* Loads a given rundown * Loads a given rundown
*/ */
@@ -88,7 +76,11 @@ router.post('/:id/load', paramsWithId, async (req: Request, res: Response<Projec
*/ */
router.post('/', rundownPostValidator, async (req: Request, res: Response<ProjectRundownsList | ErrorResponse>) => { router.post('/', rundownPostValidator, async (req: Request, res: Response<ProjectRundownsList | ErrorResponse>) => {
try { try {
const projectRundowns = await createNewRundown(req.body.title); const emptyRundown = makeNewRundown();
emptyRundown.title = req.body.title;
await getDataProvider().setRundown(emptyRundown.id, emptyRundown);
const projectRundowns = getDataProvider().getProjectRundowns();
res.status(201).json({ loaded: getCurrentRundown().id, rundowns: normalisedToRundownArray(projectRundowns) }); res.status(201).json({ loaded: getCurrentRundown().id, rundowns: normalisedToRundownArray(projectRundowns) });
} catch (error) { } catch (error) {
const message = getErrorMessage(error); const message = getErrorMessage(error);
@@ -188,9 +180,10 @@ router.delete('/:id', paramsWithId, async (req: Request, res: Response<ProjectRu
router.post( router.post(
'/:rundownId/entry', '/:rundownId/entry',
entryPostValidator, entryPostValidator,
validateRundownMutation,
async (req: Request, res: Response<OntimeEntry | ErrorResponse>) => { async (req: Request, res: Response<OntimeEntry | ErrorResponse>) => {
try { try {
const newEvent = await addEntry(req.params.rundownId, req.body); const newEvent = await addEntry(req.body);
res.status(201).send(newEvent); res.status(201).send(newEvent);
} catch (error) { } catch (error) {
const message = getErrorMessage(error); const message = getErrorMessage(error);
@@ -202,15 +195,20 @@ router.post(
/** /**
* Edits an entry in a given rundown * Edits an entry in a given rundown
*/ */
router.put('/:rundownId/entry', entryPutValidator, async (req: Request, res: Response<OntimeEntry | ErrorResponse>) => { router.put(
try { '/:rundownId/entry',
const event = await editEntry(req.params.rundownId, req.body); entryPutValidator,
res.status(200).send(event); validateRundownMutation,
} catch (error) { async (req: Request, res: Response<OntimeEntry | ErrorResponse>) => {
const message = getErrorMessage(error); try {
res.status(400).send({ message }); const event = await editEntry(req.body);
} res.status(200).send(event);
}); } catch (error) {
const message = getErrorMessage(error);
res.status(400).send({ message });
}
},
);
/** /**
* Edits an entry in a given rundown * Edits an entry in a given rundown
@@ -218,9 +216,10 @@ router.put('/:rundownId/entry', entryPutValidator, async (req: Request, res: Res
router.put( router.put(
'/:rundownId/batch', '/:rundownId/batch',
entryBatchPutValidator, entryBatchPutValidator,
validateRundownMutation,
async (req: Request, res: Response<Rundown | ErrorResponse>) => { async (req: Request, res: Response<Rundown | ErrorResponse>) => {
try { try {
const rundown = await batchEditEntries(req.params.rundownId, req.body.ids, req.body.data); const rundown = await batchEditEntries(req.body.ids, req.body.data);
res.status(200).send(rundown); res.status(200).send(rundown);
} catch (error) { } catch (error) {
const message = getErrorMessage(error); const message = getErrorMessage(error);
@@ -235,10 +234,11 @@ router.put(
router.patch( router.patch(
'/:rundownId/reorder', '/:rundownId/reorder',
entryReorderValidator, entryReorderValidator,
validateRundownMutation,
async (req: Request, res: Response<Rundown | ErrorResponse>) => { async (req: Request, res: Response<Rundown | ErrorResponse>) => {
try { try {
const { entryId, destinationId, order } = req.body; const { entryId, destinationId, order } = req.body;
const rundown = await reorderEntry(req.params.rundownId, entryId, destinationId, order); const rundown = await reorderEntry(entryId, destinationId, order);
res.status(200).send(rundown); res.status(200).send(rundown);
} catch (error) { } catch (error) {
const message = getErrorMessage(error); const message = getErrorMessage(error);
@@ -253,9 +253,10 @@ router.patch(
router.patch( router.patch(
'/:rundownId/applydelay/:id', '/:rundownId/applydelay/:id',
paramsWithId, paramsWithId,
validateRundownMutation,
async (req: Request, res: Response<Rundown | ErrorResponse>) => { async (req: Request, res: Response<Rundown | ErrorResponse>) => {
try { try {
const rundown = await applyDelay(req.params.rundownId, req.params.id); const rundown = await applyDelay(req.params.id);
res.status(200).send(rundown); res.status(200).send(rundown);
} catch (error) { } catch (error) {
const message = getErrorMessage(error); const message = getErrorMessage(error);
@@ -267,15 +268,20 @@ router.patch(
/** /**
* Swaps data between two Ontime events * Swaps data between two Ontime events
*/ */
router.patch('/:rundownId/swap', entrySwapValidator, async (req: Request, res: Response<Rundown | ErrorResponse>) => { router.patch(
try { '/:rundownId/swap',
const rundown = await swapEvents(req.params.rundownId, req.body.from, req.body.to); entrySwapValidator,
res.status(200).send(rundown); validateRundownMutation,
} catch (error) { async (req: Request, res: Response<Rundown | ErrorResponse>) => {
const message = getErrorMessage(error); try {
res.status(400).send({ message }); const rundown = await swapEvents(req.body.from, req.body.to);
} res.status(200).send(rundown);
}); } catch (error) {
const message = getErrorMessage(error);
res.status(400).send({ message });
}
},
);
/** /**
* Clones the contents of an entry into a new one * Clones the contents of an entry into a new one
@@ -284,9 +290,10 @@ router.post(
'/:rundownId/clone/:id', '/:rundownId/clone/:id',
paramsWithId, paramsWithId,
clonePostValidator, clonePostValidator,
validateRundownMutation,
async (req: Request, res: Response<Rundown | ErrorResponse>) => { async (req: Request, res: Response<Rundown | ErrorResponse>) => {
try { try {
const rundown = await cloneEntry(req.params.rundownId, req.params.id, { const rundown = await cloneEntry(req.params.id, {
before: req.body?.before, before: req.body?.before,
after: req.body?.after, after: req.body?.after,
}); });
@@ -301,28 +308,38 @@ router.post(
/** /**
* Creates a group out of a list of entries * Creates a group out of a list of entries
*/ */
router.post('/:rundownId/group', rundownArrayOfIds, async (req: Request, res: Response<Rundown | ErrorResponse>) => { router.post(
try { '/:rundownId/group',
const rundown = await groupEntries(req.params.rundownId, req.body.ids); rundownArrayOfIds,
res.status(200).send(rundown); validateRundownMutation,
} catch (error) { async (req: Request, res: Response<Rundown | ErrorResponse>) => {
const message = getErrorMessage(error); try {
res.status(400).send({ message }); const rundown = await groupEntries(req.body.ids);
} res.status(200).send(rundown);
}); } catch (error) {
const message = getErrorMessage(error);
res.status(400).send({ message });
}
},
);
/** /**
* Dissolves a group by moving its children to the main rundown * Dissolves a group by moving its children to the main rundown
*/ */
router.post('/:rundownId/ungroup/:id', paramsWithId, async (req: Request, res: Response<Rundown | ErrorResponse>) => { router.post(
try { '/:rundownId/ungroup/:id',
const rundown = await ungroupEntries(req.params.rundownId, req.params.id); paramsWithId,
res.status(200).send(rundown); validateRundownMutation,
} catch (error) { async (req: Request, res: Response<Rundown | ErrorResponse>) => {
const message = getErrorMessage(error); try {
res.status(400).send({ message }); const rundown = await ungroupEntries(req.params.id);
} res.status(200).send(rundown);
}); } catch (error) {
const message = getErrorMessage(error);
res.status(400).send({ message });
}
},
);
/** /**
* Deletes a list of entries by their ID * Deletes a list of entries by their ID
@@ -330,9 +347,10 @@ router.post('/:rundownId/ungroup/:id', paramsWithId, async (req: Request, res: R
router.delete( router.delete(
'/:rundownId/entries', '/:rundownId/entries',
rundownArrayOfIds, rundownArrayOfIds,
validateRundownMutation,
async (req: Request, res: Response<Rundown | ErrorResponse>) => { async (req: Request, res: Response<Rundown | ErrorResponse>) => {
try { try {
const rundown = await deleteEntries(req.params.rundownId, req.body.ids); const rundown = await deleteEntries(req.body.ids);
res.status(200).send(rundown); res.status(200).send(rundown);
} catch (error) { } catch (error) {
const message = getErrorMessage(error); const message = getErrorMessage(error);
@@ -344,15 +362,19 @@ router.delete(
/** /**
* Deletes all entries in a given rundown * Deletes all entries in a given rundown
*/ */
router.delete('/:rundownId/all', async (req: Request, res: Response<Rundown | ErrorResponse>) => { router.delete(
try { '/:rundownId/all',
const rundown = await deleteAllEntries(req.params.rundownId); validateRundownMutation,
res.status(200).send(rundown); async (_req: Request, res: Response<Rundown | ErrorResponse>) => {
} catch (error) { try {
const message = getErrorMessage(error); const rundown = await deleteAllEntries();
res.status(400).send({ message }); res.status(200).send(rundown);
} } catch (error) {
}); const message = getErrorMessage(error);
res.status(400).send({ message });
}
},
);
/** /**
* Reorders two entries in a rundown * Reorders two entries in a rundown
@@ -360,10 +382,11 @@ router.delete('/:rundownId/all', async (req: Request, res: Response<Rundown | Er
router.patch( router.patch(
'/:rundownId/renumber', '/:rundownId/renumber',
entryRenumberValidator, entryRenumberValidator,
async (req: Request, res: Response<Rundown | ErrorResponse>) => { validateRundownMutation,
(req: Request, res: Response<Rundown | ErrorResponse>) => {
try { try {
const { ids, prefix, start, increment } = matchedData<RenumberCues>(req); const { ids, prefix, start, increment } = matchedData<RenumberCues>(req);
const rundown = await renumberEntries(req.params.rundownId, ids, prefix, start, increment); const rundown = renumberEntries(ids, prefix, start, increment);
res.status(200).send(rundown); res.status(200).send(rundown);
} catch (error) { } catch (error) {
const message = getErrorMessage(error); const message = getErrorMessage(error);
@@ -21,14 +21,13 @@ import { customFieldLabelToKey, getInsertAfterId, resolveInsertParent } from 'on
import { sendRefetch } from '../../adapters/WebsocketAdapter.js'; import { sendRefetch } from '../../adapters/WebsocketAdapter.js';
import { getDataProvider } from '../../classes/data-provider/DataProvider.js'; import { getDataProvider } from '../../classes/data-provider/DataProvider.js';
import { logger } from '../../classes/Logger.js'; import { logger } from '../../classes/Logger.js';
import { makeNewRundown } from '../../models/dataModel.js';
import { setLastLoadedRundown } from '../../services/app-state-service/AppStateService.js'; import { setLastLoadedRundown } from '../../services/app-state-service/AppStateService.js';
import { runtimeService } from '../../services/runtime-service/runtime.service.js'; import { runtimeService } from '../../services/runtime-service/runtime.service.js';
import { updateRundownData } from '../../stores/runtimeState.js'; import { updateRundownData } from '../../stores/runtimeState.js';
import { import {
createTransaction, createTransaction,
customFieldMutation, customFieldMutation,
getCurrentRundownId, getCurrentRundown,
rundownCache, rundownCache,
rundownMutation, rundownMutation,
updateBackgroundRundown, updateBackgroundRundown,
@@ -39,8 +38,8 @@ import { generateEvent, getIntegerAndFraction, hasChanges } from './rundown.util
/** /**
* creates a new entry with given data * creates a new entry with given data
*/ */
export async function addEntry(rundownId: string, eventData: EventPostPayload): Promise<OntimeEntry> { export async function addEntry(eventData: EventPostPayload): Promise<OntimeEntry> {
const { rundown, commit } = createTransaction({ rundownId, mutableRundown: true }); const { rundown, commit } = createTransaction({ mutableRundown: true, mutableCustomFields: false });
// we allow the user to provide an ID, but make sure it is unique // we allow the user to provide an ID, but make sure it is unique
if (eventData?.id && Object.hasOwn(rundown.entries, eventData.id)) { if (eventData?.id && Object.hasOwn(rundown.entries, eventData.id)) {
@@ -67,7 +66,7 @@ export async function addEntry(rundownId: string, eventData: EventPostPayload):
// make mutations to rundown // make mutations to rundown
rundownMutation.add(rundown, newEntry, afterId, parent); rundownMutation.add(rundown, newEntry, afterId, parent);
const { rundown: responseRundown, rundownMetadata, revision } = await commit(); const { rundownMetadata, revision } = commit();
// schedule the side effects // schedule the side effects
setImmediate(() => { setImmediate(() => {
@@ -75,17 +74,17 @@ export async function addEntry(rundownId: string, eventData: EventPostPayload):
updateRuntimeOnChange(rundownMetadata); updateRuntimeOnChange(rundownMetadata);
// notify timer and external services of change // notify timer and external services of change
notifyChanges(rundown.id, rundownMetadata, revision, { timer: [newEntry.id], external: true }); notifyChanges(rundownMetadata, revision, { timer: [newEntry.id], external: true });
}); });
return responseRundown.entries[newEntry.id] ?? newEntry; return newEntry;
} }
/** /**
* Applies a patch to an entry in the rundown * Applies a patch to an entry in the rundown
*/ */
export async function editEntry(rundownId: string, patch: PatchWithId): Promise<OntimeEntry> { export async function editEntry(patch: PatchWithId): Promise<OntimeEntry> {
const { rundown, commit } = createTransaction({ rundownId, mutableRundown: true }); const { rundown, commit } = createTransaction({ mutableRundown: true, mutableCustomFields: false });
const currentEntry = rundown.entries[patch.id]; const currentEntry = rundown.entries[patch.id];
/** /**
@@ -111,7 +110,7 @@ export async function editEntry(rundownId: string, patch: PatchWithId): Promise<
} }
const { entry, didInvalidate } = rundownMutation.edit(rundown, patch); const { entry, didInvalidate } = rundownMutation.edit(rundown, patch);
const { rundown: responseRundown, rundownMetadata, revision } = await commit(didInvalidate); const { rundownMetadata, revision } = commit(didInvalidate);
// schedule the side effects // schedule the side effects
setImmediate(() => { setImmediate(() => {
@@ -119,24 +118,17 @@ export async function editEntry(rundownId: string, patch: PatchWithId): Promise<
updateRuntimeOnChange(rundownMetadata); updateRuntimeOnChange(rundownMetadata);
// notify timer and external services of change // notify timer and external services of change
notifyChanges(rundown.id, rundownMetadata, revision, { notifyChanges(rundownMetadata, revision, { timer: didInvalidate ? true : [entry.id], external: true });
timer: didInvalidate ? true : [entry.id],
external: true,
});
}); });
return responseRundown.entries[entry.id] ?? entry; return entry;
} }
/** /**
* Applies a patch to several entries in the rundown * Applies a patch to several entries in the rundown
*/ */
export async function batchEditEntries( export async function batchEditEntries(ids: EntryId[], patch: Partial<OntimeEntry>): Promise<Rundown> {
rundownId: string, const { rundown, commit } = createTransaction({ mutableRundown: true, mutableCustomFields: false });
ids: EntryId[],
patch: Partial<OntimeEntry>,
): Promise<Rundown> {
const { rundown, commit } = createTransaction({ rundownId, mutableRundown: true });
/** /**
* We can do some validation globally, but mostly we will validate each entry individually * We can do some validation globally, but mostly we will validate each entry individually
@@ -181,7 +173,7 @@ export async function batchEditEntries(
batchDidInvalidate = true; batchDidInvalidate = true;
} }
} }
const { rundown: rundownResult, rundownMetadata, revision } = await commit(batchDidInvalidate); const { rundown: rundownResult, rundownMetadata, revision } = commit(batchDidInvalidate);
// schedule the side effects // schedule the side effects
setImmediate(() => { setImmediate(() => {
@@ -189,10 +181,7 @@ export async function batchEditEntries(
updateRuntimeOnChange(rundownMetadata); updateRuntimeOnChange(rundownMetadata);
// notify timer and external services of change // notify timer and external services of change
notifyChanges(rundown.id, rundownMetadata, revision, { notifyChanges(rundownMetadata, revision, { timer: batchDidInvalidate ? true : changedIds, external: true });
timer: batchDidInvalidate ? true : changedIds,
external: true,
});
}); });
return rundownResult; return rundownResult;
@@ -201,8 +190,8 @@ export async function batchEditEntries(
/** /**
* Deletes a known entry from the current rundown * Deletes a known entry from the current rundown
*/ */
export async function deleteEntries(rundownId: string, entryIds: EntryId[]): Promise<Rundown> { export async function deleteEntries(entryIds: EntryId[]): Promise<Rundown> {
const { rundown, commit } = createTransaction({ rundownId, mutableRundown: true }); const { rundown, commit } = createTransaction({ mutableRundown: true, mutableCustomFields: false });
for (let i = 0; i < entryIds.length; i++) { for (let i = 0; i < entryIds.length; i++) {
const entry = rundown.entries[entryIds[i]]; const entry = rundown.entries[entryIds[i]];
@@ -212,7 +201,7 @@ export async function deleteEntries(rundownId: string, entryIds: EntryId[]): Pro
rundownMutation.remove(rundown, entry); rundownMutation.remove(rundown, entry);
} }
const { rundown: rundownResult, rundownMetadata, revision } = await commit(); const { rundown: rundownResult, rundownMetadata, revision } = commit();
// schedule the side effects // schedule the side effects
setImmediate(() => { setImmediate(() => {
@@ -220,7 +209,7 @@ export async function deleteEntries(rundownId: string, entryIds: EntryId[]): Pro
updateRuntimeOnChange(rundownMetadata); updateRuntimeOnChange(rundownMetadata);
// notify timer and external services of change // notify timer and external services of change
notifyChanges(rundown.id, rundownMetadata, revision, { timer: entryIds, external: true }); notifyChanges(rundownMetadata, revision, { timer: entryIds, external: true });
}); });
return rundownResult; return rundownResult;
@@ -229,12 +218,12 @@ export async function deleteEntries(rundownId: string, entryIds: EntryId[]): Pro
/** /**
* Deletes all entries from the current rundown * Deletes all entries from the current rundown
*/ */
export async function deleteAllEntries(rundownId: string): Promise<Rundown> { export async function deleteAllEntries(): Promise<Rundown> {
const { rundown, commit } = createTransaction({ rundownId, mutableRundown: true }); const { rundown, commit } = createTransaction({ mutableRundown: true, mutableCustomFields: false });
rundownMutation.removeAll(rundown); rundownMutation.removeAll(rundown);
const { rundown: rundownResult, rundownMetadata, revision } = await commit(); const { rundown: rundownResult, rundownMetadata, revision } = commit();
// schedule the side effects // schedule the side effects
setImmediate(() => { setImmediate(() => {
@@ -242,7 +231,7 @@ export async function deleteAllEntries(rundownId: string): Promise<Rundown> {
updateRuntimeOnChange(rundownMetadata); updateRuntimeOnChange(rundownMetadata);
// notify timer and external services of change // notify timer and external services of change
notifyChanges(rundown.id, rundownMetadata, revision, { timer: true, external: true }); notifyChanges(rundownMetadata, revision, { timer: true, external: true });
}); });
return rundownResult; return rundownResult;
@@ -253,13 +242,8 @@ export async function deleteAllEntries(rundownId: string): Promise<Rundown> {
* Handles moving across root orders (a group order and top level order) * Handles moving across root orders (a group order and top level order)
* @throws if entryId or destinationId not found * @throws if entryId or destinationId not found
*/ */
export async function reorderEntry( export async function reorderEntry(entryId: EntryId, destinationId: EntryId, order: 'before' | 'after' | 'insert') {
rundownId: string, const { rundown, commit } = createTransaction({ mutableRundown: true, mutableCustomFields: false });
entryId: EntryId,
destinationId: EntryId,
order: 'before' | 'after' | 'insert',
) {
const { rundown, commit } = createTransaction({ rundownId, mutableRundown: true });
// check that both entries exist // check that both entries exist
const eventFrom = rundown.entries[entryId]; const eventFrom = rundown.entries[entryId];
@@ -271,7 +255,7 @@ export async function reorderEntry(
rundownMutation.reorder(rundown, eventFrom, eventTo, order); rundownMutation.reorder(rundown, eventFrom, eventTo, order);
const { rundown: rundownResult, rundownMetadata, revision } = await commit(); const { rundown: rundownResult, rundownMetadata, revision } = commit();
// schedule the side effects // schedule the side effects
setImmediate(() => { setImmediate(() => {
@@ -279,7 +263,7 @@ export async function reorderEntry(
updateRuntimeOnChange(rundownMetadata); updateRuntimeOnChange(rundownMetadata);
// notify timer and external services of change // notify timer and external services of change
notifyChanges(rundown.id, rundownMetadata, revision, { timer: true, external: true }); notifyChanges(rundownMetadata, revision, { timer: true, external: true });
}); });
return rundownResult; return rundownResult;
@@ -288,28 +272,22 @@ export async function reorderEntry(
/** /**
* @throws if an id is missing or not an Ontime event * @throws if an id is missing or not an Ontime event
*/ */
export async function renumberEntries( export function renumberEntries(ids: EntryId[], prefix: string, start: string, increment: string): Rundown {
rundownId: string,
ids: EntryId[],
prefix: string,
start: string,
increment: string,
): Promise<Rundown> {
const startNumber = getIntegerAndFraction(start); const startNumber = getIntegerAndFraction(start);
const incrementNumber = getIntegerAndFraction(increment); const incrementNumber = getIntegerAndFraction(increment);
// if the prefix doesn't already include a separator or is empty, then insert a separator // if the prefix doesn't already include a separator or is empty, then insert a separator
if (prefix !== '' && !prefix.endsWith('-') && !prefix.endsWith(' ')) prefix += ' '; if (prefix !== '' && !prefix.endsWith('-') && !prefix.endsWith(' ')) prefix += ' ';
const { rundown, commit } = createTransaction({ rundownId, mutableRundown: true, mutableCustomFields: false }); const { rundown, commit } = createTransaction({ mutableRundown: true, mutableCustomFields: false });
rundownMutation.renumber(rundown, ids, prefix, startNumber, incrementNumber); rundownMutation.renumber(rundown, ids, prefix, startNumber, incrementNumber);
const { rundown: rundownResult, rundownMetadata, revision } = await commit(false); const { rundown: rundownResult, rundownMetadata, revision } = commit(false);
setImmediate(() => { setImmediate(() => {
updateRuntimeOnChange(rundownMetadata); updateRuntimeOnChange(rundownMetadata);
notifyChanges(rundown.id, rundownMetadata, revision, { timer: ids, external: true }); notifyChanges(rundownMetadata, revision, { timer: ids, external: true });
}); });
return rundownResult; return rundownResult;
@@ -319,8 +297,8 @@ export async function renumberEntries(
* Applies a delay into the rundown effectively changing the schedule * Applies a delay into the rundown effectively changing the schedule
* The applied delay is deleted * The applied delay is deleted
*/ */
export async function applyDelay(rundownId: string, delayId: EntryId): Promise<Rundown> { export async function applyDelay(delayId: EntryId): Promise<Rundown> {
const { rundown, commit } = createTransaction({ rundownId, mutableRundown: true }); const { rundown, commit } = createTransaction({ mutableRundown: true, mutableCustomFields: false });
// check that delay exists // check that delay exists
const delay = rundown.entries[delayId]; const delay = rundown.entries[delayId];
@@ -332,7 +310,7 @@ export async function applyDelay(rundownId: string, delayId: EntryId): Promise<R
rundownMutation.applyDelay(rundown, delay); rundownMutation.applyDelay(rundown, delay);
rundownMutation.remove(rundown, delay); rundownMutation.remove(rundown, delay);
const { rundown: rundownResult, rundownMetadata, revision } = await commit(); const { rundown: rundownResult, rundownMetadata, revision } = commit();
// schedule the side effects // schedule the side effects
setImmediate(() => { setImmediate(() => {
@@ -340,7 +318,7 @@ export async function applyDelay(rundownId: string, delayId: EntryId): Promise<R
updateRuntimeOnChange(rundownMetadata); updateRuntimeOnChange(rundownMetadata);
// notify timer and external services of change // notify timer and external services of change
notifyChanges(rundown.id, rundownMetadata, revision, { timer: true, external: true }); notifyChanges(rundownMetadata, revision, { timer: true, external: true });
}); });
return rundownResult; return rundownResult;
@@ -349,8 +327,8 @@ export async function applyDelay(rundownId: string, delayId: EntryId): Promise<R
/** /**
* Swaps the data between two events in the rundown * Swaps the data between two events in the rundown
*/ */
export async function swapEvents(rundownId: string, fromId: EntryId, toId: EntryId): Promise<Rundown> { export async function swapEvents(fromId: EntryId, toId: EntryId): Promise<Rundown> {
const { rundown, commit } = createTransaction({ rundownId, mutableRundown: true }); const { rundown, commit } = createTransaction({ mutableRundown: true, mutableCustomFields: false });
const eventFrom = rundown.entries[fromId]; const eventFrom = rundown.entries[fromId];
const eventTo = rundown.entries[toId]; const eventTo = rundown.entries[toId];
@@ -365,7 +343,7 @@ export async function swapEvents(rundownId: string, fromId: EntryId, toId: Entry
} }
rundownMutation.swap(rundown, eventFrom, eventTo); rundownMutation.swap(rundown, eventFrom, eventTo);
const { rundown: rundownResult, rundownMetadata, revision } = await commit(); const { rundown: rundownResult, rundownMetadata, revision } = commit();
// schedule the side effects // schedule the side effects
setImmediate(() => { setImmediate(() => {
@@ -373,7 +351,7 @@ export async function swapEvents(rundownId: string, fromId: EntryId, toId: Entry
updateRuntimeOnChange(rundownMetadata); updateRuntimeOnChange(rundownMetadata);
// notify timer and external services of change // notify timer and external services of change
notifyChanges(rundown.id, rundownMetadata, revision, { timer: true, external: true }); notifyChanges(rundownMetadata, revision, { timer: true, external: true });
}); });
return rundownResult; return rundownResult;
@@ -384,8 +362,8 @@ export async function swapEvents(rundownId: string, fromId: EntryId, toId: Entry
* Handles cloning children if the entry is a group * Handles cloning children if the entry is a group
* @throws if the entry to clone does not exist * @throws if the entry to clone does not exist
*/ */
export async function cloneEntry(rundownId: string, entryId: EntryId, options: InsertOptions): Promise<Rundown> { export async function cloneEntry(entryId: EntryId, options: InsertOptions): Promise<Rundown> {
const { rundown, commit } = createTransaction({ rundownId, mutableRundown: true }); const { rundown, commit } = createTransaction({ mutableRundown: true, mutableCustomFields: false });
const originalEntry = rundown.entries[entryId]; const originalEntry = rundown.entries[entryId];
if (!originalEntry) { if (!originalEntry) {
@@ -393,7 +371,7 @@ export async function cloneEntry(rundownId: string, entryId: EntryId, options: I
} }
const newEntry = rundownMutation.clone(rundown, originalEntry, options); const newEntry = rundownMutation.clone(rundown, originalEntry, options);
const { rundown: rundownResult, rundownMetadata, revision } = await commit(); const { rundown: rundownResult, rundownMetadata, revision } = commit();
// schedule the side effects // schedule the side effects
setImmediate(() => { setImmediate(() => {
@@ -402,11 +380,11 @@ export async function cloneEntry(rundownId: string, entryId: EntryId, options: I
// notify timer and external services of change // notify timer and external services of change
if (isOntimeGroup(newEntry)) { if (isOntimeGroup(newEntry)) {
notifyChanges(rundown.id, rundownMetadata, revision, { timer: newEntry.entries, external: true }); notifyChanges(rundownMetadata, revision, { timer: newEntry.entries, external: true });
} else if (isOntimeEvent(newEntry)) { } else if (isOntimeEvent(newEntry)) {
notifyChanges(rundown.id, rundownMetadata, revision, { timer: [newEntry.id], external: true }); notifyChanges(rundownMetadata, revision, { timer: [newEntry.id], external: true });
} else if (isOntimeDelay(newEntry)) { } else if (isOntimeDelay(newEntry)) {
notifyChanges(rundown.id, rundownMetadata, revision, { external: true }); notifyChanges(rundownMetadata, revision, { external: true });
} }
}); });
@@ -416,11 +394,11 @@ export async function cloneEntry(rundownId: string, entryId: EntryId, options: I
/** /**
* Groups a list of entries into a new group * Groups a list of entries into a new group
*/ */
export async function groupEntries(rundownId: string, entryIds: EntryId[]): Promise<Rundown> { export async function groupEntries(entryIds: EntryId[]): Promise<Rundown> {
const { rundown, commit } = createTransaction({ rundownId, mutableRundown: true }); const { rundown, commit } = createTransaction({ mutableRundown: true, mutableCustomFields: false });
rundownMutation.group(rundown, entryIds); rundownMutation.group(rundown, entryIds);
const { rundown: rundownResult, rundownMetadata, revision } = await commit(); const { rundown: rundownResult, rundownMetadata, revision } = commit();
// schedule the side effects // schedule the side effects
setImmediate(() => { setImmediate(() => {
@@ -428,7 +406,7 @@ export async function groupEntries(rundownId: string, entryIds: EntryId[]): Prom
updateRuntimeOnChange(rundownMetadata); updateRuntimeOnChange(rundownMetadata);
// we need to notify the timer since we might be grouping a running event // we need to notify the timer since we might be grouping a running event
notifyChanges(rundown.id, rundownMetadata, revision, { external: true, timer: true }); notifyChanges(rundownMetadata, revision, { external: true, timer: true });
}); });
return rundownResult; return rundownResult;
@@ -437,8 +415,8 @@ export async function groupEntries(rundownId: string, entryIds: EntryId[]): Prom
/** /**
* Deletes a group and moves all its children to the top level * Deletes a group and moves all its children to the top level
*/ */
export async function ungroupEntries(rundownId: string, groupId: EntryId): Promise<Rundown> { export async function ungroupEntries(groupId: EntryId): Promise<Rundown> {
const { rundown, commit } = createTransaction({ rundownId, mutableRundown: true }); const { rundown, commit } = createTransaction({ mutableRundown: true, mutableCustomFields: false });
const group = rundown.entries[groupId]; const group = rundown.entries[groupId];
if (!group || !isOntimeGroup(group)) { if (!group || !isOntimeGroup(group)) {
@@ -446,7 +424,7 @@ export async function ungroupEntries(rundownId: string, groupId: EntryId): Promi
} }
rundownMutation.ungroup(rundown, group); rundownMutation.ungroup(rundown, group);
const { rundown: rundownResult, rundownMetadata, revision } = await commit(); const { rundown: rundownResult, rundownMetadata, revision } = commit();
// schedule the side effects // schedule the side effects
setImmediate(() => { setImmediate(() => {
@@ -454,7 +432,7 @@ export async function ungroupEntries(rundownId: string, groupId: EntryId): Promi
updateRuntimeOnChange(rundownMetadata); updateRuntimeOnChange(rundownMetadata);
// we dont need to notify the timer since the grouping does not affect the runtime // we dont need to notify the timer since the grouping does not affect the runtime
notifyChanges(rundown.id, rundownMetadata, revision, { external: true }); notifyChanges(rundownMetadata, revision, { external: true });
}); });
return rundownResult; return rundownResult;
@@ -481,7 +459,7 @@ export async function createCustomField(customField: CustomField): Promise<Custo
customFieldMutation.add(customFields, key, customField); customFieldMutation.add(customFields, key, customField);
// Adding a custom field has no immediate implications on the rundown // Adding a custom field has no immediate implications on the rundown
const { customFields: resultCustomFields } = await commit(false); const { customFields: resultCustomFields } = commit(false);
setImmediate(() => { setImmediate(() => {
sendRefetch(RefetchKey.CustomFields); sendRefetch(RefetchKey.CustomFields);
@@ -539,12 +517,12 @@ export async function editCustomField(
} }
// the custom fields have been removed and there is no processing to be done // the custom fields have been removed and there is no processing to be done
const { rundownMetadata, revision, customFields: resultCustomFields } = await commit(false); const { rundownMetadata, revision, customFields: resultCustomFields } = commit(false);
// schedule the side effects // schedule the side effects
setImmediate(() => { setImmediate(() => {
sendRefetch(RefetchKey.CustomFields); sendRefetch(RefetchKey.CustomFields);
notifyChanges(undefined, rundownMetadata, revision, { timer: true, external: true }); notifyChanges(rundownMetadata, revision, { timer: true, external: true });
}); });
return resultCustomFields; return resultCustomFields;
@@ -578,12 +556,12 @@ export async function deleteCustomField(key: CustomFieldKey, projectRundowns: Pr
customFieldMutation.remove(customFields, key); customFieldMutation.remove(customFields, key);
// the custom fields have been removed and there is no processing to be done // the custom fields have been removed and there is no processing to be done
const { rundownMetadata, revision, customFields: resultCustomFields } = await commit(false); const { rundownMetadata, revision, customFields: resultCustomFields } = commit(false);
// schedule the side effects // schedule the side effects
setImmediate(() => { setImmediate(() => {
sendRefetch(RefetchKey.CustomFields); sendRefetch(RefetchKey.CustomFields);
notifyChanges(undefined, rundownMetadata, revision, { timer: true, external: true }); notifyChanges(rundownMetadata, revision, { timer: true, external: true });
}); });
return resultCustomFields; return resultCustomFields;
@@ -595,8 +573,7 @@ export async function deleteCustomField(key: CustomFieldKey, projectRundowns: Pr
* *
* @private - exported for testing * @private - exported for testing
*/ */
export function updateRuntimeOnChange(rundownMetadata: RundownMetadata | null) { export function updateRuntimeOnChange(rundownMetadata: RundownMetadata) {
if (!rundownMetadata) return;
// we only declare the amount of playable events // we only declare the amount of playable events
const numEvents = rundownMetadata.timedEventOrder.length; const numEvents = rundownMetadata.timedEventOrder.length;
@@ -615,40 +592,29 @@ type NotifyChangesOptions = {
/** /**
* Notify services of changes in the rundown * Notify services of changes in the rundown
* TODO: we could receive a runtime flag to call updateRuntimeOnChange
* instead of having it in every consumer
*/ */
function notifyChanges( function notifyChanges(rundownMetadata: RundownMetadata, revision: number, options: NotifyChangesOptions) {
rundownId: string | undefined, // notify timer service of changed events
rundownMetadata: RundownMetadata | null, if (options.timer) {
revision: number,
options: NotifyChangesOptions,
) {
// notify timer service of changed event
if (rundownMetadata && options.timer && rundownId && isCurrentRundown(rundownId)) {
runtimeService.notifyOfChangedEvents(rundownMetadata); runtimeService.notifyOfChangedEvents(rundownMetadata);
} }
// notify external services of changes
if (options.reload) { if (options.reload) {
sendRefetch(RefetchKey.All); sendRefetch(RefetchKey.All);
} else if (options.external) { } else if (options.external) {
sendRefetch(RefetchKey.Rundown, revision, rundownId); sendRefetch(RefetchKey.Rundown, revision);
} }
} }
export function isCurrentRundown(id: string) {
return id === getCurrentRundownId();
}
/** /**
* @throws if the provided id does not exist * @throws if the provided id does not exist
*/ */
export async function loadRundown(id: string) { export async function loadRundown(id: string) {
const dataProvider = getDataProvider(); const dataProvider = getDataProvider();
if (isCurrentRundown(id)) { if (id === getCurrentRundown().id) {
return dataProvider.getProjectRundowns(); return dataProvider.getProjectRundowns();
} }
const rundown = dataProvider.getRundown(id); const rundown = dataProvider.getRundown(id);
const customField = dataProvider.getCustomFields(); const customField = dataProvider.getCustomFields();
await initRundown(rundown, customField); await initRundown(rundown, customField);
@@ -671,24 +637,9 @@ export async function initRundown(
updateRuntimeOnChange(rundownMetadata); updateRuntimeOnChange(rundownMetadata);
setImmediate(() => { setImmediate(() => {
notifyChanges(rundown.id, rundownMetadata, revision, { timer: true, external: true, reload }); notifyChanges(rundownMetadata, revision, { timer: true, external: true, reload });
sendRefetch(RefetchKey.ProjectRundowns);
setLastLoadedRundown(rundown.id).catch((error) => { setLastLoadedRundown(rundown.id).catch((error) => {
logger.error(LogOrigin.Server, `Failed to persist last loaded rundown: ${error}`); logger.error(LogOrigin.Server, `Failed to persist last loaded rundown: ${error}`);
}); });
}); });
} }
export async function createNewRundown(title: string) {
const emptyRundown = makeNewRundown();
emptyRundown.title = title;
await getDataProvider().setRundown(emptyRundown.id, emptyRundown);
const projectRundowns = getDataProvider().getProjectRundowns();
setImmediate(() => {
sendRefetch(RefetchKey.ProjectRundowns);
});
return projectRundowns;
}
@@ -1,6 +1,8 @@
import type { NextFunction, Request, Response } from 'express';
import { body, param } from 'express-validator'; import { body, param } from 'express-validator';
import { requestValidationFunction } from '../validation-utils/validationFunction.js'; import { requestValidationFunction } from '../validation-utils/validationFunction.js';
import { getCurrentRundown } from './rundown.dao.js';
// #region operations on project rundowns ========================= // #region operations on project rundowns =========================
@@ -9,6 +11,29 @@ export const rundownPostValidator = [body('title').isString().trim().notEmpty(),
// #endregion operations on project rundowns ====================== // #endregion operations on project rundowns ======================
// #region operations on rundown entries ========================== // #region operations on rundown entries ==========================
/**
* Middleware prevents mutating a rundown that is not selected
* This allows our service to still only handle the current rundown
*
* This would need to be removed in favour or rundown selection if we would like
* to implement the mutation of background rundowns
*/
export async function validateRundownMutation(req: Request, res: Response, next: NextFunction) {
const { rundownId } = req.params;
try {
if (getCurrentRundown().id !== rundownId) {
res.status(404).json({ message: 'Cannot mutate not selected rundown' });
return;
}
next();
} catch (error) {
res.status(404).json({ message: 'Rundown not found' });
return;
}
}
export const entryPostValidator = [ export const entryPostValidator = [
body('type').isString().isIn(['event', 'delay', 'group', 'milestone']), body('type').isString().isIn(['event', 'delay', 'group', 'milestone']),
body('after').optional().isString(), body('after').optional().isString(),
@@ -63,7 +63,7 @@ const actionHandlers: Record<ApiActionTag, ActionHandler> = {
throw new Error('Missing Event ID'); throw new Error('Missing Event ID');
} }
const { entries, id: currentRundownId } = getCurrentRundown(); const { entries } = getCurrentRundown();
const customFields = getProjectCustomFields(); const customFields = getProjectCustomFields();
const targetEntry = entries[id]; const targetEntry = entries[id];
@@ -89,8 +89,8 @@ const actionHandlers: Record<ApiActionTag, ActionHandler> = {
Object.assign(patchEntry, newObjectProperty); Object.assign(patchEntry, newObjectProperty);
} }
}); });
//TODO: windowed edit function
await editEntry(currentRundownId, patchEntry); await editEntry(patchEntry);
return { payload: 'success' }; return { payload: 'success' };
}, },
/* Message Service */ /* Message Service */
+1 -6
View File
@@ -32,7 +32,7 @@ import { runtimeService } from './services/runtime-service/runtime.service.js';
import { timerConfig } from './setup/config.js'; import { timerConfig } from './setup/config.js';
import { environment, isProduction } from './setup/environment.js'; import { environment, isProduction } from './setup/environment.js';
// import utils // import utils
import { publicDir, srcDir, srcFiles } from './setup/index.js'; import { publicDir, srcDir } from './setup/index.js';
import { populateDemo } from './setup/loadDemo.js'; import { populateDemo } from './setup/loadDemo.js';
import { populateStyles } from './setup/loadStyles.js'; import { populateStyles } from './setup/loadStyles.js';
import { populateTranslation } from './setup/loadTranslations.js'; import { populateTranslation } from './setup/loadTranslations.js';
@@ -113,11 +113,6 @@ app.use(`${prefix}/external`, (req, res) => {
}); });
app.use(`${prefix}/user`, express.static(publicDir.userDir, { etag: false, lastModified: true })); app.use(`${prefix}/user`, express.static(publicDir.userDir, { etag: false, lastModified: true }));
// Serve legacy timer for old browsers that don't support modern JS
app.get(`${prefix}/timer-legacy`, authenticateAndRedirect, (_req, res) => {
res.sendFile(srcFiles.timerLegacy);
});
// Base route for static files // Base route for static files
app.use(`${prefix}`, authenticateAndRedirect, compressedStatic); app.use(`${prefix}`, authenticateAndRedirect, compressedStatic);
app.use(`${prefix}/*splat`, authenticateAndRedirect, compressedStatic); app.use(`${prefix}/*splat`, authenticateAndRedirect, compressedStatic);
-218
View File
@@ -1,218 +0,0 @@
<!doctype html>
<html lang="en">
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<meta name="description" content="Timer view for legacy browsers" />
<title>Ontime Timer</title>
<style>
* {
box-sizing: border-box;
margin: 0;
padding: 0;
}
html,
body {
width: 100%;
height: 100%;
background: #121212;
color: #ffffff;
font-family: sans-serif;
overflow: hidden;
}
#container {
position: absolute;
top: 0;
left: 0;
right: 0;
bottom: 0;
display: -webkit-flex;
display: flex;
-webkit-flex-direction: column;
flex-direction: column;
-webkit-align-items: center;
align-items: center;
-webkit-justify-content: center;
justify-content: center;
}
#timer {
font-size: 20vmin;
font-weight: bold;
font-variant-numeric: tabular-nums;
letter-spacing: 0.025em;
line-height: 1;
color: #ffffff;
}
#timer.short {
font-size: 35vmin;
}
#timer.warning {
color: #ffa528;
}
#timer.danger {
color: #ff7300;
}
#timer.overtime {
color: #fa5656;
}
#title {
color: #999999;
font-size: 5vmin;
margin-top: 3vmin;
text-align: center;
padding-left: 4vmin;
padding-right: 4vmin;
display: none;
}
#progress-container {
position: absolute;
bottom: 0;
left: 0;
right: 0;
height: 4vmin;
background: rgba(255, 255, 255, 0.15);
display: none;
}
#progress-fill {
height: 100%;
width: 0%;
background: #ffffff;
}
</style>
</head>
<body>
<div id="container">
<div id="timer">--:--</div>
<div id="title"></div>
</div>
<div id="progress-container">
<div id="progress-fill"></div>
</div>
<script>
var timerEl = document.getElementById('timer');
var titleEl = document.getElementById('title');
var progressContainerEl = document.getElementById('progress-container');
var progressFillEl = document.getElementById('progress-fill');
var phaseColors = { warning: '#ffa528', danger: '#ff7300', overtime: '#fa5656' };
var state = { timerCurrent: null, timerPhase: 'none', timerDuration: null, eventTitle: null };
function pad(n) {
return n < 10 ? '0' + n : String(n);
}
function formatMs(ms) {
var sign = ms < 0 ? '-' : '';
var abs = Math.abs(ms);
var h = Math.floor(abs / 3600000);
var m = Math.floor((abs % 3600000) / 60000);
var s = Math.floor((abs % 60000) / 1000);
// remove the hours if there is nothing to show
if (h === 0) {
return sign + pad(m) + ':' + pad(s);
}
return sign + pad(h) + ':' + pad(m) + ':' + pad(s);
}
function render() {
var text = state.timerCurrent !== null ? formatMs(state.timerCurrent) : '--:--:--';
var hasHours = text.lastIndexOf(':') !== text.indexOf(':');
timerEl.textContent = text;
var phase = state.timerPhase;
var cls = phase === 'warning' || phase === 'danger' || phase === 'overtime' ? phase : '';
if (!hasHours) {
cls = cls ? cls + ' short' : 'short';
}
timerEl.className = cls;
if (state.eventTitle) {
titleEl.textContent = state.eventTitle;
titleEl.style.display = 'block';
} else {
titleEl.style.display = 'none';
}
if (state.timerDuration > 0 && state.timerCurrent !== null) {
var elapsed = state.timerDuration - Math.max(0, state.timerCurrent);
var pct = Math.min(100, Math.max(0, (elapsed / state.timerDuration) * 100));
progressFillEl.style.width = pct + '%';
progressFillEl.style.backgroundColor = phaseColors[phase] || '#ffffff';
progressContainerEl.style.display = 'block';
} else {
progressContainerEl.style.display = 'none';
}
}
function applyPatch(payload) {
if (payload.timer) {
if (payload.timer.current !== undefined) state.timerCurrent = payload.timer.current;
if (payload.timer.duration !== undefined) state.timerDuration = payload.timer.duration;
if (payload.timer.phase !== undefined) state.timerPhase = payload.timer.phase;
}
if ('eventNow' in payload) {
state.eventTitle = payload.eventNow ? payload.eventNow.title : null;
}
}
function resolveConnectionUrl() {
var isSecure = window.location.protocol === 'https:';
var stageHash = '';
var href = window.location.href;
if (href.indexOf('getontime.no') !== -1) {
var hash = href.split('/')[3];
stageHash = '/' + hash;
}
if (isSecure) {
return 'wss://' + window.location.host + stageHash + '/ws';
}
return 'ws://' + window.location.host + stageHash + '/ws';
}
var reconnectDelay = 1000;
function connect() {
var wsUrl = resolveConnectionUrl();
var ws = new WebSocket(wsUrl);
ws.onopen = function () {
reconnectDelay = 1000;
};
ws.onmessage = function (event) {
try {
var msg = JSON.parse(event.data);
if (msg.tag === 'runtime-data') {
applyPatch(msg.payload);
render();
}
} catch (_) {}
};
ws.onclose = function () {
setTimeout(connect, reconnectDelay);
reconnectDelay = Math.min(reconnectDelay * 2, 30000);
};
ws.onerror = function () {
ws.close();
};
}
connect();
</script>
</body>
</html>
-2
View File
@@ -95,8 +95,6 @@ export const srcFiles = {
translationReadme: join(srcDir.root, config.user, config.translations.directory, 'README.md'), translationReadme: join(srcDir.root, config.user, config.translations.directory, 'README.md'),
/** Path to login */ /** Path to login */
login: join(srcDir.root, 'html/login.html'), login: join(srcDir.root, 'html/login.html'),
/** Path to legacy timer for old browsers */
timerLegacy: join(srcDir.root, 'html/timer-legacy.html'),
/** Path to ontime-logo */ /** Path to ontime-logo */
logo: join(srcDir.root, config.user, config.logo, 'ontime-logo.png'), logo: join(srcDir.root, config.user, config.logo, 'ontime-logo.png'),
}; };
+15 -92
View File
@@ -6,129 +6,52 @@ test('cuesheet displays events', async ({ page }) => {
await expect(page.getByTestId('cuesheet-event').first()).toBeVisible(); await expect(page.getByTestId('cuesheet-event').first()).toBeVisible();
}); });
test('cuesheet datagrid does not submit timer cells on tab-out or escape', async ({ page }) => {
await page.goto('/cuesheet');
const firstEvent = page.getByTestId('cuesheet-event').first();
await expect(firstEvent).toBeVisible();
const durationCell = firstEvent.getByTestId('cuesheet-cell-duration');
/**
* 1. Tab out of a timer cell should not submit the typed value
*/
await durationCell.click();
const durationInput = durationCell.locator('input');
await expect(durationInput).toBeVisible();
const originalDuration = await durationInput.inputValue();
await durationInput.fill('01:00:00');
await durationInput.press('Tab');
// cell should exit edit mode without submitting
await expect(durationInput).not.toBeVisible();
// re-enter edit mode: original value should be unchanged
await durationCell.click();
await expect(durationCell.locator('input')).toHaveValue(originalDuration);
await durationCell.locator('input').press('Escape');
/**
* 2. Escape on a timer cell should not submit, should revert to original value
*/
await durationCell.click();
await expect(durationCell.locator('input')).toBeVisible();
await durationCell.locator('input').fill('02:00:00');
await durationCell.locator('input').press('Escape');
// cell should exit edit mode without submitting
await expect(durationCell.locator('input')).not.toBeVisible();
// re-enter edit mode: original value should be unchanged
await durationCell.click();
await expect(durationCell.locator('input')).toHaveValue(originalDuration);
await durationCell.locator('input').press('Escape');
});
test('cuesheet datagrid keeps keyboard focus flow while editing text cells', async ({ page }) => { test('cuesheet datagrid keeps keyboard focus flow while editing text cells', async ({ page }) => {
await page.goto('/cuesheet'); await page.goto('/cuesheet');
const firstEvent = page.getByTestId('cuesheet-event').first(); const firstEvent = page.getByTestId('cuesheet-event').first();
await expect(firstEvent).toBeVisible(); await expect(firstEvent).toBeVisible();
const cueCell = firstEvent.getByTestId('cuesheet-cell-cue');
const titleCell = firstEvent.getByTestId('cuesheet-cell-title');
const noteCell = firstEvent.getByTestId('cuesheet-cell-note');
const cueEditor = firstEvent.getByTestId('cuesheet-editor-cue'); const cueEditor = firstEvent.getByTestId('cuesheet-editor-cue');
const titleEditor = firstEvent.getByTestId('cuesheet-editor-title'); const titleEditor = firstEvent.getByTestId('cuesheet-editor-title');
const noteEditor = firstEvent.getByTestId('cuesheet-editor-note'); const noteEditor = firstEvent.getByTestId('cuesheet-editor-note');
/** /**
* 1. clicking a single line text cell opens the editor (mounted on demand) * 1. focus a cell in the datagrid single line text
* submitting with Enter closes the editor and returns focus to the parent cell * submitting the data returns the focus to the parent
*/ */
await titleCell.click(); await titleEditor.click();
await expect(titleEditor).toBeFocused(); await expect(titleEditor).toBeFocused();
const updatedTitle = `focus-title-${Date.now()}`; const updatedTitle = `focus-title-${Date.now()}`;
await titleEditor.fill(updatedTitle); await titleEditor.fill(updatedTitle);
await titleEditor.press('Enter'); await titleEditor.press('Enter');
await expect(titleEditor).toHaveCount(0); await expect(titleEditor).not.toBeFocused();
await expect(titleCell).toContainText(updatedTitle); await expect(titleEditor).toHaveValue(updatedTitle);
await expect(titleCell).toBeFocused();
/** /**
* 2. navigate to the multiline text cell with the keyboard and open it with Enter * 2. navigate and modify multiline text cell
* submitting works with ctrl/cmd + enter and the focus returns to the parent * submitting works with ctrl/cmd + enter and the focus returns to the parent
*/ */
await page.keyboard.press('ArrowRight'); await page.keyboard.press('ArrowRight');
await expect(noteCell).toBeFocused();
await page.keyboard.press('Enter'); await page.keyboard.press('Enter');
await expect(noteEditor).toBeFocused(); await expect(noteEditor).toBeFocused();
const updatedNote = `focus-note-${Date.now()}`; const updatedNote = `focus-note-${Date.now()}`;
await noteEditor.fill(updatedNote); await noteEditor.fill(updatedNote);
await noteEditor.press('ControlOrMeta+Enter'); await noteEditor.press('ControlOrMeta+Enter');
await expect(noteEditor).toHaveCount(0); await expect(noteEditor).not.toBeFocused();
await expect(noteCell).toContainText(updatedNote); await expect(noteEditor).toHaveValue(updatedNote);
await expect(noteCell).toBeFocused();
/** /**
* 3. navigating back returns focus to the title cell * 2. navigate and modify single line text cell again
* opening the cue cell and pressing escape cancels the edit and reverts the value * pressing escape cancels the edit and the focus returns to the parent
*/ */
await page.keyboard.press('ArrowLeft'); await page.keyboard.press('ArrowLeft');
await expect(titleCell).toBeFocused(); await page.keyboard.press('Enter');
await expect(titleEditor).toBeFocused();
await cueCell.click();
await expect(cueEditor).toBeFocused();
const cueBeforeCancel = await cueEditor.inputValue(); const cueBeforeCancel = await cueEditor.inputValue();
await cueEditor.click();
await cueEditor.fill(`${cueBeforeCancel} temporary`); await cueEditor.fill(`${cueBeforeCancel} temporary`);
await cueEditor.press('Escape'); await cueEditor.press('Escape');
await expect(cueEditor).toHaveCount(0); await expect(cueEditor).not.toBeFocused();
await expect(cueCell).toContainText(cueBeforeCancel); await expect(cueEditor).toHaveValue(cueBeforeCancel);
await expect(cueCell).toBeFocused();
});
test('cuesheet background edit from empty state', async ({ page }) => {
// create an empty rundown
await page.goto('/editor');
await page.getByRole('button', { name: 'Toggle settings' }).click();
await page.getByRole('button', { name: 'Manage rundowns' }).click();
await page.getByRole('button', { name: 'New' }).nth(1).click();
const emptyName = `empty-${Date.now()}`;
await page.getByRole('textbox', { name: 'Rundown title' }).fill(emptyName);
await page.getByRole('button', { name: 'Create rundown' }).click();
// edit it in the cuesheet (scope to the rundown we just created so retries stay isolated)
await page.getByRole('row', { name: emptyName }).getByTestId('rundown_menu').click();
await page.getByText('Edit in cuesheet').click();
// expect to see and empty screen
await expect(page.getByRole('button', { name: 'Create Event' })).toBeVisible();
// create 1 event
await page.getByRole('button', { name: 'Create Event' }).click();
// and expect to find it
await expect(page.getByTestId('cuesheet-event')).toBeVisible();
}); });
+3 -4
View File
@@ -231,10 +231,9 @@ test.describe('Sharing from cuesheet', () => {
// Verify that the title is visible and editable // Verify that the title is visible and editable
await expect(page.getByTestId('cuesheet-event').getByRole('cell', { name: 'title' })).toBeVisible(); await expect(page.getByTestId('cuesheet-event').getByRole('cell', { name: 'title' })).toBeVisible();
// the editor mounts on demand: clicking the cell opens it const titleEditor = page.getByTestId('cuesheet-event').getByTestId('cuesheet-editor-title');
const firstEvent = page.getByTestId('cuesheet-event').first(); await titleEditor.click();
await firstEvent.getByTestId('cuesheet-cell-title').click(); await expect(titleEditor).toBeEditable();
await expect(firstEvent.getByTestId('cuesheet-editor-title')).toBeEditable();
// other elements are not there // other elements are not there
await expect(page.getByRole('cell', { name: 'Duration' })).toBeHidden(); await expect(page.getByRole('cell', { name: 'Duration' })).toBeHidden();
+7 -13
View File
@@ -1,6 +1,6 @@
{ {
"name": "ontime", "name": "ontime",
"version": "4.9.0", "version": "4.7.0",
"description": "Time keeping for live events", "description": "Time keeping for live events",
"keywords": [ "keywords": [
"ontime", "ontime",
@@ -17,7 +17,7 @@
"license": "AGPL-3.0-only", "license": "AGPL-3.0-only",
"engines": { "engines": {
"node": "~22", "node": "~22",
"pnpm": "~11" "pnpm": "~10"
}, },
"type": "module", "type": "module",
"scripts": { "scripts": {
@@ -32,16 +32,16 @@
"dist-win": "turbo run dist-win --filter=ontime-electron", "dist-win": "turbo run dist-win --filter=ontime-electron",
"dist-mac": "turbo run dist-mac --filter=ontime-electron", "dist-mac": "turbo run dist-mac --filter=ontime-electron",
"dist-linux": "turbo run dist-linux --filter=ontime-electron", "dist-linux": "turbo run dist-linux --filter=ontime-electron",
"e2e": "turbo run build --filter=ontime-ui && pnpm clear-temp && cross-env DEBUG=pw:webserver pnpm playwright test -c playwright.config.ts", "e2e": "turbo run build --filter=ontime-ui && pnpm clear-temp && cross-env DEBUG=pw:webserver npx playwright test -c playwright.config.ts",
"e2e:ui": "cross-env NODE_ENV=development cross-env DEBUG=pw:webserver pnpm playwright test --ui -c playwright.config.ts", "e2e:ui": "cross-env NODE_ENV=development cross-env DEBUG=pw:webserver npx playwright test --ui -c playwright.config.ts",
"e2e:i": "pnpm playwright codegen", "e2e:i": "npx playwright codegen",
"clear-temp": "rimraf e2e/tests/fixtures/tmp", "clear-temp": "rimraf e2e/tests/fixtures/tmp",
"test": "turbo run test:pipeline", "test": "turbo run test:pipeline",
"format": "oxfmt", "format": "oxfmt",
"format:check": "oxfmt --check" "format:check": "oxfmt --check"
}, },
"devDependencies": { "devDependencies": {
"@playwright/test": "1.60.0", "@playwright/test": "^1.58.2",
"@types/node": "catalog:", "@types/node": "catalog:",
"cross-env": "^7.0.3", "cross-env": "^7.0.3",
"oxfmt": "^0.42.0", "oxfmt": "^0.42.0",
@@ -51,11 +51,5 @@
"turbo": "2.8.20", "turbo": "2.8.20",
"typescript": "catalog:" "typescript": "catalog:"
}, },
"packageManager": "pnpm@11.1.2+sha512.415a1cc25974731e75455c1468371be74c5aa5fb7621b50d4056d222451609f11412f23fd602e6169f1e060466641f798597e1be961a10688836a67b16569499", "packageManager": "pnpm@10.33.0+sha512.10568bb4a6afb58c9eb3630da90cc9516417abebd3fabbe6739f0ae795728da1491e9db5a544c76ad8eb7570f5c4bb3d6c637b2cb41bfdcdb47fa823c8649319"
"devEngines": {
"runtime": {
"name": "node",
"version": "22.22.2"
}
}
} }
+1 -1
View File
@@ -1,5 +1,5 @@
{ {
"version": "4.9.0", "version": "4.7.0",
"name": "ontime-types", "name": "ontime-types",
"type": "module", "type": "module",
"main": "./src/index.ts", "main": "./src/index.ts",
@@ -41,7 +41,6 @@ type RefetchPacket = {
payload: { payload: {
target: RefetchKey; target: RefetchKey;
revision: MaybeNumber; revision: MaybeNumber;
rundownId?: string; // undefined means refetch all rundowns
}; };
}; };
@@ -2,7 +2,6 @@ export enum RefetchKey {
All = 'all', All = 'all',
CustomFields = 'custom-fields', CustomFields = 'custom-fields',
ProjectData = 'project-data', ProjectData = 'project-data',
ProjectRundowns = 'project-rundowns',
Report = 'report', Report = 'report',
Rundown = 'rundown', Rundown = 'rundown',
UrlPresets = 'url-presets', UrlPresets = 'url-presets',
+527 -1320
View File
File diff suppressed because it is too large Load Diff
+5 -7
View File
@@ -9,10 +9,8 @@ catalog:
typescript: 6.0.2 typescript: 6.0.2
vitest: 4.0.17 vitest: 4.0.17
allowBuilds: onlyBuiltDependencies:
'@parcel/watcher': true - electron
'@sentry/cli': false - esbuild
core-js: false
electron: true useNodeVersion: 22.22.2
electron-winstaller: false
esbuild: true