- Revert the automation action labels back to "Aux N: action" (no
functional reason to change this wording).
- Simplify the aux timers header in the playback control: the flex
container now only handles layout, and the label text reuses the
same font-size/color as the per-timer labels below it, instead of a
bespoke style block duplicating those values.
- Replace the generic, length-driven normaliser with an explicit
sanitiseAuxTimerNames() that always deals with exactly three timers,
and rename it away from "normalise" (which didn't convey that it
trims, caps length and fills in missing entries). Static defaults
now use a plain ['', '', ''] literal instead of calling the
sanitiser with no input to sanitise.
- Settings.type.ts and AuxTimerSettings.tsx no longer generate their
three fields from a loop; the form mirrors the same explicit,
one-field-per-row style already used by GeneralSettings.tsx.
- Trim comments that only restated what the following line already
says, keeping the ones that explain non-obvious behaviour (why
AuxTimerService needs to be resynced separately from the data
provider, why SimpleTimer.reset() preserves the name).
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WCZejVTzuAY3tHTE6nB3JH
Addresses the review findings on the aux timer naming feature.
- Aux timer names are project data, but they were only applied at
bootstrap and on a settings POST. Loading another project left the
previous project's names in the runtime store, so the controls and
views disagreed with the settings panel until a restart. The names are
now applied when a project is loaded, and patching the current project
settings applies them and sends a settings refetch to the clients
(loading a project already triggers a full refetch via the rundown).
- Consolidate the name handling into a single normaliser in ontime-utils,
used by the project file parser, the API validation and to build the
default value. This creates the property when importing project files
saved before the feature existed, and enforces the name length limit
server side rather than only in the form.
- loadNames normalises its input, so the runtime state is consistent
regardless of the shape of the stored settings.
- Clarify that auxTimerNames is ordered (index 0 is aux timer 1), and
derive the settings form from the shared aux timer count.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WCZejVTzuAY3tHTE6nB3JH
Addresses review feedback on the aux timer naming feature:
- Automation action labels now reference the timers by index
("Aux timer 1: start") rather than the custom names, keeping the
automation config stable regardless of naming.
- Expose the custom names through the consumer-facing runtime interface:
the aux timer objects broadcast over the websocket now carry a `name`
field. Names are seeded from the persisted settings at bootstrap and
kept in sync whenever the settings change, so every consumer (views and
integrations) reads them from the same runtime data.
- The client control and view consumers now read the name from the
runtime store instead of querying settings directly; the settings form
remains the persisted editing source.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WCZejVTzuAY3tHTE6nB3JH
* chore: migrate eslint to oxlint
* chore: migrate prettier to oxfmt
* chore: migrate typescript
* chore: toThrow should have a expected value
* chore: cast test value as Day
* chore: small title fix
* chore: mocks should be hoisted
* chore: incorrect async useage
* chore: test should be inside description
* chore: test sohuld include an expeced
* chore: oxfmt
---------
Co-authored-by: alex-Arc <omnivox@LAPTOP-RC5SNBVV.localdomain>
Claude
Carlos Valente
Carlos Valente
Alex Christoffer Rasmussen