diff --git a/packages/utils/index.ts b/packages/utils/index.ts index 46f1b6c96..7c6cff0ce 100644 --- a/packages/utils/index.ts +++ b/packages/utils/index.ts @@ -36,8 +36,6 @@ export { MILLIS_PER_HOUR, MILLIS_PER_MINUTE, MILLIS_PER_SECOND, - millisToHours, - millisToMinutes, millisToSeconds, secondsInMillis, } from './src/date-utils/conversionUtils.js'; diff --git a/packages/utils/src/date-utils/conversionUtils.test.ts b/packages/utils/src/date-utils/conversionUtils.test.ts index 5cf99c11d..4ee5ab2d3 100644 --- a/packages/utils/src/date-utils/conversionUtils.test.ts +++ b/packages/utils/src/date-utils/conversionUtils.test.ts @@ -1,4 +1,4 @@ -import { millisToHours, millisToMinutes, millisToSeconds, secondsInMillis } from './conversionUtils'; +import { millisToSeconds, secondsInMillis } from './conversionUtils'; describe('millisToSecond()', () => { test('null values', () => { @@ -37,82 +37,6 @@ describe('millisToSecond()', () => { }); }); -describe('millisToMinutes()', () => { - test('null values', () => { - const t = { val: null, result: 0 }; - expect(millisToMinutes(t.val)).toBe(t.result); - }); - - test('valid millis', () => { - const t = { val: 3600000, result: 60 }; - expect(millisToMinutes(t.val)).toBe(t.result); - }); - - test('negative millis', () => { - const t = { val: -3600000, result: -60 }; - expect(millisToMinutes(t.val)).toBe(t.result); - }); - - test('0', () => { - const t = { val: 0, result: 0 }; - expect(millisToMinutes(t.val)).toBe(t.result); - }); - - test('-0', () => { - const t = { val: -0, result: 0 }; - expect(millisToMinutes(t.val)).toBe(t.result); - }); - - test('86401000 (24 hours and 1 second)', () => { - const t = { val: 86401000, result: 1440 }; - expect(millisToMinutes(t.val)).toBe(t.result); - }); - - test('-86401000 (-24 hours and 1 second)', () => { - // negative numbers are rounded up - const t = { val: -86401000, result: -1441 }; - expect(millisToMinutes(t.val)).toBe(t.result); - }); -}); - -describe('millisToHours()', () => { - test('null values', () => { - const t = { val: null, result: 0 }; - expect(millisToHours(t.val)).toBe(t.result); - }); - - test('valid millis', () => { - const t = { val: 3600000, result: 1 }; - expect(millisToHours(t.val)).toBe(t.result); - }); - - test('negative millis', () => { - const t = { val: -3600000, result: -1 }; - expect(millisToHours(t.val)).toBe(t.result); - }); - - test('0', () => { - const t = { val: 0, result: 0 }; - expect(millisToHours(t.val)).toBe(t.result); - }); - - test('-0', () => { - const t = { val: -0, result: 0 }; - expect(millisToHours(t.val)).toBe(t.result); - }); - - test('86401000 (24 hours and 1 second)', () => { - const t = { val: 86401000, result: 24 }; - expect(millisToHours(t.val)).toBe(t.result); - }); - - test('-86401000 (-24 hours and 1 second)', () => { - // negative numbers are rounded up - const t = { val: -86401000, result: -25 }; - expect(millisToHours(t.val)).toBe(t.result); - }); -}); - describe('secondsInMillis()', () => { it('return 0 if value is null', () => { expect(secondsInMillis(null)).toBe(0); diff --git a/packages/utils/src/date-utils/conversionUtils.ts b/packages/utils/src/date-utils/conversionUtils.ts index 3f2d56868..c9c0714bc 100644 --- a/packages/utils/src/date-utils/conversionUtils.ts +++ b/packages/utils/src/date-utils/conversionUtils.ts @@ -8,19 +8,6 @@ export const MILLIS_PER_HOUR = 1000 * 60 * 60; export const dayInMs = 86400000; export const maxDuration = dayInMs - MILLIS_PER_SECOND; -/** - * Utility converts milliseconds to a specific unit - * @param millis - * @param conversion - * @returns - */ -function convertMillis(millis: MaybeNumber, conversion: number): number { - if (!millis) { - return 0; - } - return Math.floor(millis / conversion); -} - /** * Converts value in milliseconds to seconds * @param millis @@ -44,24 +31,6 @@ export function millisToSeconds( throw new Error('?????'); } -/** - * Converts value in milliseconds to minutes - * @param millis - * @returns - */ -export function millisToMinutes(millis: MaybeNumber): number { - return convertMillis(millis, MILLIS_PER_MINUTE); -} - -/** - * Converts value in milliseconds to hours - * @param millis - * @returns - */ -export function millisToHours(millis: MaybeNumber): number { - return convertMillis(millis, MILLIS_PER_HOUR); -} - /** * Converts value in seconds to minutes * @param seconds