cpvalente/ontime
1
0
Fork 0
mirror of https://github.com/cpvalente/ontime.git synced 2026-08-22 15:39:11 +00:00
Code Issues Packages Projects Releases 10 Wiki Activity

refactor: improve sheet import UX

Browse Source
This commit is contained in:
Carlos Valente
2026-03-23 19:26:03 +01:00
committed by Carlos Valente
parent 42dcf35f45
commit f53cb687bf
39 changed files with 1739 additions and 910 deletions
Download Patch File Download Diff File Expand all files Collapse all files
e2e/tests/features/301-spreadsheet-import.spec.ts
+71 -18
View File
@@ -1,41 +1,94 @@
import { expect, test } from '@playwright/test';
import { expect, test, type Page } from '@playwright/test';
const fileToUpload = 'e2e/tests/fixtures/test-sheet.xlsx';
const fileToUpload = 'e2e/tests/fixtures/Ontime rundown template v4.xlsx';
test('sheet file upload', async ({ page }) => {
test('imports spreadsheet and applies imported rundown to editor', async ({ page }) => {
await page.goto('/editor');
await page.getByRole('button', { name: 'Edit' }).click();
// clear the rundown
await page.getByRole('button', { name: 'Rundown menu' }).click();
await page.getByRole('menuitem', { name: 'Clear all' }).click();
await page.getByRole('button', { name: 'Delete all' }).click();
await expect(page.getByTestId('rundown-event')).toHaveCount(0);
// open the spreadsheet
await page.getByRole('button', { name: 'Toggle settings' }).click();
await page.getByRole('button', { name: 'Import spreadsheet' }).click();
await page.getByRole('button', { name: 'Project settings' }).click();
await page.getByRole('button', { name: 'Import spreadsheet' }).first().click();
await expect(page.getByText('Synchronise your rundown with an external source')).toBeVisible();
// workaround to upload file on hidden input
// https://playwright.dev/docs/api/class-filechooser
// upload the spreadsheet
const fileChooserPromise = page.waitForEvent('filechooser');
await page.getByRole('button', { name: 'Import from spreadsheet', exact: true }).click();
const fileChooser = await fileChooserPromise;
await fileChooser.setFiles(fileToUpload);
const worksheetSelect = page.getByRole('combobox', { name: 'Worksheet', exact: true });
await expect(worksheetSelect).toBeVisible();
await worksheetSelect.click();
await page.getByRole('option', { name: 'Event schedule advanced' }).click();
await expect(worksheetSelect).toContainText('Event schedule advanced');
await page.getByRole('row', { name: 'Worksheet' }).getByRole('combobox').click();
await page.getByRole('option', { name: 'test' }).click();
await page.getByRole('button', { name: 'Import preview' }).click();
await page.getByRole('button', { name: 'Apply' }).click();
// apply import
await page.getByRole('button', { name: 'Preview import' }).click();
await page.getByRole('button', { name: 'Apply import' }).click();
await expect(page.getByText('Import successful')).toBeVisible();
await page.getByRole('button', { name: 'Return' }).click();
// verify the data in the rundown
await page.getByRole('button', { name: 'Close settings' }).scrollIntoViewIfNeeded();
await page.getByRole('button', { name: 'Close settings' }).click();
// asset test events
const firstTitle = page.getByTestId('entry-1').getByTestId('entry__title');
await expect(firstTitle).toHaveValue('Attempt light check');
await expectGroupSummary(page, {
title: 'Morning Sessions',
entries: '5',
start: '10:00:00',
end: '12:00:00',
duration: '2h',
});
await expectGroupSummary(page, {
title: 'Lunch',
entries: '1',
start: '12:00:00',
end: '13:00:00',
duration: '1h',
});
await expectGroupSummary(page, {
title: 'Afternoon Sessions',
entries: '4',
start: '13:00:00',
end: '14:00:00',
duration: '1h',
});
const secondTitle = page.getByTestId('entry-2').getByTestId('entry__title');
await expect(secondTitle).toHaveValue('Preset');
await expectInputValue(page, 'Lunch / Countdown to next session');
const thirdTitle = page.getByTestId('entry-3').getByTestId('entry__title');
await expect(thirdTitle).toHaveValue('Albania');
await expectInputValue(page, '11:30 - House staff setup lunch in lobby');
});
async function expectGroupSummary(
page: Page,
{
title,
entries,
start,
end,
duration,
}: { title: string; entries: string; start: string; end: string; duration: string },
) {
const group = page.getByTestId('rundown-group').filter({ has: page.locator(`input[value="${title}"]`) });
await expect(group).toHaveCount(1);
await expect(group).toContainText('Entries');
await expect(group).toContainText(entries);
await expect(group).toContainText('Start');
await expect(group).toContainText(start);
await expect(group).toContainText('End');
await expect(group).toContainText(end);
await expect(group).toContainText('Duration');
await expect(group).toContainText(duration);
}
async function expectInputValue(page: Page, value: string) {
await expect(page.locator(`input[value="${value}"]`)).toHaveCount(1);
}