Small clean-up (#1815)

* chore: remove old comment

* chore: smal lclean up of a e2e test

* chore: bump to beta.6

* chore: cleanup imports

* fix integration values com in ms

* allow linkStart and timeStrategy from API

* remove local mac dist

e2e/tests/001-smoke-tests.spec.ts

@@ -1,11 +1,10 @@
 import { expect, test } from '@playwright/test';
 
-// TODO: can we replace the clicks with something else?
 test.describe('pages routes are available', () => {
   test.use({ viewport: { width: 1920, height: 1080 } });
   test.describe('main views', () => {
     test('editor', async ({ page }) => {
-      await page.goto('http://localhost:4001/editor');
+      await page.goto('/editor');
 
       await expect(page).toHaveTitle(/ontime/);
       await expect(page.getByTestId('editor-container')).toBeVisible();
@@ -15,44 +14,41 @@ test.describe('pages routes are available', () => {
     });
 
     test('cuesheet', async ({ page }) => {
-      await page.goto('http://localhost:4001/cuesheet');
+      await page.goto('/cuesheet');
 
       await expect(page).toHaveTitle(/ontime/);
-      await page.getByTestId('cuesheet').click();
+      await expect(page.getByTestId('cuesheet')).toBeVisible();
     });
 
     test('operator', async ({ page }) => {
-      await page.goto('http://localhost:4001/op');
+      await page.goto('/op');
 
       await expect(page).toHaveTitle(/ontime/);
     });
 
     test('timer', async ({ page }) => {
-      await page.goto('http://localhost:4001/timer');
+      await page.goto('/timer');
 
       await expect(page).toHaveTitle(/ontime/);
     });
 
     test('backstage', async ({ page }) => {
-      await page.goto('http://localhost:4001/backstage');
+      await page.goto('/backstage');
 
       await expect(page).toHaveTitle(/ontime/);
     });
 
     test('studio', async ({ page }) => {
-      await page.goto('http://localhost:4001/studio');
+      await page.goto('/studio');
 
       await expect(page).toHaveTitle(/ontime/);
     });
 
     test('countdown', async ({ page }) => {
-      await page.goto('http://localhost:4001/countdown');
+      await page.goto('/countdown?sub=32d31');
 
       await expect(page).toHaveTitle(/ontime/);
 
-      await page.getByRole('button', { name: 'Add' }).click();
-      await page.getByText('Albania').click();
-      await page.getByRole('button', { name: 'Save' }).click();
       await expect(page.getByText('Albania')).toBeVisible();
       await expect(page.getByText('Latvia')).toBeHidden();
     });
@@ -60,15 +56,15 @@ test.describe('pages routes are available', () => {
 
   test.describe('detached views', () => {
     test('rundown', async ({ page }) => {
-      await page.goto('http://localhost:4001/rundown');
+      await page.goto('/rundown');
       await expect(page.getByTestId('panel-rundown')).toBeVisible();
     });
     test('timer control', async ({ page }) => {
-      await page.goto('http://localhost:4001/timercontrol');
+      await page.goto('/timercontrol');
       await expect(page.getByTestId('panel-timer-control')).toBeVisible();
     });
     test('message control', async ({ page }) => {
-      await page.goto('http://localhost:4001/messagecontrol');
+      await page.goto('/messagecontrol');
       await expect(page.getByTestId('panel-messages-control')).toBeVisible();
     });
   });

e2e/tests/features/205-operator.spec.ts

@@ -62,9 +62,4 @@ test('smoke test operator', async ({ page }) => {
   await expect(page.getByTestId('--1')).toHaveCSS('opacity', '1'); // BUG: ensure event doesn't inherit the past state of the group
   await expect(page.getByText('title 2')).toBeInViewport();
   await expect(page.getByText('title 3')).toBeInViewport();
-
-  // TODO: this part seems particularly flaky, to revise
-  // await expect(page.getByText('00:01 - 00:02')).toBeInViewport();
-  // await expect(page.getByText('00:02 - 00:03')).toBeInViewport();
-  // await expect(page.getByText('00:03 - 00:04')).toBeInViewport();
 });

e2e/tests/features/211-report-data.spec.ts

@@ -1,7 +1,5 @@
 import { expect, test } from '@playwright/test';
 
-//TODO:
-
 test('show warning when event crosses midnight', async ({ page }) => {
   await page.goto('http://localhost:4001/editor');
 

e2e/tests/features/212-time-until.spec.ts

@@ -1,4 +1,4 @@
-import { expect, Locator, Page, test } from '@playwright/test';
+import { expect, Locator, test } from '@playwright/test';
 
 test('time until absolute', async ({ context }) => {
   const editor = await context.newPage();