diff --git a/apps/server/src/services/TimerService.ts b/apps/server/src/services/TimerService.ts index 43fb96a13..cd941c703 100644 --- a/apps/server/src/services/TimerService.ts +++ b/apps/server/src/services/TimerService.ts @@ -48,7 +48,6 @@ export class TimerService { this.onUpdateCallback = timerConfig.onUpdateCallback; this._interval = setInterval(() => { this.update(); - this.onUpdateCallback; }, TimerService._updateInterval); } diff --git a/apps/server/src/services/integration-service/HttpIntegration.ts b/apps/server/src/services/integration-service/HttpIntegration.ts index 4af1437f0..67f439d49 100644 --- a/apps/server/src/services/integration-service/HttpIntegration.ts +++ b/apps/server/src/services/integration-service/HttpIntegration.ts @@ -60,7 +60,9 @@ export class HttpIntegration implements IIntegration { }); } - shutdown() {} + shutdown() { + /** shutdown is a no-op here*/ + } } export const httpIntegration = new HttpIntegration(); diff --git a/apps/server/src/services/integration-service/IntegrationService.ts b/apps/server/src/services/integration-service/IntegrationService.ts index d59ba76e9..0016edd76 100644 --- a/apps/server/src/services/integration-service/IntegrationService.ts +++ b/apps/server/src/services/integration-service/IntegrationService.ts @@ -27,7 +27,7 @@ class IntegrationService { } shutdown() { - logger.info(LogOrigin.Tx, `Shutdown Integrations`); + logger.info(LogOrigin.Tx, 'Shutdown Integrations'); this.integrations.forEach((integration) => { integration.shutdown(); }); diff --git a/apps/server/src/services/integration-service/integrationUtils.ts b/apps/server/src/services/integration-service/integrationUtils.ts index 191884c73..5b39c9cc0 100644 --- a/apps/server/src/services/integration-service/integrationUtils.ts +++ b/apps/server/src/services/integration-service/integrationUtils.ts @@ -62,9 +62,9 @@ export function parseTemplateNested(template: string, state: object, humanReadab } } else { // iterate through variable parts, and look for the property in the state object - value = variableParts.reduce((obj, key) => obj && obj[key], state); + value = variableParts.reduce((obj, key) => obj?.[key], state); } - if (typeof value !== 'undefined') { + if (value !== undefined) { parsedTemplate = parsedTemplate.replace(match[0], value); } }