cpvalente/ontime
1
0
Fork 0
mirror of https://github.com/cpvalente/ontime.git synced 2026-08-20 06:29:07 +00:00
Code Issues Packages Projects Releases 10 Wiki Activity

fix: group end elements should only send timertype data nothing else

Browse Source
This commit is contained in:
arc-alex
2025-09-17 13:16:46 +02:00
committed by Carlos Valente
parent 02cddeec4d
commit d2638d64e4
1 changed files with 11 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/server/src/services/sheet-service/sheetUtils.ts
+11 -6
View File
@@ -154,12 +154,6 @@ function getCellData(key: OntimeEntryCommonKeys | 'blank', entry: OntimeEntry) {
return {}; return {};
} }
// we need to flatten the milestones
if (key.startsWith('custom')) {
const customKey = key.split(':')[1];
return { userEnteredValue: { stringValue: entry.custom[customKey] } };
}
// we need to remap the event type to timer type in the case of groups and milestones // we need to remap the event type to timer type in the case of groups and milestones
if (key === 'timerType') { if (key === 'timerType') {
if (isOntimeGroup(entry)) if (isOntimeGroup(entry))
@@ -168,6 +162,17 @@ function getCellData(key: OntimeEntryCommonKeys | 'blank', entry: OntimeEntry) {
return { userEnteredValue: { stringValue: entry.timerType } }; return { userEnteredValue: { stringValue: entry.timerType } };
} }
// all other data is not relevant for the group end entry
if (entry.id.startsWith('group-end')) {
return {};
}
// we need to flatten the milestones
if (key.startsWith('custom')) {
const customKey = key.split(':')[1];
return { userEnteredValue: { stringValue: entry.custom[customKey] } };
}
// typescript cannot guarantee that the key exists for every entry // typescript cannot guarantee that the key exists for every entry
// so we check for the key existence and assert the type // so we check for the key existence and assert the type
if (!(key in entry)) return {}; if (!(key in entry)) return {};