cpvalente/ontime
1
0
Fork 0
mirror of https://github.com/cpvalente/ontime.git synced 2026-08-17 21:24:11 +00:00
Code Issues Packages Projects Releases 10 Wiki Activity

refactor: unify time constants

Browse Source
This commit is contained in:
Carlos Valente
2024-05-19 13:19:04 +02:00
committed by Carlos Valente
parent 119e6caca3
commit d05cc88748
7 changed files with 20 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/utils/src/date-utils/conversionUtils.ts
+3
View File
@@ -4,6 +4,9 @@ export const MILLIS_PER_SECOND = 1000;
export const MILLIS_PER_MINUTE = 1000 * 60;
export const MILLIS_PER_HOUR = 1000 * 60 * 60;
export const dayInMs = 86400000;
export const maxDuration = dayInMs - MILLIS_PER_SECOND;
function convertMillis(millis: MaybeNumber, conversion: number) {
if (!millis) {
return 0;
packages/utils/src/date-utils/timeFormatting.test.ts
+1 -2
View File
@@ -1,5 +1,4 @@
import { dayInMs } from '../timeConstants';
import { MILLIS_PER_HOUR } from './conversionUtils';
import { dayInMs, MILLIS_PER_HOUR } from './conversionUtils';
import { formatFromMillis, millisToString, removeLeadingZero } from './timeFormatting';
describe('millisToString()', () => {
packages/utils/src/timeConstants.ts
-9
View File
@@ -1,9 +0,0 @@
/**
* Milliseconds in a second
*/
export const mts = 1000;
/**
* Milliseconds in a day
*/
export const dayInMs = 86400000;
packages/utils/src/validate-times/validateTimes.test.ts
+1 -1
View File
@@ -1,7 +1,7 @@
import type { OntimeEvent } from 'ontime-types';
import { TimeStrategy } from 'ontime-types';
import { dayInMs } from '../timeConstants';
import { dayInMs } from '../date-utils/conversionUtils';
import { calculateDuration, getLinkedTimes, validateTimes } from './validateTimes';
describe('validateTimes()', () => {
packages/utils/src/validate-times/validateTimes.ts
+1 -1
View File
@@ -1,7 +1,7 @@
import type { OntimeEvent } from 'ontime-types';
import { TimeStrategy } from 'ontime-types';
import { dayInMs } from '../timeConstants.js';
import { dayInMs } from '../date-utils/conversionUtils.js';
import { validateTimeStrategy } from '../validate-events/validateEvent.js';
export function getLinkedTimes(