refactor: unify time constants

packages/utils/index.ts

@@ -26,8 +26,9 @@ export {
   swapEventData,
 } from './src/rundown-utils/rundownUtils.js';
 
-// format utils
+// time format utils
 export {
+  dayInMs,
   MILLIS_PER_HOUR,
   MILLIS_PER_MINUTE,
   MILLIS_PER_SECOND,
@@ -46,9 +47,6 @@ export {
 export { isAlphanumeric } from './src/regex-utils/isAlphanumeric.js';
 export { isColourHex } from './src/regex-utils/isColourHex.js';
 
-// time utils
-export { dayInMs, mts } from './src/timeConstants.js';
-
 // helpers from externals
 export { deepmerge } from './src/externals/deepmerge.js';
 

packages/utils/src/date-utils/conversionUtils.ts

@@ -4,6 +4,9 @@ export const MILLIS_PER_SECOND = 1000;
 export const MILLIS_PER_MINUTE = 1000 * 60;
 export const MILLIS_PER_HOUR = 1000 * 60 * 60;
 
+export const dayInMs = 86400000;
+export const maxDuration = dayInMs - MILLIS_PER_SECOND;
+
 function convertMillis(millis: MaybeNumber, conversion: number) {
   if (!millis) {
     return 0;

packages/utils/src/date-utils/timeFormatting.test.ts

@@ -1,5 +1,4 @@
-import { dayInMs } from '../timeConstants';
-import { MILLIS_PER_HOUR } from './conversionUtils';
+import { dayInMs, MILLIS_PER_HOUR } from './conversionUtils';
 import { formatFromMillis, millisToString, removeLeadingZero } from './timeFormatting';
 
 describe('millisToString()', () => {

packages/utils/src/timeConstants.ts

@@ -1,9 +0,0 @@
-/**
- * Milliseconds in a second
- */
-export const mts = 1000;
-
-/**
- * Milliseconds in a day
- */
-export const dayInMs = 86400000;

packages/utils/src/validate-times/validateTimes.test.ts

@@ -1,7 +1,7 @@
 import type { OntimeEvent } from 'ontime-types';
 import { TimeStrategy } from 'ontime-types';
 
-import { dayInMs } from '../timeConstants';
+import { dayInMs } from '../date-utils/conversionUtils';
 import { calculateDuration, getLinkedTimes, validateTimes } from './validateTimes';
 
 describe('validateTimes()', () => {

packages/utils/src/validate-times/validateTimes.ts

@@ -1,7 +1,7 @@
 import type { OntimeEvent } from 'ontime-types';
 import { TimeStrategy } from 'ontime-types';
 
-import { dayInMs } from '../timeConstants.js';
+import { dayInMs } from '../date-utils/conversionUtils.js';
 import { validateTimeStrategy } from '../validate-events/validateEvent.js';
 
 export function getLinkedTimes(