cpvalente/ontime
1
0
Fork 0
mirror of https://github.com/cpvalente/ontime.git synced 2026-09-01 20:39:18 +00:00
Code Issues Packages Projects Releases 10 Wiki Activity

remove storedViewParams from the dep array (#606)

Browse Source
This commit is contained in:
asharonbaltazar
2023-11-20 18:41:41 -05:00
committed by GitHub
parent a79ae7e0c4
commit c4886a617c
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/client/src/common/components/view-params-editor/ViewParamsEditor.tsx
+3 -3
View File
@@ -59,10 +59,10 @@ export default function ViewParamsEditor({ paramFields }: EditFormDrawerProps) {
setSearchParams(defaultSearchParams); setSearchParams(defaultSearchParams);
} }
// linter is asking for `setSearchParams` in the useEffect deps // linter is asking for `setSearchParams` & `storedViewParams` in the useEffect deps
// rule is disabled since adding `setSearchParams` results in unnecessary re-renders // rule is disabled since adding `setSearchParams` & `storedViewParams` results in unnecessary re-renders
// eslint-disable-next-line react-hooks/exhaustive-deps // eslint-disable-next-line react-hooks/exhaustive-deps
}, [storedViewParams, pathname]); }, [pathname]);
const onEditDrawerClose = () => { const onEditDrawerClose = () => {
onClose(); onClose();