Refactor/socket controller (#212)

* refactor(socket): dictionary cleanup
* refactor(socket): detangle socket from EventTimer
* refactor(socket): poll object
* refactor(socket): wip, extract data responsibilities to provider
* fix: issue with onAir
* refactor: create data provider and validation utils
* refactor: remove deprecated endpoint
* refactor: detangle and validate ontime controller
* refactor: detangle and validate events controller
* refactor: validate routers
* refactor: handle post failure in modals

server/src/routes/eventRouter.js

@@ -3,9 +3,10 @@ export const router = express.Router();
 
 // import event controller
 import { getEvent, postEvent } from '../controllers/eventController.js';
+import { eventSanitizer } from '../controllers/eventController.validate.js';
 
 // create route between controller and 'GET /event' endpoint
 router.get('/', getEvent);
 
 // create route between controller and 'POST /event' endpoint
-router.post('/', postEvent);
+router.post('/', eventSanitizer, postEvent);

server/src/routes/eventsRouter.js

@@ -13,6 +13,10 @@ import {
   eventsDeleteAll,
   eventsDelete,
 } from '../controllers/eventsController.js';
+import {
+  eventsPutValidator,
+  paramsMustHaveEventId,
+} from '../controllers/eventsController.validate.js';
 
 // create route between controller and '/events/' endpoint
 router.get('/', eventsGetAll);
@@ -24,7 +28,7 @@ router.get('/:eventId', eventsGetById);
 router.post('/', eventsPost);
 
 // create route between controller and '/events/' endpoint
-router.put('/', eventsPut);
+router.put('/', eventsPutValidator, eventsPut);
 
 // create route between controller and '/events/' endpoint
 // DEPRECATED
@@ -34,10 +38,10 @@ router.patch('/', eventsPatch);
 router.patch('/reorder/', eventsReorder);
 
 // create route between controller and '/events/applydelay/:eventId' endpoint
-router.patch('/applydelay/:eventId', eventsApplyDelay);
+router.patch('/applydelay/:eventId', paramsMustHaveEventId, eventsApplyDelay);
 
 // create route between controller and '/events/all' endpoint
 router.delete('/all', eventsDeleteAll);
 
 // create route between controller and '/events/:eventId' endpoint
-router.delete('/:eventId', eventsDelete);
+router.delete('/:eventId', paramsMustHaveEventId, eventsDelete);

server/src/routes/ontimeRouter.js

@@ -12,14 +12,19 @@ import {
   getViewSettings,
   poll,
   postAliases,
-  postInfo,
   postOSC,
   postSettings,
   postUserFields,
   postViewSettings,
 } from '../controllers/ontimeController.js';
 
-import { viewValidator } from '../validation/ontimeValidator.js';
+import {
+  viewValidator,
+  validateAliases,
+  validateUserFields,
+  validateSettings,
+  validateOSC,
+} from '../controllers/ontimeController.validate.js';
 
 export const router = express.Router();
 
@@ -36,7 +41,7 @@ router.post('/db', uploadFile, dbUpload);
 router.get('/settings', getSettings);
 
 // create route between controller and '/ontime/settings' endpoint
-router.post('/settings', postSettings);
+router.post('/settings', validateSettings, postSettings);
 
 // create route between controller and '/ontime/views' endpoint
 router.get('/views', getViewSettings);
@@ -48,25 +53,22 @@ router.post('/views', viewValidator, postViewSettings);
 router.get('/aliases', getAliases);
 
 // create route between controller and '/ontime/aliases' endpoint
-router.post('/aliases', postAliases);
+router.post('/aliases', validateAliases, postAliases);
 
 // create route between controller and '/ontime/aliases' endpoint
 router.get('/userfields', getUserFields);
 
 // create route between controller and '/ontime/aliases' endpoint
-router.post('/userfields', postUserFields);
+router.post('/userfields', validateUserFields, postUserFields);
 
 // create route between controller and '/ontime/info' endpoint
 router.get('/info', getInfo);
 
-// create route between controller and '/ontime/info' endpoint
-router.post('/info', postInfo);
-
 // create route between controller and '/ontime/osc' endpoint
 router.get('/osc', getOSC);
 
 // create route between controller and '/ontime/osc' endpoint
-router.post('/osc', postOSC);
+router.post('/osc', validateOSC, postOSC);
 
 // create route between controller and '/ontime/dbpath' endpoint
 router.post('/dbpath', dbPathToUpload);