From bf3d426649a75ce6ad00718e052926c38258723d Mon Sep 17 00:00:00 2001 From: arc-alex Date: Sat, 10 May 2025 20:17:05 +0200 Subject: [PATCH] cleanup: millisToSeconds --- packages/utils/src/date-utils/conversionUtils.ts | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/packages/utils/src/date-utils/conversionUtils.ts b/packages/utils/src/date-utils/conversionUtils.ts index c9c0714bc..d1fd6808f 100644 --- a/packages/utils/src/date-utils/conversionUtils.ts +++ b/packages/utils/src/date-utils/conversionUtils.ts @@ -19,16 +19,17 @@ export function millisToSeconds( ) { if (millis === null) return 0; + let seconds = 0; if (direction === TimerType.CountDown) { - // 0 + is there to avoid result giving -0 - return 0 + Math.ceil(millis / MILLIS_PER_SECOND); + seconds = Math.ceil(millis / MILLIS_PER_SECOND); } if (direction === TimerType.CountUp) { - return Math.floor(millis / MILLIS_PER_SECOND); + seconds = Math.floor(millis / MILLIS_PER_SECOND); } - throw new Error('?????'); + // this is there to avoid result giving -0 + return seconds === 0 ? 0 : seconds; } /**