cpvalente/ontime
1
0
Fork 0
mirror of https://github.com/cpvalente/ontime.git synced 2026-08-21 15:09:10 +00:00
Code Issues Packages Projects Releases 10 Wiki Activity

fix: insert into group

Browse Source
This commit is contained in:
Carlos Valente
2025-08-05 18:46:00 +02:00
committed by Carlos Valente
parent ad9db4edd3
commit b4aaa8966f
1 changed files with 14 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/client/src/features/rundown/Rundown.tsx
+14 -4
View File
@@ -489,8 +489,17 @@ export default function Rundown({ data }: RundownProps) {
const isFirst = index === 0; const isFirst = index === 0;
const isLast = entryId === order.at(-1); const isLast = entryId === order.at(-1);
// avoid a group referencing itself as the parent
const parentId = rundownMetadata.thisId !== rundownMetadata.groupId ? rundownMetadata.groupId : null; /**
* We need to provide the parent ID for the QuickAdd components
* This should be different depending on whether we are adding before or after an element
* - when adding before, we need to avoid a group referencing itself as the parent
* - when adding after, we can use the group ID directly to insert at the top of the group
*/
const parentIdForBefore =
rundownMetadata.thisId !== rundownMetadata.groupId ? rundownMetadata.groupId : null;
const parentIdForAfter = rundownMetadata.groupId;
return ( return (
<Fragment key={entry.id}> <Fragment key={entry.id}>
@@ -501,7 +510,7 @@ export default function Rundown({ data }: RundownProps) {
* - if it is not the first entry (the buttons would be there) * - if it is not the first entry (the buttons would be there)
*/} */}
{isEditMode && hasCursor && !isFirst && ( {isEditMode && hasCursor && !isFirst && (
<QuickAddInline previousEventId={rundownMetadata.previousEntryId} parentBlock={parentId} /> <QuickAddInline previousEventId={rundownMetadata.previousEntryId} parentBlock={parentIdForBefore} />
)} )}
{isOntimeBlock(entry) ? ( {isOntimeBlock(entry) ? (
<RundownBlock <RundownBlock
@@ -547,9 +556,10 @@ export default function Rundown({ data }: RundownProps) {
* - edit mode only * - edit mode only
* - if there is a cursor * - if there is a cursor
* - if it is not the last entry (the buttons would be there) * - if it is not the last entry (the buttons would be there)
* - if the entry is not the block header
*/} */}
{isEditMode && hasCursor && !isLast && ( {isEditMode && hasCursor && !isLast && (
<QuickAddInline previousEventId={entry.id} parentBlock={parentId} /> <QuickAddInline previousEventId={entry.id} parentBlock={parentIdForAfter} />
)} )}
</Fragment> </Fragment>
); );