From a6683fd2cd7ad3b9c38263d691776e7ba206ee44 Mon Sep 17 00:00:00 2001
From: Carlos Valente <carlosvalente@pm.me>
Date: Fri, 15 Dec 2023 22:25:26 +0100
Subject: [PATCH] style: small UI suggestion

---
 .../modals/sheets-modal/SheetsModal.tsx       | 183 ++++++++++--------
 .../modals/sheets-modal/Step.module.scss      |  44 +++++
 .../src/features/modals/sheets-modal/Step.tsx |  37 ++++
 3 files changed, 187 insertions(+), 77 deletions(-)
 create mode 100644 apps/client/src/features/modals/sheets-modal/Step.module.scss
 create mode 100644 apps/client/src/features/modals/sheets-modal/Step.tsx

diff --git a/apps/client/src/features/modals/sheets-modal/SheetsModal.tsx b/apps/client/src/features/modals/sheets-modal/SheetsModal.tsx
index 1e3f806ad..bfa3f3780 100644
--- a/apps/client/src/features/modals/sheets-modal/SheetsModal.tsx
+++ b/apps/client/src/features/modals/sheets-modal/SheetsModal.tsx
@@ -1,9 +1,11 @@
 import { ChangeEvent, useEffect, useRef, useState } from 'react';
 import {
+  Alert,
+  AlertDescription,
+  AlertIcon,
+  AlertTitle,
   Button,
   Input,
-  InputGroup,
-  InputRightAddon,
   Modal,
   ModalBody,
   ModalCloseButton,
@@ -13,10 +15,6 @@ import {
   ModalOverlay,
   Select,
 } from '@chakra-ui/react';
-import { IoArrowDownCircleOutline } from '@react-icons/all-files/io5/IoArrowDownCircleOutline';
-import { IoArrowUpCircleOutline } from '@react-icons/all-files/io5/IoArrowUpCircleOutline';
-import { IoCheckmarkCircleOutline } from '@react-icons/all-files/io5/IoCheckmarkCircleOutline';
-import { IoCloseCircleOutline } from '@react-icons/all-files/io5/IoCloseCircleOutline';
 import { useQueryClient } from '@tanstack/react-query';
 import { OntimeRundown, ProjectData, UserFields } from 'ontime-types';
 
@@ -34,8 +32,11 @@ import useSheet from '../../../common/hooks-query/useSheet';
 import useSheetState from '../../../common/hooks-query/useSheetState';
 import { projectDataPlaceholder } from '../../../common/models/ProjectData';
 import { userFieldsPlaceholder } from '../../../common/models/UserFields';
+import ModalLink from '../ModalLink';
 import PreviewExcel from '../upload-modal/preview/PreviewExcel';
 
+import Step from './Step';
+
 interface SheetsModalProps {
   onClose: () => void;
   isOpen: boolean;
@@ -180,85 +181,113 @@ export default function SheetsModal(props: SheetsModalProps) {
     >
       <ModalOverlay />
       <ModalContent>
-        <ModalHeader>Sheets!</ModalHeader>
+        <ModalHeader>Rundown from sheets</ModalHeader>
         <ModalCloseButton />
         <ModalBody>
-          {rundown && (
+          <Alert status='info' variant='ontime-on-light-info'>
+            <AlertIcon />
+            <div style={{ display: 'flex', flexDirection: 'column' }}>
+              <AlertTitle>Sync with Google Sheets</AlertTitle>
+              <AlertDescription>
+                Add information here, maybe a link too. <br />
+                The save button is also confusing, can we clarify? should the push data and pull data not be the end
+                game buttons here?
+                <ModalLink href='our-docs'>For more information, see the docs</ModalLink>
+              </AlertDescription>
+            </div>
+          </Alert>
+          {!rundown ? (
+            <>
+              <Step step={1} title='Upload token' completed={Boolean(sheetState?.secret)} disabled={false}>
+                <Input
+                  ref={fileInputRef}
+                  style={{ display: 'none' }}
+                  type='file'
+                  onChange={handleFile}
+                  accept='.json'
+                  data-testid='file-input'
+                />
+                <Button size='sm' variant='ontime-ghosted-on-light' onClick={handleClick}>
+                  Upload Client Secret
+                </Button>
+              </Step>
+
+              <Step
+                step={2}
+                title='Authenticate with Google'
+                completed={Boolean(sheetState?.auth)}
+                disabled={!sheetState?.secret}
+              >
+                <Button
+                  size='sm'
+                  variant='ontime-ghosted-on-light'
+                  onClick={handleAuthenticate}
+                  disabled={!sheetState?.secret}
+                >
+                  Authenticate
+                </Button>
+              </Step>
+
+              <Step step={3} title='Add Sheet ID' completed={Boolean(sheetState?.id)} disabled={!sheetState?.auth}>
+                <label htmlFor='sheetid'>
+                  Sheet ID
+                  <Input
+                    type='text'
+                    ref={sheetid}
+                    id='sheetid'
+                    size='sm'
+                    variant='ontime-filled-on-light'
+                    disabled={!sheetState?.auth}
+                  />
+                </label>
+              </Step>
+
+              <Step
+                step={4}
+                title='Select Worksheet to import'
+                completed={Boolean(sheetState?.auth)}
+                disabled={!sheetState?.worksheetOptions}
+              >
+                <label htmlFor='worksheet'>
+                  Worksheet
+                  <Select ref={worksheet} size='sm' id='worksheet' disabled={!sheetState?.worksheetOptions}>
+                    {sheetState?.worksheetOptions?.map((value) => (
+                      <option key={value} value={value}>
+                        {value}
+                      </option>
+                    ))}
+                  </Select>
+                </label>
+              </Step>
+
+              <Step step={5} title='Upload / Download rundown' completed={false} disabled={!sheetState?.worksheet}>
+                <div style={{ display: 'flex', gap: '1em' }}>
+                  <Button
+                    disabled={!sheetState?.worksheet}
+                    variant='ontime-ghosted-on-light'
+                    padding='0 2em'
+                    onClick={handlePullData}
+                  >
+                    Push data
+                  </Button>
+                  <Button
+                    disabled={!sheetState?.worksheet}
+                    variant='ontime-ghosted-on-light'
+                    padding='0 2em'
+                    onClick={handlePushData}
+                  >
+                    Pull data
+                  </Button>
+                </div>
+              </Step>
+            </>
+          ) : (
             <PreviewExcel
               rundown={rundown ?? []}
               project={project ?? projectDataPlaceholder}
               userFields={userFields ?? userFieldsPlaceholder}
             />
           )}
-          {!rundown && (
-            <>
-              <Input
-                ref={fileInputRef}
-                style={{ display: 'none' }}
-                type='file'
-                onChange={handleFile}
-                accept='.json'
-                data-testid='file-input'
-              />
-              <div>
-                <Button onClick={handleClick}>Upload Client Secret</Button>
-                {sheetState?.secret ? 'have good secret' : 'no or bad secret'}
-              </div>
-              <div style={sheetState?.secret ? {} : { display: 'none' }}>
-                <Button variant='ontime-filled' padding='0 2em' onClick={handleAuthenticate}>
-                  Authenticate
-                </Button>
-                {sheetState?.auth ? 'You are authenticated' : 'You are not authenticated'}
-              </div>
-              <div style={sheetState?.auth ? {} : { display: 'none' }}>
-                <label htmlFor='sheetid'>Sheet ID</label>
-                <InputGroup size='sm'>
-                  <Input
-                    type='text'
-                    ref={sheetid}
-                    id='sheetid'
-                    width='240px'
-                    textAlign='right'
-                    variant='ontime-filled-on-light'
-                  />
-                  <InputRightAddon>
-                    {sheetState?.id ? <IoCheckmarkCircleOutline color='green' /> : <IoCloseCircleOutline color='red' />}
-                  </InputRightAddon>
-                </InputGroup>
-              </div>
-              <div style={sheetState?.id ? {} : { display: 'none' }}>
-                <label htmlFor='worksheet'>Worksheet </label>
-                <Select ref={worksheet} size='sm' id='worksheet'>
-                  {sheetState?.worksheetOptions?.map((value) => (
-                    <option key={value} value={value}>
-                      {value}
-                    </option>
-                  ))}
-                </Select>
-              </div>
-              <br />
-              <div style={sheetState?.worksheet ? {} : { display: 'none' }}>
-                <Button
-                  disabled={!sheetState?.worksheet}
-                  variant='ontime-subtle-on-light'
-                  padding='0 2em'
-                  onClick={handlePullData}
-                  rightIcon={<IoArrowDownCircleOutline />}
-                >
-                  Pull Rundown
-                </Button>
-                <Button
-                  disabled={!sheetState?.worksheet}
-                  variant='ontime-subtle-on-light'
-                  padding='0 2em'
-                  onClick={handlePushData}
-                  rightIcon={<IoArrowUpCircleOutline />}
-                >
-                  Push Rundown
-                </Button>
-              </div>
-            </>
-          )}
         </ModalBody>
         <ModalFooter>
           <Button variant='ontime-ghost-on-light'>Reset</Button>
diff --git a/apps/client/src/features/modals/sheets-modal/Step.module.scss b/apps/client/src/features/modals/sheets-modal/Step.module.scss
new file mode 100644
index 000000000..f761289a9
--- /dev/null
+++ b/apps/client/src/features/modals/sheets-modal/Step.module.scss
@@ -0,0 +1,44 @@
+@use '../../../theme/ontimeColours' as *;
+
+.wrapper {
+  padding: 0.5rem;
+}
+
+.header {
+  width: 100%;
+  display: flex;
+  align-items: center;
+  gap: 0.5rem;
+  font-size: 1rem;
+  padding-bottom: 1rem;
+}
+
+.step {
+  width: 1.25rem;
+  height: 1.25rem;
+  font-size: 0.75rem;
+  display: grid;
+  place-content: center;
+  background-color: $gray-900;
+  color: $ui-white;
+  border-radius: 99px;
+}
+
+.title {
+  display: inline;
+  color: $gray-500;
+  text-transform: uppercase;
+}
+
+.check {
+  color: $green-700;
+}
+
+.errorIcon {
+  color: $red-700;
+}
+
+.errorText {
+  color: $red-700;
+  font-size: 0.75rem;
+}
diff --git a/apps/client/src/features/modals/sheets-modal/Step.tsx b/apps/client/src/features/modals/sheets-modal/Step.tsx
new file mode 100644
index 000000000..db29dd04f
--- /dev/null
+++ b/apps/client/src/features/modals/sheets-modal/Step.tsx
@@ -0,0 +1,37 @@
+import { PropsWithChildren, useState } from 'react';
+import { IoCheckmark } from '@react-icons/all-files/io5/IoCheckmark';
+import { IoClose } from '@react-icons/all-files/io5/IoClose';
+
+import style from './Step.module.scss';
+
+interface StepProps {
+  step: number;
+  title: string;
+  disabled: boolean;
+  completed: boolean;
+  error?: string;
+}
+
+export default function Step(props: PropsWithChildren<StepProps>) {
+  const { step, title, disabled, completed, error, children } = props;
+  const [collapsed, setCollapsed] = useState(disabled);
+
+  const handleCollapse = () => setCollapsed((prev) => !prev);
+
+  return (
+    <div className={style.wrapper}>
+      <div className={style.header} onClick={handleCollapse}>
+        <span className={style.step}>{step}</span>
+        <span className={style.title}>{title}</span>
+        {completed && <IoCheckmark className={style.check} />}
+        {error && <IoClose className={style.errorIcon} />}
+      </div>
+      {!collapsed && (
+        <>
+          {error && <div className={style.errorText}>{error}</div>}
+          {children}
+        </>
+      )}
+    </div>
+  );
+}