Upgrade expressjs (#1633)

* upgrade expressjs

* migration

* reenable test

* extend timeout on download test

* fixup! migration

* move empty body test from controller to validator

* enusre not empty

* extract validation function

* fixup! reenable test

* remove thin controllers

* disable e2e test of project file download

apps/server/src/api-data/validation-utils/validationFunction.ts

@@ -0,0 +1,34 @@
+import type { Request, Response, NextFunction } from 'express';
+import { param, validationResult } from 'express-validator';
+
+/**
+ * Runs validation and any error are sent with status 422
+ */
+export function requestValidationFunction(req: Request, res: Response, next: NextFunction) {
+  const errors = validationResult(req);
+  if (!errors.isEmpty()) {
+    res.status(422).json({ errors: errors.array() });
+    return;
+  }
+  next();
+}
+
+/**
+ * Runs validation and any error are sent with status 422
+ * Also checks for the presses of a `file` in the body
+ */
+export function requestValidationFunctionWithFile(req: Request, res: Response, next: NextFunction) {
+  const errors = validationResult(req);
+  if (!errors.isEmpty()) {
+    res.status(422).json({ errors: errors.array() });
+    return;
+  }
+  // check that the file exists
+  if (!req.file) {
+    res.status(422).json({ errors: 'File not found' });
+    return;
+  }
+  next();
+}
+
+export const paramsWithId = [param('id').isString().trim().notEmpty(), requestValidationFunction];