Upgrade expressjs (#1633)

* upgrade expressjs

* migration

* reenable test

* extend timeout on download test

* fixup! migration

* move empty body test from controller to validator

* enusre not empty

* extract validation function

* fixup! reenable test

* remove thin controllers

* disable e2e test of project file download

apps/server/src/api-data/url-presets/urlPresets.validation.ts

@@ -1,18 +1,14 @@
-import { body, validationResult } from 'express-validator';
-import { Request, Response, NextFunction } from 'express';
+import { body } from 'express-validator';
+import { requestValidationFunction } from '../validation-utils/validationFunction.js';
 
 /**
  * validate array of URL preset objects
  */
 export const validateUrlPresets = [
-  body().isArray(),
+  body().isArray().withMessage('No array found in request'),
   body('*.enabled').isBoolean(),
-  body('*.alias').isString().trim(),
-  body('*.pathAndParams').isString().trim(),
+  body('*.alias').isString().trim().notEmpty(),
+  body('*.pathAndParams').isString().trim().notEmpty(),
 
-  (req: Request, res: Response, next: NextFunction) => {
-    const errors = validationResult(req);
-    if (!errors.isEmpty()) return res.status(422).json({ errors: errors.array() });
-    next();
-  },
+  requestValidationFunction,
 ];