From 9ab54edbf5ef9b8401c1b604e522913290e987f9 Mon Sep 17 00:00:00 2001 From: Carlos Valente Date: Sun, 27 Jul 2025 17:10:21 +0200 Subject: [PATCH] refactor: small code cleanups - remove compiler directives --- .../app-settings/panel/automations-panel/TriggerForm.tsx | 1 - .../app-settings/panel/feature-panel/GenerateLinkForm.tsx | 3 --- .../panel/manage-panel/composite/CustomFieldForm.tsx | 1 - .../manage-panel/sources-panel/import-map/ImportMapForm.tsx | 1 - .../app-settings/panel/project-panel/ProjectCreateForm.tsx | 1 - .../features/app-settings/panel/project-panel/ProjectForm.tsx | 1 - .../app-settings/panel/project-panel/ProjectMergeForm.tsx | 1 - .../app-settings/panel/settings-panel/GeneralSettings.tsx | 1 - .../features/app-settings/panel/settings-panel/ProjectData.tsx | 1 - .../app-settings/panel/settings-panel/ViewSettings.tsx | 1 - .../src/features/app-settings/quick-start/QuickStart.tsx | 1 - 11 files changed, 13 deletions(-) diff --git a/apps/client/src/features/app-settings/panel/automations-panel/TriggerForm.tsx b/apps/client/src/features/app-settings/panel/automations-panel/TriggerForm.tsx index c3b1c409a..2a19d94c8 100644 --- a/apps/client/src/features/app-settings/panel/automations-panel/TriggerForm.tsx +++ b/apps/client/src/features/app-settings/panel/automations-panel/TriggerForm.tsx @@ -31,7 +31,6 @@ export default function TriggerForm({ onCancel, postSubmit, }: TriggerFormProps) { - 'use no memo'; // RHF and react-compiler don't seem to get along const { handleSubmit, register, diff --git a/apps/client/src/features/app-settings/panel/feature-panel/GenerateLinkForm.tsx b/apps/client/src/features/app-settings/panel/feature-panel/GenerateLinkForm.tsx index 480265f11..527becff6 100644 --- a/apps/client/src/features/app-settings/panel/feature-panel/GenerateLinkForm.tsx +++ b/apps/client/src/features/app-settings/panel/feature-panel/GenerateLinkForm.tsx @@ -1,5 +1,3 @@ -'use no memo'; // RHF and react-compiler don't seem to get along - import { useState } from 'react'; import { useForm } from 'react-hook-form'; import QRCode from 'react-qr-code'; @@ -34,7 +32,6 @@ interface GenerateLinkFormOptions { type GenerateLinkState = 'pending' | 'loading' | 'success' | 'error'; export default function GenerateLinkForm({ hostOptions, pathOptions, isLockedToView }: GenerateLinkFormProps) { - 'use no memo'; // RHF and react-compiler don't seem to get along const [formState, setFormState] = useState('pending'); const [url, setUrl] = useState(serverURL); diff --git a/apps/client/src/features/app-settings/panel/manage-panel/composite/CustomFieldForm.tsx b/apps/client/src/features/app-settings/panel/manage-panel/composite/CustomFieldForm.tsx index 223110776..6f961da4d 100644 --- a/apps/client/src/features/app-settings/panel/manage-panel/composite/CustomFieldForm.tsx +++ b/apps/client/src/features/app-settings/panel/manage-panel/composite/CustomFieldForm.tsx @@ -32,7 +32,6 @@ export default function CustomFieldForm({ initialLabel, initialKey, }: CustomFieldsFormProps) { - 'use no memo'; // RHF and react-compiler don't seem to get along const { data } = useCustomFields(); // we use this to force an update diff --git a/apps/client/src/features/app-settings/panel/manage-panel/sources-panel/import-map/ImportMapForm.tsx b/apps/client/src/features/app-settings/panel/manage-panel/sources-panel/import-map/ImportMapForm.tsx index 33ad5acef..d1d354006 100644 --- a/apps/client/src/features/app-settings/panel/manage-panel/sources-panel/import-map/ImportMapForm.tsx +++ b/apps/client/src/features/app-settings/panel/manage-panel/sources-panel/import-map/ImportMapForm.tsx @@ -31,7 +31,6 @@ export default function ImportMapForm({ onSubmitExport, onSubmitImport, }: ImportMapFormProps) { - 'use no memo'; // RHF and react-compiler don't seem to get along const namedImportMap = getPersistedOptions(); const { revoke } = useGoogleSheet(); const { diff --git a/apps/client/src/features/app-settings/panel/project-panel/ProjectCreateForm.tsx b/apps/client/src/features/app-settings/panel/project-panel/ProjectCreateForm.tsx index a420371fb..762942922 100644 --- a/apps/client/src/features/app-settings/panel/project-panel/ProjectCreateForm.tsx +++ b/apps/client/src/features/app-settings/panel/project-panel/ProjectCreateForm.tsx @@ -23,7 +23,6 @@ type ProjectCreateFormValues = { }; export default function ProjectCreateForm({ onClose }: ProjectCreateFromProps) { - 'use no memo'; // RHF and react-compiler don't seem to get along const [error, setError] = useState(null); const { diff --git a/apps/client/src/features/app-settings/panel/project-panel/ProjectForm.tsx b/apps/client/src/features/app-settings/panel/project-panel/ProjectForm.tsx index b512276af..4c5821ea6 100644 --- a/apps/client/src/features/app-settings/panel/project-panel/ProjectForm.tsx +++ b/apps/client/src/features/app-settings/panel/project-panel/ProjectForm.tsx @@ -20,7 +20,6 @@ interface ProjectFormProps { } export default function ProjectForm({ action, filename, onSubmit, onCancel }: ProjectFormProps) { - 'use no memo'; // RHF and react-compiler don't seem to get along const { handleSubmit, register, diff --git a/apps/client/src/features/app-settings/panel/project-panel/ProjectMergeForm.tsx b/apps/client/src/features/app-settings/panel/project-panel/ProjectMergeForm.tsx index 03437c9fa..560aad432 100644 --- a/apps/client/src/features/app-settings/panel/project-panel/ProjectMergeForm.tsx +++ b/apps/client/src/features/app-settings/panel/project-panel/ProjectMergeForm.tsx @@ -28,7 +28,6 @@ type ProjectMergeFormValues = { }; export default function ProjectMergeForm({ onClose, fileName }: ProjectMergeFromProps) { - 'use no memo'; // RHF and react-compiler don't seem to get along const [error, setError] = useState(null); const queryClient = useQueryClient(); diff --git a/apps/client/src/features/app-settings/panel/settings-panel/GeneralSettings.tsx b/apps/client/src/features/app-settings/panel/settings-panel/GeneralSettings.tsx index bc4a7ff9a..7ea3b780f 100644 --- a/apps/client/src/features/app-settings/panel/settings-panel/GeneralSettings.tsx +++ b/apps/client/src/features/app-settings/panel/settings-panel/GeneralSettings.tsx @@ -16,7 +16,6 @@ import * as Panel from '../../panel-utils/PanelUtils'; import GeneralPinInput from './composite/GeneralPinInput'; export default function GeneralSettings() { - 'use no memo'; // RHF and react-compiler don't seem to get along const { data, status, refetch } = useSettings(); const { handleSubmit, diff --git a/apps/client/src/features/app-settings/panel/settings-panel/ProjectData.tsx b/apps/client/src/features/app-settings/panel/settings-panel/ProjectData.tsx index 9cd130010..c3442d734 100644 --- a/apps/client/src/features/app-settings/panel/settings-panel/ProjectData.tsx +++ b/apps/client/src/features/app-settings/panel/settings-panel/ProjectData.tsx @@ -18,7 +18,6 @@ import * as Panel from '../../panel-utils/PanelUtils'; import style from './SettingsPanel.module.scss'; export default function ProjectData() { - 'use no memo'; // RHF and react-compiler don't seem to get along const { data, status } = useProjectData(); const { updateProjectData } = useUpdateProjectData(); diff --git a/apps/client/src/features/app-settings/panel/settings-panel/ViewSettings.tsx b/apps/client/src/features/app-settings/panel/settings-panel/ViewSettings.tsx index aa7fab3e5..5fced34c4 100644 --- a/apps/client/src/features/app-settings/panel/settings-panel/ViewSettings.tsx +++ b/apps/client/src/features/app-settings/panel/settings-panel/ViewSettings.tsx @@ -18,7 +18,6 @@ import CodeEditorModal from './composite/StyleEditorModal'; const cssOverrideDocsUrl = 'https://docs.getontime.no/features/custom-styling/'; export default function ViewSettings() { - 'use no memo'; // RHF and react-compiler don't seem to get along const { data, isPending, mutateAsync } = useViewSettings(); const [isCodeEditorOpen, codeEditorHandler] = useDisclosure(); diff --git a/apps/client/src/features/app-settings/quick-start/QuickStart.tsx b/apps/client/src/features/app-settings/quick-start/QuickStart.tsx index cb48ef1e2..d6fb7109e 100644 --- a/apps/client/src/features/app-settings/quick-start/QuickStart.tsx +++ b/apps/client/src/features/app-settings/quick-start/QuickStart.tsx @@ -20,7 +20,6 @@ interface QuickStartProps { } export default function QuickStart({ isOpen, onClose }: QuickStartProps) { - 'use no memo'; // RHF and react-compiler don't seem to get along const { defaultWarnTime, defaultDangerTime, setDangerTime, setWarnTime } = useEditorSettings(); const {