From 94b1f63c7c78db1b9495f19f7abb5c1b95ef2840 Mon Sep 17 00:00:00 2001
From: Carlos Valente <carlosvalente@pm.me>
Date: Fri, 8 Aug 2025 19:42:09 +0200
Subject: [PATCH] refactor: remove onAir

---
 apps/server/src/app.ts                                      | 3 +--
 apps/server/src/services/runtime-service/RuntimeService.ts  | 6 +-----
 packages/types/src/definitions/runtime/RuntimeStore.ts      | 1 -
 packages/types/src/definitions/runtime/RuntimeStore.type.ts | 1 -
 4 files changed, 2 insertions(+), 9 deletions(-)

diff --git a/apps/server/src/app.ts b/apps/server/src/app.ts
index 97dc6898a..c0a209251 100644
--- a/apps/server/src/app.ts
+++ b/apps/server/src/app.ts
@@ -1,4 +1,4 @@
-import { LogOrigin, Playback, runtimeStorePlaceholder, SimpleDirection, SimplePlayback } from 'ontime-types';
+import { LogOrigin, runtimeStorePlaceholder, SimpleDirection, SimplePlayback } from 'ontime-types';
 
 import 'dotenv/config';
 import express from 'express';
@@ -183,7 +183,6 @@ export const startServer = async (): Promise<{ message: string; serverPort: numb
   eventStore.init({
     clock: state.clock,
     timer: state.timer,
-    onAir: state.timer.playback !== Playback.Stop,
     message: { ...runtimeStorePlaceholder.message },
     runtime: state.runtime,
     eventNow: state.eventNow,
diff --git a/apps/server/src/services/runtime-service/RuntimeService.ts b/apps/server/src/services/runtime-service/RuntimeService.ts
index 05b1aabfc..8598b388a 100644
--- a/apps/server/src/services/runtime-service/RuntimeService.ts
+++ b/apps/server/src/services/runtime-service/RuntimeService.ts
@@ -730,11 +730,7 @@ function broadcastResult(_target: any, _propertyKey: string, descriptor: Propert
      */
     const shouldUpdateClock = shouldRuntimeUpdate || shouldBlockUpdate || normalClockUpdate;
 
-    //Now we set all the updates on the eventstore and update the previous value
-    if (hasChangedPlayback) {
-      batch.add('onAir', state.timer.playback !== Playback.Stop);
-    }
-
+    // Now we set all the updates on the eventstore and update the previous value
     if (shouldUpdateTimer) {
       batch.add('timer', state.timer);
       RuntimeService.previousTimerUpdate = state.clock;
diff --git a/packages/types/src/definitions/runtime/RuntimeStore.ts b/packages/types/src/definitions/runtime/RuntimeStore.ts
index 1594aef0b..90627b50e 100644
--- a/packages/types/src/definitions/runtime/RuntimeStore.ts
+++ b/packages/types/src/definitions/runtime/RuntimeStore.ts
@@ -18,7 +18,6 @@ export const runtimeStorePlaceholder: Readonly<RuntimeStore> = {
     secondaryTimer: null, // change on every update
     startedAt: null, // change can only be initiated by user
   },
-  onAir: false,
   message: {
     timer: {
       text: '',
diff --git a/packages/types/src/definitions/runtime/RuntimeStore.type.ts b/packages/types/src/definitions/runtime/RuntimeStore.type.ts
index 2d8eef8b8..51411d4d2 100644
--- a/packages/types/src/definitions/runtime/RuntimeStore.type.ts
+++ b/packages/types/src/definitions/runtime/RuntimeStore.type.ts
@@ -10,7 +10,6 @@ export type RuntimeStore = {
   // timer data
   clock: number;
   timer: TimerState;
-  onAir: boolean;
 
   // messages service
   message: MessageState;