cpvalente/ontime
1
0
Fork 0
mirror of https://github.com/cpvalente/ontime.git synced 2026-08-15 12:23:51 +00:00
Code Issues Packages Projects Releases 10 Wiki Activity

refactor: handle non numeric comparisons

Browse Source
This commit is contained in:
Carlos Valente
2025-01-22 19:55:51 +01:00
committed by Carlos Valente
parent efe5ac16f2
commit 8ba65fa2bd
4 changed files with 119 additions and 52 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/server/src/api-data/automation/automation.service.ts
+9 -2
View File
@@ -14,6 +14,7 @@ import { isOntimeCloud } from '../../externals.js';
import { emitOSC } from './clients/osc.client.js';
import { emitHTTP } from './clients/http.client.js';
import { getAutomationsEnabled, getAutomations, getAutomationTriggers } from './automation.dao.js';
import { isGreaterThan, isLessThan } from './automation.utils.js';
/**
* Exposes a method for triggering actions based on a TimerLifeCycle event
@@ -87,9 +88,15 @@ export function testConditions(
case 'not_equals':
return fieldValue != value;
case 'greater_than':
return fieldValue > value;
if (typeof fieldValue !== 'number') {
return false;
}
return isGreaterThan(fieldValue, value);
case 'less_than':
return fieldValue < value;
if (typeof fieldValue !== 'number') {
return false;
}
return isLessThan(fieldValue, value);
case 'contains':
return typeof fieldValue === 'string' && fieldValue.includes(value);
case 'not_contains':