diff --git a/apps/client/src/common/components/view-params-editor/ViewParamsEditor.tsx b/apps/client/src/common/components/view-params-editor/ViewParamsEditor.tsx index 426b97f9a..c26dc4c74 100644 --- a/apps/client/src/common/components/view-params-editor/ViewParamsEditor.tsx +++ b/apps/client/src/common/components/view-params-editor/ViewParamsEditor.tsx @@ -51,6 +51,12 @@ export default function ViewParamsEditor({ paramFields }: EditFormDrawerProps) { } }, [searchParams, onOpen]); + /** + * disabling this for now, this feature needs more testing + * - we seem to have a bug where this is conflicting with the aliases + * - I wonder if the logic below needs to be inside an effect, + * both localStorage and searchParams should trigger a component update when they change + useEffect(() => { const viewParamsObjFromLocalStorage = storedViewParams[pathname]; @@ -64,6 +70,8 @@ export default function ViewParamsEditor({ paramFields }: EditFormDrawerProps) { // eslint-disable-next-line react-hooks/exhaustive-deps }, [pathname]); + */ + const onEditDrawerClose = () => { onClose();