cpvalente/ontime
1
0
Fork 0
mirror of https://github.com/cpvalente/ontime.git synced 2026-08-07 08:23:55 +00:00
Code Issues Packages Projects Releases 10 Wiki Activity

refactor: small cleanups (#2059)

Browse Source 
* refactor: remove unneeded async

* chore: add express Router type to all routes

* refactor: don't use index in react key

* refactor: correctly get error message in excel route

* refactor: avoid exporting muteable values
This commit is contained in:
Alex Christoffer Rasmussen
2026-04-26 17:32:50 +02:00
committed by GitHub
parent 23a44b2f04
commit 7c1d2f4554
22 changed files with 55 additions and 49 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/server/src/api-data/session/session.router.ts
+4 -4
View File
@@ -1,12 +1,12 @@
import express from 'express';
import type { Request, Response } from 'express';
import type { Request, Response, Router } from 'express';
import type { ErrorResponse, GetInfo, GetUrl, SessionStats } from 'ontime-types';
import { getErrorMessage } from 'ontime-utils';
import * as sessionService from './session.service.js';
import { validateGenerateUrl } from './session.validation.js';
export const router = express.Router();
export const router: Router = express.Router();
router.get('/', async (_req: Request, res: Response<SessionStats | ErrorResponse>) => {
try {
@@ -18,9 +18,9 @@ router.get('/', async (_req: Request, res: Response<SessionStats | ErrorResponse
}
});
router.get('/info', async (_req: Request, res: Response<GetInfo | ErrorResponse>) => {
router.get('/info', (_req: Request, res: Response<GetInfo | ErrorResponse>) => {
try {
const info = await sessionService.getInfo();
const info = sessionService.getInfo();
res.status(200).send(info);
} catch (error) {
const message = getErrorMessage(error);
apps/server/src/api-data/session/session.service.ts
+1 -1
View File
@@ -37,7 +37,7 @@ export async function getSessionStats(): Promise<SessionStats> {
/**
* Adds business logic to gathering data for the info endpoint
*/
export async function getInfo(): Promise<GetInfo> {
export function getInfo(): GetInfo {
const { version } = getDataProvider().getSettings();
const { port } = portManager.getPort();