cpvalente/ontime
1
0
Fork 0
mirror of https://github.com/cpvalente/ontime.git synced 2026-08-14 03:43:50 +00:00
Code Issues Packages Projects Releases 10 Wiki Activity

fix: block uploading already existing file name

Browse Source
This commit is contained in:
arc-alex
2025-12-11 15:35:41 +01:00
committed by Carlos Valente
parent f0e81c0cf0
commit 77225383a4
3 changed files with 27 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/server/src/utils/fileManagement.ts
+16 -3
View File
@@ -1,6 +1,8 @@
import { existsSync, mkdirSync, PathLike } from 'fs';
import { existsSync, mkdirSync, PathLike, constants } from 'fs';
import { readdir, copyFile, unlink } from 'fs/promises';
import { basename, join, parse } from 'path';
import { consoleError } from './console.js';
import { is } from './is.js';
/**
* @description Creates a directory if it doesn't exist
@@ -102,12 +104,23 @@ export async function copyDirectory(src: string, dest: string) {
}
/**
* @throws if the file already exits
* workaround avoids origin errors in docker deployments
* EXDEV cross-device link not permitted
*/
export async function dockerSafeRename(oldPath: PathLike, newPath: PathLike) {
await copyFile(oldPath, newPath);
await unlink(oldPath);
try {
await copyFile(oldPath, newPath, constants.COPYFILE_EXCL);
await unlink(oldPath);
} catch (error) {
// for securely reasons we should not let the error or fs leak server file path up the error chain
if (is.object(error) && 'code' in error && error.code === 'EEXIST') {
consoleError(`rename error: File already exists ${newPath}`);
throw new Error(`File already exists`);
}
consoleError(`rename error ${error}`);
throw new Error('Unknown file rename error');
}
}
/**