cpvalente/ontime
1
0
Fork 0
mirror of https://github.com/cpvalente/ontime.git synced 2026-09-08 15:59:16 +00:00
Code Issues Packages Projects Releases 10 Wiki Activity

fix: stop playback when event is deleted

Browse Source
This commit is contained in:
Carlos Valente
2024-08-09 19:58:28 +02:00
committed by Carlos Valente
parent 347f333b3e
commit 66ed92e215
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/server/src/services/runtime-service/RuntimeService.ts
+5 -1
View File
@@ -231,19 +231,23 @@ class RuntimeService {
// 1. we are not confident that changes do not affect running event (eg. all events where changed) // 1. we are not confident that changes do not affect running event (eg. all events where changed)
const safeOption = typeof affectedIds === 'undefined'; const safeOption = typeof affectedIds === 'undefined';
// 2. the edited event is in memory (now or next) running // 2. the edited event is in memory (now or next) running
// behind conditional to avoid doing unnecessary work
const eventInMemory = safeOption ? false : this.affectsLoaded(affectedIds); const eventInMemory = safeOption ? false : this.affectsLoaded(affectedIds);
// 3. the edited event replaces next event // 3. the edited event replaces next event
let isNext = false; let isNext = false;
// TODO: review logic // if we are not sure, or the event is in memory, we reload
if (safeOption || eventInMemory) { if (safeOption || eventInMemory) {
if (state.eventNow !== null) { if (state.eventNow !== null) {
// load stuff again, but keep running if our events still exist // load stuff again, but keep running if our events still exist
const eventNow = getEventWithId(state.eventNow.id); const eventNow = getEventWithId(state.eventNow.id);
if (!isOntimeEvent(eventNow) || !isPlayableEvent(eventNow)) { if (!isOntimeEvent(eventNow) || !isPlayableEvent(eventNow)) {
// maybe the event was deleted or the skip state was changed
runtimeState.stop();
return; return;
} }
const onlyChangedNow = affectedIds?.length === 1 && affectedIds.at(0) === eventNow.id; const onlyChangedNow = affectedIds?.length === 1 && affectedIds.at(0) === eventNow.id;
if (onlyChangedNow) { if (onlyChangedNow) {
runtimeState.reload(eventNow); runtimeState.reload(eventNow);
} else { } else {