refactor(logo): improve flow for managing logo

apps/server/src/api-data/project-data/projectData.dao.ts

@@ -16,19 +16,13 @@ export function getProjectData(): Readonly<ProjectData> {
 
 /**
  * Patches the current project data
- * Handles deleting the local logo if the logo has been removed
  */
 export async function editCurrentProjectData(newData: Partial<ProjectData>) {
   const currentProjectData = getDataProvider().getProjectData();
   const updatedProjectData = await getDataProvider().setProjectData(newData);
 
-  // Delete the old logo if the logo has been removed
-  if (!updatedProjectData.logo && currentProjectData.logo) {
-    const filePath = join(publicDir.logoDir, currentProjectData.logo);
-
-    deleteFile(filePath).catch((_error) => {
-      /** we do not handle this error */
-    });
+  if (currentProjectData.logo && currentProjectData.logo !== updatedProjectData.logo) {
+    deleteFile(join(publicDir.logoDir, currentProjectData.logo));
   }
 
   // Notify the websocket clients to refetch the project data

apps/server/src/services/project-service/projectServiceUtils.ts

@@ -3,6 +3,7 @@ import { readFile, stat } from 'fs/promises';
 import { extname, join } from 'path';
 
 import { DatabaseModel, MaybeString, ProjectFile } from 'ontime-types';
+import { generateId } from 'ontime-utils';
 
 import { publicDir } from '../../setup/index.js';
 import { dockerSafeRename, getFilesFromFolder, removeFileExtension } from '../../utils/fileManagement.js';
@@ -20,15 +21,16 @@ export async function handleProjectUploaded(filePath: string, name: string) {
 
 /**
  * Handles the upload of a logo image
- * @throws if the file already exits
+ * Each upload gets a unique filename so logos cannot conflict across projects.
  * @param filePath
  * @param name
- * @returns
+ * @returns the generated filename
  */
 export async function handleImageUpload(filePath: string, name: string): Promise<string> {
-  const newFilePath = join(publicDir.logoDir, name);
+  const filename = `${generateId()}${extname(name)}`;
+  const newFilePath = join(publicDir.logoDir, filename);
   await dockerSafeRename(filePath, newFilePath);
-  return name;
+  return filename;
 }
 
 /**