cpvalente/ontime
1
0
Fork 0
mirror of https://github.com/cpvalente/ontime.git synced 2026-09-01 20:39:18 +00:00
Code Issues Packages Projects Releases 10 Wiki Activity

Timer: fix too many renders error when using ?progress (#305)

Browse Source 
* Timer: fix too many renders error when using ?progress
This commit is contained in:
Marks Polakovs
2023-03-06 18:59:45 +00:00
committed by GitHub
parent 7d2b88b626
commit 48bfe477f0
1 changed files with 10 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
client/src/features/viewers/timer/Timer.jsx
+10 -12
View File
@@ -23,8 +23,17 @@ const formatOptions = {
export default function Timer(props) { export default function Timer(props) {
const { general, pres, title, time, viewSettings } = props; const { general, pres, title, time, viewSettings } = props;
const { shouldRender } = useRuntimeStylesheet(viewSettings?.overrideStyles && overrideStylesURL); const { shouldRender } = useRuntimeStylesheet(viewSettings?.overrideStyles && overrideStylesURL);
const [elapsed, setElapsed] = useState(true);
const [searchParams] = useSearchParams(); const [searchParams] = useSearchParams();
const [elapsed, setElapsed] = useState(() => {
// eg. http://localhost:3000/timer?progress=up
// Check for user options
// progress: selector
// Should be 'up' or 'down'
const progress = searchParams.get('progress');
return progress === 'up';
});
const [isMirrored] = useAtom(mirrorViewersAtom); const [isMirrored] = useAtom(mirrorViewersAtom);
useEffect(() => { useEffect(() => {
@@ -36,17 +45,6 @@ export default function Timer(props) {
return null; return null;
} }
// eg. http://localhost:3000/timer?progress=up
// Check for user options
// progress: selector
// Should be 'up' or 'down'
const progress = searchParams.get('progress');
if (progress === 'up') {
setElapsed(true);
} else if (progress === 'down') {
setElapsed(false);
}
const clock = formatTime(time.clock, formatOptions); const clock = formatTime(time.clock, formatOptions);
const showOverlay = pres.text !== '' && pres.visible; const showOverlay = pres.text !== '' && pres.visible;
const isPlaying = time.playstate !== 'pause'; const isPlaying = time.playstate !== 'pause';