cpvalente/ontime
1
0
Fork 0
mirror of https://github.com/cpvalente/ontime.git synced 2026-08-14 03:43:50 +00:00
Code Issues Packages Projects Releases 10 Wiki Activity

refactor: simplify file checks

Browse Source
This commit is contained in:
Carlos Valente
2024-07-02 18:01:51 +02:00
committed by Carlos Valente
parent 751c3329f0
commit 367997fd16
4 changed files with 41 additions and 45 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/server/src/services/project-service/ProjectService.ts
+18 -19
View File
@@ -37,12 +37,11 @@ function init() {
* Loads a data from a file into the runtime
*/
export async function loadProjectFile(name: string) {
if (!(await doesProjectExist(name))) {
const filePath = await doesProjectExist(name);
if (filePath === null) {
throw new Error('Project file not found');
}
const filePath = getPathToProject(name);
// when loading a project file, we allow parsing to fail and interrupt the process
const fileData = await parseProjectFile(filePath);
const result = parseJson(fileData);
@@ -96,45 +95,45 @@ export async function getProjectList(): Promise<ProjectFileListResponse> {
* Duplicates an existing project file
*/
export async function duplicateProjectFile(originalFile: string, newFilename: string) {
if (!(await doesProjectExist(originalFile))) {
const projectFilePath = await doesProjectExist(originalFile);
if (projectFilePath === null) {
throw new Error('Project file not found');
}
if (await doesProjectExist(newFilename)) {
const duplicateProjectFilePath = await doesProjectExist(newFilename);
if (duplicateProjectFilePath !== null) {
throw new Error(`Project file with name ${newFilename} already exists`);
}
const projectFilePath = getPathToProject(originalFile);
const duplicateProjectFilePath = getPathToProject(newFilename);
return copyFile(projectFilePath, duplicateProjectFilePath);
const pathToDuplicate = getPathToProject(newFilename);
return copyFile(projectFilePath, pathToDuplicate);
}
/**
* Renames an existing project file
*/
export async function renameProjectFile(originalFile: string, newFilename: string) {
if (!(await doesProjectExist(originalFile))) {
const projectFilePath = await doesProjectExist(originalFile);
if (projectFilePath === null) {
throw new Error('Project file not found');
}
if (await doesProjectExist(newFilename)) {
const newProjectFilePath = await doesProjectExist(newFilename);
if (newProjectFilePath !== null) {
throw new Error(`Project file with name ${newFilename} already exists`);
}
const projectFilePath = getPathToProject(originalFile);
const newProjectFilePath = getPathToProject(newFilename);
await rename(projectFilePath, newProjectFilePath);
const pathToRenamed = getPathToProject(newFilename);
await rename(projectFilePath, pathToRenamed);
// Update the last loaded project config if current loaded project is the one being renamed
const isLoaded = await appStateProvider.isLastLoadedProject(originalFile);
if (isLoaded) {
const fileData = await parseProjectFile(newProjectFilePath);
const fileData = await parseProjectFile(pathToRenamed);
const result = parseJson(fileData);
// change LowDB to point to new file
await switchDb(newProjectFilePath, result.data);
await switchDb(pathToRenamed, result.data);
logger.info(LogOrigin.Server, `Loaded project ${newFilename}`);
// persist the project selection
@@ -191,11 +190,11 @@ export async function deleteProjectFile(filename: string) {
throw new Error('Cannot delete currently loaded project');
}
if (!(await doesProjectExist(filename))) {
const projectFilePath = await doesProjectExist(filename);
if (projectFilePath === null) {
throw new Error('Project file not found');
}
const projectFilePath = getPathToProject(filename);
await deleteFile(projectFilePath);
}