fix: prevent infinite render in settings forms

This commit is contained in:
Carlos Valente
2026-02-10 06:58:16 +01:00
committed by Carlos Valente
parent b6a01a52e2
commit 31fd8e5200
3 changed files with 4 additions and 4 deletions
@@ -32,7 +32,6 @@ export default function GeneralSettings() {
} = useForm<Settings>({ } = useForm<Settings>({
mode: 'onChange', mode: 'onChange',
defaultValues: data, defaultValues: data,
values: data,
resetOptions: { resetOptions: {
keepDirtyValues: true, keepDirtyValues: true,
}, },
@@ -31,7 +31,6 @@ export default function ViewSettings() {
formState: { isSubmitting, isDirty, errors }, formState: { isSubmitting, isDirty, errors },
} = useForm<ViewSettingsType>({ } = useForm<ViewSettingsType>({
defaultValues: data, defaultValues: data,
values: data,
resetOptions: { resetOptions: {
keepDirtyValues: true, keepDirtyValues: true,
}, },
@@ -1,4 +1,4 @@
import { lazy, useEffect, useRef, useState } from 'react'; import { lazy, Suspense, useEffect, useRef, useState } from 'react';
import { getCSSContents, postCSSContents, restoreCSSContents } from '../../../../../common/api/assets'; import { getCSSContents, postCSSContents, restoreCSSContents } from '../../../../../common/api/assets';
import Button from '../../../../../common/components/buttons/Button'; import Button from '../../../../../common/components/buttons/Button';
@@ -81,7 +81,9 @@ export default function CodeEditorModal({ isOpen, onClose }: CodeEditorModalProp
showCloseButton showCloseButton
showBackdrop showBackdrop
bodyElements={ bodyElements={
<CodeEditor ref={cssRef} initialValue={css} language='css' isDirty={isDirty} setIsDirty={setIsDirty} /> <Suspense fallback={null}>
<CodeEditor ref={cssRef} initialValue={css} language='css' isDirty={isDirty} setIsDirty={setIsDirty} />
</Suspense>
} }
footerElements={ footerElements={
<div className={style.column}> <div className={style.column}>