refactor: dev label

apps/server/src/app.ts

@@ -263,6 +263,7 @@ export const shutdown = async (exitCode = 0) => {
   // clear the restore file if it was a normal exit
   // 0 means it was a SIGNAL
   // 1 means crash -> keep the file
+  // 2 means dev crash -> do nothing
   // 99 means there was a shutdown request from the UI
   if (exitCode === 0 || exitCode === 99) {
     await restoreService.clear();

apps/server/src/classes/data-provider/DataProvider.ts

@@ -13,24 +13,19 @@ import {
 import type { Low } from 'lowdb';
 import { JSONFilePreset } from 'lowdb/node';
 
-import { isProduction, isTest } from '../../setup/index.js';
+import { isTest } from '../../setup/index.js';
 import { isPath } from '../../utils/fileManagement.js';
-import { consoleError } from '../../utils/console.js';
 
 import { safeMerge } from './DataProvider.utils.js';
+import { shouldCrashDev } from '../../utils/development.js';
 
 type ReadonlyPromise<T> = Promise<Readonly<T>>;
 
 let db = {} as Low<DatabaseModel>;
 
 export async function initPersistence(filePath: string, fallbackData: DatabaseModel) {
-  if (!isProduction) {
-    if (!isPath(filePath)) {
-      consoleError(filePath);
-      consoleError(new Error('initPersistence should be called with a path').stack);
-      process.exit(0);
-    }
-  }
+  // eslint-disable-next-line no-unused-labels -- dev code path
+  DEV: shouldCrashDev(!isPath(filePath), 'initPersistence should be called with a path');
   const newDb = await JSONFilePreset<DatabaseModel>(filePath, fallbackData);
 
   // Read the database to initialize it

apps/server/src/services/app-state-service/AppStateService.ts

@@ -1,9 +1,9 @@
 import { Low } from 'lowdb';
 import { JSONFile } from 'lowdb/node';
 
-import { appStatePath, isProduction, isTest } from '../../setup/index.js';
+import { appStatePath, isTest } from '../../setup/index.js';
 import { isPath } from '../../utils/fileManagement.js';
-import { consoleError } from '../../utils/console.js';
+import { shouldCrashDev } from '../../utils/development.js';
 
 interface AppState {
   lastLoadedProject?: string;
@@ -27,13 +27,8 @@ export async function getLastLoadedProject(): Promise<string | undefined> {
 
 export async function setLastLoadedProject(filename: string): Promise<void> {
   if (isTest) return;
-  if (!isProduction) {
-    if (isPath(filename)) {
-      consoleError(filename);
-      consoleError(new Error('setLastLoadedProject should not be called with a path').stack);
-      process.exit(0);
-    }
-  }
+  // eslint-disable-next-line no-unused-labels -- dev code path
+  DEV: shouldCrashDev(isPath(filename), 'setLastLoadedProject should not be called with a path');
 
   config.data.lastLoadedProject = filename;
   await config.write();

apps/server/src/utils/development.ts

@@ -0,0 +1,20 @@
+import { isProduction } from '../setup/index.js';
+import { consoleError } from '../utils/console.js';
+
+/**
+ * Milestone checker for dev environment
+ * will terminate process if check returns true
+ * Ideally we would like to remove the call to this function on build
+ */
+export function shouldCrashDev(check: boolean, reason: string) {
+  if (isProduction) {
+    return;
+  }
+
+  if (!check) {
+    return;
+  }
+
+  consoleError(new Error(reason).stack ?? '');
+  process.exit(2);
+}