standardize layout of bad tests

This commit is contained in:
Joel Wetzell
2026-03-02 12:34:46 -06:00
parent cd1b5e1437
commit f68312ee84
3 changed files with 65 additions and 197 deletions

View File

@@ -26,59 +26,6 @@ func TestFloatParseFromRegistry(t *testing.T) {
}
}
func TestFloatParseBadConfigBitSizeString(t *testing.T) {
registration, ok := processor.ProcessorRegistry["float.parse"]
if !ok {
t.Fatalf("float.parse processor not registered")
}
_, err := registration.New(config.ProcessorConfig{
Type: "float.parse",
Params: map[string]any{
"bitSize": "64",
},
})
if err == nil {
t.Fatalf("float.parse should have returned an error for bad bitSize config")
}
}
func TestFloatParseGoodConfig(t *testing.T) {
registration, ok := processor.ProcessorRegistry["float.parse"]
if !ok {
t.Fatalf("float.parse processor not registered")
}
processorInstance, err := registration.New(config.ProcessorConfig{
Type: "float.parse",
Params: map[string]any{
"bitSize": 64.0,
},
})
if err != nil {
t.Fatalf("float.parse should have created processor but got error: %s", err)
}
payload := "12345.0"
expected := float64(12345.0)
got, err := processorInstance.Process(t.Context(), payload)
if err != nil {
t.Fatalf("float.parse processing failed: %s", err)
}
gotFloat, ok := got.(float64)
if !ok {
t.Fatalf("float.parse returned a %T payload: %s", got, got)
}
if gotFloat != expected {
t.Fatalf("float.parse got %f, expected %f", gotFloat, expected)
}
}
func TestGoodFloatParse(t *testing.T) {
tests := []struct {
name string
@@ -151,6 +98,14 @@ func TestBadFloatParse(t *testing.T) {
payload any
errorString string
}{
{
name: "non-string bitSize",
params: map[string]any{
"bitSize": "32",
},
payload: "1.23",
errorString: "float.parse bitSize error: not a number",
},
{
name: "non-string input",
params: map[string]any{
@@ -189,6 +144,13 @@ func TestBadFloatParse(t *testing.T) {
Params: test.params,
})
if err != nil {
if err.Error() != test.errorString {
t.Fatalf("float.parse got error '%s', expected '%s'", err.Error(), test.errorString)
}
return
}
got, err := processorInstance.Process(t.Context(), test.payload)
if err == nil {