From dc19d18b817197ff24d3923b2e0c8433bf5cec39 Mon Sep 17 00:00:00 2001 From: Joel Wetzell Date: Mon, 9 Feb 2026 18:17:42 -0600 Subject: [PATCH] add tests to ensure module id returns correctly --- internal/module/test/http-client_test.go | 5 +++++ internal/module/test/http-server_test.go | 5 +++++ internal/module/test/midi-input_test.go | 5 +++++ internal/module/test/midi-output_test.go | 5 +++++ internal/module/test/mqtt-client_test.go | 5 +++++ internal/module/test/nats-client_test.go | 5 +++++ internal/module/test/psn-client_test.go | 5 +++++ internal/module/test/serial-client_test.go | 5 +++++ internal/module/test/sip-call-server_test.go | 5 +++++ internal/module/test/sip-dtmf-server_test.go | 5 +++++ internal/module/test/tcp-client_test.go | 5 +++++ internal/module/test/tcp-server_test.go | 5 +++++ internal/module/test/udp-client_test.go | 5 +++++ internal/module/test/udp-multicast_test.go | 9 +++++++-- internal/module/test/udp-server_test.go | 5 +++++ 15 files changed, 77 insertions(+), 2 deletions(-) diff --git a/internal/module/test/http-client_test.go b/internal/module/test/http-client_test.go index c4cfe16..457ae43 100644 --- a/internal/module/test/http-client_test.go +++ b/internal/module/test/http-client_test.go @@ -14,6 +14,7 @@ func TestHTTPClientFromRegistry(t *testing.T) { } moduleInstance, err := registration.New(config.ModuleConfig{ + Id: "test", Type: "http.client", }) @@ -21,6 +22,10 @@ func TestHTTPClientFromRegistry(t *testing.T) { t.Fatalf("failed to create http.client module: %s", err) } + if moduleInstance.Id() != "test" { + t.Fatalf("http.client module has wrong id: %s", moduleInstance.Id()) + } + if moduleInstance.Type() != "http.client" { t.Fatalf("http.client module has wrong type: %s", moduleInstance.Type()) } diff --git a/internal/module/test/http-server_test.go b/internal/module/test/http-server_test.go index 8da7c08..d0a7f94 100644 --- a/internal/module/test/http-server_test.go +++ b/internal/module/test/http-server_test.go @@ -14,6 +14,7 @@ func TestHTTPServerFromRegistry(t *testing.T) { } moduleInstance, err := registration.New(config.ModuleConfig{ + Id: "test", Type: "http.server", Params: map[string]any{ "port": 3000.0, @@ -24,6 +25,10 @@ func TestHTTPServerFromRegistry(t *testing.T) { t.Fatalf("failed to create http.server module: %s", err) } + if moduleInstance.Id() != "test" { + t.Fatalf("http.server module has wrong id: %s", moduleInstance.Id()) + } + if moduleInstance.Type() != "http.server" { t.Fatalf("http.server module has wrong type: %s", moduleInstance.Type()) } diff --git a/internal/module/test/midi-input_test.go b/internal/module/test/midi-input_test.go index 2d2bff0..96b4dc0 100644 --- a/internal/module/test/midi-input_test.go +++ b/internal/module/test/midi-input_test.go @@ -14,6 +14,7 @@ func TestMIDIInputFromRegistry(t *testing.T) { } moduleInstance, err := registration.New(config.ModuleConfig{ + Id: "test", Type: "midi.input", Params: map[string]any{ "port": "test", @@ -24,6 +25,10 @@ func TestMIDIInputFromRegistry(t *testing.T) { t.Fatalf("failed to create midi.input module: %s", err) } + if moduleInstance.Id() != "test" { + t.Fatalf("midi.input module has wrong id: %s", moduleInstance.Id()) + } + if moduleInstance.Type() != "midi.input" { t.Fatalf("midi.input module has wrong type: %s", moduleInstance.Type()) } diff --git a/internal/module/test/midi-output_test.go b/internal/module/test/midi-output_test.go index d80c926..4209d41 100644 --- a/internal/module/test/midi-output_test.go +++ b/internal/module/test/midi-output_test.go @@ -14,6 +14,7 @@ func TestMIDIOutputFromRegistry(t *testing.T) { } moduleInstance, err := registration.New(config.ModuleConfig{ + Id: "test", Type: "midi.output", Params: map[string]any{ "port": "test", @@ -24,6 +25,10 @@ func TestMIDIOutputFromRegistry(t *testing.T) { t.Fatalf("failed to create midi.output module: %s", err) } + if moduleInstance.Id() != "test" { + t.Fatalf("midi.output module has wrong id: %s", moduleInstance.Id()) + } + if moduleInstance.Type() != "midi.output" { t.Fatalf("midi.output module has wrong type: %s", moduleInstance.Type()) } diff --git a/internal/module/test/mqtt-client_test.go b/internal/module/test/mqtt-client_test.go index 7120156..c123be6 100644 --- a/internal/module/test/mqtt-client_test.go +++ b/internal/module/test/mqtt-client_test.go @@ -14,6 +14,7 @@ func TestMQTTClientFromRegistry(t *testing.T) { } moduleInstance, err := registration.New(config.ModuleConfig{ + Id: "test", Type: "mqtt.client", Params: map[string]any{ "broker": "mqtt://localhost:1883", @@ -26,6 +27,10 @@ func TestMQTTClientFromRegistry(t *testing.T) { t.Fatalf("failed to create mqtt.client module: %s", err) } + if moduleInstance.Id() != "test" { + t.Fatalf("mqtt.client module has wrong id: %s", moduleInstance.Id()) + } + if moduleInstance.Type() != "mqtt.client" { t.Fatalf("mqtt.client module has wrong type: %s", moduleInstance.Type()) } diff --git a/internal/module/test/nats-client_test.go b/internal/module/test/nats-client_test.go index 66591c7..0ef893c 100644 --- a/internal/module/test/nats-client_test.go +++ b/internal/module/test/nats-client_test.go @@ -14,6 +14,7 @@ func TestNATSClientFromRegistry(t *testing.T) { } moduleInstance, err := registration.New(config.ModuleConfig{ + Id: "test", Type: "nats.client", Params: map[string]any{ "url": "nats://127.0.0.1:4222", @@ -25,6 +26,10 @@ func TestNATSClientFromRegistry(t *testing.T) { t.Fatalf("failed to create nats.client module: %s", err) } + if moduleInstance.Id() != "test" { + t.Fatalf("nats.client module has wrong id: %s", moduleInstance.Id()) + } + if moduleInstance.Type() != "nats.client" { t.Fatalf("nats.client module has wrong type: %s", moduleInstance.Type()) } diff --git a/internal/module/test/psn-client_test.go b/internal/module/test/psn-client_test.go index 24bedcb..93cffeb 100644 --- a/internal/module/test/psn-client_test.go +++ b/internal/module/test/psn-client_test.go @@ -14,6 +14,7 @@ func TestPSNClientFromRegistry(t *testing.T) { } moduleInstance, err := registration.New(config.ModuleConfig{ + Id: "test", Type: "psn.client", }) @@ -21,6 +22,10 @@ func TestPSNClientFromRegistry(t *testing.T) { t.Fatalf("failed to create psn.client module: %s", err) } + if moduleInstance.Id() != "test" { + t.Fatalf("psn.client module has wrong id: %s", moduleInstance.Id()) + } + if moduleInstance.Type() != "psn.client" { t.Fatalf("psn.client module has wrong type: %s", moduleInstance.Type()) } diff --git a/internal/module/test/serial-client_test.go b/internal/module/test/serial-client_test.go index dd11737..0625b4c 100644 --- a/internal/module/test/serial-client_test.go +++ b/internal/module/test/serial-client_test.go @@ -14,6 +14,7 @@ func TestSerialClientFromRegistry(t *testing.T) { } moduleInstance, err := registration.New(config.ModuleConfig{ + Id: "test", Type: "serial.client", Params: map[string]any{ "port": "/dev/ttyUSB0", @@ -26,6 +27,10 @@ func TestSerialClientFromRegistry(t *testing.T) { t.Fatalf("failed to create serial.client module: %s", err) } + if moduleInstance.Id() != "test" { + t.Fatalf("serial.client module has wrong id: %s", moduleInstance.Id()) + } + if moduleInstance.Type() != "serial.client" { t.Fatalf("serial.client module has wrong type: %s", moduleInstance.Type()) } diff --git a/internal/module/test/sip-call-server_test.go b/internal/module/test/sip-call-server_test.go index c961dca..b988fbc 100644 --- a/internal/module/test/sip-call-server_test.go +++ b/internal/module/test/sip-call-server_test.go @@ -14,6 +14,7 @@ func TestSIPCallServerFromRegistry(t *testing.T) { } moduleInstance, err := registration.New(config.ModuleConfig{ + Id: "test", Type: "sip.call.server", }) @@ -21,6 +22,10 @@ func TestSIPCallServerFromRegistry(t *testing.T) { t.Fatalf("failed to create sip.call.server module: %s", err) } + if moduleInstance.Id() != "test" { + t.Fatalf("sip.call.server module has wrong id: %s", moduleInstance.Id()) + } + if moduleInstance.Type() != "sip.call.server" { t.Fatalf("sip.call.server module has wrong type: %s", moduleInstance.Type()) } diff --git a/internal/module/test/sip-dtmf-server_test.go b/internal/module/test/sip-dtmf-server_test.go index 0e919a2..274422d 100644 --- a/internal/module/test/sip-dtmf-server_test.go +++ b/internal/module/test/sip-dtmf-server_test.go @@ -14,6 +14,7 @@ func TestSIPDTMFServerFromRegistry(t *testing.T) { } moduleInstance, err := registration.New(config.ModuleConfig{ + Id: "test", Type: "sip.dtmf.server", Params: map[string]any{ "separator": "#", @@ -24,6 +25,10 @@ func TestSIPDTMFServerFromRegistry(t *testing.T) { t.Fatalf("failed to create sip.dtmf.server module: %s", err) } + if moduleInstance.Id() != "test" { + t.Fatalf("sip.dtmf.server module has wrong id: %s", moduleInstance.Id()) + } + if moduleInstance.Type() != "sip.dtmf.server" { t.Fatalf("sip.dtmf.server module has wrong type: %s", moduleInstance.Type()) } diff --git a/internal/module/test/tcp-client_test.go b/internal/module/test/tcp-client_test.go index 9b7f13b..34d0ff1 100644 --- a/internal/module/test/tcp-client_test.go +++ b/internal/module/test/tcp-client_test.go @@ -14,6 +14,7 @@ func TestTCPClientFromRegistry(t *testing.T) { } moduleInstance, err := registration.New(config.ModuleConfig{ + Id: "test", Type: "net.tcp.client", Params: map[string]any{ "host": "localhost", @@ -26,6 +27,10 @@ func TestTCPClientFromRegistry(t *testing.T) { t.Fatalf("failed to create net.tcp.client module: %s", err) } + if moduleInstance.Id() != "test" { + t.Fatalf("net.tcp.client module has wrong id: %s", moduleInstance.Id()) + } + if moduleInstance.Type() != "net.tcp.client" { t.Fatalf("net.tcp.client module has wrong type: %s", moduleInstance.Type()) } diff --git a/internal/module/test/tcp-server_test.go b/internal/module/test/tcp-server_test.go index 9a7ed8e..29c2f89 100644 --- a/internal/module/test/tcp-server_test.go +++ b/internal/module/test/tcp-server_test.go @@ -14,6 +14,7 @@ func TestTCPServerFromRegistry(t *testing.T) { } moduleInstance, err := registration.New(config.ModuleConfig{ + Id: "test", Type: "net.tcp.server", Params: map[string]any{ "port": 8000.0, @@ -25,6 +26,10 @@ func TestTCPServerFromRegistry(t *testing.T) { t.Fatalf("failed to create net.tcp.server module: %s", err) } + if moduleInstance.Id() != "test" { + t.Fatalf("net.tcp.server module has wrong id: %s", moduleInstance.Id()) + } + if moduleInstance.Type() != "net.tcp.server" { t.Fatalf("net.tcp.server module has wrong type: %s", moduleInstance.Type()) } diff --git a/internal/module/test/udp-client_test.go b/internal/module/test/udp-client_test.go index 7a60eca..1ef7160 100644 --- a/internal/module/test/udp-client_test.go +++ b/internal/module/test/udp-client_test.go @@ -14,6 +14,7 @@ func TestUDPClientFromRegistry(t *testing.T) { } moduleInstance, err := registration.New(config.ModuleConfig{ + Id: "test", Type: "net.udp.client", Params: map[string]any{ "host": "localhost", @@ -26,6 +27,10 @@ func TestUDPClientFromRegistry(t *testing.T) { t.Fatalf("failed to create net.udp.client module: %s", err) } + if moduleInstance.Id() != "test" { + t.Fatalf("net.udp.client module has wrong id: %s", moduleInstance.Id()) + } + if moduleInstance.Type() != "net.udp.client" { t.Fatalf("net.udp.client module has wrong type: %s", moduleInstance.Type()) } diff --git a/internal/module/test/udp-multicast_test.go b/internal/module/test/udp-multicast_test.go index 43164f4..52f418b 100644 --- a/internal/module/test/udp-multicast_test.go +++ b/internal/module/test/udp-multicast_test.go @@ -14,6 +14,7 @@ func TestUDPMulticastFromRegistry(t *testing.T) { } moduleInstance, err := registration.New(config.ModuleConfig{ + Id: "test", Type: "net.udp.multicast", Params: map[string]any{ "ip": "236.10.10.10", @@ -22,10 +23,14 @@ func TestUDPMulticastFromRegistry(t *testing.T) { }) if err != nil { - t.Fatalf("failed to create udp.multicast module: %s", err) + t.Fatalf("failed to create net.udp.multicast module: %s", err) + } + + if moduleInstance.Id() != "test" { + t.Fatalf("net.udp.multicast module has wrong id: %s", moduleInstance.Id()) } if moduleInstance.Type() != "net.udp.multicast" { - t.Fatalf("udp.multicast module has wrong type: %s", moduleInstance.Type()) + t.Fatalf("net.udp.multicast module has wrong type: %s", moduleInstance.Type()) } } diff --git a/internal/module/test/udp-server_test.go b/internal/module/test/udp-server_test.go index 7c5b1ee..e7ebff7 100644 --- a/internal/module/test/udp-server_test.go +++ b/internal/module/test/udp-server_test.go @@ -14,6 +14,7 @@ func TestUDPServerFromRegistry(t *testing.T) { } moduleInstance, err := registration.New(config.ModuleConfig{ + Id: "test", Type: "net.udp.server", Params: map[string]any{ "port": 8000.0, @@ -24,6 +25,10 @@ func TestUDPServerFromRegistry(t *testing.T) { t.Fatalf("failed to create udp.server module: %s", err) } + if moduleInstance.Id() != "test" { + t.Fatalf("udp.server module has wrong id: %s", moduleInstance.Id()) + } + if moduleInstance.Type() != "net.udp.server" { t.Fatalf("net.udp.server module has wrong type: %s", moduleInstance.Type()) }