diff --git a/internal/processor/test/artnet-packet-decode_test.go b/internal/processor/test/artnet-packet-decode_test.go index 3d43fa2..4b73e66 100644 --- a/internal/processor/test/artnet-packet-decode_test.go +++ b/internal/processor/test/artnet-packet-decode_test.go @@ -60,7 +60,7 @@ func TestGoodArtnetPacketDecode(t *testing.T) { got, err := packetDecoder.Process(t.Context(), test.payload) if err != nil { - t.Fatalf("artnet.packet.decode failed: %s", err) + t.Fatalf("artnet.packet.decode processing failed: %s", err) } //TODO(jwetzell): work out better way to compare the any/any diff --git a/internal/processor/test/artnet-packet-encode_test.go b/internal/processor/test/artnet-packet-encode_test.go index 03e1b07..6c40470 100644 --- a/internal/processor/test/artnet-packet-encode_test.go +++ b/internal/processor/test/artnet-packet-encode_test.go @@ -60,7 +60,7 @@ func TestGoodArtnetPacketEncode(t *testing.T) { got, err := packetEncoder.Process(t.Context(), test.payload) if err != nil { - t.Fatalf("artnet.packet.encode failed: %s", err) + t.Fatalf("artnet.packet.encode processing failed: %s", err) } //TODO(jwetzell): work out better way to compare the any/any diff --git a/internal/processor/test/artnet-packet-filter_test.go b/internal/processor/test/artnet-packet-filter_test.go index 700a877..9a5cfdf 100644 --- a/internal/processor/test/artnet-packet-filter_test.go +++ b/internal/processor/test/artnet-packet-filter_test.go @@ -148,7 +148,7 @@ func TestGoodArtnetPacketFilter(t *testing.T) { got, err := processorInstance.Process(t.Context(), test.payload) if err != nil { - t.Fatalf("artnet.packet.filter failed: %s", err) + t.Fatalf("artnet.packet.filter processing failed: %s", err) } if test.expected == nil { diff --git a/internal/processor/test/filter-expr_test.go b/internal/processor/test/filter-expr_test.go index 5471037..906f475 100644 --- a/internal/processor/test/filter-expr_test.go +++ b/internal/processor/test/filter-expr_test.go @@ -91,7 +91,7 @@ func TestGoodFilterExpr(t *testing.T) { got, err := processorInstance.Process(t.Context(), test.payload) if err != nil { - t.Fatalf("filter.expr failed: %s", err) + t.Fatalf("filter.expr processing failed: %s", err) } //TODO(jwetzell): work out better way to compare the any/any diff --git a/internal/processor/test/float-parse_test.go b/internal/processor/test/float-parse_test.go index 7af5a62..087d464 100644 --- a/internal/processor/test/float-parse_test.go +++ b/internal/processor/test/float-parse_test.go @@ -76,14 +76,14 @@ func TestGoodFloatParse(t *testing.T) { } got, err := processorInstance.Process(t.Context(), test.payload) + if err != nil { + t.Fatalf("float.parse processing failed: %s", err) + } gotFloat, ok := got.(float64) if !ok { t.Fatalf("float.parse returned a %T payload: %s", got, got) } - if err != nil { - t.Fatalf("float.parse failed: %s", err) - } if gotFloat != test.expected { t.Fatalf("float.parse got %f, expected %f", gotFloat, test.expected) } diff --git a/internal/processor/test/int-parse_test.go b/internal/processor/test/int-parse_test.go index 31b7071..c0e55a5 100644 --- a/internal/processor/test/int-parse_test.go +++ b/internal/processor/test/int-parse_test.go @@ -97,14 +97,14 @@ func TestGoodIntParse(t *testing.T) { } got, err := processorInstance.Process(t.Context(), test.payload) + if err != nil { + t.Fatalf("int.parse processing failed: %s", err) + } gotInt, ok := got.(int64) if !ok { t.Fatalf("int.parse returned a %T payload: %s", got, got) } - if err != nil { - t.Fatalf("int.parse failed: %s", err) - } if gotInt != test.expected { t.Fatalf("int.parse got %d, expected %d", gotInt, test.expected) } diff --git a/internal/processor/test/int-random_test.go b/internal/processor/test/int-random_test.go index 20cef1d..b9a1d1b 100644 --- a/internal/processor/test/int-random_test.go +++ b/internal/processor/test/int-random_test.go @@ -98,13 +98,14 @@ func TestGoodIntRandom(t *testing.T) { } got, err := processorInstance.Process(t.Context(), test.payload) + if err != nil { + t.Fatalf("int.random processing failed: %s", err) + } + gotInt, ok := got.(int) if !ok { t.Fatalf("int.random returned a %T payload: %s", got, got) } - if err != nil { - t.Fatalf("int.random failed: %s", err) - } minNum, ok := test.params["min"].(int) if !ok { diff --git a/internal/processor/test/json-decode_test.go b/internal/processor/test/json-decode_test.go index e292f51..6a5f1f5 100644 --- a/internal/processor/test/json-decode_test.go +++ b/internal/processor/test/json-decode_test.go @@ -75,14 +75,15 @@ func TestGoodJsonDecode(t *testing.T) { for _, test := range tests { t.Run(test.name, func(t *testing.T) { got, err := jsonDecoder.Process(t.Context(), test.payload) + if err != nil { + t.Fatalf("json.decode processing failed: %s", err) + } gotMap, ok := got.(map[string]any) if !ok { t.Fatalf("json.decode returned a %T payload: %s", got, got) } - if err != nil { - t.Fatalf("json.decode failed: %s", err) - } + if !reflect.DeepEqual(gotMap, test.expected) { t.Fatalf("json.decode got %x, expected %s", got, test.expected) } diff --git a/internal/processor/test/json-encode_test.go b/internal/processor/test/json-encode_test.go index 2e3e804..ed7c48f 100644 --- a/internal/processor/test/json-encode_test.go +++ b/internal/processor/test/json-encode_test.go @@ -69,14 +69,15 @@ func TestGoodJsonEncode(t *testing.T) { for _, test := range tests { t.Run(test.name, func(t *testing.T) { got, err := jsonEncoder.Process(t.Context(), test.payload) + if err != nil { + t.Fatalf("json.encode processing failed: %s", err) + } gotBytes, ok := got.([]byte) if !ok { t.Fatalf("json.encode returned a %T payload: %s", got, got) } - if err != nil { - t.Fatalf("json.encode failed: %s", err) - } + if !slices.Equal(gotBytes, test.expected) { t.Fatalf("json.encode got %x, expected %s", got, test.expected) } diff --git a/internal/processor/test/midi-message-create_test.go b/internal/processor/test/midi-message-create_test.go index 33e855d..a3b6c9f 100644 --- a/internal/processor/test/midi-message-create_test.go +++ b/internal/processor/test/midi-message-create_test.go @@ -104,14 +104,15 @@ func TestGoodMIDIMessageCreate(t *testing.T) { } got, err := processorInstance.Process(t.Context(), test.payload) + if err != nil { + t.Fatalf("midi.message.create processing failed: %s", err) + } gotMessage, ok := got.(midi.Message) if !ok { t.Fatalf("midi.message.create returned a %T payload: %s", got, got) } - if err != nil { - t.Fatalf("midi.message.create failed: %s", err) - } + if !reflect.DeepEqual(gotMessage, test.expected) { t.Fatalf("midi.message.create got %v, expected %v", gotMessage, test.expected) } diff --git a/internal/processor/test/midi-message-decode_test.go b/internal/processor/test/midi-message-decode_test.go index ed07a9b..9cfc0b1 100644 --- a/internal/processor/test/midi-message-decode_test.go +++ b/internal/processor/test/midi-message-decode_test.go @@ -46,7 +46,7 @@ func TestGoodMIDIMessageDecode(t *testing.T) { t.Run(test.name, func(t *testing.T) { got, err := processorInstance.Process(t.Context(), test.payload) if err != nil { - t.Fatalf("midi.message.decode failed: %s", err) + t.Fatalf("midi.message.decode processing failed: %s", err) } gotMessage, ok := got.(midi.Message) diff --git a/internal/processor/test/midi-message-encode_test.go b/internal/processor/test/midi-message-encode_test.go index d742e90..e42ede8 100644 --- a/internal/processor/test/midi-message-encode_test.go +++ b/internal/processor/test/midi-message-encode_test.go @@ -45,14 +45,15 @@ func TestGoodMIDIMessageEncode(t *testing.T) { for _, test := range tests { t.Run(test.name, func(t *testing.T) { got, err := midiMessageEncoder.Process(t.Context(), test.payload) + if err != nil { + t.Fatalf("midi.message.encode processing failed: %s", err) + } gotBytes, ok := got.([]byte) if !ok { t.Fatalf("midi.message.encode returned a %T payload: %s", got, got) } - if err != nil { - t.Fatalf("midi.message.encode failed: %s", err) - } + if !slices.Equal(gotBytes, test.expected) { t.Fatalf("midi.message.encode got %+v, expected %+v", got, test.expected) } diff --git a/internal/processor/test/midi-message-filter_test.go b/internal/processor/test/midi-message-filter_test.go index b532b1c..d4a90e5 100644 --- a/internal/processor/test/midi-message-filter_test.go +++ b/internal/processor/test/midi-message-filter_test.go @@ -71,7 +71,7 @@ func TestGoodMIDIMessageFilter(t *testing.T) { got, err := processorInstance.Process(t.Context(), test.payload) if err != nil { - t.Fatalf("midi.message.filter failed: %s", err) + t.Fatalf("midi.message.filter processing failed: %s", err) } if test.expected == nil { diff --git a/internal/processor/test/mqtt-message-create_test.go b/internal/processor/test/mqtt-message-create_test.go index cf57bed..0fc14ec 100644 --- a/internal/processor/test/mqtt-message-create_test.go +++ b/internal/processor/test/mqtt-message-create_test.go @@ -106,7 +106,7 @@ func TestGoodMQTTMessageCreate(t *testing.T) { got, err := processorInstance.Process(t.Context(), test.payload) if err != nil { - t.Fatalf("mqtt.message.create process failed: %s", err) + t.Fatalf("mqtt.message.create processing failed: %s", err) } if test.expected == nil { diff --git a/internal/processor/test/mqtt-message-encode_test.go b/internal/processor/test/mqtt-message-encode_test.go index 76e14cc..ae34778 100644 --- a/internal/processor/test/mqtt-message-encode_test.go +++ b/internal/processor/test/mqtt-message-encode_test.go @@ -45,14 +45,15 @@ func TestGoodMQTTMessageEncode(t *testing.T) { for _, test := range tests { t.Run(test.name, func(t *testing.T) { got, err := stringEncoder.Process(t.Context(), test.payload) + if err != nil { + t.Fatalf("mqtt.message.encode processing failed: %s", err) + } gotBytes, ok := got.([]byte) if !ok { t.Fatalf("mqtt.message.encode returned a %T payload: %s", got, got) } - if err != nil { - t.Fatalf("mqtt.message.encode failed: %s", err) - } + if !slices.Equal(gotBytes, test.expected) { t.Fatalf("mqtt.message.encode got %s, expected %s", got, test.expected) } diff --git a/internal/processor/test/osc-message-create_test.go b/internal/processor/test/osc-message-create_test.go index 9f39e0e..4466396 100644 --- a/internal/processor/test/osc-message-create_test.go +++ b/internal/processor/test/osc-message-create_test.go @@ -152,7 +152,7 @@ func TestGoodOSCMessageCreate(t *testing.T) { got, err := processorInstance.Process(t.Context(), test.payload) if err != nil { - t.Fatalf("osc.message.create process failed: %s", err) + t.Fatalf("osc.message.create processing failed: %s", err) } if test.expected == nil { diff --git a/internal/processor/test/osc-message-filter_test.go b/internal/processor/test/osc-message-filter_test.go index b99e556..c7ec94b 100644 --- a/internal/processor/test/osc-message-filter_test.go +++ b/internal/processor/test/osc-message-filter_test.go @@ -75,7 +75,7 @@ func TestGoodOSCMessageFilter(t *testing.T) { got, err := processorInstance.Process(t.Context(), test.payload) if err != nil { - t.Fatalf("osc.message.filter process failed: %s", err) + t.Fatalf("osc.message.filter processing failed: %s", err) } if test.expected == nil { diff --git a/internal/processor/test/processor_test.go b/internal/processor/test/processor_test.go index b7d813a..ee4a0c4 100644 --- a/internal/processor/test/processor_test.go +++ b/internal/processor/test/processor_test.go @@ -36,6 +36,8 @@ func (t TestStruct) GetData() any { return t.Data } +func (t TestStruct) Void() {} + type TestProcessor struct { } diff --git a/internal/processor/test/script-expr_test.go b/internal/processor/test/script-expr_test.go index b12fca6..a87fa9a 100644 --- a/internal/processor/test/script-expr_test.go +++ b/internal/processor/test/script-expr_test.go @@ -78,7 +78,7 @@ func TestGoodScriptExpr(t *testing.T) { got, err := processorInstance.Process(t.Context(), test.payload) if err != nil { - t.Fatalf("script.expr failed: %s", err) + t.Fatalf("script.expr processing failed: %s", err) } //TODO(jwetzell): work out better way to compare the any/any diff --git a/internal/processor/test/script-js_test.go b/internal/processor/test/script-js_test.go index 05ef793..f0759b1 100644 --- a/internal/processor/test/script-js_test.go +++ b/internal/processor/test/script-js_test.go @@ -145,7 +145,7 @@ func TestGoodScriptJS(t *testing.T) { got, err := processorInstance.Process(t.Context(), test.payload) if err != nil { - t.Fatalf("script.js process failed: %s", err) + t.Fatalf("script.js processing failed: %s", err) } //TODO(jwetzell): work out better way to compare the any/any diff --git a/internal/processor/test/script-wasm_test.go b/internal/processor/test/script-wasm_test.go index 7e77015..35fb81d 100644 --- a/internal/processor/test/script-wasm_test.go +++ b/internal/processor/test/script-wasm_test.go @@ -77,7 +77,7 @@ func TestGoodScriptWASM(t *testing.T) { got, err := processorInstance.Process(t.Context(), test.payload) if err != nil { - t.Fatalf("script.wasm process failed: %s", err) + t.Fatalf("script.wasm processing failed: %s", err) } gotBytes, ok := got.([]byte) diff --git a/internal/processor/test/string-create_test.go b/internal/processor/test/string-create_test.go index ccc9572..e2ab0a1 100644 --- a/internal/processor/test/string-create_test.go +++ b/internal/processor/test/string-create_test.go @@ -98,13 +98,14 @@ func TestGoodStringCreate(t *testing.T) { got, err := processorInstance.Process(t.Context(), test.payload) + if err != nil { + t.Fatalf("string.create processing failed: %s", err) + } + gotStrings, ok := got.(string) if !ok { t.Fatalf("string.create returned a %T payload: %s", got, got) } - if err != nil { - t.Fatalf("string.create failed: %s", err) - } if gotStrings != test.expected { t.Fatalf("string.create got %s, expected %s", got, test.expected) } diff --git a/internal/processor/test/string-decode_test.go b/internal/processor/test/string-decode_test.go index c7fab0a..9b9e112 100644 --- a/internal/processor/test/string-decode_test.go +++ b/internal/processor/test/string-decode_test.go @@ -54,14 +54,15 @@ func TestGoodStringDecode(t *testing.T) { for _, test := range tests { t.Run(test.name, func(t *testing.T) { got, err := stringDecoder.Process(t.Context(), test.payload) + if err != nil { + t.Fatalf("string.decode processing failed: %s", err) + } gotString, ok := got.(string) if !ok { t.Fatalf("string.decode returned a %T payload: %s", got, got) } - if err != nil { - t.Fatalf("string.decode failed: %s", err) - } + if gotString != test.expected { t.Fatalf("string.decode got %s, expected %s", got, test.expected) } diff --git a/internal/processor/test/string-encode_test.go b/internal/processor/test/string-encode_test.go index d4b1e42..8b34198 100644 --- a/internal/processor/test/string-encode_test.go +++ b/internal/processor/test/string-encode_test.go @@ -61,16 +61,16 @@ func TestGoodStringEncode(t *testing.T) { for _, test := range tests { t.Run(test.name, func(t *testing.T) { got, err := stringEncoder.Process(t.Context(), test.payload) + if err != nil { + t.Fatalf("string.encode processing failed: %s", err) + } gotBytes, ok := got.([]byte) if !ok { t.Fatalf("string.encode returned a %T payload: %s", got, got) } - if err != nil { - t.Fatalf("string.encode failed: %s", err) - } if !slices.Equal(gotBytes, test.expected) { - t.Fatalf("string.encode got %s, expected %s", got, test.expected) + t.Fatalf("string.encode got %+v, expected %+v", gotBytes, test.expected) } }) } diff --git a/internal/processor/test/string-filter_test.go b/internal/processor/test/string-filter_test.go index 3baa252..38ac379 100644 --- a/internal/processor/test/string-filter_test.go +++ b/internal/processor/test/string-filter_test.go @@ -93,7 +93,7 @@ func TestGoodStringFilter(t *testing.T) { got, err := processorInstance.Process(t.Context(), test.payload) if err != nil { - t.Fatalf("string.filter failed: %s", err) + t.Fatalf("string.filter processing failed: %s", err) } if test.expected == nil { diff --git a/internal/processor/test/string-split_test.go b/internal/processor/test/string-split_test.go index bb3fefa..381d4c8 100644 --- a/internal/processor/test/string-split_test.go +++ b/internal/processor/test/string-split_test.go @@ -79,16 +79,17 @@ func TestGoodStringSplit(t *testing.T) { } got, err := processorInstance.Process(t.Context(), test.payload) + if err != nil { + t.Fatalf("string.split processing failed: %s", err) + } gotStrings, ok := got.([]string) if !ok { t.Fatalf("string.split returned a %T payload: %s", got, got) } - if err != nil { - t.Fatalf("string.split failed: %s", err) - } + if !slices.Equal(gotStrings, test.expected) { - t.Fatalf("string.split got %s, expected %s", got, test.expected) + t.Fatalf("string.split got %+v, expected %+v", gotStrings, test.expected) } }) } diff --git a/internal/processor/test/struct-field-get_test.go b/internal/processor/test/struct-field-get_test.go index cfcd88d..279046a 100644 --- a/internal/processor/test/struct-field-get_test.go +++ b/internal/processor/test/struct-field-get_test.go @@ -93,7 +93,7 @@ func TestGoodStructFieldGet(t *testing.T) { got, err := processorInstance.Process(t.Context(), test.payload) if err != nil { - t.Fatalf("struct.field.get failed: %s", err) + t.Fatalf("struct.field.get processing failed: %s", err) } if got != test.expected { diff --git a/internal/processor/test/struct-method-get_test.go b/internal/processor/test/struct-method-get_test.go index d5fc9a9..e88b915 100644 --- a/internal/processor/test/struct-method-get_test.go +++ b/internal/processor/test/struct-method-get_test.go @@ -1,6 +1,7 @@ package processor_test import ( + "reflect" "testing" "github.com/jwetzell/showbridge-go/internal/config" @@ -93,11 +94,11 @@ func TestGoodStructMethodGet(t *testing.T) { got, err := processorInstance.Process(t.Context(), test.payload) if err != nil { - t.Fatalf("struct.method.get failed: %s", err) + t.Fatalf("struct.method.get processing failed: %s", err) } - if got != test.expected { - t.Fatalf("struct.method.get got %s, expected %s", got, test.expected) + if !reflect.DeepEqual(got, test.expected) { + t.Fatalf("struct.method.get got %+v, expected %+v", got, test.expected) } }) } diff --git a/internal/processor/test/time-sleep_test.go b/internal/processor/test/time-sleep_test.go index dd3cdfc..49f1ee9 100644 --- a/internal/processor/test/time-sleep_test.go +++ b/internal/processor/test/time-sleep_test.go @@ -61,7 +61,7 @@ func TestGoodTimeSleep(t *testing.T) { got, err := processorInstance.Process(t.Context(), test.payload) if err != nil { - t.Fatalf("time.sleep failed: %s", err) + t.Fatalf("time.sleep processing failed: %s", err) } if got != test.payload { diff --git a/internal/processor/test/uint-parse_test.go b/internal/processor/test/uint-parse_test.go index 162c48c..164a501 100644 --- a/internal/processor/test/uint-parse_test.go +++ b/internal/processor/test/uint-parse_test.go @@ -77,14 +77,15 @@ func TestGoodUintParse(t *testing.T) { } got, err := processorInstance.Process(t.Context(), test.payload) + if err != nil { + t.Fatalf("uint.parse processing failed: %s", err) + } gotUint, ok := got.(uint64) if !ok { t.Fatalf("uint.parse returned a %T payload: %s", got, got) } - if err != nil { - t.Fatalf("uint.parse failed: %s", err) - } + if gotUint != test.expected { t.Fatalf("uint.parse got %d, expected %d", gotUint, test.expected) } diff --git a/internal/processor/test/uint-random_test.go b/internal/processor/test/uint-random_test.go index 1e3585a..9a6216b 100644 --- a/internal/processor/test/uint-random_test.go +++ b/internal/processor/test/uint-random_test.go @@ -96,14 +96,15 @@ func TestGoodUintRandom(t *testing.T) { } got, err := processorInstance.Process(t.Context(), test.payload) + if err != nil { + t.Fatalf("uint.random processing failed: %s", err) + } gotUint, ok := got.(uint) if !ok { t.Fatalf("uint.random returned a %T payload: %s", got, got) } - if err != nil { - t.Fatalf("uint.random failed: %s", err) - } + minNum, ok := test.params["min"].(int) if !ok { t.Fatalf("uint.random test min param is not a number")