From cf6519b594246ba8a36380dfa44f39a78a87cf90 Mon Sep 17 00:00:00 2001
From: Joel Wetzell <git@jwetzell.com>
Date: Wed, 24 Dec 2025 20:16:02 -0600
Subject: [PATCH] more tests for script.js

---
 internal/processor/script-js_test.go | 111 +++++++++++++++++++++++++--
 1 file changed, 106 insertions(+), 5 deletions(-)

diff --git a/internal/processor/script-js_test.go b/internal/processor/script-js_test.go
index 8c274a0..24a63dc 100644
--- a/internal/processor/script-js_test.go
+++ b/internal/processor/script-js_test.go
@@ -1,11 +1,82 @@
 package processor_test
 
 import (
+	"maps"
 	"testing"
 
+	"github.com/jwetzell/showbridge-go/internal/config"
 	"github.com/jwetzell/showbridge-go/internal/processor"
 )
 
+func TestScriptJSFromRegistry(t *testing.T) {
+	registration, ok := processor.ProcessorRegistry["script.js"]
+	if !ok {
+		t.Fatalf("script.js processor not registered")
+	}
+
+	processorInstance, err := registration.New(config.ProcessorConfig{
+		Type: "script.js",
+		Params: map[string]any{
+			"program": `
+			payload = payload + 1
+			`,
+		},
+	})
+	if err != nil {
+		t.Fatalf("failed to create script.js processor: %s", err)
+	}
+
+	if processorInstance.Type() != "script.js" {
+		t.Fatalf("script.js processor has wrong type: %s", processorInstance.Type())
+	}
+
+	payload := 1
+	expected := 2
+
+	got, err := processorInstance.Process(t.Context(), payload)
+	if err != nil {
+		t.Fatalf("script.js processing failed: %s", err)
+	}
+
+	if got != expected {
+		t.Fatalf("script.js got %+v, expected %+v", got, expected)
+	}
+}
+
+func TestScriptJSNoProgram(t *testing.T) {
+	registration, ok := processor.ProcessorRegistry["script.js"]
+	if !ok {
+		t.Fatalf("script.js processor not registered")
+	}
+
+	_, err := registration.New(config.ProcessorConfig{
+		Type:   "script.js",
+		Params: map[string]any{},
+	})
+
+	if err == nil {
+		t.Fatalf("script.js processor should have thrown an error when creating")
+	}
+}
+
+func TestScriptJSBadConfig(t *testing.T) {
+	registration, ok := processor.ProcessorRegistry["script.js"]
+	if !ok {
+		t.Fatalf("script.js processor not registered")
+	}
+
+	_, err := registration.New(config.ProcessorConfig{
+		Type: "script.js",
+		Params: map[string]any{
+			"program": 12345,
+		},
+	})
+
+	if err == nil {
+		t.Fatalf("script.js processor should have thrown an error when creating with non-string program")
+	}
+}
+
 func TestGoodScriptJS(t *testing.T) {
 	tests := []struct {
 		processor processor.Processor
@@ -14,21 +85,37 @@ func TestGoodScriptJS(t *testing.T) {
 		expected  any
 	}{
 		{
+			name: "number",
 			processor: &processor.ScriptJS{Program: `
 			payload = payload + 1
 			`},
-			name:     "number",
 			payload:  1,
 			expected: 2,
 		},
 		{
+			name: "string",
 			processor: &processor.ScriptJS{Program: `
 			payload = payload + "1"
 			`},
-			name:     "string",
 			payload:  "1",
 			expected: "11",
 		},
+		{
+			name: "object",
+			processor: &processor.ScriptJS{Program: `
+			payload = { key: payload }
+			`},
+			payload:  "1",
+			expected: map[string]any{"key": "1"},
+		},
+		{
+			name: "nil",
+			processor: &processor.ScriptJS{Program: `
+			payload = undefined
+			`},
+			payload:  "1",
+			expected: nil,
+		},
 	}
 
 	for _, test := range tests {
@@ -36,12 +123,26 @@ func TestGoodScriptJS(t *testing.T) {
 			got, err := test.processor.Process(t.Context(), test.payload)
 
 			if err != nil {
-				t.Errorf("script.js failed: %s", err)
+				t.Fatalf("script.js process failed: %s", err)
 			}
 
 			//TODO(jwetzell): work out better way to compare the any/any
-			if got != test.expected {
-				t.Errorf("script.js got %+v, expected %+v", got, test.expected)
+
+			gotMap, ok := got.(map[string]interface{})
+			if ok {
+				// got a map
+				expectedMap, ok := test.expected.(map[string]interface{})
+				if ok {
+					if !maps.Equal(gotMap, expectedMap) {
+						t.Fatalf("script.js got %+v, expected %+v", got, test.expected)
+					}
+				} else {
+					t.Fatalf("script.js got %+v, expected %+v", got, test.expected)
+				}
+			} else {
+				if got != test.expected {
+					t.Fatalf("script.js got %+v, expected %+v", got, test.expected)
+				}
 			}
 		})
 	}