test error cleanup

This commit is contained in:
Joel Wetzell
2025-12-24 19:45:24 -06:00
parent 6611821155
commit ccff105e37
13 changed files with 65 additions and 74 deletions

View File

@@ -10,6 +10,6 @@ func TestNilGetFramer(t *testing.T) {
nilFramer := framer.GetFramer("asldfiudchuehrkbjbkjrbb")
if nilFramer != nil {
t.Errorf("Expected nil framer, got %v", nilFramer)
t.Fatalf("Expected nil framer, got %v", nilFramer)
}
}

View File

@@ -28,7 +28,7 @@ func TestGoodRawFramerDecode(t *testing.T) {
t.Run(test.name, func(t *testing.T) {
frames := test.framer.Decode(test.input)
if len(frames) != len(test.expected) {
t.Errorf("raw framer got %d frames, expected %d", len(frames), len(test.expected))
t.Fatalf("raw framer got %d frames, expected %d", len(frames), len(test.expected))
}
for i, frame := range frames {
if !slices.Equal(frame, test.expected[i]) {
@@ -57,11 +57,8 @@ func TestGoodRawFramerEncode(t *testing.T) {
for _, test := range tests {
t.Run(test.name, func(t *testing.T) {
frame := test.framer.Encode(test.input)
if len(frame) != len(test.expected) {
t.Errorf("raw framer got %d frames, expected %d", len(frame), len(test.expected))
}
if !slices.Equal(frame, test.expected) {
t.Errorf("raw frame got %s, expected %s", frame, test.expected)
t.Fatalf("raw frame encode got %s, expected %s", frame, test.expected)
}
})
}
@@ -72,10 +69,10 @@ func TestRawFramerBuffer(t *testing.T) {
framer.Decode([]byte("Hello, World!"))
if !slices.Equal(framer.Buffer(), []byte{}) {
t.Errorf("raw framer buffer got %s, expected empty", framer.Buffer())
t.Fatalf("raw framer buffer got %s, expected empty", framer.Buffer())
}
framer.Clear()
if !slices.Equal(framer.Buffer(), []byte{}) {
t.Errorf("raw framer buffer got %s, expected empty after clear", framer.Buffer())
t.Fatalf("raw framer buffer got %s, expected empty after clear", framer.Buffer())
}
}

View File

@@ -65,7 +65,7 @@ func TestGoodSeparatorFramerDecode(t *testing.T) {
t.Run(test.name, func(t *testing.T) {
frames := test.framer.Decode(test.input)
if len(frames) != len(test.expected) {
t.Errorf("separator framer got %d frames, expected %d", len(frames), len(test.expected))
t.Fatalf("separator framer got %d frames, expected %d", len(frames), len(test.expected))
}
for i, frame := range frames {
if !slices.Equal(frame, test.expected[i]) {
@@ -73,7 +73,7 @@ func TestGoodSeparatorFramerDecode(t *testing.T) {
}
}
if !slices.Equal(test.framer.Buffer(), test.buffer) {
t.Errorf("separator framer buffer got %s, expected %s", test.framer.Buffer(), test.buffer)
t.Fatalf("separator framer buffer got %s, expected %s", test.framer.Buffer(), test.buffer)
}
})
}
@@ -110,7 +110,7 @@ func TestGoodSeparatorFramerEncode(t *testing.T) {
t.Run(test.name, func(t *testing.T) {
frame := test.framer.Encode(test.input)
if !slices.Equal(frame, test.expected) {
t.Errorf("separator framer got %s, expected %s", frame, test.expected)
t.Fatalf("separator framer got %s, expected %s", frame, test.expected)
}
})
}
@@ -120,11 +120,11 @@ func TestSeparatorFrameBuffer(t *testing.T) {
framer := framer.GetFramer("LF")
framer.Decode([]byte("Hello\nWorld\nThis is a test\nextra"))
if !slices.Equal(framer.Buffer(), []byte("extra")) {
t.Errorf("separator framer buffer got %s, expected %s", framer.Buffer(), []byte("extra"))
t.Fatalf("separator framer buffer got %s, expected %s", framer.Buffer(), []byte("extra"))
}
framer.Clear()
if !slices.Equal(framer.Buffer(), []byte{}) {
t.Errorf("separator framer buffer got %s, expected empty slice", framer.Buffer())
t.Fatalf("separator framer buffer got %s, expected empty slice", framer.Buffer())
}
}

View File

@@ -44,7 +44,7 @@ func TestGoodSLIPFramerDecode(t *testing.T) {
t.Run(test.name, func(t *testing.T) {
frames := test.framer.Decode(test.input)
if len(frames) != len(test.expected) {
t.Errorf("SLIP framer got %d frames, expected %d", len(frames), len(test.expected))
t.Fatalf("SLIP framer got %d frames, expected %d", len(frames), len(test.expected))
}
for i, frame := range frames {
if !slices.Equal(frame, test.expected[i]) {
@@ -52,7 +52,7 @@ func TestGoodSLIPFramerDecode(t *testing.T) {
}
}
if !slices.Equal(test.framer.Buffer(), test.buffer) {
t.Errorf("SLIP framer buffer got %s, expected %s", test.framer.Buffer(), test.buffer)
t.Fatalf("SLIP framer buffer got %s, expected %s", test.framer.Buffer(), test.buffer)
}
})
}
@@ -91,7 +91,7 @@ func TestGoodSLIPFramerEncode(t *testing.T) {
t.Run(test.name, func(t *testing.T) {
frame := test.framer.Encode(test.input)
if !slices.Equal(frame, test.expected) {
t.Errorf("SLIP framer frame got %s, expected %s", frame, test.expected)
t.Fatalf("SLIP framer frame got %s, expected %s", frame, test.expected)
}
})
}
@@ -101,10 +101,10 @@ func TestSlipFramerBuffer(t *testing.T) {
framer := framer.GetFramer("SLIP")
framer.Decode([]byte{0xc0, 0x2f, 0x68, 0x65, 0x6c, 0x6c, 0x6f, 0x00, 0x00, 0x2c, 0x00, 0x00, 0x00, 0xc0, 0xc0, 0x45})
if !slices.Equal(framer.Buffer(), []byte{0x45}) {
t.Errorf("SLIP framer buffer got %s, expected %s", framer.Buffer(), []byte{0x45})
t.Fatalf("SLIP framer buffer got %s, expected %s", framer.Buffer(), []byte{0x45})
}
framer.Clear()
if !slices.Equal(framer.Buffer(), []byte{}) {
t.Errorf("SLIP framer buffer got %s, expected empty slice", framer.Buffer())
t.Fatalf("SLIP framer buffer got %s, expected empty slice", framer.Buffer())
}
}