make http client into a processor instead of module

internal/processor/http-request-create.go

@@ -1,70 +0,0 @@
-package processor
-
-import (
-	"bytes"
-	"context"
-	"fmt"
-	"net/http"
-	"text/template"
-
-	"github.com/jwetzell/showbridge-go/internal/config"
-)
-
-type HTTPRequestCreate struct {
-	config config.ProcessorConfig
-	Method string
-	URL    *template.Template
-}
-
-func (hrc *HTTPRequestCreate) Process(ctx context.Context, payload any) (any, error) {
-
-	templateData := GetTemplateData(ctx, payload)
-
-	var urlBuffer bytes.Buffer
-	err := hrc.URL.Execute(&urlBuffer, templateData)
-
-	if err != nil {
-		return nil, err
-	}
-
-	urlString := urlBuffer.String()
-
-	//TODO(jwetzell): support body
-	request, err := http.NewRequest(hrc.Method, urlString, bytes.NewBuffer([]byte{}))
-
-	if err != nil {
-		return nil, err
-	}
-
-	return request, nil
-}
-
-func (hrc *HTTPRequestCreate) Type() string {
-	return hrc.config.Type
-}
-
-func init() {
-	RegisterProcessor(ProcessorRegistration{
-		Type: "http.request.create",
-		New: func(config config.ProcessorConfig) (Processor, error) {
-			params := config.Params
-
-			methodString, err := params.GetString("method")
-			if err != nil {
-				return nil, fmt.Errorf("http.request.create method error: %w", err)
-			}
-
-			urlString, err := params.GetString("url")
-			if err != nil {
-				return nil, fmt.Errorf("http.request.create url error: %w", err)
-			}
-
-			urlTemplate, err := template.New("url").Parse(urlString)
-
-			if err != nil {
-				return nil, err
-			}
-			return &HTTPRequestCreate{config: config, URL: urlTemplate, Method: methodString}, nil
-		},
-	})
-}

internal/processor/http-request-do.go

@@ -0,0 +1,93 @@
+package processor
+
+import (
+	"bytes"
+	"context"
+	"fmt"
+	"io"
+	"net/http"
+	"text/template"
+	"time"
+
+	"github.com/jwetzell/showbridge-go/internal/config"
+)
+
+type HTTPRequestDo struct {
+	config config.ProcessorConfig
+	client *http.Client
+	Method string
+	URL    *template.Template
+}
+
+func (hrd *HTTPRequestDo) Process(ctx context.Context, payload any) (any, error) {
+
+	templateData := GetTemplateData(ctx, payload)
+
+	var urlBuffer bytes.Buffer
+	err := hrd.URL.Execute(&urlBuffer, templateData)
+
+	if err != nil {
+		return nil, err
+	}
+
+	urlString := urlBuffer.String()
+
+	//TODO(jwetzell): support body
+	request, err := http.NewRequest(hrd.Method, urlString, bytes.NewBuffer([]byte{}))
+
+	if err != nil {
+		return nil, err
+	}
+
+	response, err := hrd.client.Do(request)
+
+	if err != nil {
+		return nil, err
+	}
+
+	body, err := io.ReadAll(response.Body)
+
+	if err != nil {
+		return nil, err
+	}
+
+	//TODO(jwetzell): support headers, etc
+	return HTTPResponse{
+		Status: response.StatusCode,
+		Body:   body,
+	}, nil
+}
+
+func (hrd *HTTPRequestDo) Type() string {
+	return hrd.config.Type
+}
+
+func init() {
+	RegisterProcessor(ProcessorRegistration{
+		Type: "http.request.do",
+		New: func(config config.ProcessorConfig) (Processor, error) {
+			params := config.Params
+
+			methodString, err := params.GetString("method")
+			if err != nil {
+				return nil, fmt.Errorf("http.request.do method error: %w", err)
+			}
+
+			urlString, err := params.GetString("url")
+			if err != nil {
+				return nil, fmt.Errorf("http.request.do url error: %w", err)
+			}
+
+			urlTemplate, err := template.New("url").Parse(urlString)
+
+			if err != nil {
+				return nil, err
+			}
+			client := &http.Client{
+				Timeout: 10 * time.Second,
+			}
+
+			return &HTTPRequestDo{config: config, URL: urlTemplate, Method: methodString, client: client}, nil
+		},
+	})
+}

internal/processor/test/http-request-do_test.go

@@ -8,13 +8,13 @@ import (
 )
 
 func TestHTTPRequestCreateFromRegistry(t *testing.T) {
-	registration, ok := processor.ProcessorRegistry["http.request.create"]
+	registration, ok := processor.ProcessorRegistry["http.request.do"]
 	if !ok {
-		t.Fatalf("http.request.create processor not registered")
+		t.Fatalf("http.request.do processor not registered")
 	}
 
 	processorInstance, err := registration.New(config.ProcessorConfig{
-		Type: "http.request.create",
+		Type: "http.request.do",
 		Params: map[string]any{
 			"method": "GET",
 			"url":    "http://example.com",
@@ -22,10 +22,10 @@ func TestHTTPRequestCreateFromRegistry(t *testing.T) {
 	})
 
 	if err != nil {
-		t.Fatalf("failed to create http.request.create processor: %s", err)
+		t.Fatalf("failed to create http.request.do processor: %s", err)
 	}
 
-	if processorInstance.Type() != "http.request.create" {
-		t.Fatalf("http.request.create processor has wrong type: %s", processorInstance.Type())
+	if processorInstance.Type() != "http.request.do" {
+		t.Fatalf("http.request.do processor has wrong type: %s", processorInstance.Type())
 	}
 }