make http client into a processor instead of module

internal/module/http-client.go

@@ -1,94 +0,0 @@
-package module
-
-import (
-	"context"
-	"errors"
-	"log/slog"
-	"net/http"
-	"time"
-
-	"github.com/jwetzell/showbridge-go/internal/common"
-	"github.com/jwetzell/showbridge-go/internal/config"
-	"github.com/jwetzell/showbridge-go/internal/processor"
-)
-
-type HTTPClient struct {
-	config config.ModuleConfig
-	ctx    context.Context
-	client *http.Client
-	router common.RouteIO
-	logger *slog.Logger
-	cancel context.CancelFunc
-}
-
-func init() {
-	RegisterModule(ModuleRegistration{
-		Type: "http.client",
-		New: func(config config.ModuleConfig) (Module, error) {
-
-			return &HTTPClient{config: config, logger: CreateLogger(config)}, nil
-		},
-	})
-}
-
-func (hc *HTTPClient) Id() string {
-	return hc.config.Id
-}
-
-func (hc *HTTPClient) Type() string {
-	return hc.config.Type
-}
-
-func (hc *HTTPClient) Start(ctx context.Context) error {
-	hc.logger.Debug("running")
-	router, ok := ctx.Value(common.RouterContextKey).(common.RouteIO)
-
-	if !ok {
-		return errors.New("http.client unable to get router from context")
-	}
-	hc.router = router
-	moduleContext, cancel := context.WithCancel(ctx)
-	hc.ctx = moduleContext
-	hc.cancel = cancel
-
-	hc.client = &http.Client{
-		Timeout: 10 * time.Second,
-	}
-
-	<-hc.ctx.Done()
-	hc.logger.Debug("done")
-	return nil
-}
-
-func (hc *HTTPClient) Output(ctx context.Context, payload any) error {
-
-	payloadRequest, ok := processor.GetAnyAs[*http.Request](payload)
-
-	if !ok {
-		return errors.New("http.client is only able to output an http.Request")
-	}
-
-	if hc.client == nil {
-		return errors.New("http.client client is nil")
-	}
-
-	response, err := hc.client.Do(payloadRequest)
-
-	if err != nil {
-		return err
-	}
-
-	if hc.router != nil {
-		hc.router.HandleInput(hc.ctx, hc.Id(), response)
-	}
-
-	return nil
-}
-
-func (hc *HTTPClient) Stop() {
-	hc.cancel()
-}
-
-func (hc *HTTPClient) Get(key string) (any, error) {
-	return nil, errors.New("http.client does not support Get")
-}

internal/module/test/http-client_test.go

@@ -1,73 +0,0 @@
-package module_test
-
-import (
-	"testing"
-
-	"github.com/jwetzell/showbridge-go/internal/config"
-	"github.com/jwetzell/showbridge-go/internal/module"
-)
-
-func TestHTTPClientFromRegistry(t *testing.T) {
-	registration, ok := module.ModuleRegistry["http.client"]
-	if !ok {
-		t.Fatalf("http.client module not registered")
-	}
-
-	moduleInstance, err := registration.New(config.ModuleConfig{
-		Id:   "test",
-		Type: "http.client",
-	})
-
-	if err != nil {
-		t.Fatalf("failed to create http.client module: %s", err)
-	}
-
-	if moduleInstance.Id() != "test" {
-		t.Fatalf("http.client module has wrong id: %s", moduleInstance.Id())
-	}
-
-	if moduleInstance.Type() != "http.client" {
-		t.Fatalf("http.client module has wrong type: %s", moduleInstance.Type())
-	}
-}
-
-func TestBadHTTPClient(t *testing.T) {
-	tests := []struct {
-		name        string
-		params      map[string]any
-		errorString string
-	}{}
-
-	for _, test := range tests {
-		t.Run(test.name, func(t *testing.T) {
-
-			registration, ok := module.ModuleRegistry["http.client"]
-			if !ok {
-				t.Fatalf("http.client module not registered")
-			}
-
-			moduleInstance, err := registration.New(config.ModuleConfig{
-				Id:     "test",
-				Type:   "http.client",
-				Params: test.params,
-			})
-
-			if err != nil {
-				if test.errorString != err.Error() {
-					t.Fatalf("http.client got error '%s', expected '%s'", err.Error(), test.errorString)
-				}
-				return
-			}
-
-			err = moduleInstance.Start(t.Context())
-
-			if err == nil {
-				t.Fatalf("http.client expected to fail")
-			}
-
-			if err.Error() != test.errorString {
-				t.Fatalf("http.client got error '%s', expected '%s'", err.Error(), test.errorString)
-			}
-		})
-	}
-}