diff --git a/internal/module/serial-client.go b/internal/module/serial-client.go index 83a828d..64702e4 100644 --- a/internal/module/serial-client.go +++ b/internal/module/serial-client.go @@ -43,20 +43,19 @@ func init() { return nil, errors.New("serial.client port must be a string") } - framingMethod := "RAW" + framingMethod, ok := params["framing"] - framingMethodRaw, ok := params["framing"] - - if ok { - framingMethodString, ok := framingMethodRaw.(string) - - if !ok { - return nil, errors.New("serial.client framing method must be a string") - } - framingMethod = framingMethodString + if !ok { + return nil, errors.New("serial.client requires a framing parameter") } - framer := framer.GetFramer(framingMethod) + framingMethodString, ok := framingMethod.(string) + + if !ok { + return nil, errors.New("serial.client framing method must be a string") + } + + framer := framer.GetFramer(framingMethodString) if framer == nil { return nil, fmt.Errorf("serial.client unknown framing method: %s", framingMethod) diff --git a/internal/module/tcp-server.go b/internal/module/tcp-server.go index 43ef7a7..de2b073 100644 --- a/internal/module/tcp-server.go +++ b/internal/module/tcp-server.go @@ -45,20 +45,19 @@ func init() { return nil, errors.New("net.tcp.server port must be a number") } - framingMethod := "RAW" + framingMethod, ok := params["framing"] - framingMethodRaw, ok := params["framing"] - - if ok { - framingMethodString, ok := framingMethodRaw.(string) - - if !ok { - return nil, errors.New("net.tcp.server framing method must be a string") - } - framingMethod = framingMethodString + if !ok { + return nil, errors.New("net.tcp.server requires a framing parameter") } - framer := framer.GetFramer(framingMethod) + framingMethodString, ok := framingMethod.(string) + + if !ok { + return nil, errors.New("net.tcp.server framing method must be a string") + } + + framer := framer.GetFramer(framingMethodString) if framer == nil { return nil, fmt.Errorf("net.tcp.server unknown framing method: %s", framingMethod)