From b6ee3c68f1d2c444f1e38c54e5d92118255ecca5 Mon Sep 17 00:00:00 2001 From: Joel Wetzell Date: Tue, 3 Feb 2026 22:26:16 -0600 Subject: [PATCH 1/2] don't default framing method --- internal/module/serial-client.go | 21 ++++++++++----------- internal/module/tcp-server.go | 21 ++++++++++----------- 2 files changed, 20 insertions(+), 22 deletions(-) diff --git a/internal/module/serial-client.go b/internal/module/serial-client.go index 83a828d..64702e4 100644 --- a/internal/module/serial-client.go +++ b/internal/module/serial-client.go @@ -43,20 +43,19 @@ func init() { return nil, errors.New("serial.client port must be a string") } - framingMethod := "RAW" + framingMethod, ok := params["framing"] - framingMethodRaw, ok := params["framing"] - - if ok { - framingMethodString, ok := framingMethodRaw.(string) - - if !ok { - return nil, errors.New("serial.client framing method must be a string") - } - framingMethod = framingMethodString + if !ok { + return nil, errors.New("serial.client requires a framing parameter") } - framer := framer.GetFramer(framingMethod) + framingMethodString, ok := framingMethod.(string) + + if !ok { + return nil, errors.New("serial.client framing method must be a string") + } + + framer := framer.GetFramer(framingMethodString) if framer == nil { return nil, fmt.Errorf("serial.client unknown framing method: %s", framingMethod) diff --git a/internal/module/tcp-server.go b/internal/module/tcp-server.go index 43ef7a7..de2b073 100644 --- a/internal/module/tcp-server.go +++ b/internal/module/tcp-server.go @@ -45,20 +45,19 @@ func init() { return nil, errors.New("net.tcp.server port must be a number") } - framingMethod := "RAW" + framingMethod, ok := params["framing"] - framingMethodRaw, ok := params["framing"] - - if ok { - framingMethodString, ok := framingMethodRaw.(string) - - if !ok { - return nil, errors.New("net.tcp.server framing method must be a string") - } - framingMethod = framingMethodString + if !ok { + return nil, errors.New("net.tcp.server requires a framing parameter") } - framer := framer.GetFramer(framingMethod) + framingMethodString, ok := framingMethod.(string) + + if !ok { + return nil, errors.New("net.tcp.server framing method must be a string") + } + + framer := framer.GetFramer(framingMethodString) if framer == nil { return nil, fmt.Errorf("net.tcp.server unknown framing method: %s", framingMethod) From fd4c2cb59ba58ddd32481f651b334bc1e7762693 Mon Sep 17 00:00:00 2001 From: Joel Wetzell Date: Tue, 3 Feb 2026 22:27:58 -0600 Subject: [PATCH 2/2] make framing parameter required in net.tcp.client --- internal/module/tcp-client.go | 21 ++++++++++----------- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/internal/module/tcp-client.go b/internal/module/tcp-client.go index e762474..0022e47 100644 --- a/internal/module/tcp-client.go +++ b/internal/module/tcp-client.go @@ -56,20 +56,19 @@ func init() { return nil, err } - framingMethod := "RAW" + framingMethod, ok := params["framing"] - framingMethodRaw, ok := params["framing"] - - if ok { - framingMethodString, ok := framingMethodRaw.(string) - - if !ok { - return nil, errors.New("net.tcp.client framing method must be a string") - } - framingMethod = framingMethodString + if !ok { + return nil, errors.New("net.tcp.client requires a framing parameter") } - framer := framer.GetFramer(framingMethod) + framingMethodString, ok := framingMethod.(string) + + if !ok { + return nil, errors.New("net.tcp.client framing method must be a string") + } + + framer := framer.GetFramer(framingMethodString) if framer == nil { return nil, fmt.Errorf("net.tcp.client unknown framing method: %s", framingMethod)