From 0cdd1f6e6a28423504b034e1ac3ec342b99ddb8d Mon Sep 17 00:00:00 2001
From: Joel Wetzell <git@jwetzell.com>
Date: Mon, 9 Feb 2026 21:06:02 -0600
Subject: [PATCH] add bad creation tests for sip servers

---
 internal/module/test/sip-call-server_test.go | 31 ++++++++++++-
 internal/module/test/sip-dtmf-server_test.go | 47 +++++++++++++++++++-
 2 files changed, 76 insertions(+), 2 deletions(-)

diff --git a/internal/module/test/sip-call-server_test.go b/internal/module/test/sip-call-server_test.go
index ffaf6d2..51d3d11 100644
--- a/internal/module/test/sip-call-server_test.go
+++ b/internal/module/test/sip-call-server_test.go
@@ -36,7 +36,36 @@ func TestBadSIPCallServer(t *testing.T) {
 		name        string
 		params      map[string]any
 		errorString string
-	}{}
+	}{
+		{
+			name: "non-number port param",
+			params: map[string]any{
+				"port": "8000",
+			},
+			errorString: "sip.call.server port must be a number",
+		},
+		{
+			name: "non-string ip param",
+			params: map[string]any{
+				"ip": 123,
+			},
+			errorString: "sip.call.server ip must be a string",
+		},
+		{
+			name: "non-string transport param",
+			params: map[string]any{
+				"transport": 123,
+			},
+			errorString: "sip.call.server transport must be a string",
+		},
+		{
+			name: "non-string userAgent param",
+			params: map[string]any{
+				"userAgent": 123,
+			},
+			errorString: "sip.call.server userAgent must be a string",
+		},
+	}
 
 	for _, test := range tests {
 		t.Run(test.name, func(t *testing.T) {
diff --git a/internal/module/test/sip-dtmf-server_test.go b/internal/module/test/sip-dtmf-server_test.go
index 3484cd4..5c5a39a 100644
--- a/internal/module/test/sip-dtmf-server_test.go
+++ b/internal/module/test/sip-dtmf-server_test.go
@@ -39,7 +39,52 @@ func TestBadSIPDTMFServer(t *testing.T) {
 		name        string
 		params      map[string]any
 		errorString string
-	}{}
+	}{
+		{
+			name:        "no separator param",
+			params:      map[string]any{},
+			errorString: "sip.dtmf.server requires a separator parameter",
+		},
+		{
+			name: "non-string separator param",
+			params: map[string]any{
+				"separator": 123,
+			},
+			errorString: "sip.dtmf.server separator must be a string",
+		},
+		{
+			name: "non-number port param",
+			params: map[string]any{
+				"separator": "#",
+				"port":      "8000",
+			},
+			errorString: "sip.dtmf.server port must be a number",
+		},
+		{
+			name: "non-string ip param",
+			params: map[string]any{
+				"separator": "#",
+				"ip":        123,
+			},
+			errorString: "sip.dtmf.server ip must be a string",
+		},
+		{
+			name: "non-string transport param",
+			params: map[string]any{
+				"separator": "#",
+				"transport": 123,
+			},
+			errorString: "sip.dtmf.server transport must be a string",
+		},
+		{
+			name: "non-string userAgent param",
+			params: map[string]any{
+				"separator": "#",
+				"userAgent": 123,
+			},
+			errorString: "sip.dtmf.server userAgent must be a string",
+		},
+	}
 
 	for _, test := range tests {
 		t.Run(test.name, func(t *testing.T) {